Re: configChanged coverage for 4.6
On Tuesday 14 September 2010 10:18:42 Marco Martin wrote: i think it's one of the very few ways to get this sort of small, long repetitive and boring things done ;) +1. It also works as an excellent way of team-building ;) Cheers! -- --- Artur Duque de Souza - MoRpHeUz --- http://claimid.com/morpheuz Blog: http://blog.morpheuz.cc PGP: 0xDBEEAAC3 @ wwwkeys.pgp.net --- signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: configChanged coverage for 4.6
On Tuesday 14 September 2010 01:55:39 Aaron J. Seigo wrote: On Saturday, September 4, 2010, Aaron J. Seigo wrote: All applets we ship that have any configuration will implement configChanged() it looks like we've accomplished our goal! folderview still has some outstanding items in it, but they are being actively worked on. thank-you to everyone who helped out with this! feedback time: was this a useful / helpful way to go about getting such improvements done? for those who got involved: was it enjoyable for you, and would you do it again? if so, i have a few more similarly entry level, detail oriented items that we could set as a new focus item. Hi, For me it was a motivating task to get back into KDE after 2 months away (summer kids holiday). I also noticed in the process that the applets in kdeplasma-addons are working well! Maybe I could have mentored a newcomer through it though (by the way of blogging for example) which would be nice for a next task. The WorldClock applet in kdeedu/marble is still to be done but it crashes on me in a weird way so I can't even look at it. Anne-Marie ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: configChanged coverage for 4.6
On Tue, Sep 14, 2010 at 10:22 PM, Anne-Marie Mahfouf ann...@gmail.comwrote: On Tuesday 14 September 2010 01:55:39 Aaron J. Seigo wrote: On Saturday, September 4, 2010, Aaron J. Seigo wrote: All applets we ship that have any configuration will implement configChanged() it looks like we've accomplished our goal! folderview still has some outstanding items in it, but they are being actively worked on. thank-you to everyone who helped out with this! feedback time: was this a useful / helpful way to go about getting such improvements done? for those who got involved: was it enjoyable for you, and would you do it again? if so, i have a few more similarly entry level, detail oriented items that we could set as a new focus item. Hi, For me it was a motivating task to get back into KDE after 2 months away (summer kids holiday). I also noticed in the process that the applets in kdeplasma-addons are working well! Maybe I could have mentored a newcomer through it though (by the way of blogging for example) which would be nice for a next task. Would you mentor me? I would like to learn c++ more. The WorldClock applet in kdeedu/marble is still to be done but it crashes on me in a weird way so I can't even look at it. Anne-Marie ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- സുജിത് ഹരിദാസന് Bangalore http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: configChanged coverage for 4.6
On Sunday, September 12, 2010 18:38:04 Rohan Garg wrote: Sorry that im waayy behind the schedule on this one, since this is my first patch to plasma, it might take another 10 days to perfect it, ive already fixed most of the issues with my patch on reviewboard for folderview, just need to fix the iconSizes issue. Extremely sorry for the delay. Don't worry, feature freeze is still months away (and this would even qualify as a bugfix). -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: configChanged coverage for 4.6
On Tue, Sep 14, 2010 at 12:55 AM, Aaron J. Seigo ase...@kde.org wrote: feedback time: was this a useful / helpful way to go about getting such improvements done? for those who got involved: was it enjoyable for you, and would you do it again? It was definitely a nice way to get into hacking on plasma, and I'll try to contribute more now - although I won't necessarily have much time once university starts again in a few weeks. if so, i have a few more similarly entry level, detail oriented items that we could set as a new focus item. I think maintaining the tasks page is a great way to track junior jobs, and having more entry level things there sounds like a good idea. Thanks, Anthony. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: configChanged coverage for 4.6
On Saturday 04 September 2010, Aaron J. Seigo wrote: hi all... as you can see here: http://community.kde.org/Plasma/Tasks#Plasmoids checked/fixed all in netbook, desktop and mobile shells Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: configChanged coverage for 4.6
On Tue, Sep 7, 2010 at 8:11 AM, Aaron J. Seigo ase...@kde.org wrote: On Saturday, September 4, 2010, Aaron J. Seigo wrote: hi all... as you can see here: http://community.kde.org/Plasma/Tasks#Plasmoids i went to finish off my evening by implementing configChanged() in another widget that needed it, and then went to this page to mark it as done .. and when i got there i was delighted to see 11 items marked off already (including the one i just did). very cool! at this rate (or faster if more people pitch in) we'll be done in short order... :) i can do a configchange adding session as soon as i get home, so sunday-monday Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
configChanged coverage for 4.6
hi all... as you can see here: http://community.kde.org/Plasma/Tasks#Plasmoids we have a large number of plasmoids in kdeplasma-addons that do not have configChanged() implementations, meaning they will not work nicely in plasmoidviewer anymore and they will not work well with the Plasma Desktop Scripting. i'd like to set out a small challenge for us for 4.6: All applets we ship that have any configuration will implement configChanged() i just knocked off one of the more hairy ones, microblogging, but most of the remaining ones are probably fairly simple. if you take one of the applets on, remove them from the list on the wiki page linked above. we can do this! :) for those who have no idea what i'm babbling on about: configChanged() is where all configuration reading should happen. many applets implement this in both init() (or elsewhere, e.g. in graphicsWidget() as the microblog plasmoid was doing) as well as in a slot connected to the configuration dialog. that code needs to put into a public slot with the signature void configChanged(). this method is called when configuration changes are made, such as after the configuration dialog has gone away or the user runs a script that modifies the applet settings. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
