Re: kf5 alpha 1 : modules, versions
On Monday 10 February 2014 15:43:13 Marco Martin wrote: On Monday 10 February 2014, Ivan Čukić wrote: the above points should be done.. only thing, in kactivities frameworks should still be merged in master (Ivan, would this be ok?) Fine by me :) (even more than 'fine') ok. i suppose kdesrc-build has to be updated beforehand tough to pick up the correct ones? (how?) Normally (in the future) this would be change kde-build-metadata/logical-module-structure. However kactivities was actually missing there, its branch name was hardcoded in the kdesrc-build file. So just update the file kf5-frameworks-build-include in the kdesrc-build repo. But still, adding an entry into logical-module-structure would be good for the future. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kf5 alpha 1 : modules, versions
On Tue, February 11, 2014 20:59:24 David Faure wrote: On Monday 10 February 2014 15:43:13 Marco Martin wrote: On Monday 10 February 2014, Ivan Čukić wrote: the above points should be done.. only thing, in kactivities frameworks should still be merged in master (Ivan, would this be ok?) Fine by me :) (even more than 'fine') ok. i suppose kdesrc-build has to be updated beforehand tough to pick up the correct ones? (how?) Normally (in the future) this would be change kde-build-metadata/logical-module-structure. However kactivities was actually missing there, its branch name was hardcoded in the kdesrc-build file. So just update the file kf5-frameworks-build-include in the kdesrc-build repo. But still, adding an entry into logical-module-structure would be good for the future. I would argue we should do both: migrate the kf5-*-build-include in kdesrc- build to use branch-groups consistently and ensure that logical-module- structure is up to date. The kde-build-metadata module has a script to verify that you get the right branch name so that you don't have to run kdesrc-build to validate the JSON or ensure you got what you expected. I might do this myself in the next day or so if there's no opposition, as now is the easiest this transition is ever going to be, at least until KDE 4 development has well and truly stopped. Regards, - Michael Pyne ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kf5 alpha 1 : modules, versions
On Saturday 08 February 2014, David Faure wrote: * OK if I run astyle-kdelibs in both, to harmonize coding style? (drawback: it makes forward-porting changes from 4.x harder) +1 if you can do it. + Can you add both to http://community.kde.org/Frameworks/List? This includes figuring out who to write down as maintainer :) + plasma-framework/README.md should be completed with a description + according to http://community.kde.org/Frameworks/Policies, the autotests and tests in plasma-framework should move to the toplevel. + In kactivities, the actual autotests like ./tests/core should move to an autotests subdir. the above points should be done.. only thing, in kactivities frameworks should still be merged in master (Ivan, would this be ok?) + kactivites needs a README.md, a kactivities.yaml and a .reviewboardrc Both frameworks need to be ported to ecm_generate_headers and ecm_generate_pri_file. Do you want to look at that too? sure.. but what I need to do for that exactly? ;) Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kf5 alpha 1 : modules, versions
the above points should be done.. only thing, in kactivities frameworks should still be merged in master (Ivan, would this be ok?) Fine by me :) (even more than 'fine') ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kf5 alpha 1 : modules, versions
On Monday 10 February 2014, Ivan Čukić wrote: the above points should be done.. only thing, in kactivities frameworks should still be merged in master (Ivan, would this be ok?) Fine by me :) (even more than 'fine') ok. i suppose kdesrc-build has to be updated beforehand tough to pick up the correct ones? (how?) -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kf5 alpha 1 : modules, versions
On Thursday 06 February 2014 23:32:11 David Faure wrote: On Wednesday 05 February 2014 22:42:00 Michael Palimaka wrote: On 02/03/2014 08:17 PM, David Faure wrote: Any new module that should be added to this release, compared to TP1? I see that plasma-framework.yaml says tier 3, is that correct - wouldn't it mean it should be released with the others? Excellent question. Plasma people: should I release plasma-framework with the other frameworks? Two things make it stand out a little bit, we might want to fix that, if the answer is yes: * it's not under frameworks/ in the projects.kde.org hierarchy. Shall we move it? * it declares itself to be version 2.0.0. Can I change that to 4.96.0 like all other frameworks? Ping? It's now or never, for alpha1 :) (I'm not on plasma-devel, please cc k-f-d) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kf5 alpha 1 : modules, versions
On Saturday 08 February 2014 10:31:10 David Faure wrote: * it's not under frameworks/ in the projects.kde.org hierarchy. Shall we move it? * it declares itself to be version 2.0.0. Can I change that to 4.96.0 like all other frameworks? Ping? It's now or never, for alpha1 :) (I'm not on plasma-devel, please cc k-f-d) To me the main issue is that there will still be several changes in there (freeze is at the end of march) would be this ok? about the version number 4.96.0 and its place in pko under frameworks/, those changes would be fine with me. opinions? comments? Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kf5 alpha 1 : modules, versions
On Saturday 08 February 2014 10:55:25 Marco Martin wrote: On Saturday 08 February 2014 10:31:10 David Faure wrote: * it's not under frameworks/ in the projects.kde.org hierarchy. Shall we move it? * it declares itself to be version 2.0.0. Can I change that to 4.96.0 like all other frameworks? Ping? It's now or never, for alpha1 :) (I'm not on plasma-devel, please cc k-f-d) To me the main issue is that there will still be several changes in there (freeze is at the end of march) would be this ok? Yes, it's just an alpha, any kind of change can still happen after that. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kf5 alpha 1 : modules, versions
On Saturday 08 February 2014 10:59:19 David Faure wrote: On Saturday 08 February 2014 10:55:25 Marco Martin wrote: On Saturday 08 February 2014 10:31:10 David Faure wrote: * it's not under frameworks/ in the projects.kde.org hierarchy. Shall we move it? * it declares itself to be version 2.0.0. Can I change that to 4.96.0 like all other frameworks? Ping? It's now or never, for alpha1 :) (I'm not on plasma-devel, please cc k-f-d) To me the main issue is that there will still be several changes in there (freeze is at the end of march) would be this ok? Yes, it's just an alpha, any kind of change can still happen after that. ok, soo, what we should have to do on our part? :) -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kf5 alpha 1 : modules, versions
On Saturday 08 February 2014 11:36:26 Marco Martin wrote: On Saturday 08 February 2014 10:59:19 David Faure wrote: On Saturday 08 February 2014 10:55:25 Marco Martin wrote: On Saturday 08 February 2014 10:31:10 David Faure wrote: * it's not under frameworks/ in the projects.kde.org hierarchy. Shall we move it? * it declares itself to be version 2.0.0. Can I change that to 4.96.0 like all other frameworks? Ping? It's now or never, for alpha1 :) (I'm not on plasma-devel, please cc k-f-d) To me the main issue is that there will still be several changes in there (freeze is at the end of march) would be this ok? Yes, it's just an alpha, any kind of change can still happen after that. ok, soo, what we should have to do on our part? :) + First, answering the questions below: * plasma-framework depends on kactivities which is also not a proper framework. Shall we make it one and release it together with the others? It needs a bit of updating in the cmake stuff (it has too many of the usually toplevel stuff like ecm_setup_version etc. in the subdir src/lib/core). * OK if I run astyle-kdelibs in both, to harmonize coding style? (drawback: it makes forward-porting changes from 4.x harder) + Can you add both to http://community.kde.org/Frameworks/List? This includes figuring out who to write down as maintainer :) + plasma-framework/README.md should be completed with a description + according to http://community.kde.org/Frameworks/Policies, the autotests and tests in plasma-framework should move to the toplevel. + In kactivities, the actual autotests like ./tests/core should move to an autotests subdir. + kactivites needs a README.md, a kactivities.yaml and a .reviewboardrc Both frameworks need to be ported to ecm_generate_headers and ecm_generate_pri_file. Do you want to look at that too? Of course I can release 4.96.0 without any of the above apart from an answer to the first question :) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kf5 alpha 1 : modules, versions
Also, kactivities is the only framework that still uses a branch named frameworks. Can we switch to master = kf5 and KDE/4.13 for the current master, assuming a 4.13 release of it is planned? [otherwise what do we do with master?] The only commit that is in master and not in 4.12 is this one btw: commit 2702febc7474537b19d816a941261755b04798f4 Author: Aaron Seigo ase...@kde.org cut off adding/removing activities at the source -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kf5 alpha 1 : modules, versions
On Saturday 08 February 2014 12:44:48 David Faure wrote: * plasma-framework depends on kactivities which is also not a proper framework. Shall we make it one and release it together with the others? It needs a bit of updating in the cmake stuff (it has too many of the usually toplevel stuff like ecm_setup_version etc. in the subdir src/lib/core). Ivan: what do you think about it? -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kf5 alpha 1 : modules, versions
On Saturday, 8. February 2014. 13.26.41 you wrote: On Saturday 08 February 2014 12:44:48 David Faure wrote: * plasma-framework depends on kactivities which is also not a proper framework. Shall we make it one and release it together with the others? It needs a bit of updating in the cmake stuff (it has too many of the usually toplevel stuff like ecm_setup_version etc. in the subdir src/lib/core). Ivan: what do you think about it? Fine by me, but I have no idea what / how should be done. Whoever wants to try it, it is fine by me. Cheers, Ivan -- So remember when you're feeling very small and insecure How amazingly unlikely is your birth And pray that there's intelligent life somewhere up in space Because there's bugger all down here on earth. -- Monty Python ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kf5 alpha 1 : modules, versions
On Saturday, 8. February 2014. 12.58.53 David Faure wrote: Also, kactivities is the only framework that still uses a branch named frameworks. Can we switch to master = kf5 and KDE/4.13 for the current master, assuming a 4.13 release of it is planned? [otherwise what do we do with master?] I wanted that, but got a frowny face from Albert: Personally I'd suggest against it since seems that even if we dicussed for that happening to kde-workspace people did not get the memo and got angry, Cheerio, Ivan -- Money can't buy happiness, but neither can poverty. -- Leo Rosten ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kf5 alpha 1 : modules, versions
more and more places - and especially all of the frameworks themselves. Ok, I'm game for the branch switch. Is there any documentation on how/what should be done to the cmake parts? p.s. Since then, kdelibs got splitted, so as I said, KF5 stuff is master in The thread in question is from 28.1. :) -- While you were hanging yourself on someone else's words Dying to believe in what you heard I was staring straight into the shining sun ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kf5 alpha 1 : modules, versions
On Saturday 08 February 2014, David Faure wrote: * plasma-framework depends on kactivities which is also not a proper framework. Shall we make it one and release it together with the others? It needs a bit of updating in the cmake stuff (it has too many of the usually toplevel stuff like ecm_setup_version etc. in the subdir src/lib/core). Yeah, kactivities should be a framework definitely * OK if I run astyle-kdelibs in both, to harmonize coding style? (drawback: it makes forward-porting changes from 4.x harder) sure, i think it's a good idea. + Can you add both to http://community.kde.org/Frameworks/List? This includes figuring out who to write down as maintainer :) added. I won't be around a couple of days, monday i'll start to tackle those issues. -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kf5 alpha 1 : modules, versions
El Dissabte, 8 de febrer de 2014, a les 16:32:04, David Faure va escriure: On Saturday 08 February 2014 14:13:40 Ivan Čukić wrote: On Saturday, 8. February 2014. 12.58.53 David Faure wrote: Also, kactivities is the only framework that still uses a branch named frameworks. Can we switch to master = kf5 and KDE/4.13 for the current master, assuming a 4.13 release of it is planned? [otherwise what do we do with master?] I wanted that, but got a frowny face from Albert: Personally I'd suggest against it since seems that even if we dicussed for that happening to kde-workspace people did not get the memo and got angry, Well, that was before we had tools to abstract branch names, like kde-build- metadata/logical-module-structure. These days such changes are a lot more transparent, which puts the matter to rest (I was one of the unhappy people when things started to get inconsistent). Good that this has been now resolved. Cheers, Albert Since then, kdelibs got splitted, so as I said, KF5 stuff is master in more and more places - and especially all of the frameworks themselves. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kf5 alpha 1 : modules, versions
On Wednesday 05 February 2014 22:42:00 Michael Palimaka wrote: On 02/03/2014 08:17 PM, David Faure wrote: Any new module that should be added to this release, compared to TP1? I see that plasma-framework.yaml says tier 3, is that correct - wouldn't it mean it should be released with the others? Excellent question. Plasma people: should I release plasma-framework with the other frameworks? Two things make it stand out a little bit, we might want to fix that, if the answer is yes: * it's not under frameworks/ in the projects.kde.org hierarchy. Shall we move it? * it declares itself to be version 2.0.0. Can I change that to 4.96.0 like all other frameworks? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
