Re: left-click on libappindicator indicators

2016-03-23 Thread Raman Gupta 
On 03/21/2016 03:19 PM, Martin Klapetek wrote:
> On Mon, Mar 21, 2016 at 3:10 PM, Raman Gupta  > wrote:
> 
> Currently (or at least as of Plasma 5.5.5 on my Fedora 23 machine),
> left-click on libappindicator-based indicator's in the plasma system
> tray does absolutely nothing.
> 
> 
> This is presumably the same as https://bugs.kde.org/show_bug.cgi?id=358589
> 
> Can you try that patch?

I tried the patch, but it did not work. Left-clicking on my
pidgin-indicator [1] indicator didn't do anything in Plasma 5.5.5 with
the patch.

[1] https://github.com/philipl/pidgin-indicator

Regards,
Raman
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: left-click on libappindicator indicators

2016-03-22 Thread Marco Martin 
On Monday 21 March 2016 15:10:17 Raman Gupta wrote:
> Currently (or at least as of Plasma 5.5.5 on my Fedora 23 machine),
> left-click on libappindicator-based indicator's in the plasma system
> tray does absolutely nothing.
> 
> An example of this indicator is pidgin with the pidgin-indicator
> plugin (https://github.com/philipl/pidgin-indicator).
> 
> On Ubuntu Unity, both left and right-click apparently open the
> indicator menu. Personally I am not fond of this behaviour, but it is
> better than doing nothing.
> 
> I would prefer if Plasma could detect whether a tray icon provides a
> window, and if so, Plasma did application show/hide when tray icons
> are left-clicked. Essentially a minimize to tray/restore from tray
> function. Thoughts?

that is the behavior of our client side implementation.
What i am not sure is that since libappindicator didn't want that behavior, it 
maybe doesn't export the window id?

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: left-click on libappindicator indicators

2016-03-21 Thread Martin Klapetek 
On Mon, Mar 21, 2016 at 3:10 PM, Raman Gupta  wrote:

> Currently (or at least as of Plasma 5.5.5 on my Fedora 23 machine),
> left-click on libappindicator-based indicator's in the plasma system
> tray does absolutely nothing.
>
> An example of this indicator is pidgin with the pidgin-indicator
> plugin (https://github.com/philipl/pidgin-indicator).
>
> On Ubuntu Unity, both left and right-click apparently open the
> indicator menu. Personally I am not fond of this behaviour, but it is
> better than doing nothing.
>
> I would prefer if Plasma could detect whether a tray icon provides a
> window, and if so, Plasma did application show/hide when tray icons
> are left-clicked. Essentially a minimize to tray/restore from tray
> function. Thoughts?
>

This is presumably the same as https://bugs.kde.org/show_bug.cgi?id=358589

Can you try that patch?

In any case, I'll post it for review.

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

left-click on libappindicator indicators

2016-03-21 Thread Raman Gupta 
Currently (or at least as of Plasma 5.5.5 on my Fedora 23 machine),
left-click on libappindicator-based indicator's in the plasma system
tray does absolutely nothing.

An example of this indicator is pidgin with the pidgin-indicator
plugin (https://github.com/philipl/pidgin-indicator).

On Ubuntu Unity, both left and right-click apparently open the
indicator menu. Personally I am not fond of this behaviour, but it is
better than doing nothing.

I would prefer if Plasma could detect whether a tray icon provides a
window, and if so, Plasma did application show/hide when tray icons
are left-clicked. Essentially a minimize to tray/restore from tray
function. Thoughts?

Regards,
Raman
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel