D24934: [notifications] Center no notification text on mobile
mart added a comment. I'm fine with it, however... there must be a bug somewhere in the shell, because the whole notification applet is supposed to be invisible when there are none, i have to investigate into that REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24934 To: nicolasfella, #plasma, #vdg, broulik Cc: mart, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra
D24934: [notifications] Center no notification text on mobile
broulik added inline comments.
INLINE COMMENTS
> FullRepresentation.qml:580
> PlasmaExtras.Heading {
> width: list.width
> +height: list.height
Now you could have used an `anchors.fill` xD
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D24934
To: nicolasfella, #plasma, #vdg, broulik
Cc: broulik, KonqiDragon, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D24934: [notifications] Center no notification text on mobile
This revision was automatically updated to reflect the committed changes. Closed by commit R120:c3ab37034791: [notifications] Center no notification text on mobile (authored by nicolasfella). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24934?vs=68721&id=68722 REVISION DETAIL https://phabricator.kde.org/D24934 AFFECTED FILES applets/notifications/package/contents/ui/FullRepresentation.qml To: nicolasfella, #plasma, #vdg, broulik Cc: broulik, KonqiDragon, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D24934: [notifications] Center no notification text on mobile
nicolasfella updated this revision to Diff 68721. nicolasfella added a comment. - Fix it REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24934?vs=68720&id=68721 BRANCH cent REVISION DETAIL https://phabricator.kde.org/D24934 AFFECTED FILES applets/notifications/package/contents/ui/FullRepresentation.qml To: nicolasfella, #plasma, #vdg, broulik Cc: broulik, KonqiDragon, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D24934: [notifications] Center no notification text on mobile
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Fix it, then ship it INLINE COMMENTS > FullRepresentation.qml:582 > +horizontalAlignment: Kirigami.Settings.isMobile ? > Text.AlignHCenter : Text.AlignLeft > +wrapMode: Text.Wrap > level: 3 WordWrap > FullRepresentation.qml:587 > visible: list.count === 0 > +anchors.centerIn: Kirigami.Settings.isMobile ? parent : > undefined > } Only vertical center now, please REPOSITORY R120 Plasma Workspace BRANCH cent REVISION DETAIL https://phabricator.kde.org/D24934 To: nicolasfella, #plasma, #vdg, broulik Cc: broulik, KonqiDragon, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D24934: [notifications] Center no notification text on mobile
nicolasfella added a comment. Looks just more complicated to me, but :shrug: REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24934 To: nicolasfella, #plasma, #vdg, broulik Cc: broulik, KonqiDragon, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D24934: [notifications] Center no notification text on mobile
nicolasfella updated this revision to Diff 68720. nicolasfella added a comment. - Do as Kai says REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24934?vs=68718&id=68720 BRANCH cent REVISION DETAIL https://phabricator.kde.org/D24934 AFFECTED FILES applets/notifications/package/contents/ui/FullRepresentation.qml To: nicolasfella, #plasma, #vdg, broulik Cc: broulik, KonqiDragon, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D24934: [notifications] Center no notification text on mobile
broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. Keep the width and enable wrapping and horizontal centering. We both know how wide some locale can get :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24934 To: nicolasfella, #plasma, #vdg, broulik Cc: broulik, KonqiDragon, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D24934: [notifications] Center no notification text on mobile
KonqiDragon added a comment. Could you add a rounded corners? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24934 To: nicolasfella, #plasma, #vdg Cc: KonqiDragon, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D24934: [notifications] Center no notification text on mobile
nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH cent REVISION DETAIL https://phabricator.kde.org/D24934 AFFECTED FILES applets/notifications/package/contents/ui/FullRepresentation.qml To: nicolasfella Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
Re: notification text
Am Montag 25 Oktober 2010, 15:53:39 schrieb Marco Martin: > here you go, in trunk text is selectable and links clickable In case I never told you: You are my personal hero. :-) Does it also work with Kopete which AFAIK sends HTML-formatted notifications for URLs? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: notification text
Am Montag 25 Oktober 2010, 13:11:21 schrieb Chani: > ...after googling the part I could read, I got my account unlocked (phew!) > but my point still stands :) I'd rather see clickable URLs than copyable ones... > also, if anyone can recommend a reliable imap server, I would be willing to > pay for an account. I hear http://gmx.com/ is good with free IMAP an such. I'm in Germany and can't register, so I can't tell how good it is. German GMX only offers POP3 for free. IMAP is a premium service here. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
notification text
so... uhm... I've run into a rather compelling use case for being able to read and copy the full text of notifications: http://chani.ca/sshots/mailfail.png it seem gmail won't let me use kmail until I visit that url (at least, I *hope* visiting that url would fix it, because just logging in doesn't) -- This message brought to you by evyl bananas and the number 3. www.chani3.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
