Re: Re: questions about KWin shadows
On Wednesday 04 May 2011 19:58:14 Aaron J. Seigo wrote: > On Wednesday, May 4, 2011 17:19:37 Martin Gräßlin wrote: > > that is in fact the main idea of the new shadow system as the compositor > > cannot know about the light model used by the client, whether to apply drop > > shadows etc. etc. And of course the compositor doesn't know the clients > > shape like Marco already said. > > well, in any case, it's working now in master for panels. awesome, it just took as eight releases to get it working :-D > those are now > rendered using the kwin effect. In fact it's not an effect, but an integrated part of the compositor which allows all the magic like not being blurred, clicks going through and not affecting anything else :-) > i'll work on the other bits and pieces in > libplasma later. cool > > it seems to work nicely with the panel autohide slide in/out effect as well, > and content behind the shadow is not blurred. clicks go through ... all in a > nice improvement. > > you may wish to check it out for yourselves to ensure there are no performance > regressions. just compiled, looks really good and I will keep an eye on performance. It also seems to be no issue that the shadow is above the windows and not below. > > there is just one copy of the pixmaps kept for all the panels; there will end > up being another set for popups and yet another for tooltips, i believe. Currently KWin is still keeping an additional copy of the pixmaps for each window, but that is something I want to optimize. Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: questions about KWin shadows
On Wednesday 04 May 2011, Aaron J. Seigo wrote: > On Wednesday, May 4, 2011 17:19:37 Martin Gräßlin wrote: > > that is in fact the main idea of the new shadow system as the compositor > > cannot know about the light model used by the client, whether to apply > > drop shadows etc. etc. And of course the compositor doesn't know the > > clients shape like Marco already said. > > well, in any case, it's working now in master for panels. those are now > rendered using the kwin effect. i'll work on the other bits and pieces in > libplasma later. > > it seems to work nicely with the panel autohide slide in/out effect as > well, and content behind the shadow is not blurred. clicks go through ... > all in a nice improvement. > > you may wish to check it out for yourselves to ensure there are no > performance regressions. > > there is just one copy of the pixmaps kept for all the panels; there will > end up being another set for popups and yet another for tooltips, i > believe. yup, they should stay inside the dialogs/tooltips svgs. while it could probably save something using a single set, themes can have pretty different svgs for those 3 things, altough in the case of air a single set would probably work -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: questions about KWin shadows
On Wednesday, May 4, 2011 17:19:37 Martin Gräßlin wrote: > that is in fact the main idea of the new shadow system as the compositor > cannot know about the light model used by the client, whether to apply drop > shadows etc. etc. And of course the compositor doesn't know the clients > shape like Marco already said. well, in any case, it's working now in master for panels. those are now rendered using the kwin effect. i'll work on the other bits and pieces in libplasma later. it seems to work nicely with the panel autohide slide in/out effect as well, and content behind the shadow is not blurred. clicks go through ... all in a nice improvement. you may wish to check it out for yourselves to ensure there are no performance regressions. there is just one copy of the pixmaps kept for all the panels; there will end up being another set for popups and yet another for tooltips, i believe. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: questions about KWin shadows
On Wednesday 04 May 2011 13:32:55 Aaron J. Seigo wrote: > On Wednesday, May 4, 2011 10:19:34 Marco Martin wrote: > > On Monday 02 May 2011, Martin Gräßlin wrote: > > > Windows wich have decorations are the only ones which should not get the > > > shadows. Docks should work. > > > > > > In any case I recommend reading [1]. Feel free to show me the diff. > > > > > > Cheers > > > Martin > > > > > > [1]: https://projects.kde.org/projects/kde/kdebase/kde- > > > workspace/repository/revisions/master/entry/kstyles/oxygen/oxygenshadowh > > > elp er.cpp > > > > from a quick look it seems that what is missing in the panel is the actual > > insertion of the shadow pixmaps > > aha; i was under the impression that the shadows were to be provided by the > compositor, not the client. fair enough ... that is in fact the main idea of the new shadow system as the compositor cannot know about the light model used by the client, whether to apply drop shadows etc. etc. And of course the compositor doesn't know the clients shape like Marco already said. Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: questions about KWin shadows
On Wednesday, May 4, 2011 10:19:34 Marco Martin wrote: > On Monday 02 May 2011, Martin Gräßlin wrote: > > Windows wich have decorations are the only ones which should not get the > > shadows. Docks should work. > > > > In any case I recommend reading [1]. Feel free to show me the diff. > > > > Cheers > > Martin > > > > [1]: https://projects.kde.org/projects/kde/kdebase/kde- > > workspace/repository/revisions/master/entry/kstyles/oxygen/oxygenshadowh > > elp er.cpp > > from a quick look it seems that what is missing in the panel is the actual > insertion of the shadow pixmaps aha; i was under the impression that the shadows were to be provided by the compositor, not the client. fair enough ... -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: questions about KWin shadows
On Wednesday 04 May 2011, Aaron J. Seigo wrote: > thanks for the answers .. > > On Monday, May 2, 2011 17:34:17 Martin Gräßlin wrote: > > > * is there a way to get the default sizes for the offsets? e.g. if > > > passing in -1 or some such? > > > > there is no default offset size. It is completly controlled by the client > > why should the client be forced to control the size of the shadow? the > panel, for instance, has no particular requirement for or reason to have a > spcifically sized shadow. using whatever the default is would increase > consistency between different clients, no? problem: the radius of the rounded window is controlled by the plasma theme, so is pretty easy creating a shadow that doesn't match -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: questions about KWin shadows
thanks for the answers .. On Monday, May 2, 2011 17:34:17 Martin Gräßlin wrote: > > * is there a way to get the default sizes for the offsets? e.g. if > > passing in -1 or some such? > > there is no default offset size. It is completly controlled by the client why should the client be forced to control the size of the shadow? the panel, for instance, has no particular requirement for or reason to have a spcifically sized shadow. using whatever the default is would increase consistency between different clients, no? -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: questions about KWin shadows
On Monday 02 May 2011, Martin Gräßlin wrote: > Windows wich have decorations are the only ones which should not get the > shadows. Docks should work. > > In any case I recommend reading [1]. Feel free to show me the diff. > > Cheers > Martin > > [1]: https://projects.kde.org/projects/kde/kdebase/kde- > workspace/repository/revisions/master/entry/kstyles/oxygen/oxygenshadowhelp > er.cpp from a quick look it seems that what is missing in the panel is the actual insertion of the shadow pixmaps -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: questions about KWin shadows
On Monday 02 May 2011 15:34:52 Aaron J. Seigo wrote: > hi.. > > i just pushed a commit which attempts to replace the ShadowWindow that > PanelView in plasma-desktop was using with the _KDE_NET_WM_SHADOW hint. > > it doesn't seem to be working, however .. some general questions i have after > reading http://community.kde.org/KWin/Shadow : > > * the property is a single char*, correct? yes > > * are all four numeric offsets required even if showing only one shadow? yes, all values are required. > > * is there a way to get the default sizes for the offsets? e.g. if passing in > -1 or some such? there is no default offset size. It is completly controlled by the client > > * does it work with windows that don't have decorations? dock windows, in > particular? Windows wich have decorations are the only ones which should not get the shadows. Docks should work. In any case I recommend reading [1]. Feel free to show me the diff. Cheers Martin [1]: https://projects.kde.org/projects/kde/kdebase/kde- workspace/repository/revisions/master/entry/kstyles/oxygen/oxygenshadowhelper.cpp signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
questions about KWin shadows
hi.. i just pushed a commit which attempts to replace the ShadowWindow that PanelView in plasma-desktop was using with the _KDE_NET_WM_SHADOW hint. it doesn't seem to be working, however .. some general questions i have after reading http://community.kde.org/KWin/Shadow : * the property is a single char*, correct? * are all four numeric offsets required even if showing only one shadow? * is there a way to get the default sizes for the offsets? e.g. if passing in -1 or some such? * does it work with windows that don't have decorations? dock windows, in particular? -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
