[Differential] [Request, 11 lines] D3416: [Task Manager] Strip application:// prefix before looking up service

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  According to Unity Launcher API documentation [1] this prefix should be 
there, actually, so we weren't standard-compliant here.
  
  [1] https://wiki.ubuntu.com/Unity/LauncherAPI
  
  CHANGELOG: Badges and progress display in task manager now works with more 
3rd party applications

TEST PLAN
  Together with https://phabricator.kde.org/D3415 I now get badges by 
Mattermost (Electron) chat application
  
  Verified that Chrome and Dolphin still show badges and download progress

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3416

AFFECTED FILES
  applets/taskmanager/plugin/smartlaunchers/smartlauncherbackend.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Changed Subscribers] D3433: tabbar on proper side when ltr

[broulik (Kai Uwe Broulik)]

broulik added inline comments.

INLINE COMMENTS

> FullRepresentation.qml:174
>  case PlasmaCore.Types.LeftEdge:
> -return "left";
> +return Qt.application.layoutDirection == Qt.RightToLeft 
> ? "right" : "left";
>  case PlasmaCore.Types.TopEdge:

Perhaps better check whether LayoutMirroring.enabled

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3433

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Changed Subscribers] D3365: Implement interactive window selection for Wayland platforms

[broulik (Kai Uwe Broulik)]

broulik added inline comments.

INLINE COMMENTS

> input.cpp:488
> +if (event->buttons() == Qt::NoButton) {
> +if (event->button() == Qt::RightButton) {
> +cancel();

Can this happen? You check for buttons being NoButton and then for button being 
RightButton?

> input.cpp:1409
>  installInputEventFilter(new LockScreenFilter);
> +m_windowSelector = new WindowSelectorFilter;
> +installInputEventFilter(m_windowSelector);

Where is that being cleaned up?

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3365

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: broulik, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  We could do the same hack we have with Kickoff, where the first task manager 
it finds with a global shortcut will be invoked. But that's not really 
discoverable how to change/why it broke when you created a new panel manually, 
etc etc.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2680

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: cfeck, colomar, ivan, graesslin, lbeltrame, mart, plasma-devel, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3425: If we get a notification with no body, treat the subject line as the body

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  Heh, you were quicker :)
  
  Can we perhaps use the application name as summary in case none is set?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3425

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: broulik, apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Request, 10 lines] D3209: [Notification Applet] Position dialog before showing it

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, mck182.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This ensures the dialog gets a proper position before being shown.
  
  On Wayland notification popups are animated by the morphing popup effect and 
would fly all over the screen when shown; now they only move around in the 
vicinity of their final position, looking really nice.

TEST PLAN
  Only tested on Wayland.
  
  With all of X's quirks this overly complex code needs to be tested more. I 
removed the updateVisibility calls which I don't think are neccessary and it 
works just fine here but I don't trust X here. Will test on X soon.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3209

AFFECTED FILES
  applets/notifications/plugin/notificationshelper.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mck182
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3200: Add a widget gallery page to the Dashboard.

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  Sorry for being late to the party

INLINE COMMENTS

> DashboardRepresentation.qml:102
> +if (tabBar.activeTab == 1 /* Widgets */ || tabBar.hoveredTab == 1) {
> +root.widgetExplorer = widgetExplorerComponent.createObject(root);
> +root.widgetExplorer.containment = 
> containmentInterface.screenContainment(plasmoid);

Would it help if you pass the containment to the createObject call to avoid 
some re-evaluation?

  root.widgetExplorer = widgetExplorerComponent.createObject(root, {
  containment: containmentInterface.screenContainment(plasmoid)
  })

> containmentinterface.h:53
> +static Q_INVOKABLE bool screenContainmentMutable(QObject 
> *appletInterface);
> +static Q_INVOKABLE void ensureMutable(Plasma::Containment 
> *containment);
>  

Note that you cannot unlock widgets if kiosk restrictions (SystemImmutable) 
apply in which case this entire feature should be disabled or else you open a 
neat way for users to screw with a locked-down desktop.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3200

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, mart
Cc: broulik, davidedmundson, mart, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Updated] D3089: Restore global menu support

[broulik (Kai Uwe Broulik)]

broulik marked 3 inline comments as done.
broulik added inline comments.

INLINE COMMENTS

> graesslin wrote in abstract_client.cpp:75-77
> why carry the bool in the signal? That seems to make it way more complicated 
> here

In DecoratedClient I do

  connect(client, ::hasApplicationMenuChanged, decoratedClient, 
::DecoratedClient::hasApplicationMenuChanged);

So either I need it here or there.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3089

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Updated, 299 lines] D3089: WIP: Restore global menu support

[broulik (Kai Uwe Broulik)]

broulik updated this revision to Diff 7664.
broulik added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  - Rebase on master
  - Implement ShellClient so it reads the property from Wayland windows
  
  The menu button shows up on Wayland but the menu itself doesn't - the menu is 
properly exported, though, I can access the menu from my applet just fine, as 
long as I know the DBus service name and object path, that is.

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3089?vs=7575=7664

REVISION DETAIL
  https://phabricator.kde.org/D3089

AFFECTED FILES
  CMakeLists.txt
  abstract_client.cpp
  abstract_client.h
  appmenu.cpp
  appmenu.h
  atoms.cpp
  atoms.h
  client.cpp
  client.h
  decorations/decoratedclient.cpp
  decorations/decoratedclient.h
  events.cpp
  kcmkwin/kwindecoration/declarative-plugin/previewclient.cpp
  kcmkwin/kwindecoration/declarative-plugin/previewclient.h
  manage.cpp
  shell_client.cpp
  shell_client.h
  useractions.cpp
  workspace.cpp
  workspace.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Updated, 483 lines] D3089: WIP: Restore global menu support

[broulik (Kai Uwe Broulik)]

broulik updated the test plan for this revision.
broulik updated this revision to Diff 7730.
broulik added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  - Cleanup a bit
  - Listen to menuShown signal rather than assuming a showMenu call will be 
successful
  - Listen to showRequest signal when an application wants the menu to show
  - Implement Wayland support

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3089?vs=7664=7730

REVISION DETAIL
  https://phabricator.kde.org/D3089

AFFECTED FILES
  CMakeLists.txt
  abstract_client.cpp
  abstract_client.h
  appmenu.cpp
  appmenu.h
  atoms.cpp
  atoms.h
  client.cpp
  client.h
  cmake/modules/FindQt5PlatformSupport.cmake
  decorations/decoratedclient.cpp
  decorations/decoratedclient.h
  events.cpp
  kcmkwin/kwindecoration/declarative-plugin/previewclient.cpp
  kcmkwin/kwindecoration/declarative-plugin/previewclient.h
  manage.cpp
  plugins/qpa/CMakeLists.txt
  shell_client.cpp
  shell_client.h
  useractions.cpp
  workspace.cpp
  workspace.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 1,679 lines] D3085: RFC: Use DBusMenu if available

[broulik (Kai Uwe Broulik)]

broulik updated the summary for this revision.
broulik updated the test plan for this revision.
broulik updated this revision to Diff 7726.
broulik added a comment.


  - Move setWindowProperty to x11/wayland integration to unclutter the code a 
bit
  
  - Adds an Alt key listener which, on long-pressing Alt, will activate the 
menu of the active window. This only works in QApplications with a QMainWindow, 
I'm open to suggestions how to improve this. Also, Alt+left-click for moving 
around the window still causes the timer to fire

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3085?vs=7652=7726

REVISION DETAIL
  https://phabricator.kde.org/D3085

AFFECTED FILES
  CMakeLists.txt
  COPYING.LGPL-2
  COPYING.LGPL-3
  COPYING.LIB
  autotests/CMakeLists.txt
  src/platformtheme/CMakeLists.txt
  src/platformtheme/kdeplatformtheme.cpp
  src/platformtheme/kdeplatformtheme.h
  src/platformtheme/kwaylandintegration.cpp
  src/platformtheme/kwaylandintegration.h
  src/platformtheme/qdbusmenubar.cpp
  src/platformtheme/qdbusmenubar_p.h
  src/platformtheme/x11integration.cpp
  src/platformtheme/x11integration.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated, 2,660 lines] D3086: RFC: Clean up KAppMenu

[broulik (Kai Uwe Broulik)]

broulik updated the summary for this revision.
broulik updated this revision to Diff 7727.
broulik added a comment.


  - Remove GtkIcons, it's not like GTK applications support this stuff 
anymore...
  - Introduce showMenu signal so KWin can reliably know whether the menu 
actually showed (sometimes when the menu doesn't show up for reasons, KWin 
would get stuck thinking it's open, so we explicitly emit a signal when we 
popup'd the menu)
  - Listen to ItemActivationRequested signal we emit in Plasma-Integration, 
when called with 0,0 arguments we emit a generic "show menu" request
  - Re-introduce Unity about to show hack but it doesn't actually fix the 
situation with Firefox for me :/

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3086?vs=7572=7727

REVISION DETAIL
  https://phabricator.kde.org/D3086

AFFECTED FILES
  appmenu/CMakeLists.txt
  appmenu/appmenu.cpp
  appmenu/appmenu.h
  appmenu/appmenu_dbus.cpp
  appmenu/appmenu_dbus.h
  appmenu/glowbar.cpp
  appmenu/glowbar.h
  appmenu/gtkicons.h
  appmenu/kdbusimporter.h
  appmenu/menubar.cpp
  appmenu/menubar.h
  appmenu/menubutton.cpp
  appmenu/menubutton.h
  appmenu/menuimporter.cpp
  appmenu/menuimporter.h
  appmenu/menuwidget.cpp
  appmenu/menuwidget.h
  appmenu/org.kde.kappmenu.xml
  appmenu/shadows.cpp
  appmenu/shadows.h
  appmenu/topmenubar.cpp
  appmenu/topmenubar.h
  appmenu/verticalmenu.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D3114: [Session Model] Show new session entry only if we actually can

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEf0e27ed71bcf: [Session Model] Show new session 
entry only if we actually can (authored by broulik).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3114?vs=7550=7772

REVISION DETAIL
  https://phabricator.kde.org/D3114

AFFECTED FILES
  components/sessionsprivate/sessionsmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Changed Subscribers] D3212: Support drags from Widget Explorer onto System Tray

[broulik (Kai Uwe Broulik)]

broulik added inline comments.

INLINE COMMENTS

> main.qml:241
> +onDragEnter: {
> +if (event.mimeData.formats.indexOf("text/x-plasmoidservicename") 
> < 0) {
> +event.ignore();

Can you split that into a function so we then have

  onDragEnter: {
  if (!isAcceptableDragEvent(event)) {
  event.ignore()
  return
  }
  }
  onDrop: {
  if (!isAcceptableDragEvent(event)) {
  event.ignore()
  return
  }
  ...
  }

> systemtray.h:100
>  
> +Q_INVOKABLE bool isSystemTrayApplet(const QString );
> +

const

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3212

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D2962: [Breeze Window Decoration] Disable size grip for windows without border

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  Wtf phab

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2962

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #breeze, #plasma:_design, #plasma, hpereiradacosta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 2,678 lines] D3086: Clean up KAppMenu

[broulik (Kai Uwe Broulik)]

broulik retitled this revision from "RFC: Clean up KAppMenu" to "Clean up 
KAppMenu".
broulik updated the test plan for this revision.
broulik updated this revision to Diff 7784.
broulik added a comment.


  - Cache atom to avoid roundtrip to the x server
  - Add "reconfigured" signal so interested parties (like KWin) get notified 
when the app menu config changes
  - Drop Gtk Icons mapping - it's not like GTK would support DBusMenu anymore 
anyway...

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3086?vs=7727=7784

REVISION DETAIL
  https://phabricator.kde.org/D3086

AFFECTED FILES
  appmenu/CMakeLists.txt
  appmenu/appmenu.cpp
  appmenu/appmenu.h
  appmenu/appmenu_dbus.cpp
  appmenu/appmenu_dbus.h
  appmenu/glowbar.cpp
  appmenu/glowbar.h
  appmenu/gtkicons.h
  appmenu/kdbusimporter.h
  appmenu/menubar.cpp
  appmenu/menubar.h
  appmenu/menubutton.cpp
  appmenu/menubutton.h
  appmenu/menuimporter.cpp
  appmenu/menuimporter.h
  appmenu/menuwidget.cpp
  appmenu/menuwidget.h
  appmenu/org.kde.kappmenu.xml
  appmenu/shadows.cpp
  appmenu/shadows.h
  appmenu/topmenubar.cpp
  appmenu/topmenubar.h
  appmenu/verticalmenu.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated] D2962: [Breeze Window Decoration] Disable size grip for windows without border

[broulik (Kai Uwe Broulik)]

broulik added a reviewer: hpereiradacosta.

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D2962

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #breeze, #plasma:_design, #plasma, hpereiradacosta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2962: [Breeze Window Decoration] Disable size grip for windows without border

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  Ping

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D2962

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #breeze, #plasma:_design, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Reopened] D2962: [Breeze Window Decoration] Disable size grip for windows without border

[broulik (Kai Uwe Broulik)]

broulik reopened this revision.

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D2962

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #breeze, #plasma:_design, #plasma, hpereiradacosta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2965: [Logout Greeter] Add QtQuickSettings

[broulik (Kai Uwe Broulik)]

broulik closed this revision.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2965

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, graesslin
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2959: [KAccess] Set componentDisplayName

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOPaad0a3e51d8e: [KAccess] Set componentDisplayName 
(authored by broulik).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2959?vs=7142=7781

REVISION DETAIL
  https://phabricator.kde.org/D2959

AFFECTED FILES
  kaccess/kaccess.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2962: [Breeze Window Decoration] Disable size grip for windows without border

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEf12a62830e81: [Logout Greeter] Add 
QtQuickSettings (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D2962?vs=7151=7779#toc

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2962?vs=7151=7779

REVISION DETAIL
  https://phabricator.kde.org/D2962

AFFECTED FILES
  ksmserver/logout-greeter/CMakeLists.txt
  ksmserver/logout-greeter/main.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #breeze, #plasma:_design, #plasma, hpereiradacosta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 440 lines] D3089: Restore global menu support

[broulik (Kai Uwe Broulik)]

broulik updated this revision to Diff 7785.
broulik added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  - Rebase on master
  - Honor global menu setting (only show button if is "in window decoration") 
and listen to kappmenu reconfigured signal

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3089?vs=7732=7785

REVISION DETAIL
  https://phabricator.kde.org/D3089

AFFECTED FILES
  CMakeLists.txt
  abstract_client.cpp
  abstract_client.h
  appmenu.cpp
  appmenu.h
  atoms.cpp
  atoms.h
  client.cpp
  client.h
  decorations/decoratedclient.cpp
  decorations/decoratedclient.h
  events.cpp
  kcmkwin/kwindecoration/declarative-plugin/previewclient.cpp
  kcmkwin/kwindecoration/declarative-plugin/previewclient.h
  manage.cpp
  org.kde.kappmenu.xml
  shell_client.cpp
  shell_client.h
  useractions.cpp
  workspace.cpp
  workspace.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 2 lines] D2962: [Breeze Window Decoration] Disable size grip for windows without border

[broulik (Kai Uwe Broulik)]

broulik changed the repository for this revision from rPLASMAWORKSPACE Plasma 
Workspace to rBREEZE Breeze.
broulik updated this revision to Diff 7780.
broulik added a comment.


  Restore original diff...

REPOSITORY
  rBREEZE Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2962?vs=7779=7780

REVISION DETAIL
  https://phabricator.kde.org/D2962

AFFECTED FILES
  kdecoration/breezesettingsdata.kcfg

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #breeze, #plasma:_design, #plasma, hpereiradacosta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 339 lines] D3216: WIP: Restore Menubar style config in application style

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This restores the configuration for whether menus should be shown in the 
application (no global menu), as title bar button, or as "widget".
  
  The notification popup is removed and replaced by a simple KMessageWidget. 
The option "Application Menu widget" doesn't actually do anything, it just 
enables global menu but not visible to the user. Perhaps it should show a hint, 
like "Place the Application Menu widget in a panel" or something like that.

TEST PLAN
  Placement for the message widget needs fixing.
  
  When I change the style from inapp to something else it shows that this 
setting will only work after restarting the respective app. The title bar 
button in KWin comes and goes as I change it to "title bar button" or something 
else.
  
  Technically, you could use window decoration button and the appmenu applet 
simultaneously (nothing keeps you from placing a appmenu widget even while it's 
set to title bar button) but that will cause interaction problems, eg. who's 
turn is it if I press Alt?
  The plasma applet could even say "application menu applet is currently not 
enabled [enable]" so we really allow only one of the two (we need something 
like this anyway when you disable appmenu and you have the applet)
  F394768: Screenshot_20161031_164535.png 

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3216

AFFECTED FILES
  kcms/style/CMakeLists.txt
  kcms/style/finetuning.ui
  kcms/style/kcmstyle.cpp
  kcms/style/kcmstyle.notifyrc

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2962: [Breeze Window Decoration] Disable size grip for windows without border

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  Thanks, Hugo.
  
  I just checked and resizing outside of windows works when I disable 
compositing. On Wayland there were some changes/fixes going on there but I need 
to check.{quote}I recal that "no borders" is not the default for the window 
decorations borders, so that the resize handle is indeed not visible by 
default.{quote}Right but it shows up as soon as you actually choose "No 
Borders" :)

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D2962

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #breeze, #plasma:_design, #plasma, hpereiradacosta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 442 lines] D3089: Restore global menu support

[broulik (Kai Uwe Broulik)]

broulik updated this revision to Diff 7787.
broulik added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  - Don't blindly connect applicationMenu*Enabled*Changed to 
hasApplicationMenuChanged because the former is just the setting but a client 
doesn't neccessarily have an application menu

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3089?vs=7785=7787

REVISION DETAIL
  https://phabricator.kde.org/D3089

AFFECTED FILES
  CMakeLists.txt
  abstract_client.cpp
  abstract_client.h
  appmenu.cpp
  appmenu.h
  atoms.cpp
  atoms.h
  client.cpp
  client.h
  decorations/decoratedclient.cpp
  decorations/decoratedclient.h
  events.cpp
  kcmkwin/kwindecoration/declarative-plugin/previewclient.cpp
  kcmkwin/kwindecoration/declarative-plugin/previewclient.h
  manage.cpp
  org.kde.kappmenu.xml
  shell_client.cpp
  shell_client.h
  useractions.cpp
  workspace.cpp
  workspace.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Abandoned] D2962: [Breeze Window Decoration] Disable size grip for windows without border

[broulik (Kai Uwe Broulik)]

broulik abandoned this revision.

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D2962

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #breeze, #plasma:_design, #plasma, hpereiradacosta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D3247: Invert the scroll direction for wheel events on internal windows

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  How does that affect horizontal scrolling? Also, does that already take into 
account scroll direction "natural"/normal (or was that maybe the case for it 
being wrong in the first place?)?

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3247

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, broulik
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D3232: [Lock Screen] Don't assume last user is "New Session" entry

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEd1133288c335: [Lock Screen] Don't assume last 
user is "New Session" entry (authored by broulik).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3232?vs=7835=7865

REVISION DETAIL
  https://phabricator.kde.org/D3232

AFFECTED FILES
  lookandfeel/contents/lockscreen/LockScreenUi.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, subdiff, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 3 lines] D3231: [Lock Screen] Show "Switch User" button only if allowed

[broulik (Kai Uwe Broulik)]

broulik updated this revision to Diff 7866.
broulik added a comment.


  Take into account canSwitchUser

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3231?vs=7834=7866

REVISION DETAIL
  https://phabricator.kde.org/D3231

AFFECTED FILES
  lookandfeel/contents/lockscreen/LockScreenUi.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, subdiff
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3244: Internal windows cannot be minimized

[broulik (Kai Uwe Broulik)]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  internal-window-non-minimize-5.8

REVISION DETAIL
  https://phabricator.kde.org/D3244

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, broulik
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3247: Invert the scroll direction for wheel events on internal windows

[broulik (Kai Uwe Broulik)]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Verified that horizontal scrolling also scrolls correctly (dragged one 
TreeWidget colum super wide to have it scroll)

REPOSITORY
  rKWIN KWin

BRANCH
  invert-scroll-direction-internal-window-5.8

REVISION DETAIL
  https://phabricator.kde.org/D3247

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, broulik
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 445 lines] D3089: Restore global menu support

[broulik (Kai Uwe Broulik)]

broulik updated this revision to Diff 7832.
broulik added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  - Move comment
  - Check for service name / object path being empty before finding a client
  - Remove added empty line

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3089?vs=7787=7832

REVISION DETAIL
  https://phabricator.kde.org/D3089

AFFECTED FILES
  CMakeLists.txt
  abstract_client.cpp
  abstract_client.h
  appmenu.cpp
  appmenu.h
  atoms.cpp
  atoms.h
  client.cpp
  client.h
  decorations/decoratedclient.cpp
  decorations/decoratedclient.h
  events.cpp
  kcmkwin/kwindecoration/declarative-plugin/previewclient.cpp
  kcmkwin/kwindecoration/declarative-plugin/previewclient.h
  manage.cpp
  org.kde.kappmenu.xml
  shell_client.cpp
  shell_client.h
  useractions.cpp
  workspace.cpp
  workspace.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Request, 3 lines] D3231: [Lock Screen] Show "Switch User" button only if allowed

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, subdiff.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Only the button if there's a session to switch to and/or the user is allowed 
to launch a new session.

TEST PLAN
  Default setup, no other session: Got the button with a switch user entry
  Disabled new session starting via kiosk restriction: No swtich user entry
  Started a new session on console: Got the button again

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3231

AFFECTED FILES
  lookandfeel/contents/lockscreen/LockScreenUi.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, subdiff
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 3 lines] D3232: [Lock Screen] Don't assume last user is "New Session" entry

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, subdiff.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Ask the model instead. The entry might not be there if the user is not 
allowed to start a new session

TEST PLAN
  Creating new sessions (didn't know there was magic code in the session model 
that switching to a negative VT would start a new session...) and switching 
still works. Button label is also correct, even if I'm not allowed to create a 
new session and I select the last user.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3232

AFFECTED FILES
  lookandfeel/contents/lockscreen/LockScreenUi.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, subdiff
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Changed Subscribers] D3159: Set wayland output scale

[broulik (Kai Uwe Broulik)]

broulik added inline comments.

INLINE COMMENTS

> x11windowed_backend.cpp:477-480
> +QVector ret;
> +for (auto it = m_windows.constBegin(); it != m_windows.constEnd(); ++it) 
> {
> +ret << initialOutputScale();
> +}

QVector ::fill(const T , int size = -1)

Assigns value to all items in the vector. If size is different from -1 (the 
default), the vector is resized to size size beforehand.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3159

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: broulik, graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Updated, 381 lines] D3089: Restore global menu support

[broulik (Kai Uwe Broulik)]

broulik retitled this revision from "WIP: Restore global menu support" to 
"Restore global menu support".
broulik updated this revision to Diff 7732.
broulik added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  - Rebase to QtPlatformSupport cmake changes - cannot test with Qt 5.8
  - Ship a copy of kappmenu.xml

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3089?vs=7730=7732

REVISION DETAIL
  https://phabricator.kde.org/D3089

AFFECTED FILES
  CMakeLists.txt
  abstract_client.cpp
  abstract_client.h
  appmenu.cpp
  appmenu.h
  atoms.cpp
  atoms.h
  client.cpp
  client.h
  decorations/decoratedclient.cpp
  decorations/decoratedclient.h
  events.cpp
  kcmkwin/kwindecoration/declarative-plugin/previewclient.cpp
  kcmkwin/kwindecoration/declarative-plugin/previewclient.h
  manage.cpp
  org.kde.kappmenu.xml
  shell_client.cpp
  shell_client.h
  useractions.cpp
  workspace.cpp
  workspace.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Updated] D3051: [applets/notification] Add nullptr check

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  While in principle the patch is fine, the only way this can be null is when 
NotificationPopup.qml (which is a Plasma Dialog) failed to load, so I think 
we're masking a deeper problem here.
  
var popup = notificationPopupComponent.createObject();
notificationPositioner.addNotificationPopup(popup);

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3051

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3038: [krunner] Make KRunner on Wayland a Panel

[broulik (Kai Uwe Broulik)]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  krunner-wayland-panel

REVISION DETAIL
  https://phabricator.kde.org/D3038

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D3012: [DrKonqi] Update URL to Wiki page on how to create useful bug reports

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEb9a75d39cf86: [DrKonqi] Update URL to Wiki 
page on how to create useful bug reports (authored by broulik).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3012?vs=7282=7297

REVISION DETAIL
  https://phabricator.kde.org/D3012

AFFECTED FILES
  drkonqi/drkonqi_globals.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 2,180 lines] D3086: RFC: Clean up KAppMenu

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This is part two in a series to restore global menu support in Plasma.
  
  Massively cleanup KAppMenu by removing outdated and unused code. The global 
menu has been removed as it will eventually be provided by a plasmoid (famous 
last words). Also many of the workarounds (like the unity about to show hack) 
have been removed and will only get re-introduced if they are in fact still 
neccessary.

TEST PLAN
  Added the following to ~/.config/kdeglobals
  
[Appmenu Style]
Style=ButtonVertical
  
  Applications like Kwrite, Dolphin, as well as VLC start exporting their manus 
on DBus now. The "showMenu" method on the org.kde.kappmenu dbus interface can 
be used to show the application menu.
  
  The about to show hack seemed to have been neccessary for the global menu 
which is updated as soon as the active menu changes; right now calling showMenu 
does work with Firefox.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3086

AFFECTED FILES
  appmenu/CMakeLists.txt
  appmenu/appmenu.cpp
  appmenu/appmenu.h
  appmenu/glowbar.cpp
  appmenu/glowbar.h
  appmenu/kdbusimporter.h
  appmenu/menubar.cpp
  appmenu/menubar.h
  appmenu/menubutton.cpp
  appmenu/menubutton.h
  appmenu/menuimporter.cpp
  appmenu/menuimporter.h
  appmenu/menuwidget.cpp
  appmenu/menuwidget.h
  appmenu/shadows.cpp
  appmenu/shadows.h
  appmenu/topmenubar.cpp
  appmenu/topmenubar.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3085: RFC: Use DBusMenu if available

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  It's not much code on our side because Qt has the code nowadays. :)

INLINE COMMENTS

> graesslin wrote in FindQt5PlatformSupport.cmake:1
> given that it has my copyright I assume you copied from kwin - that would be 
> a reason to move it to ecm. We have two users.

+1 to that.

I had one issue regarding the include path, though, but I can't reproduce it 
anymore and I forgot what I actually did but the path I need is

  /usr/include/x86_64-linux-gnu/qt5/QtPlatformSupport/5.7.0/QtPlatformSupport/

but I sometimes got

  /usr/include/x86_64-linux-gnu/qt5/QtPlatformSupport/5.7.0/

but I'm sure we can figur that out.

> graesslin wrote in kdeplatformtheme.cpp:59
> can we really make that static? What about runtime changes?

That's what Qt does and I don't think Qt is equipped to re-create a platform 
menu at runtime; at least that's what I was told when I raised the very same 
concern in the upstream Qt codereview that added this.

We could perhaps do it for newly created menus but when the service becomes 
unavailable at runtime there's no way for us to re-create existing menus.

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D3085

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Request, 171 lines] D3085: RFC: Use DBusMenu if available

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAINTEGRATION Integration 
for Qt applications in Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This is part one in a series to restore global menu support in Plasma.
  
  Since we inherit from QPlatformTheme we do not get the global menu support 
for free like Qt's own platform themes inheriting from QGenericUnixTheme would, 
hence the use of private headers.

TEST PLAN
  - platform integration cmake thing is from kwin
  - checkDBusGlobalMenuAvailable() et al are from Qt's upstream
  - requires Qt 5.7
  
  - in KXMLGui applications you still get a traditional menu bar in addition to 
the global menu, it seems it explicitly sets visible true on the menu bar - in 
VLC it hides its own menu bar.
  
  Upcoming patches will:
  
  - restore and cleanup kappmenu (the kded module that acts as a registrar for 
Qt apps, so they will actually start exporting their menus)

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D3085

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  cmake/modules/FindQt5PlatformSupport.cmake
  src/platformtheme/CMakeLists.txt
  src/platformtheme/kdeplatformtheme.cpp
  src/platformtheme/kdeplatformtheme.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 89 lines] D3088: WIP: Restore application menu button

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rKDECORATION Window Decoration 
Library.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  rKDECORATION Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D3088

AFFECTED FILES
  autotests/mockclient.cpp
  autotests/mockclient.h
  src/decoratedclient.cpp
  src/decoratedclient.h
  src/decoration.cpp
  src/decoration.h
  src/decorationbutton.cpp
  src/private/decoratedclientprivate.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 286 lines] D3089: WIP: Restore global menu support

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rKWIN KWin.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

TEST PLAN
  Together with the other three patches gives you an application menu button in 
the title bar.
  
  What doesn't work is pressing Alt in an app and have the global menu open. 
There basically the app tells kwin to show the menu which then tells the 
decoration which gets the offset from the button and passes that back to kwin 
which then opens the menu ……… I suppose?
  
  F367907: Screenshot_20161017_124159.png 

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3089

AFFECTED FILES
  CMakeLists.txt
  abstract_client.cpp
  abstract_client.h
  appmenu.cpp
  appmenu.h
  config-kwin.h.cmake
  decorations/decoratedclient.cpp
  decorations/decoratedclient.h
  kcmkwin/kwindecoration/declarative-plugin/previewclient.cpp
  kcmkwin/kwindecoration/declarative-plugin/previewclient.h
  useractions.cpp
  workspace.cpp
  workspace.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Updated] D3606: Listen for broadcast notifications on system bus

[broulik (Kai Uwe Broulik)]

broulik retitled this revision from "RFC: Listen for broadcast notifications on 
system bus" to "Listen for broadcast notifications on system bus".
broulik updated the summary for this revision.
broulik updated the test plan for this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3606

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 52 lines] D3606: Listen for broadcast notifications on system bus

[broulik (Kai Uwe Broulik)]

broulik updated the test plan for this revision.
broulik updated this revision to Diff 8854.
broulik added a comment.


  - Drop plasmashell from interface name and upper camel case

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3606?vs=8853=8854

REVISION DETAIL
  https://phabricator.kde.org/D3606

AFFECTED FILES
  dataengines/notifications/notificationsengine.cpp
  dataengines/notifications/notificationsengine.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 52 lines] D3606: Listen for broadcast notifications on system bus

[broulik (Kai Uwe Broulik)]

broulik removed a subscriber: davidedmundson.
broulik updated this revision to Diff 8853.
broulik added a comment.


  - Support passing "uids" as stringlist, my initial QVariantList with int 
approach didnt really work
  - Enable only if configured

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3606?vs=8806=8853

REVISION DETAIL
  https://phabricator.kde.org/D3606

AFFECTED FILES
  dataengines/notifications/notificationsengine.cpp
  dataengines/notifications/notificationsengine.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3616: [Lock Screen / Login] Add "reveal password button"

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  One thing we perhaps should do is add a kiosk restriction to globally disable 
this button everywhere.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3616

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, #plasma, graesslin
Cc: cfeck, graesslin, subdiff, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Accepted] D3607: AppletConfiguration: Remove custom handling of moving window

[broulik (Kai Uwe Broulik)]

broulik accepted this revision.
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3607

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3606: Listen for broadcast notifications on system bus

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  What would be the best place to put a little utility (similar to notify-send 
or kdialog --passivepopup) for this?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3606

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3598: rework kscreen's OSD logic

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  A bunch of nitpicks below. Haven't tried it yet, though :)
  
  Is there a chance we could serve the novice user usecase of Meta+P and then 
*click* / choose the desired setup? As far as I can tell we only show "You now 
use $setup" but not "You can choose: [Clone, Left of, Internal only, External 
only, Right of]" (doesn't neccessarily have to be part of this patchset, 
obviously, just food for thought, and you know how obsessed I am with the 
Meta+P menu ;)

INLINE COMMENTS

> daemon.cpp:242-243
>  QDBusConnection::sessionBus().asyncCall(msg);
> +
> +
> +}

Superfluous lines

> daemon.cpp:283
>  
> +QHash actionMessages({
> +{Generator::DisplaySwitchAction::None, i18nc("osd when displaybutton 
> is pressed", "No Action")},

static?

> daemon.cpp:287
> +{Generator::DisplaySwitchAction::ExtendToLeft, i18nc("osd when 
> displaybutton is pressed", "Extend Left")},
> +{Generator::DisplaySwitchAction::TurnOffEmbedded, i18nc("osd when 
> displaybutton is pressed", "Embedded Off")},
> +{Generator::DisplaySwitchAction::TurnOffExternal, i18nc("osd when 
> displaybutton is pressed", "External Off")},

Not sure about "Embedded", perhaps "Internal"? Dunno.

Also I'd rather turn the wording around, rather than "internal off" and 
"external off", say "external only" and "internal only"?

> daemon.cpp:291
> +});
> +QString message = actionMessages.value(m_iteration);
> +

const &

> osd.cpp:32
> +
> +namespace KScreen {
> +

using namespace

> osd.cpp:37
> +, m_output(output)
> +, 
> m_osdPath(QStandardPaths::locate(QStandardPaths::QStandardPaths::GenericDataLocation,
>  QStringLiteral("kded_kscreen/qml/Osd.qml")))
> +, m_osdObject(new KDeclarative::QmlObject(this))

You're only using it in the constructor, no need for it to be a member variable 
that stays around

> osd.cpp:38
> +, 
> m_osdPath(QStandardPaths::locate(QStandardPaths::QStandardPaths::GenericDataLocation,
>  QStringLiteral("kded_kscreen/qml/Osd.qml")))
> +, m_osdObject(new KDeclarative::QmlObject(this))
> +{

Can we lazy-load this first time it is used? It's not like you often change 
screen setup

Edit: nvm, saw later that you actually create the entire thing on demand

> osd.cpp:53
> +
> +if (!m_osdTimer) {
> +m_osdTimer = new QTimer(this);

Is always null here

> osd.cpp:85
> +} else {
> +realSize = QSize(mode->size().height(), mode->size().width());
> +}

QSize has a transpose() method "Swaps the width and height values."

> osd.cpp:120
> +// pukes loads of warnings into our logs
> +if (qGuiApp->platformName() == QStringLiteral("xcb")) {
> +rootObject->setProperty("animateOpacity", false);

Compare with QL1S - in case you have KWindowSystem you can ask it

> osd.h:47
> +void showOutputIdentifier(const KScreen::OutputPtr output);
> +
> +

Superfluous line

> osd.h:49
> +
> +private Q_SLOTS:
> +void hideOsd();

Doesn't have to be a slot with new connect syntax

> osdmanager.cpp:21
> +#include "osd.h"
> +#include "debug.h"
> +

Unused?

> osdmanager.cpp:31
> +
> +OsdManager* OsdManager::m_instance = 0;
> +

nullptr, also s_ prefix since it's static

> osdmanager.cpp:41
> +connect(m_cleanupTimer, ::timeout, this, [this]() {
> +qDeleteAll(m_osds.begin(), m_osds.end());
> +m_osds.clear();

There's a a qDeleteAll(m_osds) that does begin() and end() for you

> osdmanager.cpp:44
> +});
> +
> QDBusConnection::sessionBus().registerObject(QStringLiteral("/org/kde/kscreen/osdService"),
>  this, QDBusConnection::ExportAllSlots | QDBusConnection::ExportAllSignals);
> +}

There are no signals in this class

> osdmanager.cpp:78
> +KScreen::Osd* osd = nullptr;
> +if (m_osds.keys().contains(output->name())) {
> +osd = m_osds.value(output->name());

QMap::contains(key), no need for keys()

Also, better use (const)Find to avoid double loop-up (once for contains and 
once for value)

> osdmanager.cpp:99
> +
> +const KScreen::ConfigPtr config = 
> qobject_cast(op)->config();
> +

Can you perhaps put that stuff into a separate function to avoid code 
duplication - the loops are almost identical

> Osd.qml:57
> +if (item != undefined) {
> +item.rootItem = root;
> +}

Not really happy with this "rootItem" property but then David told us that 
randomly accessing properties outside a file is bad, too ;)

Perhaps try

  Loader setSource(source, {rootItem: root})

so the item is already created with that property set, avoids warnings and/or 
`foo ? foo.bar : null` dance and re-evaluations

> OsdItem.qml:55
> +}
> +Component.onCompleted: print("osditem loaded..." + root.infoText);
> +}

;)

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D3598

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Closed] D3615: [Kicker] Hide "Edit Applications..." context menu entry if system immutable

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:00d160aab929: [Kicker] Hide "Edit Applications..." 
context menu entry if system immutable (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3615?vs=8834=8934

REVISION DETAIL
  https://phabricator.kde.org/D3615

AFFECTED FILES
  applets/kicker/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3660: Plasma 5.9 "Canopee" Wallpaper

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  Overall I quite like it, especially the stylized 9 referencing Plasma 5.9 
(not sure if that was fully intentional, though? ;)
  
  The blurry jaggy, coronal mass ejection like edges of the yellow band, look 
weird.
  F708275: Screenshot_20161213_081935.png 
  F708277: Screenshot_20161213_082052.png 
  F708280: Screenshot_20161213_082113.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3660

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kvermette, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Closed] D3660: Plasma 5.9 "Canopee" Wallpaper

[broulik (Kai Uwe Broulik)]

broulik closed this revision.
broulik added a comment.


  Committed into master in 
https://cgit.kde.org/breeze.git/commit/?id=ab984d2ed689322c3b11be6042053bcfd33f3807

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3660

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kvermette, #plasma, broulik
Cc: mart, broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3660: Plasma 5.9 "Canopee" Wallpaper

[broulik (Kai Uwe Broulik)]

broulik accepted this revision.
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3660

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kvermette, #plasma, broulik
Cc: mart, broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Request, 204 lines] D3674: RFC: Allow pausing media players when screen is locked

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design, graesslin.
broulik set the repository for this revision to R133 KScreenLocker.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  ... and unpause those that were playing before when unlocking.
  
  BUG: 373641
  FIXED-IN: 5.9.0

TEST PLAN
  Locked screen, VLC stopped, unlocked screen, VLC continued playing
  
  Default is off, ie. keep playing
  
  F719087: Screenshot_20161214_144521.png 

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D3674

AFFECTED FILES
  CMakeLists.txt
  kcfg/kscreenlockersettings.kcfg
  kcm/kcm.ui
  ksldapp.cpp
  ksldapp.h
  mpris.cpp
  mpris.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, graesslin
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 1,015 lines] D2687: [Icon Widget] Bring back properties dialog

[broulik (Kai Uwe Broulik)]

broulik updated this revision to Diff 9074.
broulik added a comment.


  - Remove now unused icon qml plugin
  - Drop cumbersome drop handling – if the user explicitly dropped some files 
somewhere the application should just launch with them, shouting at the user if 
unsupported

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2687?vs=9029=9074

REVISION DETAIL
  https://phabricator.kde.org/D2687

AFFECTED FILES
  applets/icon/CMakeLists.txt
  applets/icon/iconapplet.cpp
  applets/icon/iconapplet.h
  applets/icon/package/contents/config/main.xml
  applets/icon/package/contents/ui/main.qml
  applets/icon/plugin/icon_p.cpp
  applets/icon/plugin/icon_p.h
  applets/icon/plugin/iconplugin.cpp
  applets/icon/plugin/iconplugin.h
  applets/icon/plugin/qmldir
  runners/baloo/baloosearchrunner.cpp
  runners/calculator/calculatorrunner.cpp
  runners/recentdocuments/recentdocuments.cpp
  runners/shell/shellrunner.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, dfaure, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3705: do not explicitly check NotShownIn it's not necessary and incomplete

[broulik (Kai Uwe Broulik)]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3705

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D3688: [Runners] Register actions right away

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:4440a0d0115f: [Runners] Register actions right away 
(authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3688?vs=9043=9085

REVISION DETAIL
  https://phabricator.kde.org/D3688

AFFECTED FILES
  runners/baloo/baloosearchrunner.cpp
  runners/calculator/calculatorrunner.cpp
  runners/recentdocuments/recentdocuments.cpp
  runners/shell/shellrunner.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 56 lines] D3688: [Runners] Register actions right away

[broulik (Kai Uwe Broulik)]

broulik updated this revision to Diff 9043.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3688?vs=9042=9043

REVISION DETAIL
  https://phabricator.kde.org/D3688

AFFECTED FILES
  runners/baloo/baloosearchrunner.cpp
  runners/calculator/calculatorrunner.cpp
  runners/recentdocuments/recentdocuments.cpp
  runners/shell/shellrunner.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 54 lines] D3688: [Runners] Register actions right away

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design, hein.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Previously, they were created on-demand, which was the wrong approach, I 
think.
  Kicker checks for actions() being available before it even bothers getting 
actions for a match.

TEST PLAN
  I now get runner actions in Kickoff for search results.
  F743618: Screenshot_20161215_173627.png 
  F743649: Spectacle.M20286.png 
  
  Verified that:
  
  - shell runner still runs applications and run in terminal still works, both 
in KRunner and Kickoff
  - calculator runner still invokes result and copy to clipboard, in KRunner
  - recent docs runner still opens files and open containing folder action 
still works, both in KRunner and Kickoff
  - baloo runner still opens files and open containing folder action still 
works, both in KRunner and Kickoff

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3688

AFFECTED FILES
  runners/baloo/baloosearchrunner.cpp
  runners/calculator/calculatorrunner.cpp
  runners/recentdocuments/recentdocuments.cpp
  runners/shell/shellrunner.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3687: take matching logic out of match method and put it into a class

[broulik (Kai Uwe Broulik)]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Thanks

INLINE COMMENTS

> servicerunner.cpp:124
> +qCDebug(RUNNER_SERVICES) << service->name() << "is an exact 
> match!" << service->storageId() << service->exec();
> +if (service->noDisplay() || 
> service->property(QStringLiteral("NotShowIn"), QVariant::String) == "KDE") {
>  continue;

isnt NotShowIn a list property? Doesn't KService have a getter for that or even 
take that into account in noDisplay()?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3687

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3706: WIP: Global Menu Applet

[broulik (Kai Uwe Broulik)]

broulik added inline comments.

INLINE COMMENTS

> appmenuapplet.cpp:91
> +ctx->window()->mouseGrabberItem()->ungrabMouse();
> +}
> +

Somehow your indentation is a bit off?

> configGeneral.qml:44
> +id: fullRepresentationRadio
> +text: i18n("Full Representation")
> +exclusiveGroup: representationGroup

Not too happy with the naming here. The old applet just had a checkbox for "Use 
single button" for menu or something like that, that would also simplify the 
settings page a lot ;)

> configGeneral.qml:56
> +if (plasmoid.configuration.fullRepresentation) {
> + fullRepresentationRadio.checked = true
> +} else {

I *think* you can just in the ExclusiveGroup above bind to the "current" 
property:

  Controls.ExclusiveGroup {
  id: representationGroup
  current: plasmoid.configuration.fullRepresentation ? 
fullRepresentationRadio : compactRepresentationRadio
  }

or you could perhaps just bind "checked" in the RadioButtons

  checked: plasmoid.configuration.fullRepresentation

> main.qml:25
> +import org.kde.plasma.components 2.0 as PlasmaComponents
> +import org.kde.plasma.private.appmenu 1.0 as AppMenuPrivate
> +

Can you perhaps look into making it a c++ applet rather than using a private 
import – we somewhat try to get away from this

> main.qml:37-38
> +
> +Layout.minimumWidth: units.iconSizes.large
> +Layout.minimumHeight: units.iconSizes.large
> +

Perhaps base that on font size (or just units.gridUnit)

> main.qml:42
> +
> +Plasmoid.compactRepresentation: Component {
> +PlasmaComponents.ToolButton {

I don't think this needs to be wrapped in Component

> main.qml:43
> +Plasmoid.compactRepresentation: Component {
> +PlasmaComponents.ToolButton {
> +Layout.fillWidth: root.vertical

Also, I find it pretty cool that you just use compact and full rep for that :) 
I would not have thought of that

> main.qml:67-73
> +var count = buttonRepeater.count
> +var idx = index;
> +if (idx >= count) {
> +idx = 0;
> +} else if (idx < 0) {
> +idx = count - 1;
> +}

var idx = Math.max(0, Math.min(buttonRepeater.count - 1, index))

(too bad there's no qBound in QML)

> main.qml:77
> +if (button) {
> +plasmoid.nativeInterface.trigger(button, 
> button.buttonData, idx);
> +}

You could just do button.clicked() which will end up executing the onClicked 
below instead of duplicating the logic here

> main.qml:88
> +readonly property int buttonIndex: index
> +readonly property var buttonData: activeActions
> +

buttonData is pretty generic of a name

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3706

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: chinmoyr, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D2687: [Icon Widget] Bring back properties dialog

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:caea0aa4ee22: [Icon Widget] Bring back properties dialog 
(authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D2687?vs=9074=9086#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2687?vs=9074=9086

REVISION DETAIL
  https://phabricator.kde.org/D2687

AFFECTED FILES
  applets/icon/CMakeLists.txt
  applets/icon/iconapplet.cpp
  applets/icon/iconapplet.h
  applets/icon/package/contents/config/main.xml
  applets/icon/package/contents/ui/main.qml
  applets/icon/plugin/icon_p.cpp
  applets/icon/plugin/icon_p.h
  applets/icon/plugin/iconplugin.cpp
  applets/icon/plugin/iconplugin.h
  applets/icon/plugin/qmldir

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, dfaure, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 594 lines] D2687: [Icon Widget] Bring back properties dialog

[broulik (Kai Uwe Broulik)]

broulik retitled this revision from "WIP: [Icon Widget] Bring back properties 
dialog" to "[Icon Widget] Bring back properties dialog".
broulik updated the test plan for this revision.
broulik updated this revision to Diff 8967.
broulik added a comment.


  - Ensure Link desktop file is actually .desktop so the properties dialog 
offers to change the URL
  - Emit jump list actions changed when they do (fixes jump list actions not 
working when applet is created for the first time)
  - Call sync() on the KDesktopFile we created for the file Links so the applet 
works when it is created for the first time for a file
  - KIO::suggestName always appends suffix, so check whether the file exists 
before
  - use new KRun to run the apps and QProcess::startDetached as suggested by 
David F
  - Cleanup a bit, at least try to ;)

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2687?vs=6501=8967

REVISION DETAIL
  https://phabricator.kde.org/D2687

AFFECTED FILES
  applets/icon/CMakeLists.txt
  applets/icon/iconapplet.cpp
  applets/icon/iconapplet.h
  applets/icon/package/contents/config/main.xml
  applets/icon/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, dfaure
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3651: Add utility to send broadcast notifications

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  > I wonder if it can take usernames instead of uids?
  
  Perhaps not "instead" but in addition. The tool is mostly meant to be used by 
background services and scripts, so remembering should not be an issue but we 
can offer both. Will make a patch for the notifications dataengine.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D3651

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: bshah, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D2687: WIP: [Icon Widget] Bring back properties dialog

[broulik (Kai Uwe Broulik)]

broulik marked 9 inline comments as done.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2687

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, dfaure
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3654: [TextField] Allow disabling reveal password button through KIOSK restriction

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  > could also be a property of an object that's inside instead of the root 
object
  
  I also need to access it from the style and didn't want to randomly do 
control.someRandomObject.foo

REPOSITORY
  R242 Plasma Frameworks

REVISION DETAIL
  https://phabricator.kde.org/D3654

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 594 lines] D2687: [Icon Widget] Bring back properties dialog

[broulik (Kai Uwe Broulik)]

broulik updated this revision to Diff 8968.
broulik added a comment.


  - Create context menu actions on demand, saves some cycles on startup and 
more importantly allows us to follow SystemImmutable

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2687?vs=8967=8968

REVISION DETAIL
  https://phabricator.kde.org/D2687

AFFECTED FILES
  applets/icon/CMakeLists.txt
  applets/icon/iconapplet.cpp
  applets/icon/iconapplet.h
  applets/icon/package/contents/config/main.xml
  applets/icon/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, dfaure
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D3663: [Task Manager] Don't emit urls dropped on drag enter

[broulik (Kai Uwe Broulik)]

broulik retitled this revision from "[Task Manager] Don't emit urls droppde on 
drag enter" to "[Task Manager] Don't emit urls dropped on drag enter".

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3663

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 1 line] D3663: [Task Manager] Don't emit urls droppde on drag enter

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, hein, davidedmundson.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Otherwise we'll unexpectedly create a launcher right away.

TEST PLAN
  Dragged an app from kickoff to task manager, no longer got a launcher created 
immediately.
  
  Regression introduced by 
https://phabricator.kde.org/R119:c50948648012e66b71b757e211432190d592c90d

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3663

AFFECTED FILES
  applets/taskmanager/package/contents/ui/MouseHandler.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D3663: [Task Manager] Don't emit urls dropped on drag enter

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:643e424d7f1e: [Task Manager] Don't emit urls dropped on 
drag enter (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3663?vs=8969=8970

REVISION DETAIL
  https://phabricator.kde.org/D3663

AFFECTED FILES
  applets/taskmanager/package/contents/ui/MouseHandler.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, hein, davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D3606: Listen for broadcast notifications on system bus

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:dcf8e3dca547: Listen for broadcast notifications on 
system bus (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D3606?vs=8854=8943#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3606?vs=8854=8943

REVISION DETAIL
  https://phabricator.kde.org/D3606

AFFECTED FILES
  dataengines/notifications/notificationsengine.cpp
  dataengines/notifications/notificationsengine.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, mart, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Request, 121 lines] D3651: Add utility to send broadcast notifications

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R126 KDE CLI Utilities.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This adds a command-line utility kbroadcastnotification that emits a signal 
on the system DBus listened to by Plasma's notifications dataengine, cf. [1]
  
  [1] https://phabricator.kde.org/D3606

TEST PLAN
kbroadcastnotification --summary "Backup failed" --persistent --icon 
dialog-error --uids 1000,1337 "Please contact system administration for 
assistance."
  
  F701355: Screenshot_20161212_144253.png 

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D3651

AFFECTED FILES
  CMakeLists.txt
  kbroadcastnotification/CMakeLists.txt
  kbroadcastnotification/Messages.sh
  kbroadcastnotification/main.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 12 lines] D3654: [TextField] Allow disabling reveal password button through KIOSK restriction

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R242 Plasma Frameworks.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This introduces a new lineedit_reveal_password restriction (similar to 
lineedit_text_completion) that disables the reveal password button on Plasma 
text fields, like the lock screen and WiFi password inputs.

TEST PLAN
  Placed the following in kdeglobals
  
[KDE Action Restrictions]
lineedit_reveal_password=false
  
  No longer got said button on the lock screen and click area for the textfield 
also was as if the button was never there. Without aforementioned restriction 
it behaves like before.
  
  As discussed in https://phabricator.kde.org/D3616
  
  Depends on https://git.reviewboard.kde.org/r/129642/
  
  Needs additional patch in plasma-nm. KNewPasswordDialog is in KWidgetsAddons 
which cannot depend on KConfigCore (where KAuthorized) is and thus we cannot do 
this there. However, being able to restrict this in the most prominent places 
should be good enough™

REPOSITORY
  R242 Plasma Frameworks

REVISION DETAIL
  https://phabricator.kde.org/D3654

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/TextField.qml
  src/declarativeimports/plasmastyle/TextFieldStyle.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D3654: [TextField] Allow disabling reveal password button through KIOSK restriction

[broulik (Kai Uwe Broulik)]

broulik updated the test plan for this revision.

REPOSITORY
  R242 Plasma Frameworks

REVISION DETAIL
  https://phabricator.kde.org/D3654

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D3616: [Lock Screen / Login] Add "reveal password button"

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:2f9bfbc5e153: [Lock Screen / Login] Add "reveal password 
button" (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3616?vs=8841=8947

REVISION DETAIL
  https://phabricator.kde.org/D3616

AFFECTED FILES
  lookandfeel/contents/lockscreen/MainBlock.qml
  sddm-theme/Login.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, #plasma, graesslin
Cc: colomar, cfeck, graesslin, subdiff, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D3667: [MPRIS Dataengine] Let clients distinguish media players by process id more easily

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  LGTM overall
  
  "Prototype of redesigned taskbar" made me curious ;)

INLINE COMMENTS

> playercontainer.cpp:123
> +int secondaryInstancePid = -1;
> +int lastPoint = m_dbusAddress.lastIndexOf(".");
> +QString end = m_dbusAddress.right(m_dbusAddress.length() - (lastPoint + 
> 1));

QLatin1Char?

> playercontainer.cpp:124
> +int lastPoint = m_dbusAddress.lastIndexOf(".");
> +QString end = m_dbusAddress.right(m_dbusAddress.length() - (lastPoint + 
> 1));
> +const QString pre = "instance";

Can you use rightRef and the like, if possible?

> playercontainer.cpp:128
> +end.remove(0, pre.length());
> +bool convertSuccess;
> +int i = end.toInt();

bool ok;

is sufficient in that context imho

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3667

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Closed] D3593: [Folder View] Clear hover state when mouse leaves view

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7585f2953635: [Folder View] Clear hover state when mouse 
leaves view (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3593?vs=8767=8820

REVISION DETAIL
  https://phabricator.kde.org/D3593

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, hein, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 4 lines] D3615: [Kicker] Hide "Edit Applications..." context menu entry if system immutable

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  We don't want users in a locked-down environment to mess with applications.
  This makes it consistent with Kickoff.

TEST PLAN
  Reported in 
https://mail.kde.org/pipermail/enterprise/2016-December/35.html
  
  Placed the following in kdeglobals:
  
[KDE Action Restrictions]
plasma/plasmashell/unlockedDesktop=false
  
  No longer got "Edit Applications..." entry in Kickoff and kickerdash. Without 
it behaves like before.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3615

AFFECTED FILES
  applets/kicker/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 2 lines] D3616: [Lock Screen / Login] Add "reveal password button"

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Allows to show the password on click, similar to how it's done in most other 
password fields throughout the workspace.

TEST PLAN
  F672029: Screenshot_20161207_125143.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3616

AFFECTED FILES
  lookandfeel/contents/lockscreen/MainBlock.qml
  sddm-theme/Login.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3603: Option to show percentage charge in the icon

[broulik (Kai Uwe Broulik)]

broulik accepted this revision.
broulik added a reviewer: broulik.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> BadgeOverlay.qml:31
> +id: badgeRect
> +x: Qt.application.layoutDirection === Qt.RightToLeft ? 0 : 
> parent.width - width
> +y: parent.height - height

just use anchors?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  phab/batterypercent

REVISION DETAIL
  https://phabricator.kde.org/D3603

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, broulik
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D3603: Option to show percentage charge in the icon

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  You forgot BadgeOverlay.qml

INLINE COMMENTS

> ConfigGeneral.qml:28
> +
> +signal configurationChanged
> +

Unused

> ConfigGeneral.qml:30-31
> +
> +width: childrenRect.width
> +height: childrenRect.height
> +implicitWidth: pageColumn.implicitWidth

Not needed since we have implicitWidth?

> ConfigGeneral.qml:37
> +
> +SystemPalette {
> +id: palette

Unused

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3603

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Abandoned] D3674: RFC: Allow pausing media players when screen is locked

[broulik (Kai Uwe Broulik)]

broulik abandoned this revision.
broulik added a comment.


  IMHO this feature is completely orthogonal to "proper" media controls. But I 
respect your decision.
  
  So, about proper media controls, would re-using the mpris data engine in 
Plasma from QML be an option or should it rather be some implementation in 
ksldapp given you wanted to disable dbus access for the locker?

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D3674

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, graesslin
Cc: davidedmundson, mart, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D3674: RFC: Allow pausing media players when screen is locked

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  > use apparmor at some future point
  
  and from what I understand DBus access can be restricted on a 
per-interface/service basis with that? Dunno if it can do wildcards, though.
  
  > Kai, can you expand on your use cases
  
  At Randa I was listening to music, then when I locked my screen to get some 
more coffee, I always forgot to pause my music and since Plasma encourages you 
to be lazy usually, that's when I really wanted that feature and even built a 
hack into media controller applet for the rest of the week.
  
  > I think after a suspend movie should always be paused
  
  I like that, what about me adding a checkbox to PowerDevil to have it pause 
music on suspend? That would fix [1] (I know we forward media keys but I still 
liked that scene in that video).
  
  [1] https://www.youtube.com/watch?v=cQoQE_HDG8g=32m6s

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D3674

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, graesslin
Cc: oliverhenshaw, davidedmundson, mart, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Request, 159 lines] D3684: WIP: Media Controls on lock screen

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This provides media controls on the lock screen including album art, track, 
and title names.

TEST PLAN
  What's to be done:
  
  - Allow to disable this for privacy reasons
  - Crashes when unlocking kscreenlocker_greet in KGlobalAccel after printing 
QObject::connect: No such slot 
QObject::_k_shortcutGotChanged(QStringList,QList) (when I don't use 
kglobalaccel in the Multiplexer in the engine it doesn't crash)
  - Prints a couple of QML warnings when the player exits as the source goes 
away but since you cannot quit the player from here (and it still ends up 
hiding the controls then) isn't too bad
  
  Album art, title, artist, controls
  F739728: Screenshot_20161215_115036.png 
  No album art, no artist, in this case the player name is shown instead
  F739729: Screenshot_20161215_115123.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3684

AFFECTED FILES
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  lookandfeel/contents/lockscreen/MediaControls.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 589 lines] D2687: [Icon Widget] Bring back properties dialog

[broulik (Kai Uwe Broulik)]

broulik updated this revision to Diff 9029.
broulik marked 2 inline comments as done.
broulik added a comment.


  - update actions also in Component.onCompleted so the "configure" button in 
applet handle works correctly the first time
  - Set icon for properties dialog ("document-properties", same as the context 
menu) instead of generic Plasma icon
  - Let processDrop return void, nobody used the return value
  - Use QUrl::toStringList
  - Parent KRun to QApplication::desktop()
  - Some minor cleanup

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2687?vs=8968=9029

REVISION DETAIL
  https://phabricator.kde.org/D2687

AFFECTED FILES
  applets/icon/CMakeLists.txt
  applets/icon/iconapplet.cpp
  applets/icon/iconapplet.h
  applets/icon/package/contents/config/main.xml
  applets/icon/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, dfaure
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D2687: [Icon Widget] Bring back properties dialog

[broulik (Kai Uwe Broulik)]

broulik marked 4 inline comments as done.
broulik added inline comments.

INLINE COMMENTS

> dfaure wrote in iconapplet.cpp:242
> Just wondering, why is the parent widget nullptr here, while it's 
> QApplication::desktop() in other code further down? Not that it changes 
> anything at runtime, I suppose.

No particular reason, changed it to QApplication::desktop() now

> dfaure wrote in iconapplet.cpp:306
> This for loop can be written in one line with
> 
>   const QStringList params = QUrl::toStringList(urls);
> 
> (I added that to QUrl for Qt 5.1)

You tell me all the time yet I can never remember this thing exists :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2687

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, dfaure
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3650: lower mouse acceleration limit to 0.0

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  I think KWin's Wayland input mapping logic needs to be adjusted then?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3650

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sitter, plasma-devel
Cc: broulik, jensreuterberg, lesliezhai, ali-mohamed, abetts, sebas

[Differential] [Closed] D3582: [Task Manager] Honor activateTaskManagerEntry by plasmashell

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:008099974805: [Task Manager] Honor 
activateTaskManagerEntry by plasmashell (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3582?vs=8730=8951

REVISION DETAIL
  https://phabricator.kde.org/D3582

AFFECTED FILES
  applets/taskmanager/package/contents/code/tools.js
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D3581: [PlasmaShell] Introduce activateTaskManagerEntry(index) method

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ea4579f312c6: [PlasmaShell] Introduce 
activateTaskManagerEntry(index) method (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3581?vs=8728=8950

REVISION DETAIL
  https://phabricator.kde.org/D3581

AFFECTED FILES
  shell/shellcorona.cpp
  shell/shellcorona.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3655: Kicker backend changes for Simple Menu.

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  some minor minor nitpicks, +1 from me though

INLINE COMMENTS

> rootmodel.cpp:281
>  
> -foreach (const AbstractEntry *groupEntry, m_entryList) {
> -AbstractModel *model = groupEntry->childModel();
> +for (int i = 0; i < subModel->count(); ++i) {
> +AppEntry *appEntry = 
> static_cast(subModel->index(i, 0).internalPointer());

i is already occupied by the outer loop?

> rootmodel.cpp:293
> +
> +apps = appsHash.values();
> +

Too bad there's no Qt container which keeps its custom order :)

> rootmodel.cpp:308
> +int at = 0;
> +QList page;
> +

reserve?

> rootmodel.cpp:323
>  
> -QList groups;
> -QHashIterator i(m_categoryHash);
> +if (page.count()) {
> +AppsModel *model = new AppsModel(page, false, this);

!isEmpty

> rootmodel.h:90
>  
> +void classBegin();
> +void componentComplete();

override

> wheelinterceptor.cpp:52
> +
> +emit wheelMoved(event->angleDelta());
>  }

Is this for another patch?

Also, you lose pixel-precise scrolling here

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3655

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, #plasma, mart
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated] D3581: [PlasmaShell] Introduce activateTaskManagerEntry(index) method

[broulik (Kai Uwe Broulik)]

broulik updated the test plan for this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3581

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Abandoned] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

[broulik (Kai Uwe Broulik)]

broulik abandoned this revision.
broulik added a comment.


  Superseded by https://phabricator.kde.org/D3581 and 
https://phabricator.kde.org/D3582

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2680

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: cfeck, colomar, ivan, graesslin, lbeltrame, mart, plasma-devel, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 18 lines] D3582: [Task Manager] Honor activateTaskManagerEntry by plasmashell

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added reviewers: Plasma: Design, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This adds a method activateTaskAtIndex that is called by plasmashell in 
response to a Meta+Number shortcut
  
  CHANGELOG: Items in task manager can now be activated using Meta+number 
shortcuts

TEST PLAN
  Meta+number shortcuts work
  
  Needs https://phabricator.kde.org/D3581 and obsoletes 
https://phabricator.kde.org/D2680

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3582

AFFECTED FILES
  applets/taskmanager/package/contents/code/tools.js
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  Ping
  
  > How would I tell the "primary monitor task manager" applet?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2680

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: cfeck, colomar, ivan, graesslin, lbeltrame, mart, plasma-devel, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 71 lines] D3581: [PlasmaShell] Introduce activateTaskManagerEntry(index) method

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  It registers global shortcuts Meta+1 through 9 and 0 and will ask the first 
task manager it finds* to activate the task at the given index.
  
  *) It searches all panels on the primary screen for an applet that provides 
"multitasking" (ie. task manager, icon task, window list) and invokes said 
method. If there is none, it will then search all panels. This will fit the 90% 
usecase and avoids an overly complex configuration workflow

TEST PLAN
  I now have 10 new global shortcuts in "Plasmashell" global shortcuts config 
and pressing them calls the method and invokes said method on task manager.
  
  This replaces https://phabricator.kde.org/D2680 and will be accompanied by a 
patch for task manager

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3581

AFFECTED FILES
  shell/shellcorona.cpp
  shell/shellcorona.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D3549: [Lock Screen] Add keyboard icon for keyboard layout switcher

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b34601f0ef1a: [Lock Screen] Add keyboard icon for 
keyboard layout switcher (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3549?vs=8638=8675

REVISION DETAIL
  https://phabricator.kde.org/D3549

AFFECTED FILES
  lookandfeel/contents/components/KeyboardLayoutButton.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, mart
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas