rescuecd.spec - problems with sending build request
http://wklej.org/id/0868358518 What I break?;) And how to fix that? -- Regards, Kamil Dziedzic signature.asc Description: This is a digitally signed message part. ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: SOURCES (rpm-4_4_9): rpm-lualeak.patch - more _free() compatible, ...
On Mar 17, 2008, at 5:44 PM, Tomasz Wittner wrote:
>
> IMO construction like `if(foo) free(foo);' has little value (maybe
> is useful
> for performance reasons - conditional instruction vs. calling
> function - I
> don't know). I didn't write any piece of C code for ages, but it
> seems to me
> that you would like achieve rather sth like:
> if(_lua_init) { free(_lua_init); _lua_init = NULL; }
>
Heh, Real Men use reference counted garbage collected slab memory
memory with
a SAT solving loop breaker.
Meanwhile, you're looking at code out-of-context.
The snippet that is extracted came from rpm code that looks like
ptr = _free(ptr);
Whether free(NULL) is permitted (or not) is hardly the issue. The
stoopid _free() wrapper immediately poisons (by setting to NULL)
the pointer that used to reference malloc'd memory, thereby preventing
any possibility of accidentally referencing already free'd memory.
Those bugs are _REALLY_ hard to find, segfault's from looking through
a NULL pointer are easy pie fixing in comparison.
73 de Jeff
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: SOURCES (rpm-4_4_9): rpm-lualeak.patch - more _free() compatible, ...
On Monday 17 of March 2008, 21:12, glen wrote:
> Author: glen Date: Mon Mar 17 20:12:18 2008 GMT
> Module: SOURCES Tag: rpm-4_4_9
> Log message:
> - more _free() compatible, however no luck still
>
> Files affected:
> SOURCES:
>rpm-lualeak.patch (1.1.2.1 -> 1.1.2.2)
>
> Diffs:
>
>
> Index: SOURCES/rpm-lualeak.patch
> diff -u SOURCES/rpm-lualeak.patch:1.1.2.1 SOURCES/rpm-lualeak.patch:1.1.2.2
> --- SOURCES/rpm-lualeak.patch:1.1.2.1 Mon Mar 17 20:25:50 2008
> +++ SOURCES/rpm-lualeak.patch Mon Mar 17 21:12:13 2008
> @@ -6,7 +6,7 @@
> lua_pushliteral(L, "LUA_PATH");
> lua_pushstring(L, _lua_path);
> -free(_lua_path);
> -+free(_lua_path); _lua_path = NULL;
> ++if (_lua_path) free(_lua_path); _lua_path = NULL;
> }
> }
> lua_rawset(L, LUA_GLOBALSINDEX);
> @@ -15,7 +15,7 @@
> if (Stat(_lua_init, &st) != -1)
> (void)rpmluaRunScriptFile(lua, _lua_init);
> -free(_lua_init);
> -+free(_lua_init); _lua_init = NULL;
> ++if (_lua_init) free(_lua_init); _lua_init = NULL;
man 3 free
free() frees the memory space pointed to by ptr, which must have been returned
by a previous call to malloc(), calloc() or realloc(). Otherwise, or if
free(ptr) has already been called before, undefined behaviour occurs.
If ptr is NULL, no operation is performed.
^^
IMO construction like `if(foo) free(foo);' has little value (maybe is useful
for performance reasons - conditional instruction vs. calling function - I
don't know). I didn't write any piece of C code for ages, but it seems to me
that you would like achieve rather sth like:
if(_lua_init) { free(_lua_init); _lua_init = NULL; }
> }
> }
> #undef _LUADOTDIR
>
>
> CVS-web:
>
> http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/SOURCES/rpm-lualeak.patch?r1=1.
>1.2.1&r2=1.1.2.2&f=u
>
> ___
> pld-cvs-commit mailing list
> [EMAIL PROTECTED]
> http://lists.pld-linux.org/mailman/listinfo/pld-cvs-commit
--
Tomasz Wittner
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: Package with make-request.sh?
On Mon, 17 Mar 2008, Kamil Dziedzic wrote: > What do you think about adding make-request.sh script to rpm-build-tools > package or to separate package/spec make-request.spec? Separate spec -- pozdr. Paweł Gołaszewski jid:bluesjabbergdapl -- If you think of MS-DOS as mono, and Windows as stereo, then Linux is Dolby Pro-Logic Surround Sound with Bass Boost and all the music is free.___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Package with make-request.sh?
What do you think about adding make-request.sh script to rpm-build-tools package or to separate package/spec make-request.spec? -- Regards, Kamil Dziedzic signature.asc Description: This is a digitally signed message part. ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: rpm 4.4.9 broken on Ac?
On Sunday 16 March 2008 14:06:07 Elan Ruusamäe wrote:
> found too something similar from one vserver root dir:
appears that such sequence of macros in rpm 4.4.9 causes the mess and TMPDIR
macros containing garbage:
$ tail -n3 ~/.rpmmacros
%_tmppath %{expand:%%global _tmppath %{lua:print(os.getenv("TMPDIR") or
"/tmp")}}%{_tmppath}
%tmpdir%{_tmppath}
%tmpdir%{expand:%%global tmpdir %{lua:print(os.getenv("TMPDIR") or
"/tmp")}}%tmpdir
not using %{lua:...} or not overwriting macros is workaround
--
glen
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
plplot & libnome & popt
err, where's the popt coming in here? and why? and why it's not in shared lib
list?
dlopen(".libs/gnome.so", 1)
= NULL
dlerror()
= "/usr/lib/libgnome.so.32: undefined symbol: poptHelpOptions"
free(0x804f1a8)
=
free(0x804f188)
=
__assert_fail(0x804d77d, 0x804d733, 2449, 0x804d761, 0x804f088lt-get-drv-info:
ltdl.c:2449: tryall_dlopen_module: Assertion `dirname' failed.
--- SIGABRT (Aborted) ---
+++ killed by SIGABRT +++
[EMAIL PROTECTED] plplot-5.3.1/drivers $ ldd /usr/lib/libgnome.so.32
linux-gate.so.1 => (0xe000)
libglib-1.2.so.0 => /usr/lib/libglib-1.2.so.0 (0xb7f34000)
libz.so.1 => /lib/libz.so.1 (0xb7f22000)
libm.so.6 => /lib/tls/libm.so.6 (0xb7eff000)
libc.so.6 => /lib/tls/libc.so.6 (0xb7de5000)
/lib/ld-linux.so.2 (0x8000)
[EMAIL PROTECTED] plplot-5.3.1/drivers $ objdump -T
/usr/lib/libgnome.so.32|grep poptHelpOptions
D *UND* poptHelpOptions
[EMAIL PROTECTED] plplot-5.3.1/drivers $
it all started from plplot build failure:
...
creating get-drv-info
./get-drv-info `echo cgm.la | sed 's/.la//'` > cgm.rc
./get-drv-info `echo dg300.la | sed 's/.la//'` > dg300.rc
./get-drv-info `echo gd.la | sed 's/.la//'` > gd.rc
./get-drv-info `echo gnome.la | sed 's/.la//'` > gnome.rc
lt-get-drv-info: ltdl.c:2449: tryall_dlopen_module: Assertion `dirname' failed.
Abort
make[2]: *** [gnome.rc] Error 134
make[2]: Leaving directory `/home/glen/rpm/pld/BUILD/plplot-5.3.1/drivers'
[EMAIL PROTECTED] plplot-5.3.1/drivers $ ./get-drv-info gd
jpeg:JPEG file:0:gd:40:jpeg
png:PNG file:0:gd:39:png
[EMAIL PROTECTED] plplot-5.3.1/drivers $ ./get-drv-info gnome
lt-get-drv-info: ltdl.c:2449: tryall_dlopen_module: Assertion `dirname' failed.
Aborted
[EMAIL PROTECTED] plplot-5.3.1/drivers $
--
glen
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
