Re: [packages/efi-shell/notes/commits] Notes added by 'git notes add'

2012-11-04 Thread Jeffrey Johnson



> 
> so how we fix it

There isn't a simple fix.

Macro's are expanded when encountered as the simplest
possible (and most general)
solution.

It's certainly possible to make
the *.spec parser section dependent.

However there are many problematic
constricts if that path is pursued.

hth

73 de Jeff
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en


Re: [packages/efi-shell/notes/commits] Notes added by 'git notes add'

2012-11-04 Thread Michael Shigorin
On Mon, Nov 05, 2012 at 12:07:03AM +0200, Elan Ruusam?e wrote:
> so how we fix it? :)

In ALT Linux we've agreed to escape section names
(and most of the macros) in %changelog :)

-- 
my two copecks
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en


Re: [packages/efi-shell/notes/commits] Notes added by 'git notes add'

2012-11-04 Thread Elan Ruusamäe

On 11/04/2012 11:20 PM, Jacek Konieczny wrote:

On Sun, Nov 04, 2012 at 11:10:56PM +0200, Elan Ruusamäe wrote:

>On 11/04/2012 12:52 PM, Jakub Bogusz wrote:

> >Note: with current git log -> %changelog generation you can't begin
> >changelog entry with "%post" (or other rpm section keyword) - it would
> >cause changelog to end immediately, thus leading to spec syntax error.
> >
> >That's why I added git note overriding changelog entry for this commit.
> >

>are you sure it's from that, that it's %changelog  generated from git log?
>
>perhaps rpm5 yet again parses %changelog for macros, in rpm45 we had
>patch to skip any parsing there.

I have the same problem with rpm 4.5.

ah, indeed, now i "see"

%post in the beginning of line, starts that section, regardless that we 
are "in" %changelog section
in pld, as %changelog is last section, could perhaps omit parsing that 
as well? :)


altho it's farily easy to replace ^% -> ^%% in the generated changelog, 
but then, when we "fix" rpmbuild side, it won't be consistent anymore.


so how we fix it? :)

--
glen

___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en


Re: [packages/efi-shell/notes/commits] Notes added by 'git notes add'

2012-11-04 Thread Jacek Konieczny
On Sun, Nov 04, 2012 at 11:10:56PM +0200, Elan Ruusamäe wrote:
> On 11/04/2012 12:52 PM, Jakub Bogusz wrote:
> > Note: with current git log -> %changelog generation you can't begin
> > changelog entry with "%post" (or other rpm section keyword) - it would
> > cause changelog to end immediately, thus leading to spec syntax error.
> >
> > That's why I added git note overriding changelog entry for this commit.
> >
> are you sure it's from that, that it's %changelog  generated from git log?
> 
> perhaps rpm5 yet again parses %changelog for macros, in rpm45 we had 
> patch to skip any parsing there.

I have the same problem with rpm 4.5.

Greets,
Jacek
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en


Re: [packages/efi-shell/notes/commits] Notes added by 'git notes add'

2012-11-04 Thread Elan Ruusamäe

On 11/04/2012 12:52 PM, Jakub Bogusz wrote:

Note: with current git log -> %changelog generation you can't begin
changelog entry with "%post" (or other rpm section keyword) - it would
cause changelog to end immediately, thus leading to spec syntax error.

That's why I added git note overriding changelog entry for this commit.


are you sure it's from that, that it's %changelog  generated from git log?

perhaps rpm5 yet again parses %changelog for macros, in rpm45 we had 
patch to skip any parsing there.


--
glen

___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en


Re: [packages/efi-shell/notes/commits] Notes added by 'git notes add'

2012-11-04 Thread Jeffrey Johnson

On Nov 4, 2012, at 5:52 AM, Jakub Bogusz wrote:

> Note: with current git log -> %changelog generation you can't begin
> changelog entry with "%post" (or other rpm section keyword) - it would
> cause changelog to end immediately, thus leading to spec syntax error.
> 

The problem is actually worse if/when %post (as a section marker)
is overloaded as %poist (as a macro), particularly with multiple lines.

I'd suggest %%post escaping … ymmv.



> That's why I added git note overriding changelog entry for this commit.
> 
> 
> On Sun, Nov 04, 2012 at 11:41:08AM +0100, qboosh wrote:
>> commit 2ae807df00a23e6b1b9823da11c1cc38231b5ae0
>> Author: Jakub Bogusz 
>> Date:   Sun Nov 4 11:38:18 2012 +0100
>> 
>>Notes added by 'git notes add'
>> 
>> af5feaae61966c7e64cdf39baececae4c4f5b0f4 | 1 +
>> 1 file changed, 1 insertion(+)
>> ---
>> diff --git a/af5feaae61966c7e64cdf39baececae4c4f5b0f4 
>> b/af5feaae61966c7e64cdf39baececae4c4f5b0f4
>> new file mode 100644
>> index 000..8cb4260
>> --- /dev/null
>> +++ b/af5feaae61966c7e64cdf39baececae4c4f5b0f4
>> @@ -0,0 +1 @@
>> +- %post improved, %postun added
>> 
>> 
>>  gitweb:
>> 
>> http://git.pld-linux.org/gitweb.cgi/packages/efi-shell.git/commitdiff/2ae807df00a23e6b1b9823da11c1cc38231b5ae0
>> 
>> ___
>> pld-cvs-commit mailing list
>> pld-cvs-com...@lists.pld-linux.org
>> http://lists.pld-linux.org/mailman/listinfo/pld-cvs-commit
> 
> -- 
> Jakub Boguszhttp://qboosh.pl/
> ___
> pld-devel-en mailing list
> pld-devel-en@lists.pld-linux.org
> http://lists.pld-linux.org/mailman/listinfo/pld-devel-en

___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en


Re: [packages/efi-shell/notes/commits] Notes added by 'git notes add'

2012-11-04 Thread Jakub Bogusz
Note: with current git log -> %changelog generation you can't begin
changelog entry with "%post" (or other rpm section keyword) - it would
cause changelog to end immediately, thus leading to spec syntax error.

That's why I added git note overriding changelog entry for this commit.


On Sun, Nov 04, 2012 at 11:41:08AM +0100, qboosh wrote:
> commit 2ae807df00a23e6b1b9823da11c1cc38231b5ae0
> Author: Jakub Bogusz 
> Date:   Sun Nov 4 11:38:18 2012 +0100
> 
> Notes added by 'git notes add'
> 
>  af5feaae61966c7e64cdf39baececae4c4f5b0f4 | 1 +
>  1 file changed, 1 insertion(+)
> ---
> diff --git a/af5feaae61966c7e64cdf39baececae4c4f5b0f4 
> b/af5feaae61966c7e64cdf39baececae4c4f5b0f4
> new file mode 100644
> index 000..8cb4260
> --- /dev/null
> +++ b/af5feaae61966c7e64cdf39baececae4c4f5b0f4
> @@ -0,0 +1 @@
> +- %post improved, %postun added
> 
> 
>  gitweb:
> 
> http://git.pld-linux.org/gitweb.cgi/packages/efi-shell.git/commitdiff/2ae807df00a23e6b1b9823da11c1cc38231b5ae0
> 
> ___
> pld-cvs-commit mailing list
> pld-cvs-com...@lists.pld-linux.org
> http://lists.pld-linux.org/mailman/listinfo/pld-cvs-commit

-- 
Jakub Boguszhttp://qboosh.pl/
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en


Re: RFC: EFI System partition and native EFI binaries (xen.efi, vmlinuz.efi, etc)

2012-11-04 Thread Jacek Konieczny
On Mon, Oct 29, 2012 at 01:50:39PM +0100, Jacek Konieczny wrote:
> Any thoughts? Does anybody know how other distros solve this problem?

I have not expected such a heated discussion here… thanks for all your
comments and suggestions…

So I have created another monster – the 'efi-boot-update' script.
Packages providing EFI boot loaders install them to the
/lib/efi/{ia32,x64} directories and their configuration files to the
/etc/efi-boot/ directory. Additionally, an efi-boot-update configuration
files are provided in the /etc/efi-boot/update.d directory which
describe what files should be copied to the EFI partition for each boot
loader and what boot manager label to use.

/etc/efi-boot/update.conf file is used to define the boot order and
other global options for the efi-boot-update scripts. Everything seems
to work good enough for me. It would be great if anybody else could test
this too and tell if it makes sense.

The packages supporting efi-boot-update now:
– xen-efi 4.2.0-1 (xen.spec)
– elilo 3.14-2 (elilo.spec)
– efi-shell-{ia32,x64) 2.0 (efi-shell.spec)

Additionally, the efi-boot-update script contains a configuration file
to set a boot manager entry for GRUB2 installed as usual with
'grub-install'.

TODO:
- if this really makes sense, then the /lib/efi/{ia32,x64} and
  /etc/efi-boot/  directories should be probably moved to the filesystem
  package.

I will also try to write wiki page about EFI boot.

Greets,
Jacek
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en