Re: python3 optional deps

2016-05-06 Thread Jeff Johnson

On May 6, 2016, at 3:41 AM, Elan Ruusamäe wrote:

> On 06.05.2016 10:11, Jacek Konieczny wrote:
>> 
>> I guess the python dependency generator should be fixed in our RPM, to 
>> ignore the 'extras' dependencies (or to make them 'suggest', skipping the 
>> ':python_version' ones.
> is there python module to parse the egg info? or just manual parsing each time
> 
> btw, maybe it's better to extract the python dependency generators as 
> separate package, out of rpm sourcetree?
> it would be a lot simplier to maintain, than patching patch patching the 
> previous patch. our patches will likely never end up upstream.
> 

Submit any patches for rpm you wish.

Meanwhile, rpm cannot carry extractors for every possible dependency forever,
that simply does not scale.

73 de Jeff

___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en


Re: python3 optional deps

2016-05-06 Thread Jacek Konieczny

On 2016-05-06 10:59, Elan Ruusamäe wrote:

On 06.05.2016 11:47, Jacek Konieczny wrote:


Feel free to separate it :-)

sure. suggest package name?


rpm-pythonprov? It is already a separate package, just built with whole RPM.



looks like there's just one file to move:
/usr/lib/rpm/pythoneggs.py



[jajcus@jajo ~]$ rpm -ql rpm-pythonprov
/usr/lib/rpm/pythondeps.sh
/usr/lib/rpm/pythoneggs.py

Jacek
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en


Re: python3 optional deps

2016-05-06 Thread Elan Ruusamäe

On 06.05.2016 11:47, Jacek Konieczny wrote:


Feel free to separate it :-)

sure. suggest package name?

looks like there's just one file to move:
/usr/lib/rpm/pythoneggs.py

or just move it to rpm-build-macros package?

--
glen

___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en


Re: python3 optional deps

2016-05-06 Thread Jacek Konieczny

On 2016-05-06 09:41, Elan Ruusamäe wrote:

On 06.05.2016 10:11, Jacek Konieczny wrote:


I guess the python dependency generator should be fixed in our RPM, to
ignore the 'extras' dependencies (or to make them 'suggest', skipping
the ':python_version' ones.

is there python module to parse the egg info? or just manual parsing
each time

btw, maybe it's better to extract the python dependency generators as
separate package, out of rpm sourcetree?
it would be a lot simplier to maintain, than patching patch patching the
previous patch. our patches will likely never end up upstream.


Feel free to separate it :-)

I can try to fix it then.

Jacek
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en


Re: python3 optional deps

2016-05-06 Thread Elan Ruusamäe

On 06.05.2016 10:11, Jacek Konieczny wrote:


I guess the python dependency generator should be fixed in our RPM, to 
ignore the 'extras' dependencies (or to make them 'suggest', skipping 
the ':python_version' ones.
is there python module to parse the egg info? or just manual parsing 
each time


btw, maybe it's better to extract the python dependency generators as 
separate package, out of rpm sourcetree?
it would be a lot simplier to maintain, than patching patch patching the 
previous patch. our patches will likely never end up upstream.


--
glen

___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en


Re: python3 optional deps

2016-05-06 Thread Jacek Konieczny

On 2016-05-04 11:11, Elan Ruusamäe wrote:


can someone check (and fix?) why those optional deps:
https://github.com/docker/docker-py/blob/1.8.1/setup.py#L14-L17




extras_require = {

':python_version < "3.5"': 'backports.ssl_match_hostname >= 3.5',

':python_version < "3.3"': 'ipaddress >= 1.0.16',

}



end up in python3 egg and therefore rpm deps:


They will end up in the egg, that is the design. Those should not be 
converted to rpm deps, though. And for python3 package these deps are 
useless even in the egg-info.


I guess the python dependency generator should be fixed in our RPM, to 
ignore the 'extras' dependencies (or to make them 'suggest', skipping 
the ':python_version' ones.


The easy fix for python-docker.spec would be to strip those from
docker_py-1.8.1-py3.5.egg-info/requires.txt (everything from the first '[').

Jacek
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en