Re: [packages/iptables] - added ebtables init scripts

2017-07-03 Thread Jacek Konieczny 

On 2016-04-09 15:45, baggins wrote:

commit 9ec3dc4d5d00befe1b59d557cc4d4e34635816c5
Author: Jan Rękorajski 
Date:   Sat Apr 9 21:57:09 2016 +0900

- added ebtables init scripts


Have you actually tested this?



+   if is_yes "$EBTABLES_BINARY_FORMAT"; then
+   for table in $(ls /etc/sysconfig/ebtables.* 2>/dev/null 
| sed -e 's/.*ebtables\.//' -e '/save/d' ); do
+   /usr/sbin/ebtables -t $table --atomic-file 
/etc/sysconfig/ebtables.$table --atomic-commit || RETVAL=1
+   done


--atomic-file, --atomic-commit do not seem to work at all in the 
iptables-provided 'ebtables'


[root@jajo ~]# ebtables-compat -t filter  --atomic-file /tmp/x 
--atomic-commit

Extensions only for -A, -I, -D and -C.
[root@jajo ~]# ebtables-compat -t filter  --atomic-file /tmp/x --atomic-save
Extensions only for -A, -I, -D and -C.



+   else
+   /usr/sbin/ebtables-restore < /etc/sysconfig/ebtables || 
RETVAL=1
+   fi


And there is no such thing as ebtables-restore or ebtables-save here,

Jacek
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en

Re: [packages/iptables] - added ebtables patch to support plain ebtables command

2017-07-03 Thread Jacek Konieczny 

On 2016-02-28 10:30, qboosh wrote:

commit 87ffab9ee39fd264c3cbae4bd42e4c8b663d04bf
Author: Jakub Bogusz 
Date:   Sun Feb 28 10:33:51 2016 +0100

- added ebtables patch to support plain ebtables command


I lost a few hours of work today because of this
not-well-thought-out change.

There was a reason this command is not there upstream. This is not 
compatible with original ebtables, and buggy even in the basic 
functionality it is supposed to provide.


Jacek
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en