Re: SPEC: fet
Here is an update. Zsolt fet.diff Description: Binary data ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: SPEC: fet
> - remove trailing slashes from lines like this
> "install -d $RPM_BUILD_ROOT%{_bindir}/"
OK.
> - translation files should be packaged with %lang()
And will they placed to a good place?
> - I guess sample_inputs should be packaged as %doc (and not installed into
> _datadir/name)
And they will not packed with gzip?
> - libstdc++-devel is required by QtCore-devel (BR)
> so "BuildRequires: libstdc++-devel" should be removed
OK.
Zsolt
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: SPEC: fet
On Monday 28 July 2008 18:33:46 Szymon Siwek wrote: > On Mon, Jul 28, 2008 at 07:35:19PM +0200, Zsolt Udvari wrote: > > > It does not build for me (th/i686). Here is builder output: > > > http://user.touk.pl/pzz/fet.log > > > > Hm, I hate the devel-packages. So some devel-dependencies are missed > > > > :( This is my fault :( > > > > I hope that this version works. > > Works for me. OK, it works for me too - after upgrade of gcc. It works on gcc-c++-4.2.4-1 and newer. It does not work on gcc-c++-4.2.3-1. So there sould be BR gcc-c++ >= 4.2.4-1 -- Paweł Zuzelski ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: SPEC: fet
On Mon, Jul 28, 2008 at 08:33:46PM +0200, Szymon Siwek wrote:
> On Mon, Jul 28, 2008 at 07:35:19PM +0200, Zsolt Udvari wrote:
> > > It does not build for me (th/i686). Here is builder output:
> > > http://user.touk.pl/pzz/fet.log
> > Hm, I hate the devel-packages. So some devel-dependencies are missed
> > :( This is my fault :(
> > I hope that this version works.
> >
> Works for me.
>
Actually, rpmbuild -bc works for me. But rpmbuild -bi fails on installing
some sample_inputs dirs.
I read spec so I've got some hints:
- remove trailing slashes from lines like this
"install -d $RPM_BUILD_ROOT%{_bindir}/"
- translation files should be packaged with %lang()
- I guess sample_inputs should be packaged as %doc (and not installed into
_datadir/name)
- libstdc++-devel is required by QtCore-devel (BR)
so "BuildRequires: libstdc++-devel" should be removed
--
Szymon Siwek
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: SPEC: fet
On Mon, Jul 28, 2008 at 19:35:19 +0200, Zsolt Udvari wrote:
> Is there any solution to find what devel packages are needed? IMHO
rpm -e *devel
;)
BTW
#v+
%install
rm -rf $RPM_BUILD_ROOT
install -d
$RPM_BUILD_ROOT{%{_bindir},%{_mandir}/man1,%{_datadir}/%{name}/{sample_inputs,translations}}
install fet $RPM_BUILD_ROOT%{_bindir}
install doc/fet.1 $RPM_BUILD_ROOT%{_mandir}/man1
install sample_inputs/* $RPM_BUILD_ROOT%{_datadir}/%{name}/sample_inputs
install translations/* $RPM_BUILD_ROOT%{_datadir}/%{name}/translations
%clean
rm -rf $RPM_BUILD_ROOT
#v-
--
Tomasz Pala <[EMAIL PROTECTED]>
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: SPEC: fet
Zsolt Udvari wrote:
> What I'm thinking:
> grep "\#include *<" $(find ../BUILD/fet-5.6.0/ -iname "*.h" -o -iname
> "*.cpp" ) | awk -F ":" {'print $2'} | awk {'print $2'} | sort -u | sed
> "s@<\(.*\)>@search -f /usr/include/\1@"
> This script create the list which contains all system-wide headers
> what the program want to include.
> And it'd be good to know that what packages provides these files. OK,
> I can pipe to poldek but when the included files are very much it
> takes a very long time.
> Is there any way to do this faster?
rpm -qf ?
--
===
Andrzej M. Krzysztofowicz [EMAIL PROTECTED]
phone (48)(58) 347 19 36
Faculty of Applied Phys. & Math., Gdansk University of Technology
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: SPEC: fet
On Mon, Jul 28, 2008 at 07:35:19PM +0200, Zsolt Udvari wrote:
> > It does not build for me (th/i686). Here is builder output:
> > http://user.touk.pl/pzz/fet.log
> Hm, I hate the devel-packages. So some devel-dependencies are missed
> :( This is my fault :(
> I hope that this version works.
>
Works for me.
> Is there any solution to find what devel packages are needed?
There is no simple solution, I believe.
> IMHO
> maybe can grep the source tree what headers are included and sort
> them, but I can't send it to poldek.
> What I'm thinking:
> grep "\#include *<" $(find ../BUILD/fet-5.6.0/ -iname "*.h" -o -iname
> "*.cpp" ) | awk -F ":" {'print $2'} | awk {'print $2'} | sort -u | sed
> "s@<\(.*\)>@search -f /usr/include/\1@"
> This script create the list which contains all system-wide headers
> what the program want to include.
... and what about conditional includes?
> And it'd be good to know that what packages provides these files. OK,
> I can pipe to poldek but when the included files are very much it
> takes a very long time.
> Is there any way to do this faster?
>
> Zsolt
--
Szymon Siwek
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: SPEC: fet
On Mon, Jul 28, 2008 at 02:29:18PM +0200, Paweł Zuzelski wrote: > On Monday 28 of July 2008 13:55:04 Zsolt Udvari wrote: > > > Have a look at it and see what it thinks about fet.spec > > > > Thanks, here is a perfect version :) > > > > # adapter fet.spec > > The SPEC is perfect ;) > > It looks better now, but still it is not perfect. There are some hints: > [...] > * add summary and description in your national language (hungarian?) (-; > ... if you want be awarded Order Of Labour Glory. If you add summaries and descriptions in hungarian for all specs you'll be awarded Order Of The Red Banner Of Labour. Seriously - it's good to have descriptions in all languages but only english is required - for example glen doesn't care about estonian translations. -- Szymon Siwek ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: SPEC: fet
On Monday 28 July 2008 17:35:19 Zsolt Udvari wrote: > > It does not build for me (th/i686). Here is builder output: > > http://user.touk.pl/pzz/fet.log > > Hm, I hate the devel-packages. So some devel-dependencies are missed No, the devel dependencies are ok. Something is wrong with qmake-qt4 and src/interface/Makefile. INCPATH in Makefile generated at my system does not points to c++ include dir... -- Paweł Zuzelski ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: SPEC: fet
> It does not build for me (th/i686). Here is builder output:
> http://user.touk.pl/pzz/fet.log
Hm, I hate the devel-packages. So some devel-dependencies are missed
:( This is my fault :(
I hope that this version works.
Is there any solution to find what devel packages are needed? IMHO
maybe can grep the source tree what headers are included and sort
them, but I can't send it to poldek.
What I'm thinking:
grep "\#include *<" $(find ../BUILD/fet-5.6.0/ -iname "*.h" -o -iname
"*.cpp" ) | awk -F ":" {'print $2'} | awk {'print $2'} | sort -u | sed
"s@<\(.*\)>@search -f /usr/include/\1@"
This script create the list which contains all system-wide headers
what the program want to include.
And it'd be good to know that what packages provides these files. OK,
I can pipe to poldek but when the included files are very much it
takes a very long time.
Is there any way to do this faster?
Zsolt
fet.spec
Description: Binary data
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: SPEC: fet
On Monday 28 July 2008 13:30:31 Zsolt Udvari wrote: > Here is the next version :) It does not build for me (th/i686). Here is builder output: http://user.touk.pl/pzz/fet.log -- Pawel Zuzelski ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: SPEC: fet
Here is the next version :) Zsolt fet.spec Description: Binary data ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: SPEC: fet
On Monday 28 of July 2008 13:55:04 Zsolt Udvari wrote: > > Have a look at it and see what it thinks about fet.spec > > Thanks, here is a perfect version :) > > # adapter fet.spec > The SPEC is perfect ;) It looks better now, but still it is not perfect. There are some hints: * use install instead of cp -r in %install section * do not install COPYING - it contains well known GPLv2 licence. * add summary and description in your national language (hungarian?) (-; -- Regards, Pawel Zuzelski ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: SPEC: fet
> Have a look at it and see what it thinks about fet.spec Thanks, here is a perfect version :) # adapter fet.spec The SPEC is perfect ;) fet.spec Description: Binary data ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
Re: SPEC: fet
On Mon, Jul 28, 2008 at 01:37:35PM +0200, Zsolt Udvari wrote: > Hi! > > fet is a free timetabling program. I hope that this spec-file is > (almost) perfect ;) Unfortunately, it's not -- it does not fully comply with PLD style. There's a handy little tool, called adapter (cvs::SPECS/adapter and cvs::SPECS/adapter.awk), that does some basic checks and proposes changes in an unified diff format. Have a look at it and see what it thinks about fet.spec -- http://www.mysza.eu.org/ | Everybody needs someone sure, someone true, PLD Linux developer| Everybody needs some solid rock, I know I do. ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
SPEC: fet
Hi! fet is a free timetabling program. I hope that this spec-file is (almost) perfect ;) Zsolt fet.spec Description: Binary data ___ pld-devel-en mailing list pld-devel-en@lists.pld-linux.org http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
