Re: [Framework-Team] getting rid of plone.app.search
Am 07.02.15 um 03:26 schrieb Nathan Van Gheem: I'm working on fixing live search. I was wondering if I could move plone.app.search into Products.CMFPlone. The package only provides a view right now--seems a bit silly to be in it's own package. +1 It would be part of this PLIP: https://dev.plone.org/ticket/13283 +1 Makes more sense to do it package by package instead of one huge PR. +1 Timo ___ Framework-Team mailing list framework-t...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-framework-team
[Framework-Team] getting rid of plone.app.search
I'm working on fixing live search. I was wondering if I could move plone.app.search into Products.CMFPlone. The package only provides a view right now--seems a bit silly to be in it's own package. It would be part of this PLIP: https://dev.plone.org/ticket/13283 Makes more sense to do it package by package instead of one huge PR. -Nathan ___ Framework-Team mailing list framework-t...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-framework-team
Re: [Framework-Team] social media meta tags plip
Hi Nathan, Thank you for the PLIP and the implementation. We'll discuss this during the next FWT meeting. Cheers! On 6 February 2015 at 21:41, Mikel Larreategi wrote: > I'm not in the FWT but there's at least one add on that provides this > functionality collective.opengraph and allows to be extended providing > adapters for each content type. > > Mikel > > -- > Mikel Larreategi > CodeSyntax > > +34 943821780 > El 06/02/2015 15:42, "Eric Bréhault" escribió: > > Hi Nathan, >> >> I agree it can be very useful. >> Nevertheless, on the technical point of view, it could also be >> implemented as an add-on. >> Could you explain why you think it is better to put it in the core? >> >> Eric >> >> On Fri, Feb 6, 2015 at 3:15 PM, Nathan Van Gheem >> wrote: >> >>> Hi all, >>> >>> I just added a real simple plip for some core functionality I think we >>> should have. >>> >>> https://dev.plone.org/ticket/20256 >>> >>> Please consider this simple change to be included with Plone 5 yet. >>> >>> All the code is done, pull requests are made, we just need review and >>> the review will only take 1 minute. >>> >>> >>> -- >>> Nathan Van Gheem >>> Solutions Architect >>> Wildcard Corp >>> >>> ___ >>> Framework-Team mailing list >>> framework-t...@lists.plone.org >>> https://lists.plone.org/mailman/listinfo/plone-framework-team >>> >>> >> >> ___ >> Framework-Team mailing list >> framework-t...@lists.plone.org >> https://lists.plone.org/mailman/listinfo/plone-framework-team >> >> > ___ > Framework-Team mailing list > framework-t...@lists.plone.org > https://lists.plone.org/mailman/listinfo/plone-framework-team > > -- Roel Bruggink https://www.fourdigits.nl/over-ons#roel-bruggink Four Digits BV https://www.fourdigits.nl tel: +31 26 4422700 ___ Framework-Team mailing list framework-t...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-framework-team
Re: [Framework-Team] social media meta tags plip
I'm not in the FWT but there's at least one add on that provides this functionality collective.opengraph and allows to be extended providing adapters for each content type. Mikel -- Mikel Larreategi CodeSyntax +34 943821780 El 06/02/2015 15:42, "Eric Bréhault" escribió: > Hi Nathan, > > I agree it can be very useful. > Nevertheless, on the technical point of view, it could also be implemented > as an add-on. > Could you explain why you think it is better to put it in the core? > > Eric > > On Fri, Feb 6, 2015 at 3:15 PM, Nathan Van Gheem > wrote: > >> Hi all, >> >> I just added a real simple plip for some core functionality I think we >> should have. >> >> https://dev.plone.org/ticket/20256 >> >> Please consider this simple change to be included with Plone 5 yet. >> >> All the code is done, pull requests are made, we just need review and the >> review will only take 1 minute. >> >> >> -- >> Nathan Van Gheem >> Solutions Architect >> Wildcard Corp >> >> ___ >> Framework-Team mailing list >> framework-t...@lists.plone.org >> https://lists.plone.org/mailman/listinfo/plone-framework-team >> >> > > ___ > Framework-Team mailing list > framework-t...@lists.plone.org > https://lists.plone.org/mailman/listinfo/plone-framework-team > > ___ Framework-Team mailing list framework-t...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-framework-team
Re: [Framework-Team] social media meta tags plip
I like this functionality and I will help review it over the weekend. I do think we will need to discuss if we can include it in 5.0 in next FWT meeting Thanks for the work Nathan On Fri Feb 06 2015 at 11:52:18 AM Eric Bréhault wrote: > Not every site needs it (Plone is used a lot to build intranets), but I > agree you are making a good point with the DublinCore similarity. > > On Fri, Feb 6, 2015 at 3:46 PM, Nathan Van Gheem > wrote: > >> Every site we do gets this. Many things could be argued to not be in core >> and be put in an addon. This is similar to dublin core meta tags that have >> been in core for a long time and are mostly useless only this is actually >> useful. >> >> On Fri, Feb 6, 2015 at 8:41 AM, Eric Bréhault >> wrote: >> >>> Hi Nathan, >>> >>> I agree it can be very useful. >>> Nevertheless, on the technical point of view, it could also be >>> implemented as an add-on. >>> Could you explain why you think it is better to put it in the core? >>> >>> Eric >>> >>> On Fri, Feb 6, 2015 at 3:15 PM, Nathan Van Gheem >>> wrote: >>> Hi all, I just added a real simple plip for some core functionality I think we should have. https://dev.plone.org/ticket/20256 Please consider this simple change to be included with Plone 5 yet. All the code is done, pull requests are made, we just need review and the review will only take 1 minute. -- Nathan Van Gheem Solutions Architect Wildcard Corp ___ Framework-Team mailing list framework-t...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-framework-team >>> >> >> >> -- >> Nathan Van Gheem >> Solutions Architect >> Wildcard Corp >> > > ___ > Framework-Team mailing list > framework-t...@lists.plone.org > https://lists.plone.org/mailman/listinfo/plone-framework-team > ___ Framework-Team mailing list framework-t...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-framework-team
Re: [Framework-Team] social media meta tags plip
Not every site needs it (Plone is used a lot to build intranets), but I agree you are making a good point with the DublinCore similarity. On Fri, Feb 6, 2015 at 3:46 PM, Nathan Van Gheem wrote: > Every site we do gets this. Many things could be argued to not be in core > and be put in an addon. This is similar to dublin core meta tags that have > been in core for a long time and are mostly useless only this is actually > useful. > > On Fri, Feb 6, 2015 at 8:41 AM, Eric Bréhault wrote: > >> Hi Nathan, >> >> I agree it can be very useful. >> Nevertheless, on the technical point of view, it could also be >> implemented as an add-on. >> Could you explain why you think it is better to put it in the core? >> >> Eric >> >> On Fri, Feb 6, 2015 at 3:15 PM, Nathan Van Gheem >> wrote: >> >>> Hi all, >>> >>> I just added a real simple plip for some core functionality I think we >>> should have. >>> >>> https://dev.plone.org/ticket/20256 >>> >>> Please consider this simple change to be included with Plone 5 yet. >>> >>> All the code is done, pull requests are made, we just need review and >>> the review will only take 1 minute. >>> >>> >>> -- >>> Nathan Van Gheem >>> Solutions Architect >>> Wildcard Corp >>> >>> ___ >>> Framework-Team mailing list >>> framework-t...@lists.plone.org >>> https://lists.plone.org/mailman/listinfo/plone-framework-team >>> >>> >> > > > -- > Nathan Van Gheem > Solutions Architect > Wildcard Corp > ___ Framework-Team mailing list framework-t...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-framework-team
Re: [Framework-Team] social media meta tags plip
Every site we do gets this. Many things could be argued to not be in core and be put in an addon. This is similar to dublin core meta tags that have been in core for a long time and are mostly useless only this is actually useful. On Fri, Feb 6, 2015 at 8:41 AM, Eric Bréhault wrote: > Hi Nathan, > > I agree it can be very useful. > Nevertheless, on the technical point of view, it could also be implemented > as an add-on. > Could you explain why you think it is better to put it in the core? > > Eric > > On Fri, Feb 6, 2015 at 3:15 PM, Nathan Van Gheem > wrote: > >> Hi all, >> >> I just added a real simple plip for some core functionality I think we >> should have. >> >> https://dev.plone.org/ticket/20256 >> >> Please consider this simple change to be included with Plone 5 yet. >> >> All the code is done, pull requests are made, we just need review and the >> review will only take 1 minute. >> >> >> -- >> Nathan Van Gheem >> Solutions Architect >> Wildcard Corp >> >> ___ >> Framework-Team mailing list >> framework-t...@lists.plone.org >> https://lists.plone.org/mailman/listinfo/plone-framework-team >> >> > -- Nathan Van Gheem Solutions Architect Wildcard Corp ___ Framework-Team mailing list framework-t...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-framework-team
Re: [Framework-Team] social media meta tags plip
Hi Nathan, I agree it can be very useful. Nevertheless, on the technical point of view, it could also be implemented as an add-on. Could you explain why you think it is better to put it in the core? Eric On Fri, Feb 6, 2015 at 3:15 PM, Nathan Van Gheem wrote: > Hi all, > > I just added a real simple plip for some core functionality I think we > should have. > > https://dev.plone.org/ticket/20256 > > Please consider this simple change to be included with Plone 5 yet. > > All the code is done, pull requests are made, we just need review and the > review will only take 1 minute. > > > -- > Nathan Van Gheem > Solutions Architect > Wildcard Corp > > ___ > Framework-Team mailing list > framework-t...@lists.plone.org > https://lists.plone.org/mailman/listinfo/plone-framework-team > > ___ Framework-Team mailing list framework-t...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-framework-team
[Framework-Team] social media meta tags plip
Hi all, I just added a real simple plip for some core functionality I think we should have. https://dev.plone.org/ticket/20256 Please consider this simple change to be included with Plone 5 yet. All the code is done, pull requests are made, we just need review and the review will only take 1 minute. -- Nathan Van Gheem Solutions Architect Wildcard Corp ___ Framework-Team mailing list framework-t...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-framework-team
