Re: [Podofo-users] Fix for the "could avoid useless dependency" Debian build warning

[Peter Linnell]

On Wed, 10 Jan 2018 01:07:59 +0100 (CET)
Matthew Brincke  wrote:

> Hello all,
> 
> the patch for that is attached, please accept.
> It's made against version 0.9.5, but to parts
> of CMakeLists.txt files which haven't been changed
> there (& context) since then AFAIK.
> I've build-tested with sbuild into an (up-to-date,
> minimal except for GNU autotools, maybe that's
> needed for the Debian packing tools however)
> Debian sid chroot, then tested the programs by
> invoking them without parameters, getting their
> respective usage message fine, so no problems with
> shared-library linking (at load time, but they don't
> use later dynamic loading with dlopen() AFAIK).
> 
> Best regards, mabri

My take is this should be ok for other Linux distros as well.

Thanks for the patch!

Peter

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users

[Podofo-users] Fix for the "could avoid useless dependency" Debian build warning

[Matthew Brincke]

Hello all,

the patch for that is attached, please accept.
It's made against version 0.9.5, but to parts
of CMakeLists.txt files which haven't been changed
there (& context) since then AFAIK.
I've build-tested with sbuild into an (up-to-date,
minimal except for GNU autotools, maybe that's
needed for the Debian packing tools however)
Debian sid chroot, then tested the programs by
invoking them without parameters, getting their
respective usage message fine, so no problems with
shared-library linking (at load time, but they don't
use later dynamic loading with dlopen() AFAIK).

Best regards, mabri--- libpodofo-0.9.5.orig/CMakeLists.txt
+++ libpodofo-0.9.5/CMakeLists.txt
@@ -509,10 +509,14 @@ IF(FONTCONFIG_FOUND AND WANT_FONTCONFIG)
   INCLUDE_DIRECTORIES(${FONTCONFIG_INCLUDE_DIR})
 ENDIF(FONTCONFIG_FOUND AND WANT_FONTCONFIG)
 
-SET(PODOFO_LIB
-podofo
-${PODOFO_LIB_DEPENDS}
-)
+IF(WIN32 OR PODOFO_BUILD_STATIC)
+  SET(PODOFO_LIB
+  podofo
+  ${PODOFO_LIB_DEPENDS}
+  )
+ELSE(WIN32 OR PODOFO_BUILD_STATIC)
+  SET(PODOFO_LIB podofo)
+ENDIF(WIN32 OR PODOFO_BUILD_STATIC)
 
 #
 # Setup directories we will need
--- libpodofo-0.9.5.orig/tools/podofosign/CMakeLists.txt
+++ libpodofo-0.9.5/tools/podofosign/CMakeLists.txt
@@ -1,7 +1,12 @@
 ADD_EXECUTABLE(podofosign podofosign.cpp)
 
 TARGET_INCLUDE_DIRECTORIES(podofosign PUBLIC ${LIBCRYPTO_INCLUDE_DIR})
-TARGET_LINK_LIBRARIES(podofosign ${PODOFO_LIB})
+
+SET(podofosign_extra_libs ${LIBCRYPTO_LIBRARIES})
+TARGET_LINK_LIBRARIES(podofosign
+  ${PODOFO_LIB}
+  ${podofosign_extra_libs}
+)
 SET_TARGET_PROPERTIES(podofosign PROPERTIES COMPILE_FLAGS "${PODOFO_CFLAGS}")
 ADD_DEPENDENCIES(podofosign ${PODOFO_DEPEND_TARGET})
 INSTALL(TARGETS podofosign
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users