Re: cvs commit: jakarta-poi/src/testcases/org/apache/poi/poifs/filesystem SlowInputStream.java TestDocument.java
Slow input stream patch, bug 13478
...
for (;;) {
int got = in.read(b, off + total, len - total);
if (got 0) {
return (total == 0) ? -1 : total;
} else {
total += got;
if (total == len)
return total;
}
}
Hi Avik,
thanks for the patch! I suggest that the loop waits for a moment when read()
received less bytes than expected. Otherwise it would be a waste of CPU
cycles on very slow streams.
Best regards
Rainer Klute
--
RAINER KLUTE IT-CONSULTING GMBH
Dipl.-Inform.
Rainer Klute [EMAIL PROTECTED]
Körner Grund 24 Telefon: +49 172 2324824
D-44143 Dortmund Telefax: +49 231 5349423
COMPUTERBILD 15/03: Premium-e-mail-Dienste im Test
--
1. GMX TopMail - Platz 1 und Testsieger!
2. GMX ProMail - Platz 2 und Preis-Qualitätssieger!
3. Arcor - 4. web.de - 5. T-Online - 6. freenet.de - 7. daybyday - 8. e-Post
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
Re: cvs commit:jakarta-poi/src/testcases/org/apache/poi/poifs/filesystemSlowInputStream.java TestDocument.java
On 8/1/03 6:58 AM, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:
Slow input stream patch, bug 13478
...
for (;;) {
int got = in.read(b, off + total, len - total);
if (got 0) {
return (total == 0) ? -1 : total;
} else {
total += got;
if (total == len)
return total;
}
}
Hi Avik,
thanks for the patch! I suggest that the loop waits for a moment when read()
received less bytes than expected. Otherwise it would be a waste of CPU
cycles on very slow streams.
Best regards
Rainer Klute
That and it needs a timeout as well.
--
Andrew C. Oliver
http://www.superlinksoftware.com/poi.jsp
Custom enhancements and Commercial Implementation for Jakarta POI
http://jakarta.apache.org/poi
For Java and Excel, Got POI?
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
DO NOT REPLY [Bug 15353] - [RFE] creating a cell with a hyperlink
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15353. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15353 [RFE] creating a cell with a hyperlink --- Additional Comments From [EMAIL PROTECTED] 2003-08-01 13:47 --- Any feel as to when this will be resolved?. Would really like to have this feature by October. - To unsubscribe, e-mail: [EMAIL PROTECTED] Mailing List:http://jakarta.apache.org/site/mail2.html#poi The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
DO NOT REPLY [Bug 15353] - [RFE] creating a cell with a hyperlink
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15353. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15353 [RFE] creating a cell with a hyperlink --- Additional Comments From [EMAIL PROTECTED] 2003-08-01 13:58 --- SuperLink had a client funding this effort but the deal fell through so it will be when someone steps up and volunteers. I've tried to assign deadlines to developers I'm not paying in the past...doesn't work that way. - To unsubscribe, e-mail: [EMAIL PROTECTED] Mailing List:http://jakarta.apache.org/site/mail2.html#poi The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
DO NOT REPLY [Bug 22014] - wordDocument.writeAllText() return null
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22014. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22014 wordDocument.writeAllText() return null [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Additional Comments From [EMAIL PROTECTED] 2003-08-01 14:11 --- This document is from Word 2.0. Next time you have this problem go into Word and try to Save As. The version of the format will show up in the Save as type field. We don't support Word 2.0 and we have no plans to support Word 2.0...Sorry - To unsubscribe, e-mail: [EMAIL PROTECTED] Mailing List:http://jakarta.apache.org/site/mail2.html#poi The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
[RESULTS] Effect a naming policy g/POI/s//Poi/g
The motion failed to pass. +1 = 1 vote -0 = 1 vote To pass it required 3 +1 votes and not -1s. Lets move on now please. Regardless of personal preference lets put the community first. We don't have consensus on this, can never achieve consensus on this. That¹s why the policy was set to either in the first place. Tetsuya's issue seems to be primarily based on an issue with his editor not knowing which is correct POI or Poi. I have offered off-list to write his editor. Let us always remember what the project is about: writing great code and working with great guys. The details REALLY TRULY don't matter. It is important that we stick together and work together. It is important that we work towards things we CAN agree on and come up with inclusive ways to deal with things that we can't. We have a precedent of working in this way and if that¹s me not letting go of my baby then DAMN STRAIGHT. And neither should you. There are some people on this project with pretty strong opinions and hard heads and that is why we must always find the middle road. The one with either two winners or no losers. Lets get 2.0 out the door! I want to have some fun again! Lets make 3.0 into a hummer instead of a Hummer* ;-) -Andy * - a consumer version of a US mechanized infantry vehicle which has become popular. Its most notable for being HUGE, taking a lot of gas and looking like a big box. Very popular now a days... (logic however has fallen from favor) On 7/30/03 12:34 AM, Andrew C. Oliver [EMAIL PROTECTED] wrote: Let me put this the right way. This vote will be conducted by the Apache voting rules as documented here: http://jakarta.apache.org/site/decisions.html http://httpd.apache.org/dev/guidelines.html Note specifically: The act of voting carries certain obligations. Voting members are not only stating their opinion, they are also agreeing to help do the work. An action requiring consensus approval must receive at least 3 binding +1 votes and no binding vetos . An action requiring majority approval must receive at least 3 binding +1 votes and more +1 votes than -1 votes. All other action items are considered to have lazy approval until somebody votes -1 , after which point they are decided by either consensus or majority vote, depending on the type of action item. Product Changes Changes to the products of the Project, including code and documentation, will appear as action items in the status file. All product changes to the currently active repository are subject to lazy consensus. However, I'm opting to call a vote. === Presently the policy is: So if you like acronyms, then POI is an acronym. If you hate them, then we just used the name of the food for our project. If you wish to signify your love or hate for acronyms, use POI or Poi to refer to the project respectively. I propose to CHANGE this policy to: Only Poi is the acceptable spelling, POI is not an acronym. You must use Poi to refer to the project in all documentation. To preserve consistency with earlier releases all source code will use POI in class names and poi in package names. Please remember that a +1 indicates that you will help rename everything!!! [ ] +1 - I wish to enact this product change and will help [ ] +0 - I wish it to happen but will not help [ ] -0 - I don't wish it to happen but will not veto [ ] -1 - I veto the proposal. This vote will end at Thursday Friday August 1 at 00:30:00 EST. As mentioned above, to carry it must receive 3 BINDING +1 votes (active committers) and NO binding vetoes (-1). I expect that once this vote is complete that the matter should be closed. -Andy --- Andrew C. Oliver http://www.superlinksoftware.com/poi.jsp Custom enhancements and Commercial Implementation for Jakarta POI http://jakarta.apache.org/poi For Java and Excel, Got POI? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Andrew C. Oliver http://www.superlinksoftware.com/poi.jsp Custom enhancements and Commercial Implementation for Jakarta POI http://jakarta.apache.org/poi For Java and Excel, Got POI? - To unsubscribe, e-mail: [EMAIL PROTECTED] Mailing List:http://jakarta.apache.org/site/mail2.html#poi The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
Re: cvs commit: jakarta-poi/src/testcases/org/apache/poi/poifs/filesystem SlowInputStream.java TestDocument.java
On Fri, Aug 01, 2003 at 09:33:10AM -0400, Andrew C. Oliver wrote:
On 8/1/03 6:58 AM, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:
Slow input stream patch, bug 13478
...
for (;;) {
int got = in.read(b, off + total, len - total);
if (got 0) {
return (total == 0) ? -1 : total;
} else {
total += got;
if (total == len)
return total;
}
}
Hi Avik,
thanks for the patch! I suggest that the loop waits for a moment when read()
received less bytes than expected. Otherwise it would be a waste of CPU
cycles on very slow streams.
It will never just spin, it is guaranteed to return at least one byte
each time through the loop. And the way these things actually work, it
won't be just one byte either--there is almost always some buffering
going on at a lower level. Overall I am positive that making it wait
will have a negative impact on performance.
That and it needs a timeout as well.
You could have easily had a timeout situation with the old code--it was
blocking as well. In any case, I don't think this is the appropriate
place for a timeout. Instead, you should use a dedicated thread for
reading the document if that is a concern.
Chris
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
Re: cvs commit:jakarta-poi/src/testcases/org/apache/poi/poifs/filesystemSlowInputStream.java TestDocument.java
You could have easily had a timeout situation with the old code--it was blocking as well. In any case, I don't think this is the appropriate place for a timeout. Instead, you should use a dedicated thread for reading the document if that is a concern. The problem is that the only methods of stopping a dedicated thread are deprecated and are not blessed for multi-platform. -Andy Chris - To unsubscribe, e-mail: [EMAIL PROTECTED] Mailing List:http://jakarta.apache.org/site/mail2.html#poi The Apache Jakarta POI Project: http://jakarta.apache.org/poi/ -- Andrew C. Oliver http://www.superlinksoftware.com/poi.jsp Custom enhancements and Commercial Implementation for Jakarta POI http://jakarta.apache.org/poi For Java and Excel, Got POI? - To unsubscribe, e-mail: [EMAIL PROTECTED] Mailing List:http://jakarta.apache.org/site/mail2.html#poi The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
Re: cvs commit: jakarta-poi/src/testcases/org/apache/poi/poifs/filesystem SlowInputStream.java TestDocument.java
On Fri, Aug 01, 2003 at 12:08:52PM -0400, Andrew C. Oliver wrote: You could have easily had a timeout situation with the old code--it was blocking as well. In any case, I don't think this is the appropriate place for a timeout. Instead, you should use a dedicated thread for reading the document if that is a concern. The problem is that the only methods of stopping a dedicated thread are deprecated and are not blessed for multi-platform. There are ways...interrupt(), setting a flag to be checked by the reading thread periodically, etc. But my main point was that the current situation is not any different from the previous one, where there was no timeout code--you could block on the very first read of the stream. The discussion of how to implement a timeout is orthogonal to the slow input stream patch. Chris - To unsubscribe, e-mail: [EMAIL PROTECTED] Mailing List:http://jakarta.apache.org/site/mail2.html#poi The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
Re: cvs commit:jakarta-poi/src/testcases/org/apache/poi/poifs/filesystemSlowInputStream.java TestDocument.java
On 8/1/03 12:30 PM, Chris Nokleberg [EMAIL PROTECTED] wrote: On Fri, Aug 01, 2003 at 12:08:52PM -0400, Andrew C. Oliver wrote: You could have easily had a timeout situation with the old code--it was blocking as well. In any case, I don't think this is the appropriate place for a timeout. Instead, you should use a dedicated thread for reading the document if that is a concern. The problem is that the only methods of stopping a dedicated thread are deprecated and are not blessed for multi-platform. There are ways...interrupt(), setting a flag to be checked by the reading thread periodically, etc. But my main point was that the current situation is not any different from the previous one, where there was no timeout code--you could block on the very first read of the stream. The discussion of how to implement a timeout is orthogonal to the slow input stream patch. I'm not saying it is. I'm just saying we should consider it. Weird, for some reason I thought interrupt was deprecated as well. Apparently its not, only suspend, stop and resume. I still avoid interrupt because I've seen some weird threading issues with WebSphere when it's used. Also note that EJBs are not supposed to launch Thread. While I don't think generating XLS through an EJB is the most brilliant thing to do, it is done and there probably are reasons to do it. (esp where EJB-WebService are 1:1) -Andy Chris - To unsubscribe, e-mail: [EMAIL PROTECTED] Mailing List:http://jakarta.apache.org/site/mail2.html#poi The Apache Jakarta POI Project: http://jakarta.apache.org/poi/ -- Andrew C. Oliver http://www.superlinksoftware.com/poi.jsp Custom enhancements and Commercial Implementation for Jakarta POI http://jakarta.apache.org/poi For Java and Excel, Got POI? - To unsubscribe, e-mail: [EMAIL PROTECTED] Mailing List:http://jakarta.apache.org/site/mail2.html#poi The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
Re: cvs commit: jakarta-poi/src/testcases/org/apache/poi/poifs/filesystem SlowInputStream.java TestDocument.java
On Fri, Aug 01, 2003 at 12:33:36PM -0400, Andrew C. Oliver wrote: I'm not saying it is. I'm just saying we should consider it. Weird, for some reason I thought interrupt was deprecated as well. Apparently its not, only suspend, stop and resume. I still avoid interrupt because I've seen some weird threading issues with WebSphere when it's used. Also note that EJBs are not supposed to launch Thread. While I don't think generating XLS through an EJB is the most brilliant thing to do, it is done and there probably are reasons to do it. (esp where EJB-WebService are 1:1) Another possibility for people who need a timeout w/o a Thread is that they can wrap the InputStream in something like a TimeoutInputStream...no need to build it into the core POI IO routines. Chris - To unsubscribe, e-mail: [EMAIL PROTECTED] Mailing List:http://jakarta.apache.org/site/mail2.html#poi The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
Fw: [Apache Newsletter Draft] News on Jakarta in July, 2003
Dear Jakarta POI Development Team, (http://jakarta.apache.org/poi/) Hello, I am now in the process of preparing the first all-Apache-wide newsletter. http://www.apache.org/newsletter/ Please feel free to write statement/comment etc. to the Apache Newsletter (Issue 1) using ApacheWiki or in this mailing list. Hope to hear from you. http://nagoya.apache.org/wiki/apachewiki.cgi?ApacheNewsletterDrafts/Issue1 Sincerely, -- Tetsuya Kitahata ([EMAIL PROTECTED]) P.S. Jakarta POI Project's Wikipage is here: http://nagoya.apache.org/wiki/apachewiki.cgi?POIProjectPages Forwarded by Tetsuya Kitahata [EMAIL PROTECTED] --- Original Message --- From:Tetsuya Kitahata [EMAIL PROTECTED] To: [EMAIL PROTECTED] Date:Fri, 01 Aug 2003 15:54:21 +0900 Subject: [Apache Newsletter Draft] News on Jakarta in July, 2003 Hello, All (Jakarta-General Mailing List Subscribers) I am now preparing the 'The Apache Newsletter Issue 1', the first ASF-wide-newsletter of July 2003, which will be published in the middle of August 2003. -- http://www.apache.org/newsletter/ -- This The Apache Newsletter will be published as a result of the outgrowth of the previous Jakarta Newsletter and The Apache Newsletter can now cover all the projects under apache.org including infrastructure, incubator, xml, webservice, et cetra. 'The Apache Newsletter Issue 1' will be appeared at http://www.apache.org/newsletter/200307.html and the editorial deadline will be 00:00 GMT, 9th August. ApacheWiki (http://nagoya.apache.org/wiki/apachewiki.cgi) had been already set up. If you have anything to be added to the ApacheWiki, please go to http://nagoya.apache.org/wiki/apachewiki.cgi?ApacheNewsletterDrafts/Issue1 and fill up what you want to append in. If there's nothing news-worthy on your sub/projects, then please write something you *hope* (e.g. XX project will release FINAL version of XX product in the middle of August, etc etc). If you have been voted in warmly as a new committer in ASF the last month (July) please add your name to the list on ApacheWiki. If your project really want some ADVERTISEMENT (to recruit new comers, etc etc), please write nice and catchy blurb at the advertisement section so that it will attract the readers' attentions. Probably, the former newsletter final draft and newsletter itself (Jakarta Newsletter Issue 9) will give you some hints in writing the articles. cf. http://nagoya.apache.org/wiki/apachewiki.cgi?JakartaNewsletterDrafts/Issue9 http://jakarta.apache.org/site/news/200305.html If you have any questions about this, please send your messages to [EMAIL PROTECTED] This Newsletter will be published as webpage and be announced at [EMAIL PROTECTED] (the ASF-wide announcement list) To subscribe to [EMAIL PROTECTED], please follow this instruction: http://www.apache.org/foundation/mailinglists.html#foundation-announce Hope to hear from many jakarta subprojects!! (If you feel hesitation in writing articles on ApacheWiki, please write your memo in this Jakarta General mailing list or give me a note). http://nagoya.apache.org/wiki/apachewiki.cgi?ApacheNewsletterDrafts/Issue1 Sincerely, -- Tetsuya Kitahata ([EMAIL PROTECTED]) P.S. Also, your voice at Readers' Voice section will be highly appreciated. Contributions from readers are cordially invited !! - Tetsuya Kitahata -- Terra-International, Inc. E-mail: [EMAIL PROTECTED] http://www.terra-intl.com/ (Apache Jakarta Translation, Japanese) http://jakarta.terra-intl.com/ - Original Message Ends - To unsubscribe, e-mail: [EMAIL PROTECTED] Mailing List:http://jakarta.apache.org/site/mail2.html#poi The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
