RE: [PATCH] FormulaEvaluator functions added

2005-06-03 Thread Amol Deshmukh
 --- Additional Comments From [EMAIL PROTECTED] 
2005-06-01 
 19:52 ---
 Some testcases failed!
snipped/
 
 Not sure, but these seem to be places where you have
=NA() as 
 the expected
 value. Can you pls investigate, thanks!
 


Avik,

I presume you opened the test xls in OpenOffice.
The =NA() values are actually Error values 
(#VALUE! etc.), since those tests check if the
evaluator can return error values when that is the
expectation. However, OpenOffice seems to evaluate
some of the formulas that return error in excel.

I have fixed problems in the core eval classes that
was causing the automated tests to fail and updated
the patch - so the new patch file should be good to
go :)

Regards,
~ amol



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/



RE: [PATCH] FormulaEvaluator functions added

2005-06-03 Thread Avik Sengupta
Ok, I'll put it in. Dont assign bugs to yourself, leave it assigned to
be the lists, else we cant figure when you put in new comments :)

On Fri, 2005-06-03 at 05:30 -0700, Amol Deshmukh wrote:
  --- Additional Comments From [EMAIL PROTECTED] 
 2005-06-01 
  19:52 ---
  Some testcases failed!
 snipped/
  
  Not sure, but these seem to be places where you have
 =NA() as 
  the expected
  value. Can you pls investigate, thanks!
  
 
 
 Avik,
 
 I presume you opened the test xls in OpenOffice.
 The =NA() values are actually Error values 
 (#VALUE! etc.), since those tests check if the
 evaluator can return error values when that is the
 expectation. However, OpenOffice seems to evaluate
 some of the formulas that return error in excel.
 
 I have fixed problems in the core eval classes that
 was causing the automated tests to fail and updated
 the patch - so the new patch file should be good to
 go :)
 
 Regards,
 ~ amol
 
 
 
 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 Mailing List:http://jakarta.apache.org/site/mail2.html#poi
 The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
 
-- 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/



DO NOT REPLY [Bug 35204] New: - [PATCH] Updated documentation for PowerPoint Support

2005-06-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=35204.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=35204

   Summary: [PATCH] Updated documentation for PowerPoint Support
   Product: POI
   Version: unspecified
  Platform: Other
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P2
 Component: POI Overall
AssignedTo: poi-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


Some documentation updates, and a new document giving an overview of the
powerpoint file format

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/



DO NOT REPLY [Bug 35204] - [PATCH] Updated documentation for PowerPoint Support

2005-06-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=35204.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=35204





--- Additional Comments From [EMAIL PROTECTED]  2005-06-03 16:07 ---
Created an attachment (id=15285)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=15285action=view)
Update to HSLF documentation


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/



DO NOT REPLY [Bug 35204] - [PATCH] Updated documentation for PowerPoint Support

2005-06-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=35204.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=35204





--- Additional Comments From [EMAIL PROTECTED]  2005-06-03 16:07 ---
Created an attachment (id=15286)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=15286action=view)
Initial documentation on the PowerPoint file format


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/



DO NOT REPLY [Bug 35206] New: - [PATCH] New unit tests for HSLF

2005-06-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=35206.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=35206

   Summary: [PATCH] New unit tests for HSLF
   Product: POI
   Version: unspecified
  Platform: Other
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P2
 Component: POI Overall
AssignedTo: poi-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


A few new unit tests for HSLF

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/



DO NOT REPLY [Bug 35206] - [PATCH] New unit tests for HSLF

2005-06-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=35206.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=35206





--- Additional Comments From [EMAIL PROTECTED]  2005-06-03 17:06 ---
Created an attachment (id=15291)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=15291action=view)
Some more unit tests for HSLF


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/



DO NOT REPLY [Bug 35208] New: - [PATCH] HSLF Update: new (quicker but greedy) text extractor

2005-06-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=35208.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=35208

   Summary: [PATCH] HSLF Update: new (quicker but greedy) text
extractor
   Product: POI
   Version: unspecified
  Platform: Other
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P2
 Component: POI Overall
AssignedTo: poi-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


To quote from the javadoc of this single class:
 * This class will get all the text from a Powerpoint Document, including
 *  all the bits you didn't want, and in a somewhat random order, but will
 *  do it very fast.
 * The class ignores most of the hslf classes, and doesn't use 
 *  HSLFSlideShow. Instead, it just does a very basic scan through the
 *  file, grabbing all the text records as it goes. It then returns the
 *  text, either as a single string, or as a vector of all the individual
 *  strings.
 * Because of how it works, it will return a lot of crud text that you 
 *  probably didn't want! It will return text from master slides. It will
 *  return duplicate text, and some mangled text (powerpoint files often
 *  have duplicate copies of slide text in them). You don't get any idea
 *  what the text was associated with.
 * Almost everyone will want to use @see PowerPointExtractor instead. There
 *  are only a very small number of cases (eg some performance sensitive
 *  lucene indexers) that would ever want to use this!


File should go in org.apache.poi.hslf.extractor. Also needs a single line change
in org.apache.poi.hslf.record.Record:


Index: Record.java
===
RCS file:
/home/cvspublic/jakarta-poi/src/scratchpad/src/org/apache/poi/hslf/record/Record.java,v
retrieving revision 1.1
diff -u -r1.1 Record.java
--- Record.java 28 May 2005 05:36:00 -  1.1
+++ Record.java 3 Jun 2005 16:31:00 -
@@ -122,7 +122,7 @@
 *  (not including the size of the header), this code assumes you're
 *  passing in corrected lengths
 */
-   protected static Record createRecordForType(long type, byte[] b, int
start, int len) {
+   public static Record createRecordForType(long type, byte[] b, int start,
int len) {
// Default is to use UnknownRecordPlaceholder
// When you create classes for new Records, add them here
switch((int)type) {

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/



DO NOT REPLY [Bug 35208] - [PATCH] HSLF Update: new (quicker but greedy) text extractor

2005-06-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=35208.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=35208





--- Additional Comments From [EMAIL PROTECTED]  2005-06-03 18:34 ---
Created an attachment (id=15292)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=15292action=view)
org.apache.poi.hslf.extractor.QuickButCruddyTextExtractor


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/



[VOTE] Nick and Amol as committers

2005-06-03 Thread avik . sengupta
Nick Burch has been working on the Powerpoint support for POI for a while now.
His code has been recently committed to the repository, and I'm sure there is
more on the way.

Amol Deshmukh has added significant new functionality to POI in formula
evaluation, and has offered many other bugfixes and comments over the past few
months.

I believe it is time that they checked in their own pathes now :)

Please provide your votes for

Nick Burch as jakarta-poi committer [  ]
Amol Deshmukh as jakarta-poi committer [  ]

To start, here's my  +1 to both.

Regards
-
Avik

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/



Re: [VOTE] Nick and Amol as committers

2005-06-03 Thread Rainer Klute
Am Samstag, den 04.06.2005, 00:20 +0530 schrieb
[EMAIL PROTECTED]:
 Nick Burch as jakarta-poi committer [ +1 ]
 Amol Deshmukh as jakarta-poi committer [ +1 ]
-- 
Best regards
Rainer Klute

   Rainer Klute IT-Consulting GmbH
  Dipl.-Inform.
  Rainer Klute E-Mail:  [EMAIL PROTECTED]
  Körner Grund 24  Telefon: +49 172 2324824
D-44143 Dortmund   Telefax: +49 231 5349423

Inhibit software patents: http://www.nosoftwarepatents.com/


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/



Re: [VOTE] Nick and Amol as committers

2005-06-03 Thread acoliver

+1, +1

[EMAIL PROTECTED] wrote:

Nick Burch has been working on the Powerpoint support for POI for a while now.
His code has been recently committed to the repository, and I'm sure there is
more on the way.

Amol Deshmukh has added significant new functionality to POI in formula
evaluation, and has offered many other bugfixes and comments over the past few
months.

I believe it is time that they checked in their own pathes now :)

Please provide your votes for

Nick Burch as jakarta-poi committer [  ]
Amol Deshmukh as jakarta-poi committer [  ]

To start, here's my  +1 to both.

Regards
-
Avik

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/




--
Andrew C. Oliver
SuperLink Software, Inc.

Java to Excel using POI
http://www.superlinksoftware.com/services/poi
Commercial support including features added/implemented, bugs fixed.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/



Re: [VOTE] Nick and Amol as committers

2005-06-03 Thread Glen Stampoultzis



Nick Burch as jakarta-poi committer [ +1 ]
Amol Deshmukh as jakarta-poi committer [ +1 ]

 




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/