Re: Build/release stuff WAS Re: What Are Current POI Release Plans?

[David Fisher]

Nick,

Thanks.

Regards,
Dave

On Jan 11, 2007, at 5:46 AM, Nick Burch wrote:


On Wed, 10 Jan 2007, Andrew C. Oliver wrote:

1. Someone needs to anoint themselves release manager for 3.x.x XXx


I can do this, if no-one else fancies it. (I will need several  
people to volunteer to check things)



2. Someone needs to get a valid key recognized by Apache.


I have a pgp key that's signed by a fair number of apache people

can someone please figure out if we have any other REAL issues and  
list them here?


We still need to do a few more tweaks to the build process. I'm  
hoping to get that sorted within a week.


My plan after that was:
1) Lazy consensus vote to fork a release branch
2) Fork a release branch
3) Prod people to review outstanding bugs, and decide which of them we
should fix for 3.0
4) Ensure that patches go against trunk and the release branch
5) Wait for the patches to come rolling in
6) Do periodic release candidate builds
7) Do a vote to release one of these as -FINAL, once people are  
happy with

them

Nick

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/

DO NOT REPLY [Bug 40143] - HSLF: RichTextRun returns wrong style attributes

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40143





--- Additional Comments From [EMAIL PROTECTED]  2007-01-11 08:36 ---
The file I attached (returns 0 for the font.size) has one text box with font
size 20. This is the value I expected, but RichTextRun.getFontSize() returns 0.
Running with the file previously attached, the values returned were correct.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/

DO NOT REPLY [Bug 40143] - HSLF: RichTextRun returns wrong style attributes

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40143





--- Additional Comments From [EMAIL PROTECTED]  2007-01-11 08:22 ---
Tales - could you let us know which data you would expect from your test file,
so we can turn it into a (failing) test to work against?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/

DO NOT REPLY [Bug 40143] - HSLF: RichTextRun returns wrong style attributes

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40143





--- Additional Comments From [EMAIL PROTECTED]  2007-01-11 08:21 ---
Bah, that code hurt my head enough when it was written the first time...

I've committed your code (hopefully infra will do your account soon!). Glad you
managed to track the bug down :)

I agree we should split out the TextPropCollection and TextProp stuff, probably
into model. I suspect we'll want two sub classes, one for the slide style
definitions, and one for the master definitions. Should be cleaner code then.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/

svn commit: r495278 - in /jakarta/poi/trunk/src/scratchpad: src/org/apache/poi/hslf/model/TextRun.java src/org/apache/poi/hslf/record/StyleTextPropAtom.java testcases/org/apache/poi/hslf/record/TestSt

[nick]

Author: nick
Date: Thu Jan 11 08:18:30 2007
New Revision: 495278

URL: http://svn.apache.org/viewvc?view=rev&rev=495278
Log:
Handle the fact that StyleTextPropAtom needs to work with a text length that's 
one larger than the underlying text it represents. (Fix from Yegor from bug 
#40143)

Modified:
jakarta/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/model/TextRun.java

jakarta/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/StyleTextPropAtom.java

jakarta/poi/trunk/src/scratchpad/testcases/org/apache/poi/hslf/record/TestStyleTextPropAtom.java

Modified: 
jakarta/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/model/TextRun.java
URL: 
http://svn.apache.org/viewvc/jakarta/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/model/TextRun.java?view=diff&rev=495278&r1=495277&r2=495278
==
--- jakarta/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/model/TextRun.java 
(original)
+++ jakarta/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/model/TextRun.java 
Thu Jan 11 08:18:30 2007
@@ -417,7 +417,7 @@
}

// Create a new one at the right size
-   _styleAtom = new StyleTextPropAtom(getRawText().length());
+   _styleAtom = new StyleTextPropAtom(getRawText().length() + 1);

// Use the TextHeader atom to get at the parent
RecordContainer runAtomsParent = _headerAtom.getParentRecord();

Modified: 
jakarta/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/StyleTextPropAtom.java
URL: 
http://svn.apache.org/viewvc/jakarta/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/StyleTextPropAtom.java?view=diff&rev=495278&r1=495277&r2=495278
==
--- 
jakarta/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/StyleTextPropAtom.java
 (original)
+++ 
jakarta/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/StyleTextPropAtom.java
 Thu Jan 11 08:18:30 2007
@@ -228,7 +228,8 @@
 
// While we have text in need of paragraph stylings, go ahead 
and
// grok the contents as paragraph formatting data
-   while(pos < rawContents.length && textHandled < size) {
+int prsize = size;
+   while(pos < rawContents.length && textHandled < prsize) {
// First up, fetch the number of characters this 
applies to
int textLen = LittleEndian.getInt(rawContents,pos);
textHandled += textLen;
@@ -250,11 +251,21 @@
 
// Save this properties set
paragraphStyles.add(thisCollection);
+
+// Handle extra 1 paragraph styles at the end
+if(pos < rawContents.length && textHandled == size) {
+prsize++;
+}
+
}
+if (rawContents.length > 0 && textHandled != (size+1)){
+System.err.println("Problem reading paragraph style runs: 
textHandled = " + textHandled + ", text.size+1 = " + (size+1));
+}
 
// Now do the character stylings
textHandled = 0;
-   while(pos < rawContents.length && textHandled < size) {
+int chsize = size;
+   while(pos < rawContents.length && textHandled < chsize) {
// First up, fetch the number of characters this 
applies to
int textLen = LittleEndian.getInt(rawContents,pos);
textHandled += textLen;
@@ -279,9 +290,12 @@

// Handle extra 1 char styles at the end
if(pos < rawContents.length && textHandled == size) {
-   size++;
+   chsize++;
}
}
+if (rawContents.length > 0 && textHandled != (size+1)){
+System.err.println("Problem reading character style runs: 
textHandled = " + textHandled + ", text.size+1 = " + (size+1));
+}
 
// Handle anything left over
if(pos < rawContents.length) {

Modified: 
jakarta/poi/trunk/src/scratchpad/testcases/org/apache/poi/hslf/record/TestStyleTextPropAtom.java
URL: 
http://svn.apache.org/viewvc/jakarta/poi/trunk/src/scratchpad/testcases/org/apache/poi/hslf/record/TestStyleTextPropAtom.java?view=diff&rev=495278&r1=495277&r2=495278
==
--- 
jakarta/poi/trunk/src/scratchpad/testcases/org/apache/poi/hslf/record/TestStyleTextPropAtom.java
 (original)
+++ 
jakarta/poi/trunk/src/scratchpad/testcases/org/apache/poi/hslf/record/TestStyleTextPropAtom.java
 Thu Jan 11 08:18:30 2007
@@ -49,7 +49,7 @@
   00, 00, 0x04, 00, // font.color only
   0xFF-256, 0x33, 00, 0xFE-256 // red
};
-   private int 

DO NOT REPLY [Bug 41223] - Simple image extraction for HSSFWorkbook

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41223


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |NEEDINFO




--- Additional Comments From [EMAIL PROTECTED]  2007-01-11 08:14 ---
This code looks good, thanks for it.

Any chance you could knock up a quick test for it? I guess it just needs to
extract a pre-defined image out of a workbook, and check it has the right data
in it. That way, we can be sure we don't break the functionality in the future.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/

DO NOT REPLY [Bug 40143] - HSLF: RichTextRun returns wrong style attributes

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40143





--- Additional Comments From [EMAIL PROTECTED]  2007-01-11 08:07 ---
Created an attachment (id=19393)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=19393&action=view)
returns 0 for the font.size

I applied the patch with the fix of this bug, but the same problem still
happens. The font.size value returned is wrong (almost always, it returns 0). I
tested the file test2 and this I'm uploading and I have more two files with the
same problem. 

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/

Re: Build/release stuff WAS Re: What Are Current POI Release Plans?

[Yegor Kozlov]

ACO> can someone please figure out if we have any other REAL issues and list 
ACO> them here?  Some seemed to be "preference" issues of Jakarta members.  I 
ACO> do not plan to assist in satiating those.  #2 is a serious issue, we 
ACO> should be signing releases.  I will help with any serious legal or 
ACO> technical issues as the integrity of POI is important to me / our business.

For HSSF we have 84 open issues in the bugzilla.

I'm going to sort them out. 
There are duplicates of already closed bugs or bugs that were fixed but not 
closed.
It's a good idea to clean up the bug database before the release.

Yegor


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/

Re: Build/release stuff WAS Re: What Are Current POI Release Plans?

[Mark Thomas]

Avik Sengupta wrote:
> Most important  issue was the file headers. Been fixed. Key signing needs to 
> be arranged.

A number if source files have no header at all. I haven't done an
exhaustive check but the ones I found on my random wander through the
source were:
font_metrics.properties
various package.html files
various xml files

My reading of http://www.apache.org/legal/src-headers.html is that
most, if not all, of these files require headers and that this really
does need to be fixed before the next release.

I should have some time to fix these over the next week or so. It
would be easier to grant me the necessary karma to fix these myself
but I can provide patches on a bugzilla entry if you prefer. Let me know.

I also spotted a handful of "nice to have"s whilst I was looking at
the build process. Again karma or patches? Let me know.

Mark


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/

DO NOT REPLY [Bug 41026] - [PATCH] ArrayIndexOutOfBoundsException in ValueRecordsAggregate.rowHasCells

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41026





--- Additional Comments From [EMAIL PROTECTED]  2007-01-11 04:04 ---
Can someone please put in a testcase that triggers this bug? Its quite 
difficult to fix otherwise. Thanks. 

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/

Re: Build/release stuff WAS Re: What Are Current POI Release Plans?

[Nick Burch]

On Wed, 10 Jan 2007, Andrew C. Oliver wrote:

1. Someone needs to anoint themselves release manager for 3.x.x XXx


I can do this, if no-one else fancies it. (I will need several people to 
volunteer to check things)



2. Someone needs to get a valid key recognized by Apache.


I have a pgp key that's signed by a fair number of apache people

can someone please figure out if we have any other REAL issues and list 
them here?


We still need to do a few more tweaks to the build process. I'm hoping to 
get that sorted within a week.


My plan after that was:
1) Lazy consensus vote to fork a release branch
2) Fork a release branch
3) Prod people to review outstanding bugs, and decide which of them we
should fix for 3.0
4) Ensure that patches go against trunk and the release branch
5) Wait for the patches to come rolling in
6) Do periodic release candidate builds
7) Do a vote to release one of these as -FINAL, once people are happy with
them

Nick

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/