cvs commit: jakarta-poi/src/java/org/apache/poi/util StringUtil.java

[acoliver]

acoliver02/05/19 10:54:07

  Modified:src/java/org/apache/poi/util StringUtil.java
  Log:
  Forgot to check in support functions for yet ANOTHER way that Excel handles strings 
(makes 3-4th way)
  
  Revision  ChangesPath
  1.2   +223 -175  jakarta-poi/src/java/org/apache/poi/util/StringUtil.java
  
  Index: StringUtil.java
  ===
  RCS file: /home/cvs/jakarta-poi/src/java/org/apache/poi/util/StringUtil.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- StringUtil.java   31 Jan 2002 02:23:46 -  1.1
  +++ StringUtil.java   19 May 2002 17:54:07 -  1.2
  @@ -1,58 +1,58 @@
   
  -/* 
  - * The Apache Software License, Version 1.1
  +/*
  + *  
  + *  The Apache Software License, Version 1.1
*
  - * Copyright (c) 2002 The Apache Software Foundation.  All rights
  - * reserved.
  + *  Copyright (c) 2002 The Apache Software Foundation.  All rights
  + *  reserved.
*
  - * Redistribution and use in source and binary forms, with or without
  - * modification, are permitted provided that the following conditions
  - * are met:
  - *
  - * 1. Redistributions of source code must retain the above copyright
  - *notice, this list of conditions and the following disclaimer.
  - *
  - * 2. Redistributions in binary form must reproduce the above copyright
  - *notice, this list of conditions and the following disclaimer in
  - *the documentation and/or other materials provided with the
  - *distribution.
  - *
  - * 3. The end-user documentation included with the redistribution,
  - *if any, must include the following acknowledgment:
  - *   "This product includes software developed by the
  - *Apache Software Foundation (http://www.apache.org/)."
  - *Alternately, this acknowledgment may appear in the software itself,
  - *if and wherever such third-party acknowledgments normally appear.
  - *
  - * 4. The names "Apache" and "Apache Software Foundation" and
  - *"Apache POI" must not be used to endorse or promote products
  - *derived from this software without prior written permission. For
  - *written permission, please contact [EMAIL PROTECTED]
  - *
  - * 5. Products derived from this software may not be called "Apache",
  - *"Apache POI", nor may "Apache" appear in their name, without
  - *prior written permission of the Apache Software Foundation.
  - *
  - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
  - * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
  - * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
  - * DISCLAIMED.  IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR
  - * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  - * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  - * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
  - * USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
  - * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
  - * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
  - * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  - * SUCH DAMAGE.
  - * 
  - *
  - * This software consists of voluntary contributions made by many
  - * individuals on behalf of the Apache Software Foundation.  For more
  - * information on the Apache Software Foundation, please see
  - * .
  + *  Redistribution and use in source and binary forms, with or without
  + *  modification, are permitted provided that the following conditions
  + *  are met:
  + *
  + *  1. Redistributions of source code must retain the above copyright
  + *  notice, this list of conditions and the following disclaimer.
  + *
  + *  2. Redistributions in binary form must reproduce the above copyright
  + *  notice, this list of conditions and the following disclaimer in
  + *  the documentation and/or other materials provided with the
  + *  distribution.
  + *
  + *  3. The end-user documentation included with the redistribution,
  + *  if any, must include the following acknowledgment:
  + *  "This product includes software developed by the
  + *  Apache Software Foundation (http://www.apache.org/)."
  + *  Alternately, this acknowledgment may appear in the software itself,
  + *  if and wherever such third-party acknowledgments normally appear.
  + *
  + *  4. The names "Apache" and "Apache Software Foundation" and
  + *  "Apache POI" must not be used to endorse or promote products
  + *  derived from this software without prior written permission. For
  + *  written permission, please contact [EMAIL PROTECTED]
  + *
  + *  5. Products derive

cvs commit: jakarta-poi/src/java/org/apache/poi/util StringUtil.java

[acoliver]

acoliver2002/07/28 15:50:42

  Modified:src/java/org/apache/poi/util StringUtil.java
  Log:
  backed out this code it causes 
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10393
  
  Revision  ChangesPath
  1.4   +16 -41jakarta-poi/src/java/org/apache/poi/util/StringUtil.java
  
  Index: StringUtil.java
  ===
  RCS file: /home/cvs/jakarta-poi/src/java/org/apache/poi/util/StringUtil.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- StringUtil.java   21 Jul 2002 03:03:57 -  1.3
  +++ StringUtil.java   28 Jul 2002 22:50:41 -  1.4
  @@ -62,14 +62,8 @@
   
   /**
*  Title: String Utility Description: Collection of string handling utilities
  - * 
  - * Now it is quite confusing: the method pairs, in which
  - * one of them write data and other read written data are:
  - * putUncompressedUnicodeHigh and getFromUnicode
  - * putUncompressedUnicode and getFromUnicodeHigh
*
*@author Andrew C. Oliver
  - *@author Sergei Kozello (sergeikozello at mail.ru)
*@createdMay 10, 2002
*@version1.0
*/
  @@ -85,8 +79,6 @@
*  given a byte array of 16-bit unicode characters, compress to 8-bit and
*  return a string
*
  - * { 0x16, 0x00 } -> 0x16
  - * 
*@param  string  the byte array to be converted
*@param  offset  the initial offset into the
*  byte array. it is assumed that string[ offset ] and string[ offset +
  @@ -111,37 +103,22 @@
   if ((len < 0) || (((string.length - offset) / 2) < len)) {
   throw new IllegalArgumentException("Illegal length");
   }
  -
  -char[] chars = new char[ len ];
  -for ( int i = 0; i < chars.length; i++ ) {
  -chars[i] = (char)( string[ offset + ( 2*i ) ] + 
  - ( string[ offset + ( 2*i+1 ) ] << 8 ) );
  +byte[] bstring = new byte[len];
  +int index = offset;
  +// start with high bits.
  +
  +for (int k = 0; k < len; k++) {
  +bstring[k] = string[index];
  +index += 2;
   }
  -
  -return new String( chars );
  +return new String(bstring);
   }
   
   
  -/**
  - *  given a byte array of 16-bit unicode characters, compress to 8-bit and
  - *  return a string
  - * 
  - * { 0x16, 0x00 } -> 0x16
  - *
  - *@param  string  the byte array to be converted
  - *@return the converted string
  - */
  -
  -public static String getFromUnicodeHigh( final byte[] string ) {
  -return getFromUnicodeHigh( string, 0, string.length / 2 );
  -}
  -
   
   /**
*  given a byte array of 16-bit unicode characters, compress to 8-bit and
*  return a string
  - * 
  - * { 0x00, 0x16 } -> 0x16
*
*@param  string  the byte array to be converted
*@param  offset  the initial offset into the
  @@ -167,23 +144,21 @@
   if ((len < 0) || (((string.length - offset) / 2) < len)) {
   throw new IllegalArgumentException("Illegal length");
   }
  -
  -
  -char[] chars = new char[ len ];
  -for ( int i = 0; i < chars.length; i++ ) {
  -chars[i] = (char)( ( string[ offset + ( 2*i ) ] << 8 ) +
  - string[ offset + ( 2*i+1 ) ] );
  +byte[] bstring = new byte[len];
  +int index = offset + 1;
  +// start with low bits.
  +
  +for (int k = 0; k < len; k++) {
  +bstring[k] = string[index];
  +index += 2;
   }
  -
  -return new String( chars );
  +return new String(bstring);
   }
   
   
   /**
*  given a byte array of 16-bit unicode characters, compress to 8-bit and
*  return a string
  - * 
  - * { 0x00, 0x16 } -> 0x16
*
*@param  string  the byte array to be converted
*@return the converted string
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-poi/src/java/org/apache/poi/util StringUtil.java

[acoliver]

acoliver2002/09/11 18:49:40

  Modified:src/java/org/apache/poi/util StringUtil.java
  Log:
  http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12410
  
  Revision  ChangesPath
  1.6   +1 -1  jakarta-poi/src/java/org/apache/poi/util/StringUtil.java
  
  Index: StringUtil.java
  ===
  RCS file: /home/cvs/jakarta-poi/src/java/org/apache/poi/util/StringUtil.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- StringUtil.java   2 Sep 2002 02:11:16 -   1.5
  +++ StringUtil.java   12 Sep 2002 01:49:40 -  1.6
  @@ -114,7 +114,7 @@
   
   char[] chars = new char[ len ];
   for ( int i = 0; i < chars.length; i++ ) {
  -chars[i] = (char)( string[ offset + ( 2*i ) ] + 
  +chars[i] = (char)( string[ offset + ( 2*i ) ] & 0xFF | 
( string[ offset + ( 2*i+1 ) ] << 8 ) );
   }
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-poi/src/java/org/apache/poi/util StringUtil.java

[acoliver]

acoliver2002/11/07 18:49:51

  Modified:src/java/org/apache/poi/util StringUtil.java
  Log:
  javadoc
  
  Revision  ChangesPath
  1.8   +3 -0  jakarta-poi/src/java/org/apache/poi/util/StringUtil.java
  
  Index: StringUtil.java
  ===
  RCS file: /home/cvs/jakarta-poi/src/java/org/apache/poi/util/StringUtil.java,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- StringUtil.java   8 Nov 2002 02:34:08 -   1.7
  +++ StringUtil.java   8 Nov 2002 02:49:51 -   1.8
  @@ -335,6 +335,9 @@
   return 1;
   }
   
  +/**
  + * @return the encoding we want to use (ISO-8859-1)
  + */
   public static String getPreferredEncoding() {
   return ENCODING;   
   }
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-poi/src/java/org/apache/poi/util StringUtil.java

[avik]

avik2003/06/03 06:14:48

  Modified:src/java/org/apache/poi/util Tag: REL_2_BRANCH
StringUtil.java
  Log:
  Removed the mess created by lost line endings. PLEASE take care the next time you 
commit
  
  Revision  ChangesPath
  No   revision
  
  
  No   revision
  
  
  1.10.2.1  +363 -1jakarta-poi/src/java/org/apache/poi/util/StringUtil.java
  
  Index: StringUtil.java
  ===
  RCS file: /home/cvs/jakarta-poi/src/java/org/apache/poi/util/StringUtil.java,v
  retrieving revision 1.10
  retrieving revision 1.10.2.1
  diff -u -r1.10 -r1.10.2.1
  --- StringUtil.java   30 Apr 2003 04:39:08 -  1.10
  +++ StringUtil.java   3 Jun 2003 13:14:47 -   1.10.2.1
  @@ -1 +1,363 @@
  -/* *   *  The 
Apache Software License, Version 1.1 * *  Copyright (c) 2003 The Apache Software 
Foundation.  All rights *  reserved. * *  Redistribution and use in source and binary 
forms, with or without *  modification, are permitted provided that the following 
conditions *  are met: * *  1. Redistributions of source code must retain the above 
copyright *  notice, this list of conditions and the following disclaimer. * *  2. 
Redistributions in binary form must reproduce the above copyright *  notice, this list 
of conditions and the following disclaimer in *  the documentation and/or other 
materials provided with the *  distribution. * *  3. The end-user documentation 
included with the redistribution, *  if any, must include the following 
acknowledgment: *  "This product includes software developed by the *  Apache Software 
Foundation (http://www.apache.org/)." *  Alternately, this acknowledgment may appear 
in the software itself, *  if and wherever such third-party acknowledgments normally 
appear. * *  4. The names "Apache" and "Apache Software Foundation" and *  "Apache 
POI" must not be used to endorse or promote products *  derived from this software 
without prior written permission. For *  written permission, please contact [EMAIL 
PROTECTED] * *  5. Products derived from this software may not be called "Apache", *  
"Apache POI", nor may "Apache" appear in their name, without *  prior written 
permission of the Apache Software Foundation. * *  THIS SOFTWARE IS PROVIDED ``AS IS'' 
AND ANY EXPRESSED OR IMPLIED *  WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED 
WARRANTIES *  OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE *  
DISCLAIMED.  IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR *  ITS CONTRIBUTORS 
BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, *  SPECIAL, EXEMPLARY, OR 
CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT *  LIMITED TO, PROCUREMENT OF SUBSTITUTE 
GOODS OR SERVICES; LOSS OF *  USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER 
CAUSED AND *  ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, *  OR 
TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT *  OF THE USE OF THIS 
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF *  SUCH DAMAGE. *  
 * *  This 
software consists of voluntary contributions made by many *  individuals on behalf of 
the Apache Software Foundation.  For more *  information on the Apache Software 
Foundation, please see *  . */package 
org.apache.poi.util;import java.io.UnsupportedEncodingException;import 
java.text.NumberFormat;import java.text.FieldPosition;/** *  Title: String Utility 
Description: Collection of string handling utilities *  * Now it is quite confusing: 
the method pairs, in which * one of them write data and other read written data are: * 
putUncompressedUnicodeHigh and getFromUnicode * putUncompressedUnicode and 
getFromUnicodeHigh * [EMAIL PROTECTED] Andrew C. Oliver [EMAIL PROTECTED] 
Sergei Kozello (sergeikozello at mail.ru) [EMAIL PROTECTED]May 10, 2002 [EMAIL 
PROTECTED]1.0 */public class StringUtil {private final static String 
ENCODING="ISO-8859-1";/** *  Constructor for the StringUtil object */
private StringUtil() { }/** *  given a byte array of 16-bit unicode 
characters, compress to 8-bit and *  return a string * * { 0x16, 0x00 } -> 
0x16 *  [EMAIL PROTECTED]  string  the byte array 
to be converted [EMAIL PROTECTED]  offset  the initial 
offset into the *  byte array. it is assumed that string[ offset ] and string[ 
offset + *  1 ] contain the first 16-bit unicode character [EMAIL 
PROTECTED]  len [EMAIL PROTECTED] the 
converted string [EMAIL PROTECTED]  ArrayIndexOutOfBoundsException  if offset is 
out of bounds for *  the byte array (i.e., is negative or is greater than or 
equal to 

cvs commit: jakarta-poi/src/java/org/apache/poi/util StringUtil.java

[tetsuya]

tetsuya 2003/07/24 09:58:09

  Modified:src/java/org/apache/poi/util StringUtil.java
  Log:
  Fixed Weird Line Feed: Submitted by Toshiaki Kamoshida
  
  Revision  ChangesPath
  1.11  +346 -1jakarta-poi/src/java/org/apache/poi/util/StringUtil.java
  
  Index: StringUtil.java
  ===
  RCS file: /home/cvs/jakarta-poi/src/java/org/apache/poi/util/StringUtil.java,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- StringUtil.java   30 Apr 2003 04:39:08 -  1.10
  +++ StringUtil.java   24 Jul 2003 16:58:09 -  1.11
  @@ -1 +1,346 @@
  -/* *   *  The 
Apache Software License, Version 1.1 * *  Copyright (c) 2003 The Apache Software 
Foundation.  All rights *  reserved. * *  Redistribution and use in source and binary 
forms, with or without *  modification, are permitted provided that the following 
conditions *  are met: * *  1. Redistributions of source code must retain the above 
copyright *  notice, this list of conditions and the following disclaimer. * *  2. 
Redistributions in binary form must reproduce the above copyright *  notice, this list 
of conditions and the following disclaimer in *  the documentation and/or other 
materials provided with the *  distribution. * *  3. The end-user documentation 
included with the redistribution, *  if any, must include the following 
acknowledgment: *  "This product includes software developed by the *  Apache Software 
Foundation (http://www.apache.org/)." *  Alternately, this acknowledgment may appear 
in the software itself, *  if and wherever such third-party acknowledgments normally 
appear. * *  4. The names "Apache" and "Apache Software Foundation" and *  "Apache 
POI" must not be used to endorse or promote products *  derived from this software 
without prior written permission. For *  written permission, please contact [EMAIL 
PROTECTED] * *  5. Products derived from this software may not be called "Apache", *  
"Apache POI", nor may "Apache" appear in their name, without *  prior written 
permission of the Apache Software Foundation. * *  THIS SOFTWARE IS PROVIDED ``AS IS'' 
AND ANY EXPRESSED OR IMPLIED *  WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED 
WARRANTIES *  OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE *  
DISCLAIMED.  IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR *  ITS CONTRIBUTORS 
BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, *  SPECIAL, EXEMPLARY, OR 
CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT *  LIMITED TO, PROCUREMENT OF SUBSTITUTE 
GOODS OR SERVICES; LOSS OF *  USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER 
CAUSED AND *  ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, *  OR 
TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT *  OF THE USE OF THIS 
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF *  SUCH DAMAGE. *  
 * *  This 
software consists of voluntary contributions made by many *  individuals on behalf of 
the Apache Software Foundation.  For more *  information on the Apache Software 
Foundation, please see *  . */package 
org.apache.poi.util;import java.io.UnsupportedEncodingException;import 
java.text.NumberFormat;import java.text.FieldPosition;/** *  Title: String Utility 
Description: Collection of string handling utilities *  * Now it is quite confusing: 
the method pairs, in which * one of them write data and other read written data are: * 
putUncompressedUnicodeHigh and getFromUnicode * putUncompressedUnicode and 
getFromUnicodeHigh * [EMAIL PROTECTED] Andrew C. Oliver [EMAIL PROTECTED] 
Sergei Kozello (sergeikozello at mail.ru) [EMAIL PROTECTED]May 10, 2002 [EMAIL 
PROTECTED]1.0 */public class StringUtil {private final static String 
ENCODING="ISO-8859-1";/** *  Constructor for the StringUtil object */
private StringUtil() { }/** *  given a byte array of 16-bit unicode 
characters, compress to 8-bit and *  return a string * * { 0x16, 0x00 } -> 
0x16 *  [EMAIL PROTECTED]  string  the byte array 
to be converted [EMAIL PROTECTED]  offset  the initial 
offset into the *  byte array. it is assumed that string[ offset ] and string[ 
offset + *  1 ] contain the first 16-bit unicode character [EMAIL 
PROTECTED]  len [EMAIL PROTECTED] the 
converted string [EMAIL PROTECTED]  ArrayIndexOutOfBoundsException  if offset is 
out of bounds for *  the byte array (i.e., is negative or is greater than or 
equal to *  string.length) [EMAIL PROTECTED]  IllegalArgumentException 
   if len is too large (i.e., *  there is not enough data in string to create 
a S

cvs commit: jakarta-poi/src/java/org/apache/poi/util StringUtil.java

[tetsuya]

tetsuya 2003/07/26 01:53:23

  Modified:src/java/org/apache/poi/util StringUtil.java
  Log:
  Rewinded: StringUtil.java: Sync to REL_2 BRANCH
  
  Revision  ChangesPath
  1.12  +343 -326  jakarta-poi/src/java/org/apache/poi/util/StringUtil.java
  
  Index: StringUtil.java
  ===
  RCS file: /home/cvs/jakarta-poi/src/java/org/apache/poi/util/StringUtil.java,v
  retrieving revision 1.11
  retrieving revision 1.12
  diff -u -r1.11 -r1.12
  --- StringUtil.java   24 Jul 2003 16:58:09 -  1.11
  +++ StringUtil.java   26 Jul 2003 08:53:22 -  1.12
  @@ -1,346 +1,363 @@
   /*
  - * 
  - * The Apache Software License, Version 1.1
  + *  
  + *  The Apache Software License, Version 1.1
*
  - * Copyright (c) 2003 The Apache Software Foundation.  All rights
  - * reserved.
  + *  Copyright (c) 2002 The Apache Software Foundation.  All rights
  + *  reserved.
*
  - * Redistribution and use in source and binary forms, with or without
  - * modification, are permitted provided that the following conditions
  - * are met:
  + *  Redistribution and use in source and binary forms, with or without
  + *  modification, are permitted provided that the following conditions
  + *  are met:
*
  - * 1. Redistributions of source code must retain the above copyright
  - *notice, this list of conditions and the following disclaimer.
  + *  1. Redistributions of source code must retain the above copyright
  + *  notice, this list of conditions and the following disclaimer.
*
  - * 2. Redistributions in binary form must reproduce the above copyright
  - *notice, this list of conditions and the following disclaimer in
  - *the documentation and/or other materials provided with the
  - *distribution.
  + *  2. Redistributions in binary form must reproduce the above copyright
  + *  notice, this list of conditions and the following disclaimer in
  + *  the documentation and/or other materials provided with the
  + *  distribution.
*
  - * 3. The end-user documentation included with the redistribution,
  - *if any, must include the following acknowledgment:
  - *   "This product includes software developed by the
  - *Apache Software Foundation (http://www.apache.org/)."
  - *Alternately, this acknowledgment may appear in the software itself,
  - *if and wherever such third-party acknowledgments normally appear.
  + *  3. The end-user documentation included with the redistribution,
  + *  if any, must include the following acknowledgment:
  + *  "This product includes software developed by the
  + *  Apache Software Foundation (http://www.apache.org/)."
  + *  Alternately, this acknowledgment may appear in the software itself,
  + *  if and wherever such third-party acknowledgments normally appear.
*
  - * 4. The names "Apache" and "Apache Software Foundation" and
  - *"Apache POI" must not be used to endorse or promote products
  - *derived from this software without prior written permission. For
  - *written permission, please contact [EMAIL PROTECTED]
  + *  4. The names "Apache" and "Apache Software Foundation" and
  + *  "Apache POI" must not be used to endorse or promote products
  + *  derived from this software without prior written permission. For
  + *  written permission, please contact [EMAIL PROTECTED]
*
  - * 5. Products derived from this software may not be called "Apache",
  - *"Apache POI", nor may "Apache" appear in their name, without
  - *prior written permission of the Apache Software Foundation.
  + *  5. Products derived from this software may not be called "Apache",
  + *  "Apache POI", nor may "Apache" appear in their name, without
  + *  prior written permission of the Apache Software Foundation.
*
  - * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
  - * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
  - * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
  - * DISCLAIMED.  IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR
  - * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  - * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  - * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
  - * USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
  - * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
  - * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
  - * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  - * SUCH DAMAGE.
  - * 
  + *  THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
  + *  WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRAN

cvs commit: jakarta-poi/src/java/org/apache/poi/util StringUtil.java

[avik]

avik2005/04/28 07:03:28

  Modified:src/java/org/apache/poi/hssf/record FooterRecord.java
HeaderRecord.java
   src/java/org/apache/poi/util StringUtil.java
  Log:
  Refactored
  
  Revision  ChangesPath
  1.14  +1 -16 
jakarta-poi/src/java/org/apache/poi/hssf/record/FooterRecord.java
  
  Index: FooterRecord.java
  ===
  RCS file: 
/home/cvs/jakarta-poi/src/java/org/apache/poi/hssf/record/FooterRecord.java,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- FooterRecord.java 28 Apr 2005 13:35:38 -  1.13
  +++ FooterRecord.java 28 Apr 2005 14:03:28 -  1.14
  @@ -107,21 +107,6 @@
return ((field_2_unicode_flag & 0xFF) == 1);
   }
   
  -/**
  - * check the parameter has multibyte character
  - *
  - * @param value  string to check
  - * @return  boolean result
  - *  true:string has at least one multibyte character
  - */
  -private static boolean hasMultibyte(String value){
  -if( value == null )return false;
  -for(int i = 0 ; i < value.length() ; i++ ){
  -char c = value.charAt(i);
  -if(c > 0xFF )return true;
  -}
  -return false;
  -}
   
   /**
* set the length of the footer string
  @@ -146,7 +131,7 @@
   {
   field_3_footer = footer;
   field_2_unicode_flag = 
  -(byte) (hasMultibyte(field_3_footer) ? 1 : 0);
  +(byte) (StringUtil.hasMultibyte(field_3_footer) ? 1 : 0);
   }
   
   /**
  
  
  
  1.14  +1 -17 
jakarta-poi/src/java/org/apache/poi/hssf/record/HeaderRecord.java
  
  Index: HeaderRecord.java
  ===
  RCS file: 
/home/cvs/jakarta-poi/src/java/org/apache/poi/hssf/record/HeaderRecord.java,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- HeaderRecord.java 28 Apr 2005 13:35:38 -  1.13
  +++ HeaderRecord.java 28 Apr 2005 14:03:28 -  1.14
  @@ -108,22 +108,6 @@
   }
   
   /**
  - * check the parameter has multibyte character
  - *
  - * @param value  string to check
  - * @return  boolean result
  - *  true:string has at least one multibyte character
  - */
  -private static boolean hasMultibyte(String value){
  -if( value == null )return false;
  -for(int i = 0 ; i < value.length() ; i++ ){
  -char c = value.charAt(i);
  -if(c > 0xFF )return true;
  -}
  -return false;
  -}
  -
  -/**
* set the length of the header string
*
* @param len  length of the header string
  @@ -146,7 +130,7 @@
   {
   field_3_header = header;
   field_2_unicode_flag = 
  -(byte) (hasMultibyte(field_3_header) ? 1 : 0);
  +(byte) (StringUtil.hasMultibyte(field_3_header) ? 1 : 0);
   }
   
   /**
  
  
  
  1.18  +28 -0 jakarta-poi/src/java/org/apache/poi/util/StringUtil.java
  
  Index: StringUtil.java
  ===
  RCS file: /home/cvs/jakarta-poi/src/java/org/apache/poi/util/StringUtil.java,v
  retrieving revision 1.17
  retrieving revision 1.18
  diff -u -r1.17 -r1.18
  --- StringUtil.java   23 Aug 2004 08:52:45 -  1.17
  +++ StringUtil.java   28 Apr 2005 14:03:28 -  1.18
  @@ -303,4 +303,32 @@
public static String getPreferredEncoding() {
return ENCODING;
}
  +
  + /**
  +  * check the parameter has multibyte character
  +  *
  +  * @param value  string to check
  +  * @return  boolean result
  +  *  true:string has at least one multibyte character
  +  */
  + public static boolean hasMultibyte(String value){
  + if( value == null )return false;
  + for(int i = 0 ; i < value.length() ; i++ ){
  + char c = value.charAt(i);
  + if(c > 0xFF )return true;
  + }
  + return false;
  + }
  + 
  + /**
  +* @param format
  +* @return true if format is Unicode.
  +*/
  +   public static boolean isUnicodeFormat(final String format) {
  + try {
  +   return !format.equals(new String(format.getBytes("ISO-8859-1"), 
"ISO-8859-1"));
  + } catch (UnsupportedEncodingException e) {
  +   return true;
  + }
  +   }
   }
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/

cvs commit: jakarta-poi/src/java/org/apache/poi/util StringUtil.java

[avik]

avik2005/05/01 22:26:13

  Modified:src/java/org/apache/poi/hssf/model Workbook.java
   src/java/org/apache/poi/hssf/record FormatRecord.java
   src/java/org/apache/poi/util StringUtil.java
  Log:
  refactored
  
  Revision  ChangesPath
  1.44  +0 -1  
jakarta-poi/src/java/org/apache/poi/hssf/model/Workbook.java
  
  Index: Workbook.java
  ===
  RCS file: 
/home/cvs/jakarta-poi/src/java/org/apache/poi/hssf/model/Workbook.java,v
  retrieving revision 1.43
  retrieving revision 1.44
  diff -u -r1.43 -r1.44
  --- Workbook.java 1 May 2005 11:26:17 -   1.43
  +++ Workbook.java 2 May 2005 05:26:12 -   1.44
  @@ -1996,7 +1996,6 @@
   maxformatid = maxformatid >= (short) 0xa4 ? (short) ( maxformatid + 
1 ) : (short) 0xa4; //Starting value from M$ empiracle study.
   rec.setIndexCode( maxformatid );
   rec.setFormatStringLength( (byte) format.length() );
  -rec.setUnicodeFlag(StringUtil.isUnicodeFormat(format));
   rec.setFormatString( format );
   
   int pos = 0;
  
  
  
  1.13  +6 -5  
jakarta-poi/src/java/org/apache/poi/hssf/record/FormatRecord.java
  
  Index: FormatRecord.java
  ===
  RCS file: 
/home/cvs/jakarta-poi/src/java/org/apache/poi/hssf/record/FormatRecord.java,v
  retrieving revision 1.12
  retrieving revision 1.13
  diff -u -r1.12 -r1.13
  --- FormatRecord.java 23 Aug 2004 08:52:32 -  1.12
  +++ FormatRecord.java 2 May 2005 05:26:13 -   1.13
  @@ -36,7 +36,7 @@
   {
   public final static short sid = 0x41e;
   private short field_1_index_code;
  -private short field_2_formatstring_len;
  +
   private short field_3_unicode_len;  // unicode string 
length
   private boolean  field_3_unicode_flag; // it is not 
undocumented - it is unicode flag
   private Stringfield_4_formatstring;
  @@ -85,7 +85,7 @@
   field_1_index_code   = LittleEndian.getShort(data, 0 + offset);
   // field_2_formatstring_len = data[ 2 + offset ];
   field_3_unicode_len  = LittleEndian.getShort( data, 2 + offset );
  - field_2_formatstring_len = field_3_unicode_len;
  +
   field_3_unicode_flag = ( data[ 4 + offset ] & (byte)0x01 ) != 0;
 
 
  @@ -120,7 +120,7 @@
   
   public void setFormatStringLength(byte len)
   {
  -field_2_formatstring_len = len;
  +
field_3_unicode_len = len;
   }
   
  @@ -144,6 +144,7 @@
   public void setFormatString(String fs)
   {
   field_4_formatstring = fs;
  +setUnicodeFlag(StringUtil.isUnicodeString(fs));
   }
   
   /**
  @@ -165,10 +166,10 @@
* @see #getFormatString()
*/
   
  -public short getFormatStringLength()
  +   /* public short getFormatStringLength()
   {
   return field_3_unicode_flag ? field_3_unicode_len : 
field_2_formatstring_len;
  -}
  +}*/
   
   /**
* get whether the string is unicode
  
  
  
  1.19  +3 -3  jakarta-poi/src/java/org/apache/poi/util/StringUtil.java
  
  Index: StringUtil.java
  ===
  RCS file: /home/cvs/jakarta-poi/src/java/org/apache/poi/util/StringUtil.java,v
  retrieving revision 1.18
  retrieving revision 1.19
  diff -u -r1.18 -r1.19
  --- StringUtil.java   28 Apr 2005 14:03:28 -  1.18
  +++ StringUtil.java   2 May 2005 05:26:13 -   1.19
  @@ -322,11 +322,11 @@

/**
   * @param format
  -* @return true if format is Unicode.
  +* @return true if string needs Unicode to be represented.
   */
  -   public static boolean isUnicodeFormat(final String format) {
  +   public static boolean isUnicodeString(final String value) {
try {
  -   return !format.equals(new String(format.getBytes("ISO-8859-1"), 
"ISO-8859-1"));
  +   return !value.equals(new String(value.getBytes("ISO-8859-1"), 
"ISO-8859-1"));
} catch (UnsupportedEncodingException e) {
  return true;
}
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List:http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/

cvs commit: jakarta-poi/src/java/org/apache/poi/util StringUtil.java

[avik]

avik2005/05/16 07:44:37

  Modified:src/java/org/apache/poi/util StringUtil.java
  Log:
  StringUtil javadocs, supplied by Nick Burch, thanks. bug 34922
  
  Revision  ChangesPath
  1.20  +39 -32jakarta-poi/src/java/org/apache/poi/util/StringUtil.java
  
  Index: StringUtil.java
  ===
  RCS file: /home/cvs/jakarta-poi/src/java/org/apache/poi/util/StringUtil.java,v
  retrieving revision 1.19
  retrieving revision 1.20
  diff -u -r1.19 -r1.20
  --- StringUtil.java   2 May 2005 05:26:13 -   1.19
  +++ StringUtil.java   16 May 2005 14:44:37 -  1.20
  @@ -39,8 +39,9 @@
}
   
/** 
  -  *  given a byte array of 16-bit unicode characters, compress to 8-bit 
and 
  -  *  return a string 
  +  *  Given a byte array of 16-bit unicode characters in Little Endian
  +  *  format (most important byte last), return a Java String 
representation
  +  *  of it. 
 * 
 * { 0x16, 0x00 } -0x16 
 *  
  @@ -77,8 +78,9 @@
}
   
/** 
  -  *  given a byte array of 16-bit unicode characters, compress to 8-bit 
and 
  -  *  return a string 
  +  *  Given a byte array of 16-bit unicode characters in little endian
  +  *  format (most important byte last), return a Java String 
representation
  +  *  of it. 
 *  
 * { 0x16, 0x00 } -0x16 
 * 
  @@ -90,8 +92,9 @@
}
   
/** 
  -  *  given a byte array of 16-bit unicode characters, compress to 8-bit 
and 
  -  *  return a string 
  +  *  Given a byte array of 16-bit unicode characters in big endian
  +  *  format (most important byte first), return a Java String 
representation
  +  *  of it. 
 *  
 * { 0x00, 0x16 } -0x16 
 * 
  @@ -127,8 +130,9 @@
}
   
/** 
  -  *  given a byte array of 16-bit unicode characters, compress to 8-bit 
and 
  -  *  return a string 
  +  *  Given a byte array of 16-bit unicode characters in big endian
  +  *  format (most important byte first), return a Java String 
representation
  +  *  of it.
 *  
 * { 0x00, 0x16 } -0x16 
 * 
  @@ -140,7 +144,9 @@
}
   
/**  
  -  * read compressed unicode(8bit)  
  +  * Read 8 bit data (in ISO-8859-1 codepage) into a (unicode) Java
  +  * String and return.
  +  * (In Excel terms, read compressed 8 bit unicode as a string)
 *   
 * @param string byte array to read  
 * @param offset offset to read byte array  
  @@ -158,8 +164,10 @@
}
}
   
  - /** 
  -  *  write compressed unicode 
  + /**  
  +  * Takes a unicode (java) string, and returns it as 8 bit data (in 
ISO-8859-1 
  +  * codepage).
  +  * (In Excel terms, write compressed 8 bit unicode)
 * 
 [EMAIL PROTECTED]  input   the String containing the data to be 
written 
 [EMAIL PROTECTED]  output  the byte array to which the data is to be 
written 
  @@ -179,10 +187,12 @@
}
   
/** 
  -  *  Write uncompressed unicode 
  +  * Takes a unicode string, and returns it as little endian (most 
  +  * important byte last) bytes in the supplied byte array.
  +  * (In Excel terms, write uncompressed unicode)
 * 
 [EMAIL PROTECTED]  input   the String containing the unicode data to 
be written 
  -  [EMAIL PROTECTED]  output  the byte array to hold the uncompressed 
unicode 
  +  [EMAIL PROTECTED]  output  the byte array to hold the uncompressed 
unicode, should be twice the length of the String
 [EMAIL PROTECTED]  offset  the offset to start writing into the byte 
array 
 */
public static void putUnicodeLE(
  @@ -198,10 +208,12 @@
}
   
/** 
  -  *  Write uncompressed unicode 
  +  * Takes a unicode string, and returns it as big endian (most 
  +  * important byte first) bytes in the supplied byte array.
  +  * (In Excel terms, write uncompressed unicode)
 * 
 [EMAIL PROTECTED]  input   the String containing the unicode data to 
be written 
  -  [EMAIL PROTECTED]  output  the byte array to hold the uncompressed 
unicode 
  +  [EMAIL PROTECTED]  output  the byte array to hold the uncompressed 
unicode, should be twice the length of the String
 [EMAIL PROTECTED]  offset  the offset to start writing into the byte 
array 
 */
public static void putUnicodeBE(
  @@ -217,11 +229,12 @@
}
   
/** 
  -  *  Description of the Method 
  -  * 
  -  [EMAIL PROTECTED]  message  Description of the Parameter 
  -  [EMAIL PROTECTED]  params   D

Re: cvs commit: jakarta-poi/src/java/org/apache/poi/util StringUtil.java

[Glen Stampoultzis]

Doh.  Looks like we're still paying for this little mess I created from a 
while back.  Many apologies to all.  I still don't know what caused this 
but I am watching my commits more closely these days.

Regards,

Glen

At 02:58 AM 25/07/2003, you wrote:
tetsuya 2003/07/24 09:58:09

  Modified:src/java/org/apache/poi/util StringUtil.java
  Log:
  Fixed Weird Line Feed: Submitted by Toshiaki Kamoshida
  Revision  ChangesPath
  1.11  +346 
-1jakarta-poi/src/java/org/apache/poi/util/StringUtil.java

  Index: StringUtil.java
  ===
  RCS file: 
/home/cvs/jakarta-poi/src/java/org/apache/poi/util/StringUtil.java,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- StringUtil.java   30 Apr 2003 04:39:08 -  1.10
  +++ StringUtil.java   24 Jul 2003 16:58:09 -  1.11
  @@ -1 +1,346 @@
  -/* 
*   
*  The Apache Software License, Version 1.1 * *  Copyright (c) 2003 The 
Apache Software Foundation.  All rights *  reserved. * *  Redistribution 
and use in source and binary forms, with or without *  modification, are 
permitted provided that the following conditions *  are met: * *  1. 
Redistributions of source code must retain the above copyright *  notice, 
this list of conditions and the following disclaimer. * *  2. 
Redistributions in binary form must reproduce the above copyright 
*  notice, this list of conditions and the following disclaimer in *  the 
documentation and/or other materials provided with the *  distribution. * 
*  3. The end-user documentation included with the redistribution, *  if 
any, must include the following acknowledgment: *  "This product includes 
software developed by the *  Apache Software Foundation 
(http://www.apache.org/)." *  Alternately, this acknowledgment may appear 
in the software itself, *  if and wherever such third-party 
acknowledgments normally appear. * *  4. The names "Apache" and "Apache 
Software Foundation" and *  "Apache POI" must not be used to endorse or 
promote products *  derived from this software without prior written 
permission. For *  written permission, please contact [EMAIL PROTECTED] 
* *  5. Products derived from this software may not be called "Apache", 
*  "Apache POI", nor may "Apache" appear in their name, without *  prior 
written permission of the Apache Software Foundation. * *  THIS SOFTWARE 
IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED *  WARRANTIES, 
INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES *  OF 
MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE 
*  DISCLAIMED.  IN NO EVENT SHALL THE APACHE SOFTWARE FOUNDATION OR 
*  ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 
*  SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 
*  LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF 
*  USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND 
*  ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, 
*  OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT 
*  OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF 
*  SUCH DAMAGE. 
*   * 
*  This software consists of voluntary contributions made by many 
*  individuals on behalf of the Apache Software Foundation.  For more 
*  information on the Apache Software Foundation, please see 
*  . */package org.apache.poi.util;import 
java.io.UnsupportedEncodingException;import java.text.NumberFormat;import 
java.text.FieldPosition;/** *  Title: String Utility Description: 
Collection of string handling utilities *  * Now it is quite confusing: 
the method pairs, in which * one of them write data and other read 
written data are: * putUncompressedUnicodeHigh and getFromUnicode * 
putUncompressedUnicode and getFromUnicodeHigh * [EMAIL PROTECTED] Andrew 
C. Oliv  \ No newline at end of file
  +/*
  + * 
  + * The Apache Software License, Version 1.1
  + *
  + * Copyright (c) 2003 The Apache Software Foundation.  All rights
  + * reserved.
  + *
  + * Redistribution and use in source and binary forms, with or without
  + * modification, are permitted provided that the following conditions
  + * are met:
  + *
  + * 1. Redistributions of source code must retain the above copyright
  + *notice, this list of conditions and the following disclaimer.
  + *
  + * 2. Redistributions in binary form must reproduce the above copyright
  + *notice, this list of conditions and the following disclaimer in
  + *the documentation and/or other materials provided with the
  + *distribution.
  + *
  + * 3. The end-user documentation included with the redistribution,
  + *if any, must include the following acknowledgment:
  + *  

Re: cvs commit: jakarta-poi/src/java/org/apache/poi/util StringUtil.java

[Tetsuya Kitahata]

Andrew,
CC: Toshiaki Kamoshida <[EMAIL PROTECTED]>

Okay, I ommitted the [RFE] prefix and the matter was worse,
there were weird s. I regret I had to check it
more seriously.

Toshiaki,

Please supply the patches using "cvs diff -u" style
once more. I assume you used [copy and paste] method,
so it seems there was unnecessary information.
Please do this on the MS-DOS prompt or **ix shell with
"cvs diff -u > PR18846.PATCH.TXT"
If you use winCVS, just set the "path" environment variable
to the directory you installed winCVS.

You can supply the patches to either
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18846
and
[EMAIL PROTECTED] (with [PATCH] prefixed subject
and zipped attachment)

I prefer the dev mailing list :)

--

I'll append the @author tag on the class,
after I will confirm Toshiaki's upcoming patches.

Sincerely,

-- Tetsuya ([EMAIL PROTECTED])

On Sat, 26 Jul 2003 15:14:55 -0400
(Subject: Re: cvs commit: jakarta-poi/src/java/org/apache/poi/util StringUtil.java)
"Andrew C. Oliver" <[EMAIL PROTECTED]> wrote:

> Hi Tetsuya,
> 
> @author tags should be on the class not the methods in chronological order
> of contribution.  Unless the class is completely a clean-room
> implementation, we regard it as a derivative work and should be done with
> the previous @author tags in tact.  This not only preserves
> credit/visibility for the work but helps us know who to ping (without having
> to read all the CVS logs especially in the case of developers submitting
> patches as opposed to whom commits it).
> 
> On 7/26/03 4:53 AM, "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote:





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-poi/src/java/org/apache/poi/util StringUtil.java

[Tetsuya Kitahata]

Doh, I've forgotten to mention.

I'll append the @author tag on the class,
after I will confirm Toshiaki's upcoming patches
for *BOTH* of REL_2_BRANCH and HEAD.  :-)

Toshiaki, please resubmit patches for HEAD only.
I will apply them to both of REL_2_BRANCH and HEAD
after the confirmation.
Also, if you are not in the status of "subscribe" to poi-dev
right now, it's okay. I'll moderate your mail to poi-dev.

Sincerely,

-- Tetsuya ([EMAIL PROTECTED])

--

On Sun, 27 Jul 2003 04:52:58 +0900
(Subject: Re: cvs commit: jakarta-poi/src/java/org/apache/poi/util StringUtil.java)
Tetsuya Kitahata <[EMAIL PROTECTED]> wrote:

> 
> Andrew,
> CC: Toshiaki Kamoshida <[EMAIL PROTECTED]>
> 
> Okay, I ommitted the [RFE] prefix and the matter was worse,
> there were weird s. I regret I had to check it
> more seriously.
> 
> Toshiaki,
> 
> Please supply the patches using "cvs diff -u" style
> once more. I assume you used [copy and paste] method,
> so it seems there was unnecessary information.
> Please do this on the MS-DOS prompt or **ix shell with
> "cvs diff -u > PR18846.PATCH.TXT"
> If you use winCVS, just set the "path" environment variable
> to the directory you installed winCVS.
> 
> You can supply the patches to either
> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18846
> and
> [EMAIL PROTECTED] (with [PATCH] prefixed subject
> and zipped attachment)
> 
> I prefer the dev mailing list :)
> 
> --
> 
> I'll append the @author tag on the class,
> after I will confirm Toshiaki's upcoming patches.
> 
> Sincerely,
> 
> -- Tetsuya ([EMAIL PROTECTED])
> 
> On Sat, 26 Jul 2003 15:14:55 -0400
> (Subject: Re: cvs commit: jakarta-poi/src/java/org/apache/poi/util StringUtil.java)
> "Andrew C. Oliver" <[EMAIL PROTECTED]> wrote:
> 
> > Hi Tetsuya,
> > 
> > @author tags should be on the class not the methods in chronological order
> > of contribution.  Unless the class is completely a clean-room
> > implementation, we regard it as a derivative work and should be done with
> > the previous @author tags in tact.  This not only preserves
> > credit/visibility for the work but helps us know who to ping (without having
> > to read all the CVS logs especially in the case of developers submitting
> > patches as opposed to whom commits it).
> > 
> > On 7/26/03 4:53 AM, "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote:
> 
> 
> 
> 
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]