Re: [poppler] Example travis configuration file for poppler
me too, I was misunderstanding the github.com/freedesktop/ was the official mirror. Albert Astals Cid wrote: https://github.com/freedesktop/poppler repository. >>> WHAT THE FUCK IS THAT REPOSITORY? Who is pushing there? I'll ask the >>> freedesktop people. >>> >> This is just a mirror of cgit.freedesktop.org > > I disagree, nowhere it says it's a mirror, and there's 3 people that sent > patches https://github.com/freedesktop/poppler/pulls probably thinking people > would answer. I submitted 2 pulls in there by misunderstanding as if the repository were official mirror. Soon I found it was my mistake (at least, even if the duplication of the repository is done by official member of freedesktop.org, poppler developers do not receive the pull request on there). I filed same things on bugzilla on freedesktop.org. Recently I received the comments to my mis-requests from tsdgeos, saying as: "This is not were we do poppler development, no idea why this even does exist, please use https://poppler.freedesktop.org/#bugzilla and close this." https://github.com/freedesktop/poppler/pull/2#issuecomment-365077940 (note: the "reply" in the discussion thread on github.com does not mean that it was from the owner of the repository) "no idea why this even does exist" coincides with what Albert says. Regards, mpsuzuki ___ poppler mailing list poppler@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/poppler
Re: [poppler] fix build with gtk-doc 1.27
are you subscribed to the list? If not i'd really welcome if you used http://bugs.freedesktop.org/ to send patches. Anyhow it seems someone already sent https://bugs.freedesktop.org/show_bug.cgi?id=105075 Cheers, Albert El dimecres, 7 de febrer de 2018, a les 17:20:27 CET, David Tardon va escriure: > Hello, > > building with ENABLE_GTK_DOC fails with gtk-doc 1.27 (I'm pretty sure the > culprit is > https://git.gnome.org/browse/gtk-doc/commit/?id=775e4a467dc448a130d33ddcc35 > a879f8dfb5e97). The attached patch fixes that. > > D. ___ poppler mailing list poppler@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/poppler
Re: [poppler] Example travis configuration file for poppler
El dimarts, 13 de febrer de 2018, a les 15:53:42 CET, jose.ali...@gmail.com va escriure: > Hi, > > On Mon, Feb 12, 2018 at 6:57 PM, Albert Astals Cid wrote: > > El dilluns, 12 de febrer de 2018, a les 16:03:35 CET, Jeroen Ooms va > > > > escriure: > > > We have been working on a .travis configuration file to automatically > > > test poppler feature branches on various linux and osx configurations. > > > Perhaps this may be interesting to other poppler users as well. > > > > > > The example ".travis.yml" file can be copied from: > > > https://github.com/jeroen/poppler/blob/travis/.travis.yml (example > > > results: https://travis-ci.org/jeroen/poppler). Github users can > > > active the CI up by adding the .travis.yml file to the root of the > > > poppler source directory, and then login to travis.com and activate > > > the switch for the poppler source repository. > > > > I don't think promoting a non free platform on the official poppler > > repository > > makes sense. > > > > I'm running travis on my non official poppler mirror > > https://travis-ci.org/tsdgeos/poppler_mirror > > as you obviously know since you're using my packages. > > > > I'll see if i adopt your mac parts. > > Is there other ways of automatically test with travis using free > infrastructure? You mean if something that is free supports .travis.yml ? No idea, probably not? > > > > If there is sufficient interest, we can explore additional travis > > > targets for other platforms, compilers, sanitizers, etc. Large > > > projects like libcurl [1] and gdal [2] extensively use travis in the > > > development process. It may be useful to use this for the official > > > https://github.com/freedesktop/poppler repository. > > > > WHAT THE FUCK IS THAT REPOSITORY? Who is pushing there? I'll ask the > > freedesktop people. > > > This is just a mirror of cgit.freedesktop.org I disagree, nowhere it says it's a mirror, and there's 3 people that sent patches https://github.com/freedesktop/poppler/pulls probably thinking people would answer. That is *very* sub-optimal and i already complained about it in the freedesktop list. In typical freedesktop manner no one is answering. Cheers, Albert P.S: https://github.com/tsdgeos/poppler_mirror is more obvious it's a mirror > > Greetings > > José > > This is not our repository, our repository is > > > http://cgit.freedesktop.org/poppler/poppler > > > > Cheers, > > > > Albert > > > > > [1] https://travis-ci.org/curl/curl > > > [2] https://travis-ci.org/OSGeo/gdal > > > ___ > > > poppler mailing list > > > poppler@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/poppler > > > > ___ > > poppler mailing list > > poppler@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/poppler ___ poppler mailing list poppler@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/poppler
[poppler] 2 commits - poppler/SplashOutputDev.cc poppler/SplashOutputDev.h
poppler/SplashOutputDev.cc |9 ++---
poppler/SplashOutputDev.h |6 ++
2 files changed, 4 insertions(+), 11 deletions(-)
New commits:
commit 73130ae1125c86ebd0ee504d0681d9911ff2cfbd
Author: Albert Astals Cid
Date: Wed Feb 14 17:40:23 2018 +0100
SplashGouraudPattern: Remove mode member variable
We don't need it anymore, was introduced in the initial overprint
implementation and was forgotten to be removed when merging xpdf 3.03
diff --git a/poppler/SplashOutputDev.cc b/poppler/SplashOutputDev.cc
index 50b78245..efc0aaec 100644
--- a/poppler/SplashOutputDev.cc
+++ b/poppler/SplashOutputDev.cc
@@ -197,15 +197,10 @@ static inline void convertGfxShortColor(SplashColorPtr
dest,
// SplashGouraudPattern
//
SplashGouraudPattern::SplashGouraudPattern(GBool bDirectColorTranslationA,
- GfxState *stateA,
GfxGouraudTriangleShading *shadingA, SplashColorMode modeA) {
- SplashColor defaultColor;
- GfxColor srcColor;
+ GfxState *stateA,
GfxGouraudTriangleShading *shadingA) {
state = stateA;
shading = shadingA;
- mode = modeA;
bDirectColorTranslation = bDirectColorTranslationA;
- shadingA->getColorSpace()->getDefaultColor(&srcColor);
- convertGfxColor(defaultColor, mode, shadingA->getColorSpace(), &srcColor);
gfxMode = shadingA->getColorSpace()->getMode();
}
@@ -4754,7 +4749,7 @@ GBool SplashOutputDev::gouraudTriangleShadedFill(GfxState
*state, GfxGouraudTria
}
// restore vector antialias because we support it here
if (shading->isParameterized()) {
-SplashGouraudColor *splashShading = new
SplashGouraudPattern(bDirectColorTranslation, state, shading, colorMode);
+SplashGouraudColor *splashShading = new
SplashGouraudPattern(bDirectColorTranslation, state, shading);
GBool vaa = getVectorAntialias();
GBool retVal = gFalse;
setVectorAntialias(gTrue);
diff --git a/poppler/SplashOutputDev.h b/poppler/SplashOutputDev.h
index 4dc97e82..3a5883c4 100644
--- a/poppler/SplashOutputDev.h
+++ b/poppler/SplashOutputDev.h
@@ -135,9 +135,9 @@ private:
class SplashGouraudPattern: public SplashGouraudColor {
public:
- SplashGouraudPattern(GBool bDirectColorTranslation, GfxState *state,
GfxGouraudTriangleShading *shading, SplashColorMode mode);
+ SplashGouraudPattern(GBool bDirectColorTranslation, GfxState *state,
GfxGouraudTriangleShading *shading);
- SplashPattern *copy() override { return new
SplashGouraudPattern(bDirectColorTranslation, state, shading, mode); }
+ SplashPattern *copy() override { return new
SplashGouraudPattern(bDirectColorTranslation, state, shading); }
~SplashGouraudPattern();
@@ -162,7 +162,6 @@ private:
GfxGouraudTriangleShading *shading;
GfxState *state;
GBool bDirectColorTranslation;
- SplashColorMode mode;
GfxColorSpaceMode gfxMode;
};
commit 37efb98d77c14c27a22806ec676c13f0a8b99490
Author: Albert Astals Cid
Date: Wed Feb 14 17:43:41 2018 +0100
SplashOutputDev:: Remove unused maskBitmap member
diff --git a/poppler/SplashOutputDev.h b/poppler/SplashOutputDev.h
index 89655d66..4dc97e82 100644
--- a/poppler/SplashOutputDev.h
+++ b/poppler/SplashOutputDev.h
@@ -466,7 +466,6 @@ private:
SplashTransparencyGroup *// transparency group stack
transpGroupStack;
- SplashBitmap *maskBitmap; // for image masks in pattern colorspace
int nestCount;
};
___
poppler mailing list
poppler@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/poppler
