[UPDATE] misc/screen (4.9.0 => 4.9.1)
Greetings, This patch updates GNU Screen to version 4.9.1. Released yesterday. Please review/test it. Screen is a full-screen window manager that multiplexes a physical terminal between several processes (typically interactive shells). 'portcheck', 'port-lib-depends-check' and 'update-plist' returns 0. Updated and tested on x86_64 and aarch64. All tests are OK: * 'make test' * manually started the screen and did some basic operation with it. I removed: Info-file (texinfo, manpage still there) from the list of files (pkg/PLIST) because it seems broken in this release. ChangeLog for 4.9.1: * Support stop/parity bits on serial port * Add needed system headers in checks and return values for implicit function declarations * Fixes: - Avoid zombies after shell exit - Missed signal sending permission check on failed query messages (CVE-2023-24626) - manpage fixes - source code fixes during cleanup - UTF-8 encoding can emit invalid UTF-8 sequences for out of range unicode values Cheers, Alexander Naumov Index: Makefile === RCS file: /cvs/ports/misc/screen/Makefile,v retrieving revision 1.77 diff -u -p -u -p -r1.77 Makefile --- Makefile 11 Mar 2022 19:38:20 - 1.77 +++ Makefile 18 Aug 2023 19:58:48 - @@ -1,10 +1,12 @@ COMMENT= multi-screen window manager -DISTNAME= screen-4.9.0 +DISTNAME= screen-4.9.1 CATEGORIES= misc MASTER_SITES= ${MASTER_SITE_GNU:=screen/} HOMEPAGE= https://www.gnu.org/software/screen/ # GPLv3+ PERMIT_PACKAGE= Yes Index: distinfo === RCS file: /cvs/ports/misc/screen/distinfo,v retrieving revision 1.14 diff -u -p -u -p -r1.14 distinfo --- distinfo 5 Feb 2022 11:57:36 - 1.14 +++ distinfo 18 Aug 2023 19:58:48 - @@ -1,2 +1,2 @@ -SHA256 (screen-4.9.0.tar.gz) = +TNSgbtNFTjtB433iiDC8506+aTpHFfQhCceAonHMPQ= -SIZE (screen-4.9.0.tar.gz) = 798229 +SHA256 (screen-4.9.1.tar.gz) = Js7z48QlccDUhK1vrxEMXBUJH7+HKwb6eqR2bHQFrGk= +SIZE (screen-4.9.1.tar.gz) = 1040785 Index: pkg/PLIST === RCS file: /cvs/ports/misc/screen/pkg/PLIST,v retrieving revision 1.25 diff -u -p -u -p -r1.25 PLIST --- pkg/PLIST 11 Mar 2022 19:38:20 - 1.25 +++ pkg/PLIST 18 Aug 2023 19:58:48 - @@ -1,5 +1,4 @@ @bin bin/screen -@info info/screen.info @man man/man1/screen.1 share/examples/screen/ share/examples/screen/screenrc
Re: [UPDATE] misc/screen (4.9.0 => 4.9.1)
Something's wrong with your diff, it doesn't apply with patch. Rather than just removing from plist, please either @comment the file in plist so it doesn't get readded, or maybe better add a post-install target rm'ing the file with a comment saying why. On 2023/08/18 22:44, Alex Naumov wrote: > Greetings, > > This patch updates GNU Screen to version 4.9.1. Released yesterday. Please > review/test it. > > Screen is a full-screen window manager that multiplexes a physical terminal > between several processes (typically interactive shells). > > 'portcheck', 'port-lib-depends-check' and 'update-plist' returns 0. > Updated and tested on x86_64 and aarch64. > > All tests are OK: > * 'make test' > * manually started the screen and did some basic operation with it. > > I removed: > Info-file (texinfo, manpage still there) from the list of files (pkg/PLIST) > because it seems broken in this release. > > ChangeLog for 4.9.1: > * Support stop/parity bits on serial port > * Add needed system headers in checks and return values for implicit > function declarations > * Fixes: > - Avoid zombies after shell exit > - Missed signal sending permission check on failed query messages > (CVE-2023-24626) > - manpage fixes > - source code fixes during cleanup > - UTF-8 encoding can emit invalid UTF-8 sequences for out of range unicode > values > > > Cheers, > Alexander Naumov > Index: Makefile > === > RCS file: /cvs/ports/misc/screen/Makefile,v > retrieving revision 1.77 > diff -u -p -u -p -r1.77 Makefile > --- Makefile 11 Mar 2022 19:38:20 - 1.77 > +++ Makefile 18 Aug 2023 19:58:48 - > @@ -1,10 +1,12 @@ > COMMENT= multi-screen window manager > > -DISTNAME=screen-4.9.0 > +DISTNAME=screen-4.9.1 > CATEGORIES= misc > MASTER_SITES=${MASTER_SITE_GNU:=screen/} > > HOMEPAGE=https://www.gnu.org/software/screen/ > > # GPLv3+ > PERMIT_PACKAGE= Yes > Index: distinfo > === > RCS file: /cvs/ports/misc/screen/distinfo,v > retrieving revision 1.14 > diff -u -p -u -p -r1.14 distinfo > --- distinfo 5 Feb 2022 11:57:36 - 1.14 > +++ distinfo 18 Aug 2023 19:58:48 - > @@ -1,2 +1,2 @@ > -SHA256 (screen-4.9.0.tar.gz) = +TNSgbtNFTjtB433iiDC8506+aTpHFfQhCceAonHMPQ= > -SIZE (screen-4.9.0.tar.gz) = 798229 > +SHA256 (screen-4.9.1.tar.gz) = Js7z48QlccDUhK1vrxEMXBUJH7+HKwb6eqR2bHQFrGk= > +SIZE (screen-4.9.1.tar.gz) = 1040785 > Index: pkg/PLIST > === > RCS file: /cvs/ports/misc/screen/pkg/PLIST,v > retrieving revision 1.25 > diff -u -p -u -p -r1.25 PLIST > --- pkg/PLIST 11 Mar 2022 19:38:20 - 1.25 > +++ pkg/PLIST 18 Aug 2023 19:58:48 - > @@ -1,5 +1,4 @@ > @bin bin/screen > -@info info/screen.info > @man man/man1/screen.1 > share/examples/screen/ > share/examples/screen/screenrc
Re: [UPDATE] misc/screen (4.9.0 => 4.9.1)
On 2023/08/18 23:40, Stuart Henderson wrote: > Something's wrong with your diff, it doesn't apply with patch. > > @@ -1,10 +1,12 @@ Must be hand-edited without using editdiff or similar, there aren't 2 new lines. > > COMMENT= multi-screen window manager > > > > -DISTNAME= screen-4.9.0 > > +DISTNAME= screen-4.9.1 > > CATEGORIES=misc > > MASTER_SITES= ${MASTER_SITE_GNU:=screen/} > > > > HOMEPAGE= https://www.gnu.org/software/screen/ > > > > # GPLv3+ > > PERMIT_PACKAGE=Yes
Re: [UPDATE] misc/screen (4.9.0 => 4.9.1)
Thanks for review. Here is the new patch. On Sat, Aug 19, 2023 at 12:40 AM Stuart Henderson wrote: > Something's wrong with your diff, it doesn't apply with patch. > > Rather than just removing from plist, please either @comment the file > in plist so it doesn't get readded, or maybe better add a post-install > target rm'ing the file with a comment saying why. > > > On 2023/08/18 22:44, Alex Naumov wrote: > > Greetings, > > > > This patch updates GNU Screen to version 4.9.1. Released yesterday. > Please > > review/test it. > > > > Screen is a full-screen window manager that multiplexes a physical > terminal > > between several processes (typically interactive shells). > > > > 'portcheck', 'port-lib-depends-check' and 'update-plist' returns 0. > > Updated and tested on x86_64 and aarch64. > > > > All tests are OK: > > * 'make test' > > * manually started the screen and did some basic operation with it. > > > > I removed: > > Info-file (texinfo, manpage still there) from the list of files > (pkg/PLIST) > > because it seems broken in this release. > > > > ChangeLog for 4.9.1: > > * Support stop/parity bits on serial port > > * Add needed system headers in checks and return values for implicit > > function declarations > > * Fixes: > > - Avoid zombies after shell exit > > - Missed signal sending permission check on failed query messages > > (CVE-2023-24626) > > - manpage fixes > > - source code fixes during cleanup > > - UTF-8 encoding can emit invalid UTF-8 sequences for out of range > unicode > > values > > > > > > Cheers, > > Alexander Naumov > > > Index: Makefile > > === > > RCS file: /cvs/ports/misc/screen/Makefile,v > > retrieving revision 1.77 > > diff -u -p -u -p -r1.77 Makefile > > --- Makefile 11 Mar 2022 19:38:20 - 1.77 > > +++ Makefile 18 Aug 2023 19:58:48 - > > @@ -1,10 +1,12 @@ > > COMMENT= multi-screen window manager > > > > -DISTNAME=screen-4.9.0 > > +DISTNAME=screen-4.9.1 > > CATEGORIES= misc > > MASTER_SITES=${MASTER_SITE_GNU:=screen/} > > > > HOMEPAGE=https://www.gnu.org/software/screen/ > > > > # GPLv3+ > > PERMIT_PACKAGE= Yes > > Index: distinfo > > === > > RCS file: /cvs/ports/misc/screen/distinfo,v > > retrieving revision 1.14 > > diff -u -p -u -p -r1.14 distinfo > > --- distinfo 5 Feb 2022 11:57:36 - 1.14 > > +++ distinfo 18 Aug 2023 19:58:48 - > > @@ -1,2 +1,2 @@ > > -SHA256 (screen-4.9.0.tar.gz) = > +TNSgbtNFTjtB433iiDC8506+aTpHFfQhCceAonHMPQ= > > -SIZE (screen-4.9.0.tar.gz) = 798229 > > +SHA256 (screen-4.9.1.tar.gz) = > Js7z48QlccDUhK1vrxEMXBUJH7+HKwb6eqR2bHQFrGk= > > +SIZE (screen-4.9.1.tar.gz) = 1040785 > > Index: pkg/PLIST > > === > > RCS file: /cvs/ports/misc/screen/pkg/PLIST,v > > retrieving revision 1.25 > > diff -u -p -u -p -r1.25 PLIST > > --- pkg/PLIST 11 Mar 2022 19:38:20 - 1.25 > > +++ pkg/PLIST 18 Aug 2023 19:58:48 - > > @@ -1,5 +1,4 @@ > > @bin bin/screen > > -@info info/screen.info > > @man man/man1/screen.1 > > share/examples/screen/ > > share/examples/screen/screenrc > Index: Makefile === RCS file: /cvs/ports/misc/screen/Makefile,v retrieving revision 1.77 diff -u -p -u -p -r1.77 Makefile --- Makefile 11 Mar 2022 19:38:20 - 1.77 +++ Makefile 19 Aug 2023 00:50:16 - @@ -1,6 +1,6 @@ COMMENT= multi-screen window manager -DISTNAME= screen-4.9.0 +DISTNAME= screen-4.9.1 CATEGORIES= misc MASTER_SITES= ${MASTER_SITE_GNU:=screen/} @@ -38,5 +38,8 @@ post-install: ${INSTALL_DATA_DIR} ${PREFIX}/share/examples/screen ${INSTALL_DATA} ${WRKSRC}/etc/etcscreenrc \ ${PREFIX}/share/examples/screen/screenrc + + #screen 4.9.1 has broken info file + @rm ${PREFIX}/info/screen.info .include Index: distinfo === RCS file: /cvs/ports/misc/screen/distinfo,v retrieving revision 1.14 diff -u -p -u -p -r1.14 distinfo --- distinfo 5 Feb 2022 11:57:36 - 1.14 +++ distinfo 19 Aug 2023 00:50:16 - @@ -1,2 +1,2 @@ -SHA256 (screen-4.9.0.tar.gz) = +TNSgbtNFTjtB433iiDC8506+aTpHFfQhCceAonHMPQ= -SIZE (screen-4.9.0.tar.gz) = 798229 +SHA256 (screen-4.9.1.tar.gz) = Js7z48QlccDUhK1vrxEMXBUJH7+HKwb6eqR2bHQFrGk= +SIZE (screen-4.9.1.tar.gz) = 1040785
Re: [UPDATE] misc/screen (4.9.0 => 4.9.1)
On 2023/08/19 14:07, Alex Naumov wrote: > Thanks for review. Here is the new patch. > > On Sat, Aug 19, 2023 at 12:40 AM Stuart Henderson > wrote: > > > Something's wrong with your diff, it doesn't apply with patch. > > > > Rather than just removing from plist, please either @comment the file > > in plist so it doesn't get readded, or maybe better add a post-install > > target rm'ing the file with a comment saying why. > > > > > > On 2023/08/18 22:44, Alex Naumov wrote: > > > Greetings, > > > > > > This patch updates GNU Screen to version 4.9.1. Released yesterday. > > Please > > > review/test it. > > > > > > Screen is a full-screen window manager that multiplexes a physical > > terminal > > > between several processes (typically interactive shells). > > > > > > 'portcheck', 'port-lib-depends-check' and 'update-plist' returns 0. > > > Updated and tested on x86_64 and aarch64. > > > > > > All tests are OK: > > > * 'make test' > > > * manually started the screen and did some basic operation with it. > > > > > > I removed: > > > Info-file (texinfo, manpage still there) from the list of files > > (pkg/PLIST) > > > because it seems broken in this release. > > > > > > ChangeLog for 4.9.1: > > > * Support stop/parity bits on serial port > > > * Add needed system headers in checks and return values for implicit > > > function declarations > > > * Fixes: > > > - Avoid zombies after shell exit > > > - Missed signal sending permission check on failed query messages > > > (CVE-2023-24626) > > > - manpage fixes > > > - source code fixes during cleanup > > > - UTF-8 encoding can emit invalid UTF-8 sequences for out of range > > unicode > > > values > > > > > > > > > Cheers, > > > Alexander Naumov > > > > > Index: Makefile > > > === > > > RCS file: /cvs/ports/misc/screen/Makefile,v > > > retrieving revision 1.77 > > > diff -u -p -u -p -r1.77 Makefile > > > --- Makefile 11 Mar 2022 19:38:20 - 1.77 > > > +++ Makefile 18 Aug 2023 19:58:48 - > > > @@ -1,10 +1,12 @@ > > > COMMENT= multi-screen window manager > > > > > > -DISTNAME=screen-4.9.0 > > > +DISTNAME=screen-4.9.1 > > > CATEGORIES= misc > > > MASTER_SITES=${MASTER_SITE_GNU:=screen/} > > > > > > HOMEPAGE=https://www.gnu.org/software/screen/ > > > > > > # GPLv3+ > > > PERMIT_PACKAGE= Yes > > > Index: distinfo > > > === > > > RCS file: /cvs/ports/misc/screen/distinfo,v > > > retrieving revision 1.14 > > > diff -u -p -u -p -r1.14 distinfo > > > --- distinfo 5 Feb 2022 11:57:36 - 1.14 > > > +++ distinfo 18 Aug 2023 19:58:48 - > > > @@ -1,2 +1,2 @@ > > > -SHA256 (screen-4.9.0.tar.gz) = > > +TNSgbtNFTjtB433iiDC8506+aTpHFfQhCceAonHMPQ= > > > -SIZE (screen-4.9.0.tar.gz) = 798229 > > > +SHA256 (screen-4.9.1.tar.gz) = > > Js7z48QlccDUhK1vrxEMXBUJH7+HKwb6eqR2bHQFrGk= > > > +SIZE (screen-4.9.1.tar.gz) = 1040785 > > > Index: pkg/PLIST > > > === > > > RCS file: /cvs/ports/misc/screen/pkg/PLIST,v > > > retrieving revision 1.25 > > > diff -u -p -u -p -r1.25 PLIST > > > --- pkg/PLIST 11 Mar 2022 19:38:20 - 1.25 > > > +++ pkg/PLIST 18 Aug 2023 19:58:48 - > > > @@ -1,5 +1,4 @@ > > > @bin bin/screen > > > -@info info/screen.info > > > @man man/man1/screen.1 > > > share/examples/screen/ > > > share/examples/screen/screenrc > > > Index: Makefile > === > RCS file: /cvs/ports/misc/screen/Makefile,v > retrieving revision 1.77 > diff -u -p -u -p -r1.77 Makefile > --- Makefile 11 Mar 2022 19:38:20 - 1.77 > +++ Makefile 19 Aug 2023 00:50:16 - > @@ -1,6 +1,6 @@ > COMMENT= multi-screen window manager > > -DISTNAME=screen-4.9.0 > +DISTNAME=screen-4.9.1 > CATEGORIES= misc > MASTER_SITES=${MASTER_SITE_GNU:=screen/} > > @@ -38,5 +38,8 @@ post-install: > ${INSTALL_DATA_DIR} ${PREFIX}/share/examples/screen > ${INSTALL_DATA} ${WRKSRC}/etc/etcscreenrc \ > ${PREFIX}/share/examples/screen/screenrc > + > + #screen 4.9.1 has broken info file > + @rm ${PREFIX}/info/screen.info I regenerated the patches, and added one to fix the texinfo input file committed.