UPDATE: ntop-1.1p3
The below diff fixes a bug in the assumptions ntop 1.1 makes about terminal column widths. When ntop is run on terminals with more than 257 columns, the printHeader() function will write a NULL byte beyond the end of the progName string. While I was there I converted sprintf() to snprintf(), since one of the variables written to the progName string is osName, which is ultimately populated from the output of `sh config.guess` during configure. I don’t believe this method guarantees osName can never cause progName to overflow. The patch itself is meant to be minimally invasive while addressing the problem. About getting this patch upstream: I don’t see how to do that, since upstream has moved onto a re-write called ‘ntop-ng’. I can’t even find old versions of ntop there. I did look on the MASTER_SITES url. There is a newer version of the ntop tarball hosted there, ntop-1.2a2.tar.gz, but the relevant source has this issue as well. Perhaps I should just use iftop ;) - Eric ntop-1.1p3.diff Description: Binary data
Re: [Update] ntop
Another Ok, on this? :) On Thu, 8 Mar 2012 23:38:46 -0500, Brad Smith wrote: On Wed, Mar 07, 2012 at 03:26:33PM -0300, Gonzalo L. R. wrote: Hi, A little update for ntop. Comments, Ok? Looks good. Tested on amd64. -- Sending from my VCR
Re: [Update] ntop
On Wed, Mar 07, 2012 at 03:26:33PM -0300, Gonzalo L. R. wrote: Hi, A little update for ntop. Comments, Ok? Looks good. Tested on amd64. -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.
[Update] ntop
Hi, A little update for ntop. Comments, Ok? Cheers. -- Sending from my VCR ntop-1.1p1.diff Description: Binary data
