Re: [ld.bfd] Unbreak x11/gnome/seahorse

2021-06-07 Thread Antoine Jacoutot
On Mon, Jun 07, 2021 at 06:10:30AM +, Charlene Wendling wrote:
> Hi,
> 
> > http://build-failures.rhaalovely.net/sparc64/2021-05-22/x11/gnome/seahorse.log
> (same on macppc, no mips64 bulk report available)
> 
> The `--as-needed' linker flag strikes again, it builds fine on macppc
> once it is removed [0]. No REVISION bump is needed, since this version
> has never been built on sparc64 and macppc.
> 
> OK?

OK.

> 
> Charlène.
> 
> 
> [0] https://bin.charlenew.xyz/seahorse.log
> 
> 
> Index: Makefile
> ===
> RCS file: /cvs/ports/x11/gnome/seahorse/Makefile,v
> retrieving revision 1.129
> diff -u -p -u -p -r1.129 Makefile
> --- Makefile  14 May 2021 08:30:12 -  1.129
> +++ Makefile  6 Jun 2021 21:58:43 -
> @@ -26,6 +26,11 @@ DEBUG_PACKAGES=${BUILD_PACKAGES}
>  .if !${PROPERTIES:Mclang}
>  CFLAGS +=-std=gnu99
>  .endif
> +# disable meson's default of using "-Wl,--as-needed" on ld.bfd arches;
> +# build failures due to undefined references are often seen.
> +.if !${PROPERTIES:Mlld}
> +CONFIGURE_ARGS +=-Db_asneeded=false
> +.endif
>  
>  LIB_DEPENDS= databases/openldap \
>   devel/libsoup \
> 

-- 
Antoine



[ld.bfd] Unbreak x11/gnome/seahorse

2021-06-07 Thread Charlene Wendling
Hi,

> http://build-failures.rhaalovely.net/sparc64/2021-05-22/x11/gnome/seahorse.log
(same on macppc, no mips64 bulk report available)

The `--as-needed' linker flag strikes again, it builds fine on macppc
once it is removed [0]. No REVISION bump is needed, since this version
has never been built on sparc64 and macppc.

OK?

Charlène.


[0] https://bin.charlenew.xyz/seahorse.log


Index: Makefile
===
RCS file: /cvs/ports/x11/gnome/seahorse/Makefile,v
retrieving revision 1.129
diff -u -p -u -p -r1.129 Makefile
--- Makefile14 May 2021 08:30:12 -  1.129
+++ Makefile6 Jun 2021 21:58:43 -
@@ -26,6 +26,11 @@ DEBUG_PACKAGES=  ${BUILD_PACKAGES}
 .if !${PROPERTIES:Mclang}
 CFLAGS +=  -std=gnu99
 .endif
+# disable meson's default of using "-Wl,--as-needed" on ld.bfd arches;
+# build failures due to undefined references are often seen.
+.if !${PROPERTIES:Mlld}
+CONFIGURE_ARGS +=  -Db_asneeded=false
+.endif
 
 LIB_DEPENDS=   databases/openldap \
devel/libsoup \