Re: [ld.bfd] don't build net/dleyna-*

2020-03-24 Thread Kurt Mosiejczuk
On Wed, Mar 11, 2020 at 08:14:10PM +0100, Charlene Wendling wrote:

> > http://build-failures.rhaalovely.net/sparc64/2020-03-08/net/dleyna/
> > http://build-failures.rhaalovely.net/powerpc/2020-02-14/net/dleyna/
> > http://build-failures.rhaalovely.net/mips64/2020-02-23/net/dleyna/

> I'm proposing to not build dleyna on ld.bfd archs, the renderer is known
> to be broken with modern version of net/gupnp [0].

> I think that the implied changes in the renderer are too big to be
> patched in our ports tree [1], actually the proposed changes are not
> even committed yet upstream.

> Note that dleyna-server has some potential fix [2] committed, so
> we could be just mark dleyna-renderer broken and patch dleyna-server.
> But i don't have the hardware to test, so it makes things difficult.

I've sent a fix for dleyna-server out. There's a number of ports that
don't build currently because of the lack of dleyna-server.

I'd be okay with marking the renderer BROKEN though.

--Kurt

> Comments/feedback are welcome,
> 
> Charlène.
> 
> 
> [0] https://github.com/intel/dleyna-renderer/issues/166
> [1] https://github.com/intel/dleyna-renderer/pull/167/files
> [2] https://github.com/intel/dleyna-server/pull/161
> 
> 
> Index: Makefile.inc
> ===
> RCS file: /cvs/ports/net/dleyna/Makefile.inc,v
> retrieving revision 1.6
> diff -u -p -u -p -r1.6 Makefile.inc
> --- Makefile.inc  12 Jul 2019 20:48:25 -  1.6
> +++ Makefile.inc  11 Mar 2020 19:04:59 -
> @@ -1,5 +1,9 @@
>  # $OpenBSD: Makefile.inc,v 1.6 2019/07/12 20:48:25 sthen Exp $
>  
> +# Requires this to be fixed with ld.bfd:
> +# https://github.com/intel/dleyna-renderer/issues/166
> +ONLY_FOR_ARCHS=  ${LLD_ARCHS}
> +
>  CATEGORIES ?=net multimedia
>  HOMEPAGE ?=  https://01.org/dleyna/
>  
> 



[ld.bfd] don't build net/dleyna-*

2020-03-11 Thread Charlene Wendling


> http://build-failures.rhaalovely.net/sparc64/2020-03-08/net/dleyna/
> http://build-failures.rhaalovely.net/powerpc/2020-02-14/net/dleyna/
> http://build-failures.rhaalovely.net/mips64/2020-02-23/net/dleyna/

I'm proposing to not build dleyna on ld.bfd archs, the renderer is known
to be broken with modern version of net/gupnp [0].

I think that the implied changes in the renderer are too big to be
patched in our ports tree [1], actually the proposed changes are not
even committed yet upstream.

Note that dleyna-server has some potential fix [2] committed, so
we could be just mark dleyna-renderer broken and patch dleyna-server.
But i don't have the hardware to test, so it makes things difficult.

Comments/feedback are welcome,

Charlène.


[0] https://github.com/intel/dleyna-renderer/issues/166
[1] https://github.com/intel/dleyna-renderer/pull/167/files
[2] https://github.com/intel/dleyna-server/pull/161


Index: Makefile.inc
===
RCS file: /cvs/ports/net/dleyna/Makefile.inc,v
retrieving revision 1.6
diff -u -p -u -p -r1.6 Makefile.inc
--- Makefile.inc12 Jul 2019 20:48:25 -  1.6
+++ Makefile.inc11 Mar 2020 19:04:59 -
@@ -1,5 +1,9 @@
 # $OpenBSD: Makefile.inc,v 1.6 2019/07/12 20:48:25 sthen Exp $
 
+# Requires this to be fixed with ld.bfd:
+# https://github.com/intel/dleyna-renderer/issues/166
+ONLY_FOR_ARCHS=${LLD_ARCHS}
+
 CATEGORIES ?=  net multimedia
 HOMEPAGE ?=https://01.org/dleyna/