On 2022/05/27 10:35, portno12 wrote:
> ping?
> i am still not sure what is going on with the tests. can i please get a hand
> reviewing them?
>
> --- Original Message ---
> On Friday, May 20th, 2022 at 8:30 PM, portno12
> wrote:
>
> > ping?
> > --- Original Message ---
> > On Thursday, May 12th, 2022 at 10:54 PM, portno12
> > wrote:
> >
> >> the project says it supports openbsd but i see a number of test failures,
> >> not sure if the failures mean totally incompatible.
> >>
> >> can someone please look and see if its worth pursuing or if any tweaks
> >> need made?
small comments;
COMMENT = Multi-distribution method for cloud instance initialization.
start with lowercase except for proper nouns. don't use . at the end.
but this is not a very clear description, could do with simplifying.
DESCR is also overcomplicated and doesn't really say what it does.
the text on https://cloud-init.io/ isn't quite right to use directly
either but it's a lot closer to what somebody needs to know to decide
if the port is useful to them.
FLAVOR =python3
FLAVORS = python3
these are more for Python libraries/modules; this seems to be more
standalone software which doesn't use them. (generally if it's a
"py-something" port then it wants FLAVOR, otherwise not)
TEST_DEPENDS = [...] devel/py-test${MODPY_FLAVOR} \
drop devel/py-test from this list, it is already set by MODPY_PYTEST
about the tests. it looks like most things work but some of the hyper-v
things aren't entirely portable, and netlink of course is linux-only
anyway. and they only go as far as testing things that upstream has
decided to test and aren't a full indication that the software does
something useful on OpenBSD, actual runtime testing is probably more
important for this to make sure it integrates properly.
I can't help much more than this, I don't really do cloud stuff