Re: [new] www/viewgit
Comments inline below from a read of the Makefile. But I will talk about
this up front so more people notice it:
| # AGPLv3
Not specific to this port but I am thinking we should draw more attention
to packages which have this nasty license. No general problem with distribution
but there are requirements on the user _even if they don't distribute the
code_. I think maybe a one-line MESSAGE noting the license which will get
displayed at pkg_add time would be appropriate. Comments welcome...
On 2012-01-18, Landry Breuil wrote:
> On Tue, Jan 17, 2012 at 12:34:27PM -0500, David Hill wrote:
>> Like to get this in. I am using it on amd64 and sparc64.
>>
>> Can someone at least okay that it looks right? :)
>
> MESSAGE should be a README, as what most ports do those days. And i
IMHO this depends on the port and what's in the file, but I think
README is appropriate for this text. See ports/infr*/templates/R*template
> think there's a new stanza to depend on the correct version of php, i
> recall sthen doing a sweep about it recently. Will try to test it today.
That sweep was for php-foo-*|php-bar-* constructs which override the
default package spec and break updates. Basically PHP ports should
be using as much as possible from the php.port.mk module to get the
dependency information right. No info in port-modules(5) yet so
read the module itself to see what it does.
| PERMIT_PACKAGE_CDROM =Yes
| PERMIT_PACKAGE_FTP = Yes
| PERMIT_DISTFILES_CDROM =Yes
| PERMIT_DISTFILES_FTP =Yes
|
| MASTER_SITES= ${MASTER_SITE_SOURCEFORGE:=viewgit/}
spaces->tabs
| NO_BUILD= Yes
| NO_REGRESS= Yes
| PKG_ARCH= *
mixed 'FOO=' and 'FOO =' in Makefile, stick to one or the other
|
| PREFIX= /var/www
| INSTDIR=${PREFIX}/viewgit
| SUBST_VARS= INSTDIR
|
| MODULES= lang/php
| RUN_DEPENDS= devel/git \
| lang/php/${MODPHP_VERSION}
don't include this yourself, php.port.mk does it for you.
$ make dump-vars|grep DEP
www/viewgit.BUILD_DEPENDS=
www/viewgit.REGRESS_DEPENDS=
www/viewgit.RUN_DEPENDS=devel/git lang/php/5.3 php->=5.3,<5.4:lang/php/5.3
^^yours^ ^^from php.port.mk^
www/viewgit.LIB_DEPENDS=
| WRKDIST= ${WRKDIR}/viewgit
|
| do-install:
| @cp ${WRKDIST}/inc/example-localconfig.php \
|${WRKDIST}/inc/localconfig.php
Kirill is right, @sample this.
| @mv ${WRKDIST} ${INSTDIR}
I'm not too keen on this as it makes it harder to do a package/edit
patches/clean=fake/repackage cycle when testing, some other ports
use pax -rw to copy the tree. mv doesn't really save you much time
with typical directory layouts that porters are likely to have.
| @chown -R ${SHAREOWN}:${SHAREGRP} ${PREFIX}
|
| .include
Re: [new] www/viewgit
On Tue, Jan 17, 2012 at 12:34:27PM -0500, David Hill wrote: > Like to get this in. I am using it on amd64 and sparc64. > > Can someone at least okay that it looks right? :) MESSAGE should be a README, as what most ports do those days. And i think there's a new stanza to depend on the correct version of php, i recall sthen doing a sweep about it recently. Will try to test it today. Landry > On Thu, Jan 12, 2012 at 12:07:14PM -0500, David Hill wrote: > :Anyone? :) > : > :On Mon, Jan 09, 2012 at 01:47:10PM -0500, David Hill wrote: > ::Attached is a newer version. > :: > ::How does this look? > :: > :: > ::On Tue, Aug 30, 2011 at 06:27:49PM +0200, Landry Breuil wrote: > :::On Tue, Aug 30, 2011 at 10:37:33AM -0400, David Hill wrote: > :::> On Fri, Aug 26, 2011 at 01:27:25PM -0400, David Hill wrote: > :::> :Hello - > :::> : > :::> :Here is an attempt of a viewgit port. > :::> : > :::> :ViewGit is a git web repository viewer that aims to be easy to set up > :::> :and upgrade, light on dependencies, and comfortable to use. > :::> : > :::> :Testing and feedback appreciated > :::> : > :::> :- David > :::> : > :::> > :::> Was anyone able to test this? > :::> Or anyone want to OK it? > ::: > :::@mv definitely wont work as is : > :::Error: modes don't match for /var/www/viewgit/templates/tags.php > :::Error: no @owner for /var/www/viewgit/templates/tree.php (landry) > :::Warning: no @group for /var/www/viewgit/templates/tree.php (wsrc) > :::Error: modes don't match for /var/www/viewgit/templates/tree.php > ::: > :::you need at least chown -R, and @mv is not nice if you do make > :::clean=fake + make fake. use pax ? > :::You'd need at least to provide an httpd.conf fragment to help ootb > :::configuration, and provide an inc/localconfig.php file and tell the > :::user to edit it. I dont even see how to configure it to work in the > :::chroot. > ::: > :::Landry > ::: > :: > ::-- > ::There cannot be a crisis next week. My schedule is already full. > ::-- Henry Kissinger > : > : > : > :-- > :Rudin's Law: > : If there is a wrong way to do something, most people will do it > :every time. > : > > -- > His super power is to turn into a scotch terrier. >
Re: [new] www/viewgit
On Tue, January 17, 2012 20:34, David Hill wrote:
> Like to get this in. I am using it on amd64 and sparc64.
>
> Can someone at least okay that it looks right? :)
>
> On Thu, Jan 12, 2012 at 12:07:14PM -0500, David Hill wrote:
> :Anyone? :)
> :
> :On Mon, Jan 09, 2012 at 01:47:10PM -0500, David Hill wrote:
> ::Attached is a newer version.
> ::
> ::How does this look?
Hi. May be I'm wrong, but i think you should not use @cp
${WRKDIST}/inc/example-localconfig.php ${WRKDIST}/inc/localconfig.php, but use
@sample in PLIST to avoid checksum problems on deinstall and upgrade.
Didn't test it though.
> ::On Tue, Aug 30, 2011 at 06:27:49PM +0200, Landry Breuil wrote:
> :::On Tue, Aug 30, 2011 at 10:37:33AM -0400, David Hill wrote:
> :::> On Fri, Aug 26, 2011 at 01:27:25PM -0400, David Hill wrote:
> :::> :Hello -
> :::> :
> :::> :Here is an attempt of a viewgit port.
> :::> :
> :::> :ViewGit is a git web repository viewer that aims to be easy to set up
> :::> :and upgrade, light on dependencies, and comfortable to use.
> :::> :
> :::> :Testing and feedback appreciated
> :::> :
> :::> :- David
> :::> :
> :::>
> :::> Was anyone able to test this?
> :::> Or anyone want to OK it?
> :::
> :::@mv definitely wont work as is :
> :::Error: modes don't match for /var/www/viewgit/templates/tags.php
> :::Error: no @owner for /var/www/viewgit/templates/tree.php (landry)
> :::Warning: no @group for /var/www/viewgit/templates/tree.php (wsrc)
> :::Error: modes don't match for /var/www/viewgit/templates/tree.php
> :::
> :::you need at least chown -R, and @mv is not nice if you do make
> :::clean=fake + make fake. use pax ?
> :::You'd need at least to provide an httpd.conf fragment to help ootb
> :::configuration, and provide an inc/localconfig.php file and tell the
> :::user to edit it. I dont even see how to configure it to work in the
> :::chroot.
> :::
> :::Landry
> :::
> ::
> ::--
> ::There cannot be a crisis next week. My schedule is already full.
> ::-- Henry Kissinger
> :
> :
> :
> :--
> :Rudin's Law:
> : If there is a wrong way to do something, most people will do it
> :every time.
> :
>
> --
> His super power is to turn into a scotch terrier.
>
>
Re: [new] www/viewgit
Like to get this in. I am using it on amd64 and sparc64. Can someone at least okay that it looks right? :) On Thu, Jan 12, 2012 at 12:07:14PM -0500, David Hill wrote: :Anyone? :) : :On Mon, Jan 09, 2012 at 01:47:10PM -0500, David Hill wrote: ::Attached is a newer version. :: ::How does this look? :: :: ::On Tue, Aug 30, 2011 at 06:27:49PM +0200, Landry Breuil wrote: :::On Tue, Aug 30, 2011 at 10:37:33AM -0400, David Hill wrote: :::> On Fri, Aug 26, 2011 at 01:27:25PM -0400, David Hill wrote: :::> :Hello - :::> : :::> :Here is an attempt of a viewgit port. :::> : :::> :ViewGit is a git web repository viewer that aims to be easy to set up :::> :and upgrade, light on dependencies, and comfortable to use. :::> : :::> :Testing and feedback appreciated :::> : :::> :- David :::> : :::> :::> Was anyone able to test this? :::> Or anyone want to OK it? ::: :::@mv definitely wont work as is : :::Error: modes don't match for /var/www/viewgit/templates/tags.php :::Error: no @owner for /var/www/viewgit/templates/tree.php (landry) :::Warning: no @group for /var/www/viewgit/templates/tree.php (wsrc) :::Error: modes don't match for /var/www/viewgit/templates/tree.php ::: :::you need at least chown -R, and @mv is not nice if you do make :::clean=fake + make fake. use pax ? :::You'd need at least to provide an httpd.conf fragment to help ootb :::configuration, and provide an inc/localconfig.php file and tell the :::user to edit it. I dont even see how to configure it to work in the :::chroot. ::: :::Landry ::: :: ::-- ::There cannot be a crisis next week. My schedule is already full. :: -- Henry Kissinger : : : :-- :Rudin's Law: : If there is a wrong way to do something, most people will do it :every time. : -- His super power is to turn into a scotch terrier.
Re: [new] www/viewgit
Anyone? :) On Mon, Jan 09, 2012 at 01:47:10PM -0500, David Hill wrote: :Attached is a newer version. : :How does this look? : : :On Tue, Aug 30, 2011 at 06:27:49PM +0200, Landry Breuil wrote: ::On Tue, Aug 30, 2011 at 10:37:33AM -0400, David Hill wrote: ::> On Fri, Aug 26, 2011 at 01:27:25PM -0400, David Hill wrote: ::> :Hello - ::> : ::> :Here is an attempt of a viewgit port. ::> : ::> :ViewGit is a git web repository viewer that aims to be easy to set up ::> :and upgrade, light on dependencies, and comfortable to use. ::> : ::> :Testing and feedback appreciated ::> : ::> :- David ::> : ::> ::> Was anyone able to test this? ::> Or anyone want to OK it? :: ::@mv definitely wont work as is : ::Error: modes don't match for /var/www/viewgit/templates/tags.php ::Error: no @owner for /var/www/viewgit/templates/tree.php (landry) ::Warning: no @group for /var/www/viewgit/templates/tree.php (wsrc) ::Error: modes don't match for /var/www/viewgit/templates/tree.php :: ::you need at least chown -R, and @mv is not nice if you do make ::clean=fake + make fake. use pax ? ::You'd need at least to provide an httpd.conf fragment to help ootb ::configuration, and provide an inc/localconfig.php file and tell the ::user to edit it. I dont even see how to configure it to work in the ::chroot. :: ::Landry :: : :-- :There cannot be a crisis next week. My schedule is already full. : -- Henry Kissinger -- Rudin's Law: If there is a wrong way to do something, most people will do it every time.
Re: [new] www/viewgit
Attached is a newer version. How does this look? On Tue, Aug 30, 2011 at 06:27:49PM +0200, Landry Breuil wrote: :On Tue, Aug 30, 2011 at 10:37:33AM -0400, David Hill wrote: :> On Fri, Aug 26, 2011 at 01:27:25PM -0400, David Hill wrote: :> :Hello - :> : :> :Here is an attempt of a viewgit port. :> : :> :ViewGit is a git web repository viewer that aims to be easy to set up :> :and upgrade, light on dependencies, and comfortable to use. :> : :> :Testing and feedback appreciated :> : :> :- David :> : :> :> Was anyone able to test this? :> Or anyone want to OK it? : :@mv definitely wont work as is : :Error: modes don't match for /var/www/viewgit/templates/tags.php :Error: no @owner for /var/www/viewgit/templates/tree.php (landry) :Warning: no @group for /var/www/viewgit/templates/tree.php (wsrc) :Error: modes don't match for /var/www/viewgit/templates/tree.php : :you need at least chown -R, and @mv is not nice if you do make :clean=fake + make fake. use pax ? :You'd need at least to provide an httpd.conf fragment to help ootb :configuration, and provide an inc/localconfig.php file and tell the :user to edit it. I dont even see how to configure it to work in the :chroot. : :Landry : -- There cannot be a crisis next week. My schedule is already full. -- Henry Kissinger viewgit.tar.gz Description: application/tar-gz
Re: [new] www/viewgit
On Tue, Aug 30, 2011 at 10:37:33AM -0400, David Hill wrote: > On Fri, Aug 26, 2011 at 01:27:25PM -0400, David Hill wrote: > :Hello - > : > :Here is an attempt of a viewgit port. > : > :ViewGit is a git web repository viewer that aims to be easy to set up > :and upgrade, light on dependencies, and comfortable to use. > : > :Testing and feedback appreciated > : > :- David > : > > Was anyone able to test this? > Or anyone want to OK it? @mv definitely wont work as is : Error: modes don't match for /var/www/viewgit/templates/tags.php Error: no @owner for /var/www/viewgit/templates/tree.php (landry) Warning: no @group for /var/www/viewgit/templates/tree.php (wsrc) Error: modes don't match for /var/www/viewgit/templates/tree.php you need at least chown -R, and @mv is not nice if you do make clean=fake + make fake. use pax ? You'd need at least to provide an httpd.conf fragment to help ootb configuration, and provide an inc/localconfig.php file and tell the user to edit it. I dont even see how to configure it to work in the chroot. Landry
Re: [new] www/viewgit
On Fri, Aug 26, 2011 at 01:27:25PM -0400, David Hill wrote: :Hello - : :Here is an attempt of a viewgit port. : :ViewGit is a git web repository viewer that aims to be easy to set up :and upgrade, light on dependencies, and comfortable to use. : :Testing and feedback appreciated : :- David : Was anyone able to test this? Or anyone want to OK it?
[new] www/viewgit
Hello - Here is an attempt of a viewgit port. ViewGit is a git web repository viewer that aims to be easy to set up and upgrade, light on dependencies, and comfortable to use. Testing and feedback appreciated - David viewgit.tar.gz Description: application/tar-gz
