Re: [new] x11/xpra

[Renaud Allard]

On 12/16/20 9:19 PM, Mikolaj Kucharski wrote:



I've glanced through patches directory in your port and what caught my
attention is patch-xpra_buffers_memalign_c diff.

I had my local xpra port couple of years back, but I don't use it any
more and back then I had different patch for  include.


Thanks, I used your links and made some corrections


xpra.tgz
Description: application/compressed-tar


smime.p7s
Description: S/MIME Cryptographic Signature

Re: [new] x11/xpra

[Mikolaj Kucharski]

Hi,

On Wed, Dec 16, 2020 at 10:57:43AM +0100, Renaud Allard wrote:
> Hello,
> 
> Here is my first attempt at making xpra available on OpenBSD.
> Suggestions/corrections/tests are welcome.
> 
> xpra is a kind of tmux/screen for X11
> 
> Regards

I've glanced through patches directory in your port and what caught my
attention is patch-xpra_buffers_memalign_c diff.

I had my local xpra port couple of years back, but I don't use it any
more and back then I had different patch for  include.

Here is my old port:
 https://marc.info/?l=openbsd-ports=153207856621524=2

And per message:
 https://marc.info/?l=openbsd-ports=153301067923054=2

There was also openbsd-wip port at:
 https://github.com/jasperla/openbsd-wip/tree/master/x11/xpra

See below diff:

--- xpra/buffers/memalign.c.origMon Apr 18 12:03:12 2016
+++ xpra/buffers/memalign.c Fri May 20 00:37:58 2016
@@ -13,7 +13,7 @@
 #ifdef _WIN32
 #define _STDINT_H
 #endif
-#if !defined(__APPLE__) && !defined(__FreeBSD__) && !defined(__DragonFly__)
+#if !defined(__APPLE__) && !defined(__FreeBSD__) && !defined(__DragonFly__) && 
!defined(__OpenBSD__)
 #include 
 #endif

-- 
Regards,
 Mikolaj

Re: [new] x11/xpra

[Renaud Allard]

On 12/16/20 12:28 PM, Stuart Henderson wrote:


Initial comments from a quick read through (I have not tried building) -




Thanks Stuart, here it is again with your suggestions, a probably more 
correct WANTLIB and some PLIST tweaks.




xpra.tgz
Description: application/compressed-tar


smime.p7s
Description: S/MIME Cryptographic Signature

[new] x11/xpra

[Renaud Allard]

Hello,

Here is my first attempt at making xpra available on OpenBSD.
Suggestions/corrections/tests are welcome.

xpra is a kind of tmux/screen for X11

Regards


xpra.tgz
Description: application/compressed-tar


smime.p7s
Description: S/MIME Cryptographic Signature

Re: [new] x11/xpra

[Stuart Henderson]

On 2020/12/16 10:57, Renaud Allard wrote:
> Hello,
> 
> Here is my first attempt at making xpra available on OpenBSD.
> Suggestions/corrections/tests are welcome.
> 
> xpra is a kind of tmux/screen for X11
> 
> Regards



Initial comments from a quick read through (I have not tried building) -

COMMENT =   Xpra gives you persistent remote applications for X

please don't repeat the name here, when it's displayed it is close to the
package name anyway so there's duplication. Something like "persistent
remote applications for X" maybe?

DISTNAME =  xpra-${MODPY_EGG_VERSION}
PKGNAME =   ${DISTNAME:S/py/py-/}
REVISION =  0

the PKGNAME setting here doesn't make sense (it's a noop)
start with no REVISION

MODPY_VERSION = ${MODPY_DEFAULT_VERSION_3}
BUILD_DEPENDS = [...] x11/py-gtk2 

this doesn't make sense, py-gtk2 is py2 only

WANTLIB +=  ${COMPILER_LIBCXX} ${MODPY_WANTLIB}

if you have a WANTLIB on something from ports there should be an
associated LIB_DEPENDS (i.e. on ${MODPY_LIB_DEPENDS}) not just
a RUN_DEPENDS.