Re: [update/perl 5.32 fix] audio/p5-MP3-Tag 1.15

2020-07-02 Thread Charlene Wendling
On Thu, 2 Jul 2020 00:11:25 +0100
Stuart Henderson wrote:

> On 2020/07/01 23:51, Charlene Wendling wrote:
> > Hi,
> > 
> > This is a quick update for MP3::Tag to 1.15, fixing unescaped left
> > braces that will be fatal with Perl >= 5.32. That's the only change
> > [0], oh and now the module is distributed in zip form :-/
> 
> odd, what possible reason do they have for the zip?!

ILYAZ moved to zip files for all their modules, i don't know why as
well, maybe they got tired by permissions issues? 



Re: [update/perl 5.32 fix] audio/p5-MP3-Tag 1.15

2020-07-01 Thread Stuart Henderson
On 2020/07/01 23:51, Charlene Wendling wrote:
> Hi,
> 
> This is a quick update for MP3::Tag to 1.15, fixing unescaped left
> braces that will be fatal with Perl >= 5.32. That's the only change [0],
> oh and now the module is distributed in zip form :-/

odd, what possible reason do they have for the zip?!

> I've tested audio/pacpl though, it works fine.
> 
> I also totally rewrote the Makefile with proper ordering and spacing
> while here.
> 
> Comments/feedback are welcome,

ok

> 
> Charlène.
> 
> [0]
> https://metacpan.org/diff/file?target=ILYAZ/MP3-Tag-1.15/=ILYAZ%2FMP3-Tag-1.14
> 
> 
> Index: Makefile
> ===
> RCS file: /cvs/ports/audio/p5-MP3-Tag/Makefile,v
> retrieving revision 1.13
> diff -u -p -u -p -r1.13 Makefile
> --- Makefile  12 Jul 2019 20:43:38 -  1.13
> +++ Makefile  1 Jul 2020 21:14:56 -
> @@ -1,14 +1,17 @@
>  # $OpenBSD: Makefile,v 1.13 2019/07/12 20:43:38 sthen Exp $
>  
> -COMMENT= read tags of MP3 audio files
> +COMMENT =read tags of MP3 audio files
>  
> -MODULES= cpan
> -PKG_ARCH=*
> -DISTNAME=MP3-Tag-1.14
> -CATEGORIES=  audio
> -FIX_EXTRACT_PERMISSIONS=Yes
> +DISTNAME =   MP3-Tag-1.15
> +EXTRACT_SUFX =   .zip
>  
> -# perl
> -PERMIT_PACKAGE=  Yes
> +CATEGORIES = audio
> +
> +# Perl
> +PERMIT_PACKAGE = Yes
> +
> +MODULES =cpan
> +
> +PKG_ARCH =   *
>  
>  .include 
> Index: distinfo
> ===
> RCS file: /cvs/ports/audio/p5-MP3-Tag/distinfo,v
> retrieving revision 1.7
> diff -u -p -u -p -r1.7 distinfo
> --- distinfo  28 Apr 2017 22:20:45 -  1.7
> +++ distinfo  1 Jul 2020 21:14:56 -
> @@ -1,2 +1,2 @@
> -SHA256 (MP3-Tag-1.14.tar.gz) = PsOS8nPOOCKO4tflP3Yi9vkKnDHFB55snzVPsEqYwlk=
> -SIZE (MP3-Tag-1.14.tar.gz) = 279630
> +SHA256 (MP3-Tag-1.15.zip) = qqxI9GN+3KQI/Xk4G8C/8PmxG9jh6U3gWdrpkzZfVtE=
> +SIZE (MP3-Tag-1.15.zip) = 321983
> 



[update/perl 5.32 fix] audio/p5-MP3-Tag 1.15

2020-07-01 Thread Charlene Wendling
Hi,

This is a quick update for MP3::Tag to 1.15, fixing unescaped left
braces that will be fatal with Perl >= 5.32. That's the only change [0],
oh and now the module is distributed in zip form :-/

I've tested audio/pacpl though, it works fine.

I also totally rewrote the Makefile with proper ordering and spacing
while here.

Comments/feedback are welcome,

Charlène.

[0]
https://metacpan.org/diff/file?target=ILYAZ/MP3-Tag-1.15/=ILYAZ%2FMP3-Tag-1.14


Index: Makefile
===
RCS file: /cvs/ports/audio/p5-MP3-Tag/Makefile,v
retrieving revision 1.13
diff -u -p -u -p -r1.13 Makefile
--- Makefile12 Jul 2019 20:43:38 -  1.13
+++ Makefile1 Jul 2020 21:14:56 -
@@ -1,14 +1,17 @@
 # $OpenBSD: Makefile,v 1.13 2019/07/12 20:43:38 sthen Exp $
 
-COMMENT=   read tags of MP3 audio files
+COMMENT =  read tags of MP3 audio files
 
-MODULES=   cpan
-PKG_ARCH=  *
-DISTNAME=  MP3-Tag-1.14
-CATEGORIES=audio
-FIX_EXTRACT_PERMISSIONS=Yes
+DISTNAME = MP3-Tag-1.15
+EXTRACT_SUFX = .zip
 
-# perl
-PERMIT_PACKAGE=Yes
+CATEGORIES =   audio
+
+# Perl
+PERMIT_PACKAGE =   Yes
+
+MODULES =  cpan
+
+PKG_ARCH = *
 
 .include 
Index: distinfo
===
RCS file: /cvs/ports/audio/p5-MP3-Tag/distinfo,v
retrieving revision 1.7
diff -u -p -u -p -r1.7 distinfo
--- distinfo28 Apr 2017 22:20:45 -  1.7
+++ distinfo1 Jul 2020 21:14:56 -
@@ -1,2 +1,2 @@
-SHA256 (MP3-Tag-1.14.tar.gz) = PsOS8nPOOCKO4tflP3Yi9vkKnDHFB55snzVPsEqYwlk=
-SIZE (MP3-Tag-1.14.tar.gz) = 279630
+SHA256 (MP3-Tag-1.15.zip) = qqxI9GN+3KQI/Xk4G8C/8PmxG9jh6U3gWdrpkzZfVtE=
+SIZE (MP3-Tag-1.15.zip) = 321983