Re: [update] www/snownews 1.6.10 -> 1.8
On Mon, 5 Jul 2021 17:15:09 -0400 "trondd" wrote: > On Mon, July 5, 2021 9:53 am, Charlene Wendling wrote: > > Hi, > > > > The below diff updates snownews to 1.8 with a new repo owner and > > finally a lot of modern features [0]! I tend to separate upstream vs > > ports changes, but it's unpractical here: > > > >> Added Atom feed support > > Modify COMMENT and DESCR accordingly. While here, update to valid > > feeds and a mix of RSS and Atom. HTTPS is used where applicable. > >> Use curl for networking > > Add proper LIB_DEPENDS, remove README now that HTTPS is supported. > > There is a year 2038 printf() warning, but it would require to > > sprinkle CURLINFO_FILETIME_T instead of CURLINFO_FILETIME in many > > places first. Also, refresh WANTLIB, and remove the netio.c patch > > accordingly. > >> Use the OPML format to store the feed list, and XDG dirs > > Snownews-1.8 will migrate your urls file to the OPML format in > > ~/.config/snownews where you can find other settings (key > > bindings, colors etc.). The OPML conversion tools (snow2opml, > > opml2snow) have been removed, so we don't need p5-XML-LibXML as a > > RUN_DEPENDS. > >> Use UTF-8 everywhere (including manpages) > > The upstream configuration system couldn't find our ncurses > > library with wide chars support, so i needed to tweak CFLAGS and > > LDFLAGS. > >> Deal with lack of verbosity for the fake stage > > The most painful part of that update has been the fake stage, > > because upstream hides issued commands, so i preferred to > > unsilence them. > > > > All the rest is mostly updating old patches. > > > > Testing: > > > > It builds and works fine on amd64 and macppc. > > > > Note that feed items' text enclosed in '' is > > not displayed (yet?). > > > > Comments and feedback are welcome, > > > > Charlène. > > > > > > [0] https://github.com/msharov/snownews/releases > > > > Thanks. I use snownews. It converted my configs and works as > epxected. I had to go back in and clean up all the calls to external > conversion tools that the previous version needed but that's to be > expected. Worked either way. > > Tim. > You're welcome! I tried beforehand with a few feeds, but was not 100% sure how the migration would really fare for current users. The commit message will mention this, but given it works in either way it should be smooth for everyone. Charlène.
Re: [update] www/snownews 1.6.10 -> 1.8
On Mon, July 5, 2021 9:53 am, Charlene Wendling wrote: > Hi, > > The below diff updates snownews to 1.8 with a new repo owner and > finally a lot of modern features [0]! I tend to separate upstream vs > ports changes, but it's unpractical here: > >> Added Atom feed support > Modify COMMENT and DESCR accordingly. While here, update to valid > feeds and a mix of RSS and Atom. HTTPS is used where applicable. >> Use curl for networking > Add proper LIB_DEPENDS, remove README now that HTTPS is supported. > There is a year 2038 printf() warning, but it would require to > sprinkle CURLINFO_FILETIME_T instead of CURLINFO_FILETIME in many > places first. Also, refresh WANTLIB, and remove the netio.c patch > accordingly. >> Use the OPML format to store the feed list, and XDG dirs > Snownews-1.8 will migrate your urls file to the OPML format in > ~/.config/snownews where you can find other settings (key bindings, > colors etc.). The OPML conversion tools (snow2opml, opml2snow) have > been removed, so we don't need p5-XML-LibXML as a RUN_DEPENDS. >> Use UTF-8 everywhere (including manpages) > The upstream configuration system couldn't find our ncurses library > with wide chars support, so i needed to tweak CFLAGS and LDFLAGS. >> Deal with lack of verbosity for the fake stage > The most painful part of that update has been the fake stage, > because upstream hides issued commands, so i preferred to > unsilence them. > > All the rest is mostly updating old patches. > > Testing: > > It builds and works fine on amd64 and macppc. > > Note that feed items' text enclosed in '' is > not displayed (yet?). > > Comments and feedback are welcome, > > Charlène. > > > [0] https://github.com/msharov/snownews/releases > Thanks. I use snownews. It converted my configs and works as epxected. I had to go back in and clean up all the calls to external conversion tools that the previous version needed but that's to be expected. Worked either way. Tim.
Re: [update] www/snownews 1.6.10 -> 1.8
Comments and feedback are welcome, this is pretty cool, i think snownews will replace newsboat for me `make test` and `make install` on amd64 successfull most of my feeds did work without a problem. i will report small improvements and some "broken" feeds upstream thanks for this update
Re: [update] www/snownews 1.6.10 -> 1.8
Hi Charlene -- On 07/05/2021 09:53 AM, Charlene Wendling wrote: Hi, The below diff updates snownews to 1.8 with a new repo owner and finally a lot of modern features [0]! I tend to separate upstream vs ports changes, but it's unpractical here: Added Atom feed support Modify COMMENT and DESCR accordingly. While here, update to valid feeds and a mix of RSS and Atom. HTTPS is used where applicable. Use curl for networking Add proper LIB_DEPENDS, remove README now that HTTPS is supported. There is a year 2038 printf() warning, but it would require to sprinkle CURLINFO_FILETIME_T instead of CURLINFO_FILETIME in many places first. Also, refresh WANTLIB, and remove the netio.c patch accordingly. Use the OPML format to store the feed list, and XDG dirs Snownews-1.8 will migrate your urls file to the OPML format in ~/.config/snownews where you can find other settings (key bindings, colors etc.). The OPML conversion tools (snow2opml, opml2snow) have been removed, so we don't need p5-XML-LibXML as a RUN_DEPENDS. Use UTF-8 everywhere (including manpages) The upstream configuration system couldn't find our ncurses library with wide chars support, so i needed to tweak CFLAGS and LDFLAGS. Deal with lack of verbosity for the fake stage The most painful part of that update has been the fake stage, because upstream hides issued commands, so i preferred to unsilence them. All the rest is mostly updating old patches. Testing: It builds and works fine on amd64 and macppc. Note that feed items' text enclosed in '' is not displayed (yet?). Comments and feedback are welcome, Charlène. [0] https://github.com/msharov/snownews/releases Everything checks out and works here too. ok bcallah@ ~Brian
[update] www/snownews 1.6.10 -> 1.8
Hi,
The below diff updates snownews to 1.8 with a new repo owner and
finally a lot of modern features [0]! I tend to separate upstream vs
ports changes, but it's unpractical here:
> Added Atom feed support
Modify COMMENT and DESCR accordingly. While here, update to valid
feeds and a mix of RSS and Atom. HTTPS is used where applicable.
> Use curl for networking
Add proper LIB_DEPENDS, remove README now that HTTPS is supported.
There is a year 2038 printf() warning, but it would require to
sprinkle CURLINFO_FILETIME_T instead of CURLINFO_FILETIME in many
places first. Also, refresh WANTLIB, and remove the netio.c patch
accordingly.
> Use the OPML format to store the feed list, and XDG dirs
Snownews-1.8 will migrate your urls file to the OPML format in
~/.config/snownews where you can find other settings (key bindings,
colors etc.). The OPML conversion tools (snow2opml, opml2snow) have
been removed, so we don't need p5-XML-LibXML as a RUN_DEPENDS.
> Use UTF-8 everywhere (including manpages)
The upstream configuration system couldn't find our ncurses library
with wide chars support, so i needed to tweak CFLAGS and LDFLAGS.
> Deal with lack of verbosity for the fake stage
The most painful part of that update has been the fake stage,
because upstream hides issued commands, so i preferred to
unsilence them.
All the rest is mostly updating old patches.
Testing:
It builds and works fine on amd64 and macppc.
Note that feed items' text enclosed in '' is
not displayed (yet?).
Comments and feedback are welcome,
Charlène.
[0] https://github.com/msharov/snownews/releases
Index: Makefile
===
RCS file: /cvs/ports/www/snownews/Makefile,v
retrieving revision 1.41
diff -u -p -u -p -r1.41 Makefile
--- Makefile21 Nov 2020 22:03:13 - 1.41
+++ Makefile5 Jul 2021 13:01:43 -
@@ -1,13 +1,11 @@
# $OpenBSD: Makefile,v 1.41 2020/11/21 22:03:13 kmos Exp $
-COMMENT= text mode rss newsreader
+COMMENT= text mode rss and atom newsreader
CATEGORIES=www
-GH_ACCOUNT=kouya
+GH_ACCOUNT=msharov
GH_PROJECT=snownews
-GH_TAGNAME=1.6.10
-
-HOMEPAGE= https://github.com/kouya/snownews
+GH_TAGNAME=v1.8
# GPLv3 only
PERMIT_PACKAGE=Yes
@@ -15,21 +13,25 @@ PERMIT_PACKAGE= Yes
# C11
COMPILER= base-clang ports-gcc
-WANTLIB += c curses iconv intl xml2 z
+WANTLIB += c crypto curl curses iconv intl xml2
NO_TEST= Yes
USE_GMAKE= Yes
BUILD_DEPENDS= devel/gettext,-tools
-RUN_DEPENDS= textproc/p5-XML-LibXML
LIB_DEPENDS= devel/gettext,-runtime \
+ net/curl \
textproc/libxml
CONFIGURE_STYLE= simple
-CONFIGURE_ARGS=--prefix="\$${PREFIX}" \
- --mandir="\$${PREFIX}/man" \
- --builddir=${WRKDIR}
-MAKE_ENV= COPTFLAGS="${CFLAGS}"
+CONFIGURE_ARGS+= --builddir=${WRKDIR} --mandir=${PREFIX}/man
+MAKE_ENV= cflags="${CFLAGS}" ldflags="${LDFLAGS}"
+
+# Needed for cchar_t, setcchar() and getcchar()
+CFLAGS+= -D_XOPEN_SOURCE_EXTENDED
+# Fix linking errors due to upstream build system
+# not being able to find proper LDFLAGS for ncurses
+LDFLAGS+= -lncursesw
.include
Index: distinfo
===
RCS file: /cvs/ports/www/snownews/distinfo,v
retrieving revision 1.17
diff -u -p -u -p -r1.17 distinfo
--- distinfo20 Nov 2020 20:48:11 - 1.17
+++ distinfo5 Jul 2021 13:01:43 -
@@ -1,2 +1,2 @@
-SHA256 (snownews-1.6.10.tar.gz) = jHgGeu914oPfSzzKHJZlh7ZlTp6Eo+bl64vdWCl5kkI=
-SIZE (snownews-1.6.10.tar.gz) = 189715
+SHA256 (snownews-1.8.tar.gz) = kNJhGz46ALwUqIaTZdNmrR2rF+oWh4V0QBWfxxN8O+0=
+SIZE (snownews-1.8.tar.gz) = 154813
Index: patches/patch-Config_mk_in
===
RCS file: /cvs/ports/www/snownews/patches/patch-Config_mk_in,v
retrieving revision 1.1
diff -u -p -u -p -r1.1 patch-Config_mk_in
--- patches/patch-Config_mk_in 20 Nov 2020 20:48:11 - 1.1
+++ patches/patch-Config_mk_in 5 Jul 2021 13:01:43 -
@@ -3,25 +3,25 @@ $OpenBSD: patch-Config_mk_in,v 1.1 2020/
Index: Config.mk.in
--- Config.mk.in.orig
+++ Config.mk.in
-@@ -21,7 +21,7 @@ PREFIX := @prefix@
- BINDIR:= @bindir@
- LOCALEPATH:= @localedir@
- MANPATH := @mandir@
--BUILDDIR := @builddir@/${NAME}
-+BUILDDIR := @builddir@/build
- PKGDIR:= @pkgdir@
+@@ -19,20 +19,13 @@ mandir := @mandir@
+ man1dir := @man1dir@
+ localedir := @localedir@
+ TMPDIR:= @TMPDIR@
+-builddir := @builddir@/${name}
++builddir := @builddir@/build
O := .o/
-@@ -29,11 +29,5 @@ O := .o/
+ Compiler options
- CFLAGS:= -Wall -Wextra -Wredundant-decls
