Re: Delete print/ghostview

2019-03-12 Thread Matthias Kilian
On Mon, Mar 11, 2019 at 07:59:50PM -0600, Anthony J. Bentley wrote:
> ghostview hasn't been updated since its import 21 years ago.
> There's no homepage and the distfile is no longer available on the
> GNU mirrors.
> 
> DESCR proclaims its ability to parse Adobe documents, etc. Given the
> generally poor quality of C code 20 years ago, and the number of
> high-profile GhostScript vulnerabilities in the meantime, and the many
> alternative PostScript viewers like gv, and evince, I'd like to remove
> this "full function user interface for ghostscript 2.4 and later."
> 
> ok?

I wouldn't miss it.

Regarding ghostscript itself: I'm aware that it's hopelessly out
of date, and I really hope to find enought time to update it to the
newest version, which will more or less be a complete rework of the
port. But even after an update, I wouldn't trust it enough to process
arbitrary input.

Ciao,
Kili



Delete print/ghostview

2019-03-11 Thread Anthony J. Bentley
Hi,

ghostview hasn't been updated since its import 21 years ago.
There's no homepage and the distfile is no longer available on the
GNU mirrors.

DESCR proclaims its ability to parse Adobe documents, etc. Given the
generally poor quality of C code 20 years ago, and the number of
high-profile GhostScript vulnerabilities in the meantime, and the many
alternative PostScript viewers like gv, and evince, I'd like to remove
this "full function user interface for ghostscript 2.4 and later."

ok?

Index: Makefile
===
RCS file: /cvs/ports/print/Makefile,v
retrieving revision 1.127
diff -u -p -r1.127 Makefile
--- Makefile26 Dec 2018 10:05:37 -  1.127
+++ Makefile12 Mar 2019 01:58:51 -
@@ -25,7 +25,6 @@
 SUBDIR += foomatic-db-engine
 SUBDIR += freetype
 SUBDIR += ghostscript
-SUBDIR += ghostview
 SUBDIR += gl2ps
 SUBDIR += gtklp
 SUBDIR += gutenprint
Index: ghostview/Makefile
===
RCS file: ghostview/Makefile
diff -N ghostview/Makefile
--- ghostview/Makefile  23 Oct 2017 17:11:02 -  1.30
+++ /dev/null   1 Jan 1970 00:00:00 -
@@ -1,21 +0,0 @@
-# $OpenBSD: Makefile,v 1.30 2017/10/23 17:11:02 sthen Exp $
-
-COMMENT=   X11 front-end for ghostscript
-
-DISTNAME=  ghostview-1.5
-REVISION=  6
-CATEGORIES=print
-
-MASTER_SITES=  ${MASTER_SITE_GNU:=ghostview/}
-
-# GPLv2+
-PERMIT_PACKAGE_CDROM=  Yes
-
-WANTLIB += ICE SM X11 Xau Xaw Xdmcp Xext Xmu Xpm Xt c m xcb
-
-RUN_DEPENDS=print/ghostscript/gnu
-
-CONFIGURE_STYLE=imake
-NO_TEST=   Yes
-
-.include 
Index: ghostview/distinfo
===
RCS file: ghostview/distinfo
diff -N ghostview/distinfo
--- ghostview/distinfo  18 Jan 2015 03:14:57 -  1.4
+++ /dev/null   1 Jan 1970 00:00:00 -
@@ -1,2 +0,0 @@
-SHA256 (ghostview-1.5.tar.gz) = VseWgIXsGWwM1SAmOC3vKgc8hGJiBV0PIaFqdQotOUU=
-SIZE (ghostview-1.5.tar.gz) = 139742
Index: ghostview/patches/patch-Dir_c
===
RCS file: ghostview/patches/patch-Dir_c
diff -N ghostview/patches/patch-Dir_c
--- ghostview/patches/patch-Dir_c   26 Apr 2002 01:44:08 -  1.1
+++ /dev/null   1 Jan 1970 00:00:00 -
@@ -1,11 +0,0 @@
-$OpenBSD: patch-Dir_c,v 1.1 2002/04/26 01:44:08 espie Exp $
 Dir.c.orig Fri Apr 26 02:40:50 2002
-+++ Dir.c  Fri Apr 26 02:41:05 2002
-@@ -25,6 +25,7 @@
-  */
- 
- #include 
-+#include 
- 
- #ifdef SEL_FILE_IGNORE_CASE
- #include 
Index: ghostview/patches/patch-Draw_c
===
RCS file: ghostview/patches/patch-Draw_c
diff -N ghostview/patches/patch-Draw_c
--- ghostview/patches/patch-Draw_c  26 Apr 2002 01:44:08 -  1.1
+++ /dev/null   1 Jan 1970 00:00:00 -
@@ -1,298 +0,0 @@
-$OpenBSD: patch-Draw_c,v 1.1 2002/04/26 01:44:08 espie Exp $
 Draw.c.origSat Jul 24 04:29:12 1993
-+++ Draw.c Fri Apr 26 03:39:01 2002
-@@ -30,6 +30,7 @@
- #include 
- #include 
- #include 
-+#include "gv.h"
- 
- #define SF_DEFAULT_FONT "9x15"
- 
-@@ -59,6 +60,8 @@ static int SFcurrentListY;
- 
- static XtIntervalId SFscrollTimerId;
- 
-+
-+void
- SFinitFont()
- {
-   TextData*data;
-@@ -86,6 +89,7 @@ SFinitFont()
-   SFcharHeight = SFcharAscent + SFfont->max_bounds.descent;
- }
- 
-+void
- SFcreateGC()
- {
-   XGCValues   gcValues;
-@@ -151,6 +155,7 @@ SFcreateGC()
-   );
- }
- 
-+void
- SFclearList(n, doScroll)
-   int n;
-   int doScroll;
-@@ -193,7 +198,7 @@ SFclearList(n, doScroll)
-   }
- }
- 
--static
-+static void
- SFdeleteEntry(dir, entry)
-   SFDir   *dir;
-   SFEntry *entry;
-@@ -244,7 +249,7 @@ SFdeleteEntry(dir, entry)
-   );
- }
- 
--static
-+static void
- SFwriteStatChar(name, last, statBuf)
-   char*name;
-   int last;
-@@ -320,7 +325,7 @@ SFstatAndCheck(dir, entry)
-   return 0;
- }
- 
--static
-+static void
- SFdrawStrings(w, dir, from, to)
-   register Window w;
-   register SFDir  *dir;
-@@ -397,6 +402,7 @@ SFdrawStrings(w, dir, from, to)
-   }
- }
- 
-+void
- SFdrawList(n, doScroll)
-   int n;
-   int doScroll;
-@@ -422,6 +428,7 @@ SFdrawList(n, doScroll)
-   }
- }
- 
-+void
- SFdrawLists(doScroll)
-   int doScroll;
- {
-@@ -432,7 +439,7 @@ SFdrawLists(doScroll)
-   }
- }
- 
--static
-+static void
- SFinvertEntry(n)
-   register intn;
- {
-@@ -486,19 +493,19 @@ SFscrollTimer(p, id)
-   int save;
-   int n;
- 
--n = (int) p;
-+n = * ((int *) p);
- 
-   dir = &(SFdirs[SFdirPtr + n]);
-   save = dir->vOrigin;
- 
-   if (SFcurrentListY < SFlowerY) {
-   if (dir->vOrigin > 0) {
--  SFvSliderMovedCallback(selFileVScrolls[n], n,
-+