Re: Fix: games/sudoku-solver
ok tobiasu@
But... why not delete the whole thing? It's from mbalmer@, he's not
using it any more (at the very least not on OpenBSD) and he even pulled
his own website and any traces of the source. Why keep it? It's a nice
programming exercise, but I doubt anyone uses it.
Oh, and the compiler warning messages don't exactly inspire strict
alignment readyness.
so.. rm -rf?
On Thu, Jul 30, 2015 at 07:29:58PM +0200, Christian Weisgerber wrote:
This removes a spurious -fpic which broke the build on sparc64.
I _think_ the intention of the Makefile is to build the webui
component statically (for copying into chroot?), so I've fixed it
that way. Not sure though if we need or want this.
Index: Makefile
===
RCS file: /cvs/ports/games/sudoku-solver/Makefile,v
retrieving revision 1.19
diff -u -p -r1.19 Makefile
--- Makefile 30 Jul 2015 16:05:51 - 1.19
+++ Makefile 30 Jul 2015 17:27:51 -
@@ -3,7 +3,7 @@
COMMENT= sudoku puzzle solver with cli, gui, and web ui
DISTNAME=sudoku-solver-1.0.1
-REVISION=7
+REVISION=8
CATEGORIES= games www x11
Index: patches/patch-webui_Makefile
===
RCS file: /cvs/ports/games/sudoku-solver/patches/patch-webui_Makefile,v
retrieving revision 1.1
diff -u -p -r1.1 patch-webui_Makefile
--- patches/patch-webui_Makefile 23 Jun 2011 22:50:27 - 1.1
+++ patches/patch-webui_Makefile 30 Jul 2015 17:27:51 -
@@ -1,9 +1,18 @@
$OpenBSD: patch-webui_Makefile,v 1.1 2011/06/23 22:50:27 naddy Exp $
webui/Makefile.orig Tue Jun 21 07:13:47 2011
-+++ webui/Makefile Tue Jun 21 07:14:07 2011
-@@ -13,7 +13,7 @@ CFLAGS+= -pthread -Wall -fpic -static -I/usr/local/inc
+--- webui/Makefile.orig Sat May 26 02:38:57 2007
webui/Makefile Thu Jul 30 19:26:16 2015
+@@ -6,14 +6,15 @@ SRCS= sudoku-handler.c solver.c
+ SUBDIR+=templates
+
+ VPATH+= ..
+-CFLAGS+=-pthread -Wall -fpic -static -I/usr/local/include \
++CFLAGS+=-pthread -Wall -I/usr/local/include \
+ -I/usr/local/include/ClearSilver -I.. -DDEBUG \
+ -DNO_FCGI_DEFINES
+
LDADD+= -L/usr/local/lib -lneo_cgi -lneo_utl -lneo_cs -lpthread
\
-lintl -liconv -lcrypto -lz -lc -lfcgi
++LDSTATIC= ${STATIC}
-BINDIR= /usr/local/libexec
+BINDIR= ${TRUEPREFIX}/libexec
--
Christian naddy Weisgerber na...@mips.inka.de
Re: Fix: games/sudoku-solver
On 2015-07-31, Tobias Ulmer tobi...@tmux.org wrote: But... why not delete the whole thing? It's from mbalmer@, he's not using it any more (at the very least not on OpenBSD) and he even pulled I checked NetBSD pkgsrc hoping I might find a new master site, but he hasn't imported any of his old OpenBSD ports there. his own website and any traces of the source. Why keep it? It's a nice programming exercise, but I doubt anyone uses it. Well, that's the problem. We don't know who uses which ports. I suspect all the old mbalmer ports are cruft that we could remove (after the release), although that might be mistaken as vindicative. Oh, and the compiler warning messages don't exactly inspire strict alignment readyness. I only looked briefly. The 64-bit warnings are harmless. That's the common practice of using a pointer to pass data to callbacks and if the data is just an int, people directly cast it into the pointer. It's widely used with Motif and some other X11 stuff. -- Christian naddy Weisgerber na...@mips.inka.de
Fix: games/sudoku-solver
This removes a spurious -fpic which broke the build on sparc64.
I _think_ the intention of the Makefile is to build the webui
component statically (for copying into chroot?), so I've fixed it
that way. Not sure though if we need or want this.
Index: Makefile
===
RCS file: /cvs/ports/games/sudoku-solver/Makefile,v
retrieving revision 1.19
diff -u -p -r1.19 Makefile
--- Makefile30 Jul 2015 16:05:51 - 1.19
+++ Makefile30 Jul 2015 17:27:51 -
@@ -3,7 +3,7 @@
COMMENT= sudoku puzzle solver with cli, gui, and web ui
DISTNAME= sudoku-solver-1.0.1
-REVISION= 7
+REVISION= 8
CATEGORIES=games www x11
Index: patches/patch-webui_Makefile
===
RCS file: /cvs/ports/games/sudoku-solver/patches/patch-webui_Makefile,v
retrieving revision 1.1
diff -u -p -r1.1 patch-webui_Makefile
--- patches/patch-webui_Makefile23 Jun 2011 22:50:27 - 1.1
+++ patches/patch-webui_Makefile30 Jul 2015 17:27:51 -
@@ -1,9 +1,18 @@
$OpenBSD: patch-webui_Makefile,v 1.1 2011/06/23 22:50:27 naddy Exp $
webui/Makefile.origTue Jun 21 07:13:47 2011
-+++ webui/Makefile Tue Jun 21 07:14:07 2011
-@@ -13,7 +13,7 @@ CFLAGS+= -pthread -Wall -fpic -static -I/usr/local/inc
+--- webui/Makefile.origSat May 26 02:38:57 2007
webui/Makefile Thu Jul 30 19:26:16 2015
+@@ -6,14 +6,15 @@ SRCS=sudoku-handler.c solver.c
+ SUBDIR+= templates
+
+ VPATH+= ..
+-CFLAGS+= -pthread -Wall -fpic -static -I/usr/local/include \
++CFLAGS+= -pthread -Wall -I/usr/local/include \
+ -I/usr/local/include/ClearSilver -I.. -DDEBUG \
+ -DNO_FCGI_DEFINES
+
LDADD+= -L/usr/local/lib -lneo_cgi -lneo_utl -lneo_cs -lpthread
\
-lintl -liconv -lcrypto -lz -lc -lfcgi
++LDSTATIC= ${STATIC}
-BINDIR= /usr/local/libexec
+BINDIR= ${TRUEPREFIX}/libexec
--
Christian naddy Weisgerber na...@mips.inka.de
