Re: KDE desktop icons with wrong permissions

2007-03-01 Thread Andreas Schweitzer
On Wed, Feb 28, 2007 at 09:05:45PM +0100, Matthias Kilian wrote:
> On Wed, Feb 28, 2007 at 10:31:52AM +0100, Andreas Schweitzer wrote:
> > So, unless I did something wrong, the fix would be to either
> > have the files in $PREFIX/share/templates/.source/ user writable
> > or to tell the function in KDE which is responsible for the
> > copying to fix the permissions.
> 
> IMHO, the latter would be preferrable, since user-specific files
> created from templates shouldn't depend on the template's permissions,
> but I'm not (yet) quite sure wether kdelibs (kio/kio/job.cpp,
> CopyJob:copyNextLine(), about line 3463) or the calling code, i.e.
> kdebase (libkonq/knewmenu.cc, KNewMenu::parseFiles(), line 173) or
> even something else would be the correct place to correct it.

OTOH, there are template files in base which have the permissions
they are supposed to have:

$ ls -al /etc/skel/

But either way, from the responses it seems this is indeed a bug
and not a user mistake on my side. So I just submitted a PR.

Cheers,
Andreas



Re: KDE desktop icons with wrong permissions

2007-02-28 Thread Matthias Kilian
On Wed, Feb 28, 2007 at 10:31:52AM +0100, Andreas Schweitzer wrote:
> So, unless I did something wrong, the fix would be to either
> have the files in $PREFIX/share/templates/.source/ user writable
> or to tell the function in KDE which is responsible for the
> copying to fix the permissions.

IMHO, the latter would be preferrable, since user-specific files
created from templates shouldn't depend on the template's permissions,
but I'm not (yet) quite sure wether kdelibs (kio/kio/job.cpp,
CopyJob:copyNextLine(), about line 3463) or the calling code, i.e.
kdebase (libkonq/knewmenu.cc, KNewMenu::parseFiles(), line 173) or
even something else would be the correct place to correct it.

Ciao,
Kili

-- 
Mophobia, n.:
Fear of being verbally abused by a Mississippian.



Re: KDE desktop icons with wrong permissions

2007-02-28 Thread Nikns Siankin
yeah, I noticed this too.
anyone cares?

On Wed, Feb 28, 2007 at 10:31:52AM +0100, Andreas Schweitzer wrote:
>Hi,
>
>I'm not sure if this is a bug or if I did something wrong, so
>this will be a simple post to ports.
>
>The following happened on a 3.9 and a 4.0 system.
>
>I installed kdebase and I can start and use KDE just fine.
>Excpet when I want to create a new shortcut on the desktop
>to e.g. launch a program (let's say firefox). The whizard
>guides me through but fails to correctly save the new
>desktop icon because of incorrect permissions.
>
>And indeed, the new ~/Desktop/firefox.desktop file has
>no write permission. Comparing to the permissions in
>$PREFIX/share/templates/.source/ it seems the new item
>gets copied with all the permissions (including timestamp)
>from there.
>
>So, unless I did something wrong, the fix would be to either
>have the files in $PREFIX/share/templates/.source/ user writable
>or to tell the function in KDE which is responsible for the
>copying to fix the permissions.
>
>The user I tried this with is in the wheel group and I did not
>change any umask settings.
>
>I just downloaded a kdebase snapshot, and at least the permissions
>are still the same. Also, I did not spot any patch in
>http://www.openbsd.org/cgi-bin/cvsweb/ports/x11/kde/base3/patches/
>which could have fixed the copying behaviour.
>
>However, it seems odd that I couldn't find anything related
>to that in the mailing list archives or on google.
>
>Cheers,
>Andreas
>



KDE desktop icons with wrong permissions

2007-02-28 Thread Andreas Schweitzer
Hi,

I'm not sure if this is a bug or if I did something wrong, so
this will be a simple post to ports.

The following happened on a 3.9 and a 4.0 system.

I installed kdebase and I can start and use KDE just fine.
Excpet when I want to create a new shortcut on the desktop
to e.g. launch a program (let's say firefox). The whizard
guides me through but fails to correctly save the new
desktop icon because of incorrect permissions.

And indeed, the new ~/Desktop/firefox.desktop file has
no write permission. Comparing to the permissions in
$PREFIX/share/templates/.source/ it seems the new item
gets copied with all the permissions (including timestamp)
from there.

So, unless I did something wrong, the fix would be to either
have the files in $PREFIX/share/templates/.source/ user writable
or to tell the function in KDE which is responsible for the
copying to fix the permissions.

The user I tried this with is in the wheel group and I did not
change any umask settings.

I just downloaded a kdebase snapshot, and at least the permissions
are still the same. Also, I did not spot any patch in
http://www.openbsd.org/cgi-bin/cvsweb/ports/x11/kde/base3/patches/
which could have fixed the copying behaviour.

However, it seems odd that I couldn't find anything related
to that in the mailing list archives or on google.

Cheers,
Andreas