Re: Kill audio/bmp?

2012-04-15 Thread Edd Barrett
Hi ports,

I have checked which ports depends upon audio/bmp. There is only xmp.
The following diff removes the bmp multipackage from xmp. All we would
need to do after this is remove and unlink audio/bmp.

I have one OK, but I would like another from a senior porter if
possible.

Cheers


Index: Makefile
===
RCS file: /cvs/ports/audio/xmp/Makefile,v
retrieving revision 1.48
diff -u -p -r1.48 Makefile
--- Makefile22 Mar 2012 13:32:55 -  1.48
+++ Makefile15 Apr 2012 15:32:36 -
@@ -3,12 +3,10 @@
 SHARED_ONLY=   Yes
 
 COMMENT-main=  extended module player
-COMMENT-bmp=   extended module player plugin for BMP
 COMMENT-xmms=  extended module player plugin for XMMS
 
 DISTNAME=  xmp-3.5.0
 PKGNAME-main=  ${DISTNAME}
-PKGNAME-bmp=   bmp-${DISTNAME}
 PKGNAME-xmms=  xmms-${DISTNAME}
 CATEGORIES=audio
 
@@ -22,7 +20,7 @@ PERMIT_DISTFILES_FTP= Yes
 
 MASTER_SITES=  ${MASTER_SITE_SOURCEFORGE:=xmp/}
 
-MULTI_PACKAGES=-main -bmp -xmms
+MULTI_PACKAGES=-main -xmms
 
 MODULES=   devel/gettext
 
@@ -35,15 +33,6 @@ LIB_DEPENDS-main=# empty
 RUN_DEPENDS-main=  # empty
 WANTLIB-main=  c m sndio
 
-LIB_DEPENDS-bmp=   audio/bmp
-WANTLIB-bmp=   GL X11 Xcomposite Xcursor Xdamage Xext Xfixes \
-   Xi Xinerama Xrandr Xrender atk-1.0 beep cairo \
-   expat fontconfig freetype gdk-x11-2.0 gdk_pixbuf-2.0 \
-   gio-2.0 glib-2.0 gmodule-2.0 gobject-2.0 gthread-2.0 \
-   gtk-x11-2.0 m pango-1.0 pangocairo-1.0 pangoft2-1.0 \
-   pixman-1 png pthread-stubs xcb xcb-render xcb-shm z \
-   ${MODGETTEXT_WANTLIB}
-
 LIB_DEPENDS-xmms=  audio/xmms
 WANTLIB-xmms=  X11 Xext Xi gdk glib gmodule gtk m xmms 
${MODGETTEXT_WANTLIB}
 
@@ -55,7 +44,6 @@ CONFIGURE_ARGS+=  --disable-alsa \
--disable-esd \
--disable-oss \
--disable-pulseaudio \
-   --enable-bmp-plugin \
--enable-xmms-plugin
 CONFIGURE_ENV= CPPFLAGS=-I${LOCALBASE}/include \
LDFLAGS=-L${LOCALBASE}/lib
Index: pkg/PLIST-bmp
===
RCS file: pkg/PLIST-bmp
diff -N pkg/PLIST-bmp
--- pkg/PLIST-bmp   23 Aug 2010 18:13:58 -  1.2
+++ /dev/null   1 Jan 1970 00:00:00 -
@@ -1,4 +0,0 @@
-@comment $OpenBSD: PLIST-bmp,v 1.2 2010/08/23 18:13:58 jasper Exp $
-lib/bmp/
-lib/bmp/Input/
-lib/bmp/Input/xmp-bmp.so

-- 
Best Regards
Edd Barrett

http://www.theunixzoo.co.uk



Kill audio/bmp?

2012-04-12 Thread Edd Barrett
Does it even work? I have all of the plugins installed and there seems
to be only esound output in the outputs list.

It seems pointless, as it is unmaintained and audacious does everything
better.

Shall we cast it to the flames?

-- 
Best Regards
Edd Barrett

http://www.theunixzoo.co.uk



Re: Kill audio/bmp?

2012-04-12 Thread Brad Smith

On 12/04/12 2:49 PM, Edd Barrett wrote:

Does it even work? I have all of the plugins installed and there seems
to be only esound output in the outputs list.


Yes, it works. That is what is expected.

--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.



Re: Kill audio/bmp?

2012-04-12 Thread David Coppa
On Thu, Apr 12, 2012 at 8:49 PM, Edd Barrett vex...@gmail.com wrote:
 Does it even work? I have all of the plugins installed and there seems
 to be only esound output in the outputs list.

 It seems pointless, as it is unmaintained and audacious does everything
 better.

 Shall we cast it to the flames?

Sure. I agree it just doesn't make sense anymore and we have a handful
of alternatives. But be sure to fix the other ports that use it
(audio/xmp and others i cannot remember atm...) before killing

Ciao
David