Re: NEW: x11/kde-plasma/kpipewire
On Sat Jan 13, 2024 at 02:15:40AM +, Klemens Nanni wrote:
> On Wed, Dec 27, 2023 at 04:55:02PM +0100, Rafael Sadowski wrote:
> > On Wed Dec 27, 2023 at 02:42:20PM +0100, Rafael Sadowski wrote:
> > > Please find attached kpipewire-5.27.10. I have not been able to test it.
> > > I also have no idea how far we are with pipewire. I need it to update
> > > krfb and spectacle. (New dependency since KDE Gear 23.08.x)
> > >
> >
> > and here the mentioned kde ports:
>
> So krfb already uses -DDISABLE_PIPEWIRE=ON and the new version keeps
> building without it. Looks like the r1.15 VERSION pin could have been
> avoided by doing the r1.21 configure switch right away?
>
> If you pull FreeBSD's patch to disable it in spectactle as well, there
> is no need for a new KPipeWire port.
>
> No idea which way is better, just laying out an alternative here.
Thanks for digging so deep. I prefer the KDE build way without patching
it out if there is no impact at run-time.
>
> Both disabled or enabled after import,
> OK kn
>
> > @@ -40,12 +38,12 @@ LIB_DEPENDS = devel/kf5/kauth \
> > devel/kf5/kwallet \
> > devel/kf5/kwidgetsaddons \
> > devel/kf5/kxmlgui \
> > + devel/kf5/kwayland \
>
> Not sorted.
>
> > net/libvncserver \
> > devel/libinotify \
> > + x11/kde-plasma/kpipewire \
> > x11/qt5/qtx11extras
> >
> > CXXFLAGS +=-I${LOCALBASE}/include
> > -
> > -CONFIGURE_ARGS = -DDISABLE_PIPEWIRE=ON
> >
> > .include
>
> [...]
>
> > @@ -38,14 +33,15 @@ LIB_DEPENDS = graphics/kimageannotator>=
> > devel/kf5/ki18n \
> > devel/kf5/kio \
> > devel/kf5/kjobwidgets \
> > - devel/kf5/knewstuff \
> > devel/kf5/knotifications \
> > devel/kf5/kservice \
> > devel/kf5/kwidgetsaddons \
> > devel/kf5/kwindowsystem \
> > devel/kf5/kxmlgui \
> > devel/kf5/purpose \
> > - devel/kf5/kwayland \
> > + devel/kf5/kirigami2 \
> > + x11/qt5/qtquickcontrols2 \
> > + x11/kde-plasma/kpipewire \
>
> Not sorted.
>
> > x11/qt5/qtx11extras
> >
> > post-install:
>
Re: NEW: x11/kde-plasma/kpipewire
On Sat Jan 13, 2024 at 02:00:46AM +, Klemens Nanni wrote: > On Wed, Dec 27, 2023 at 02:42:20PM +0100, Rafael Sadowski wrote: > > Please find attached kpipewire-5.27.10. I have not been able to test it. > > I also have no idea how far we are with pipewire. I need it to update > > krfb and spectacle. (New dependency since KDE Gear 23.08.x) > > https://reviews.freebsd.org/D39978 makes PipeWire optional in spectacle, > the approach looks sane, perhaps that is a viable alternative ( upstream)? Yes I'll check it. I tested all consumers for run-time trouble and could not observe anything. > > OTOH, we have multimedia/pipewire and I assume more (KDE) ports will > require it. > > Also, spectacle uses KPipeWire in src/Platforms/VideoPlatformWayland.cpp > and KPipeWire's DESCR is about video, so my initial concern of lacking a > sndio backend seems to be irrelevant here. > > Do you know of other ports beside the two picking up KPipeWire? I check ArchLinux und FreeBSD. I hope I have them all. > > update-plist zaps a bunch of dirs that initial 'make plist' puts there. I have to re-run update-plist after adding dependencies. Thanks > > OK kn Thanks. > > > > > Comment: > > components relating to pipewire use in Plasma > > > > Required by: > > debug-kpipewire-5.27.10 > > > > Description: > > KPipeWire: offers the main components to connect to and render PipeWire > > KPipeWireRecord: using FFmpeg, helps to record a PipeWire video > > stream into a file. > > > > > > Maintainer: Rafael Sadowski > > > > OK to import? >
Re: NEW: x11/kde-plasma/kpipewire
On Wed, Dec 27, 2023 at 04:55:02PM +0100, Rafael Sadowski wrote:
> On Wed Dec 27, 2023 at 02:42:20PM +0100, Rafael Sadowski wrote:
> > Please find attached kpipewire-5.27.10. I have not been able to test it.
> > I also have no idea how far we are with pipewire. I need it to update
> > krfb and spectacle. (New dependency since KDE Gear 23.08.x)
> >
>
> and here the mentioned kde ports:
So krfb already uses -DDISABLE_PIPEWIRE=ON and the new version keeps
building without it. Looks like the r1.15 VERSION pin could have been
avoided by doing the r1.21 configure switch right away?
If you pull FreeBSD's patch to disable it in spectactle as well, there
is no need for a new KPipeWire port.
No idea which way is better, just laying out an alternative here.
Both disabled or enabled after import,
OK kn
> @@ -40,12 +38,12 @@ LIB_DEPENDS = devel/kf5/kauth \
> devel/kf5/kwallet \
> devel/kf5/kwidgetsaddons \
> devel/kf5/kxmlgui \
> + devel/kf5/kwayland \
Not sorted.
> net/libvncserver \
> devel/libinotify \
> + x11/kde-plasma/kpipewire \
> x11/qt5/qtx11extras
>
> CXXFLAGS += -I${LOCALBASE}/include
> -
> -CONFIGURE_ARGS = -DDISABLE_PIPEWIRE=ON
>
> .include
[...]
> @@ -38,14 +33,15 @@ LIB_DEPENDS = graphics/kimageannotator>=
> devel/kf5/ki18n \
> devel/kf5/kio \
> devel/kf5/kjobwidgets \
> - devel/kf5/knewstuff \
> devel/kf5/knotifications \
> devel/kf5/kservice \
> devel/kf5/kwidgetsaddons \
> devel/kf5/kwindowsystem \
> devel/kf5/kxmlgui \
> devel/kf5/purpose \
> - devel/kf5/kwayland \
> + devel/kf5/kirigami2 \
> + x11/qt5/qtquickcontrols2 \
> + x11/kde-plasma/kpipewire \
Not sorted.
> x11/qt5/qtx11extras
>
> post-install:
Re: NEW: x11/kde-plasma/kpipewire
On Wed, Dec 27, 2023 at 02:42:20PM +0100, Rafael Sadowski wrote: > Please find attached kpipewire-5.27.10. I have not been able to test it. > I also have no idea how far we are with pipewire. I need it to update > krfb and spectacle. (New dependency since KDE Gear 23.08.x) https://reviews.freebsd.org/D39978 makes PipeWire optional in spectacle, the approach looks sane, perhaps that is a viable alternative ( upstream)? OTOH, we have multimedia/pipewire and I assume more (KDE) ports will require it. Also, spectacle uses KPipeWire in src/Platforms/VideoPlatformWayland.cpp and KPipeWire's DESCR is about video, so my initial concern of lacking a sndio backend seems to be irrelevant here. Do you know of other ports beside the two picking up KPipeWire? update-plist zaps a bunch of dirs that initial 'make plist' puts there. OK kn > > Comment: > components relating to pipewire use in Plasma > > Required by: > debug-kpipewire-5.27.10 > > Description: > KPipeWire: offers the main components to connect to and render PipeWire > KPipeWireRecord: using FFmpeg, helps to record a PipeWire video > stream into a file. > > > Maintainer: Rafael Sadowski > > OK to import?
Re: NEW: x11/kde-plasma/kpipewire
On Wed Dec 27, 2023 at 02:42:20PM +0100, Rafael Sadowski wrote: > Please find attached kpipewire-5.27.10. I have not been able to test it. > I also have no idea how far we are with pipewire. I need it to update > krfb and spectacle. (New dependency since KDE Gear 23.08.x) > > Comment: > components relating to pipewire use in Plasma > > Required by: > debug-kpipewire-5.27.10 > > Description: > KPipeWire: offers the main components to connect to and render PipeWire > KPipeWireRecord: using FFmpeg, helps to record a PipeWire video > stream into a file. > > > Maintainer: Rafael Sadowski > > OK to import? Ping
Re: NEW: x11/kde-plasma/kpipewire
On Wed Dec 27, 2023 at 02:42:20PM +0100, Rafael Sadowski wrote:
> Please find attached kpipewire-5.27.10. I have not been able to test it.
> I also have no idea how far we are with pipewire. I need it to update
> krfb and spectacle. (New dependency since KDE Gear 23.08.x)
>
and here the mentioned kde ports:
Index: krfb/Makefile
===
RCS file: /cvs/ports/x11/kde-applications/krfb/Makefile,v
diff -u -p -r1.21 Makefile
--- krfb/Makefile 19 Nov 2023 12:26:58 - 1.21
+++ krfb/Makefile 27 Dec 2023 15:53:50 -
@@ -2,18 +2,16 @@ COMMENT = desktop sharing
DISTNAME = krfb-${VERSION}
CATEGORIES = net x11
-# XXX Depends on KPipeWire (pipewire)
-VERSION = 22.12.3
-REVISION = 3
-
SHARED_LIBS += krfbprivate 3.0 # 5.0
+
WANTLIB += ${COMPILER_LIBCXX} KF5Auth KF5AuthCore KF5Codecs KF5ConfigCore
WANTLIB += KF5ConfigGui KF5ConfigWidgets KF5CoreAddons KF5DBusAddons
-WANTLIB += KF5DNSSD KF5I18n KF5Notifications KF5Wallet KF5WidgetsAddons
-WANTLIB += KF5WindowSystem KF5XmlGui Qt5Core Qt5DBus Qt5Gui Qt5Network
-WANTLIB += Qt5Widgets Qt5X11Extras Qt5Xml X11 Xdamage Xext Xtst
-WANTLIB += c m vncserver xcb xcb-damage xcb-image xcb-render xcb-shape
-WANTLIB += xcb-shm xcb-xfixes
+WANTLIB += KF5DNSSD KF5I18n KF5Notifications KF5Wallet KF5WaylandClient
+WANTLIB += KF5WidgetsAddons KF5WindowSystem KF5XmlGui KPipeWire
+WANTLIB += KPipeWireDmaBuf Qt5Core Qt5DBus Qt5Gui Qt5Network Qt5Widgets
+WANTLIB += Qt5X11Extras Qt5Xml X11 Xdamage Xext Xtst c m vncserver
+WANTLIB += wayland-client xcb xcb-damage xcb-image xcb-render
+WANTLIB += xcb-shape xcb-shm xcb-xfixes
WANTLIB += lib/inotify/inotify
@@ -40,12 +38,12 @@ LIB_DEPENDS = devel/kf5/kauth \
devel/kf5/kwallet \
devel/kf5/kwidgetsaddons \
devel/kf5/kxmlgui \
+ devel/kf5/kwayland \
net/libvncserver \
devel/libinotify \
+ x11/kde-plasma/kpipewire \
x11/qt5/qtx11extras
CXXFLAGS +=-I${LOCALBASE}/include
-
-CONFIGURE_ARGS = -DDISABLE_PIPEWIRE=ON
.include
Index: krfb/distinfo
===
RCS file: /cvs/ports/x11/kde-applications/krfb/distinfo,v
diff -u -p -r1.29 distinfo
--- krfb/distinfo 8 Mar 2023 20:43:34 - 1.29
+++ krfb/distinfo 27 Dec 2023 15:53:50 -
@@ -1,2 +1,2 @@
-SHA256 (kde-applications/krfb-22.12.3.tar.xz) =
3I0muRCfNg0hnFci/NUwCfaXiRuJ39/nLjaAupQxluQ=
-SIZE (kde-applications/krfb-22.12.3.tar.xz) = 1324320
+SHA256 (kde-applications/krfb-23.08.4.tar.xz) =
uxWjAkKMRfgzHSWpFGZ0Q2fLOC1LLvoeiKPMc9rLaYQ=
+SIZE (kde-applications/krfb-23.08.4.tar.xz) = 1322700
Index: krfb/pkg/PLIST
===
RCS file: /cvs/ports/x11/kde-applications/krfb/pkg/PLIST,v
diff -u -p -r1.11 PLIST
--- krfb/pkg/PLIST 18 Dec 2022 09:11:05 - 1.11
+++ krfb/pkg/PLIST 27 Dec 2023 15:53:50 -
@@ -5,7 +5,9 @@
lib/qt5/plugins/krfb/
lib/qt5/plugins/krfb/events/
@so lib/qt5/plugins/krfb/events/x11.so
+@so lib/qt5/plugins/krfb/events/xdp.so
lib/qt5/plugins/krfb/framebuffer/
+@so lib/qt5/plugins/krfb/framebuffer/pw.so
@so lib/qt5/plugins/krfb/framebuffer/qt.so
@so lib/qt5/plugins/krfb/framebuffer/xcb.so
share/applications/org.kde.krfb.desktop
Index: spectacle/Makefile
===
RCS file: /cvs/ports/x11/kde-applications/spectacle/Makefile,v
diff -u -p -r1.32 Makefile
--- spectacle/Makefile 28 Oct 2023 07:47:54 - 1.32
+++ spectacle/Makefile 27 Dec 2023 15:53:50 -
@@ -1,23 +1,20 @@
COMMENT = KDE screen capture and screenshot program
DISTNAME = spectacle-${VERSION}
CATEGORIES = x11
-# XXX Depends on KPipeWire (pipewire)
-VERSION = 22.12.3
-REVISION = 1
HOMEPAGE = https://apps.kde.org/spectacle/
-WANTLIB += ${COMPILER_LIBCXX} KF5Attica KF5Auth KF5AuthCore KF5Codecs
-WANTLIB += KF5Completion KF5ConfigCore KF5ConfigGui KF5ConfigWidgets
-WANTLIB += KF5CoreAddons KF5DBusAddons KF5GlobalAccel KF5GuiAddons
-WANTLIB += KF5I18n KF5JobWidgets KF5KIOCore KF5KIOGui KF5KIOWidgets
-WANTLIB += KF5NewStuff KF5NewStuffCore KF5Notifications KF5Purpose
-WANTLIB += KF5PurposeWidgets KF5Service KF5Solid KF5WaylandClient
-WANTLIB += KF5WidgetsAddons KF5WindowSystem KF5XmlGui Qt5Concurrent
-WANTLIB += Qt5Core Qt5DBus Qt5Gui Qt5Network Qt5PrintSupport Qt5Svg
-WANTLIB += Qt5Widgets Qt5X11Extras Qt5Xml X11 c kImageAnnotator
-WANTLIB += m xcb xcb-cursor xcb-image xcb-render xcb-shape xcb-shm
-WANTLIB += xcb-util xcb-xfixes
+WANTLIB += ${COMPILER_LIBCXX} KF5Auth KF5AuthCore KF5Codecs KF5Completion
+WANTLIB += KF5ConfigCore KF5ConfigGui KF5ConfigWidgets KF5CoreAddons
+WANTLIB += KF5DBusAddons KF5GlobalAccel KF5GuiAddons KF5I18n KF5JobWidgets
+WANTLIB += KF5KIOCore KF5KIOGui KF5KIOWidgets KF5Kirigami2
Re: NEW: x11/kde-plasma/kpipewire
On Wed, Dec 27, 2023 at 02:42:20PM +0100, Rafael Sadowski wrote: > Please find attached kpipewire-5.27.10. I have not been able to test it. > I also have no idea how far we are with pipewire. I need it to update We are nowhere. Someone would need to write sndio support for it. -- Antoine
NEW: x11/kde-plasma/kpipewire
Please find attached kpipewire-5.27.10. I have not been able to test it. I also have no idea how far we are with pipewire. I need it to update krfb and spectacle. (New dependency since KDE Gear 23.08.x) Comment: components relating to pipewire use in Plasma Required by: debug-kpipewire-5.27.10 Description: KPipeWire: offers the main components to connect to and render PipeWire KPipeWireRecord: using FFmpeg, helps to record a PipeWire video stream into a file. Maintainer: Rafael Sadowski OK to import? kpipewire-5.27.10.tar.gz Description: application/tar-gz
