Re: [NEW] lang/mercury
On Sat, Jun 06, 2020 at 07:51:56AM +, niamkik wrote: > Hi everyone, > > Please find in attachment the port for mercury-lang[1] stable version. Here > the package description: > > Mercury is a pure logic programming language intended for the creation > of large, fast, reliable programs. The syntax of Mercury is based on > the syntax of Prolog, but semantically the two languages are very > different due to Mercury's purity, its type, mode, determinism and > module systems. > > This package was tested on OpenBSD-6.6, OpenBSD-6.7 and OpenBSD-current. This > package was initially sent to openbsd-wip on github[2]. > > Regards, > Mathieu > > [1] mercurylang.org/ > [2] https://github.com/jasperla/openbsd-wip/pull/133 Hi Mathieu, A couple issues right off the bat. You don't need a REVISION marker since this would be the initial import. It also looks like 20.01.2 was release on May 3rd. pkg/PLIST seems to be empty, so not sure how this port/pkg would even install anything. You also have CONFIGURE_ENV set CC=egcc but don't depend on ports gcc anywhere. You might want to look into the COMPILER option if you really need to depend on ports gcc.
Re: [NEW] lang/mercury
Hi James, > A couple issues right off the bat. You don't need a REVISION marker > since this would be the initial import. It also looks like 20.01.2 was > release on May 3rd. Yes, I was working on this port in February/March, so, I forgot to check if a new version was available. I corrected it. > pkg/PLIST seems to be empty, so not sure how this port/pkg would even > install anything. You also have CONFIGURE_ENV set CC=egcc but don't > depend on ports gcc anywhere. You might want to look into the COMPILER > option if you really need to depend on ports gcc. It seems I send this port in hurry without checking everything. My bad. I give you the PLIST file generated for the last release (20.01.2). Thanks for the review. mercury.tar.gz Description: application/gzip
Re: [NEW] lang/mercury
On Sun, Jun 07, 2020 at 06:10:13AM +, niamkik wrote: > Hi James, > > > A couple issues right off the bat. You don't need a REVISION marker > > since this would be the initial import. It also looks like 20.01.2 was > > release on May 3rd. > > Yes, I was working on this port in February/March, so, I forgot to check if a > new version was available. I corrected it. > > > pkg/PLIST seems to be empty, so not sure how this port/pkg would even > > install anything. You also have CONFIGURE_ENV set CC=egcc but don't > > depend on ports gcc anywhere. You might want to look into the COMPILER > > option if you really need to depend on ports gcc. > > It seems I send this port in hurry without checking everything. My bad. I > give you the PLIST file generated for the last release (20.01.2). > > Thanks for the review. > Thanks for fixing up the port. Portwise it looks good to me. I'll give it a build this evening. I don't have much experience using ports-gcc so hopefully someone else with who does can chime in.
Re: [NEW] lang/mercury
On 2020/06/07 06:10, niamkik wrote: > Hi James, > > > A couple issues right off the bat. You don't need a REVISION marker > > since this would be the initial import. It also looks like 20.01.2 was > > release on May 3rd. > > Yes, I was working on this port in February/March, so, I forgot to check if a > new version was available. I corrected it. > > > pkg/PLIST seems to be empty, so not sure how this port/pkg would even > > install anything. You also have CONFIGURE_ENV set CC=egcc but don't > > depend on ports gcc anywhere. You might want to look into the COMPILER > > option if you really need to depend on ports gcc. > > It seems I send this port in hurry without checking everything. My bad. I > give you the PLIST file generated for the last release (20.01.2). > > Thanks for the review. > > Why does the port use egcc?
