Re: [update] lang/go 1.0.2

2012-07-04 Thread Stuart Henderson
On 2012/07/04 10:37, Joel Sing wrote:
 On Wednesday 04 July 2012, Juan Francisco Cantero Hurtado wrote:
  On Wed, Jul 04, 2012 at 01:17:00AM +1000, Joel Sing wrote:
   The following diff updates lang/go to Go 1.0.2 - the current stable
   release. Regress passes on both amd64 and i386.
  
   ok?
 
  I can compile the package with USE_SYSTRACE enabled. Without
  USE_SYSTRACE, the package compiles but I haven't tested the regress
  step.
 
 Thanks for catching this - the issue is due to guenther@'s recent changes to 
 the __tfork syscall, which resulted in it getting a new syscall number (the 
 port is still using the older syscall which is now marked as compat and has a 
 different name). This is unrelated to the version update and the existing 
 port will also fail in the same way - I'll fix this in a separate diff.

We could also do this for now, though updating Go to use the
new syscall is better.

Index: systrace.filter
===
RCS file: /cvs/ports/infrastructure/db/systrace.filter,v
retrieving revision 1.34
diff -u -p -r1.34 systrace.filter
--- systrace.filter 30 Jan 2012 16:02:24 -  1.34
+++ systrace.filter 4 Jul 2012 11:19:27 -
@@ -4,6 +4,7 @@
native-__set_tcb: permit
native-__sysctl: permit
native-__tfork: permit
+   native-compat_o51___tfork: permit
native-__threxit: permit
native-__thrsigdivert: permit
native-__thrsleep: permit




Re: [update] lang/go 1.0.2

2012-07-04 Thread Joel Sing
On Wednesday 04 July 2012, Stuart Henderson wrote:
 On 2012/07/04 10:37, Joel Sing wrote:
  On Wednesday 04 July 2012, Juan Francisco Cantero Hurtado wrote:
   On Wed, Jul 04, 2012 at 01:17:00AM +1000, Joel Sing wrote:
The following diff updates lang/go to Go 1.0.2 - the current stable
release. Regress passes on both amd64 and i386.
   
ok?
  
   I can compile the package with USE_SYSTRACE enabled. Without
   USE_SYSTRACE, the package compiles but I haven't tested the regress
   step.
 
  Thanks for catching this - the issue is due to guenther@'s recent changes
  to the __tfork syscall, which resulted in it getting a new syscall number
  (the port is still using the older syscall which is now marked as compat
  and has a different name). This is unrelated to the version update and
  the existing port will also fail in the same way - I'll fix this in a
  separate diff.

 We could also do this for now, though updating Go to use the
 new syscall is better.

As far as I am aware, Go is the only thing in ports that is using the (now) 
old __tfork syscall. I should be able to fix it in the next couple of days, 
otherwise we can run with this.

 Index: systrace.filter
 ===
 RCS file: /cvs/ports/infrastructure/db/systrace.filter,v
 retrieving revision 1.34
 diff -u -p -r1.34 systrace.filter
 --- systrace.filter   30 Jan 2012 16:02:24 -  1.34
 +++ systrace.filter   4 Jul 2012 11:19:27 -
 @@ -4,6 +4,7 @@
   native-__set_tcb: permit
   native-__sysctl: permit
   native-__tfork: permit
 + native-compat_o51___tfork: permit
   native-__threxit: permit
   native-__thrsigdivert: permit
   native-__thrsleep: permit

-- 

Reason is not automatic. Those who deny it cannot be conquered by it.
 Do not count on them. Leave them alone. -- Ayn Rand



Re: [update] lang/go 1.0.2

2012-07-04 Thread Joel Sing
On Wednesday 04 July 2012, Juan Francisco Cantero Hurtado wrote:
 On Wed, Jul 04, 2012 at 10:37:50AM +1000, Joel Sing wrote:
  On Wednesday 04 July 2012, Juan Francisco Cantero Hurtado wrote:
   On Wed, Jul 04, 2012 at 01:17:00AM +1000, Joel Sing wrote:
The following diff updates lang/go to Go 1.0.2 - the current stable
release. Regress passes on both amd64 and i386.
   
ok?
  
   I can compile the package with USE_SYSTRACE enabled. Without
   USE_SYSTRACE, the package compiles but I haven't tested the regress
   step.
 
  Thanks for catching this - the issue is due to guenther@'s recent changes
  to the __tfork syscall, which resulted in it getting a new syscall number
  (the port is still using the older syscall which is now marked as compat
  and has a different name). This is unrelated to the version update and
  the existing port will also fail in the same way - I'll fix this in a
  separate diff.

 OK. Try also the regression test, I've a lot of errors like this
 (without systrace enabled):

 fork/exec /tmp/go-build449254209/unicode/utf8/_test/utf8.test:
 permission denied
 FAILunicode/utf80.001s

That looks like you have /tmp mounted with noexec - I'm guessing that the 
current version of the port fails for you in the same way.
-- 

Reason is not automatic. Those who deny it cannot be conquered by it.
 Do not count on them. Leave them alone. -- Ayn Rand



Re: [update] lang/go 1.0.2

2012-07-04 Thread Stuart Henderson
On 2012/07/05 00:56, Joel Sing wrote:
 On Wednesday 04 July 2012, Juan Francisco Cantero Hurtado wrote:
  On Wed, Jul 04, 2012 at 10:37:50AM +1000, Joel Sing wrote:
   On Wednesday 04 July 2012, Juan Francisco Cantero Hurtado wrote:
On Wed, Jul 04, 2012 at 01:17:00AM +1000, Joel Sing wrote:
 The following diff updates lang/go to Go 1.0.2 - the current stable
 release. Regress passes on both amd64 and i386.

 ok?
   
I can compile the package with USE_SYSTRACE enabled. Without
USE_SYSTRACE, the package compiles but I haven't tested the regress
step.
  
   Thanks for catching this - the issue is due to guenther@'s recent changes
   to the __tfork syscall, which resulted in it getting a new syscall number
   (the port is still using the older syscall which is now marked as compat
   and has a different name). This is unrelated to the version update and
   the existing port will also fail in the same way - I'll fix this in a
   separate diff.
 
  OK. Try also the regression test, I've a lot of errors like this
  (without systrace enabled):
 
  fork/exec /tmp/go-build449254209/unicode/utf8/_test/utf8.test:
  permission denied
  FAILunicode/utf80.001s
 
 That looks like you have /tmp mounted with noexec - I'm guessing that the 
 current version of the port fails for you in the same way.

FWIW my regression tests were clean.



Re: [update] lang/go 1.0.2

2012-07-04 Thread Juan Francisco Cantero Hurtado
On Thu, Jul 05, 2012 at 12:56:20AM +1000, Joel Sing wrote:
  OK. Try also the regression test, I've a lot of errors like this
  (without systrace enabled):
 
  fork/exec /tmp/go-build449254209/unicode/utf8/_test/utf8.test:
  permission denied
  FAILunicode/utf80.001s
 
 That looks like you have /tmp mounted with noexec - I'm guessing that the 
 current version of the port fails for you in the same way.

ALL TESTS PASSED. I forgot the mount options of /tmp.

-- 
Juan Francisco Cantero Hurtado http://juanfra.info



Re: [update] lang/go 1.0.2

2012-07-03 Thread Juan Francisco Cantero Hurtado
On Wed, Jul 04, 2012 at 01:17:00AM +1000, Joel Sing wrote:
 The following diff updates lang/go to Go 1.0.2 - the current stable release.
 Regress passes on both amd64 and i386.
 
 ok?

I can compile the package with USE_SYSTRACE enabled. Without
USE_SYSTRACE, the package compiles but I haven't tested the regress
step.

kern.version=OpenBSD 5.2-beta (GENERIC.MP) #339: Thu Jun 28 01:18:21 MDT
2012
t...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP


pkg/go/parser
pkg/os/exec
pkg/net/url
pkg/text/template/parse
pkg/text/template
pkg/go/doc
pkg/go/build
cmd/go
systrace: deny user: root, prog:
/usr/ports/pobj/go-1.0.2/go/pkg/tool/openbsd_amd64/go_bootstrap, pid:
5391(0)[2197], policy: /usr/bin/make, filters: 242, syscall:
native-compat_o51___tfork(328), args: 8
runtime: failed to create new OS thread (have 1 already; errno=1)
throw: runtime.newosproc

goroutine 1 [syscall]:
syscall.Syscall()
/usr/ports/pobj/go-1.0.2/go/src/pkg/syscall/asm_openbsd_amd64.s:15
+0x5
syscall.Stat(0xf840057c30, 0xf80025, 0xf840078090, 0x0, 0x0,
...)
/usr/local/go/src/pkg/syscall/zsyscall_openbsd_amd64.o:01

goroutine 2 [runnable]:
created by runtime.main
/usr/ports/pobj/go-1.0.2/go/src/pkg/runtime/proc.c:221
*** Error code 2

Stop in /usr/ports/lang/go (line 65 of
Makefile).*** Error code 1

Stop in /usr/ports/lang/go (line 2496 of
/usr/ports/infrastructure/mk/bsd.port.mk).***
Error code 1

Stop in /usr/ports/lang/go (line 1718 of
/usr/ports/infrastructure/mk/bsd.port.mk).***
Error code 1

Stop in /usr/ports/lang/go (line 2265 of
/usr/ports/infrastructure/mk/bsd.port.mk).***
Error code 1

Stop in /usr/ports/lang/go (line 2245 of
/usr/ports/infrastructure/mk/bsd.port.mk).

-- 
Juan Francisco Cantero Hurtado http://juanfra.info



Re: [update] lang/go 1.0.2

2012-07-03 Thread Juan Francisco Cantero Hurtado
On Tue, Jul 03, 2012 at 06:49:56PM +0200, Juan Francisco Cantero Hurtado wrote:
 On Wed, Jul 04, 2012 at 01:17:00AM +1000, Joel Sing wrote:
  The following diff updates lang/go to Go 1.0.2 - the current stable release.
  Regress passes on both amd64 and i386.
  
  ok?
 
 I can compile the package with USE_SYSTRACE enabled.

Sorry, I meant I can't compile the package with USE_SYSTRACE enabled.

-- 
Juan Francisco Cantero Hurtado http://juanfra.info



Re: [update] lang/go 1.0.2

2012-07-03 Thread Joel Sing
On Wednesday 04 July 2012, Juan Francisco Cantero Hurtado wrote:
 On Wed, Jul 04, 2012 at 01:17:00AM +1000, Joel Sing wrote:
  The following diff updates lang/go to Go 1.0.2 - the current stable
  release. Regress passes on both amd64 and i386.
 
  ok?

 I can compile the package with USE_SYSTRACE enabled. Without
 USE_SYSTRACE, the package compiles but I haven't tested the regress
 step.

Thanks for catching this - the issue is due to guenther@'s recent changes to 
the __tfork syscall, which resulted in it getting a new syscall number (the 
port is still using the older syscall which is now marked as compat and has a 
different name). This is unrelated to the version update and the existing 
port will also fail in the same way - I'll fix this in a separate diff.

 kern.version=OpenBSD 5.2-beta (GENERIC.MP) #339: Thu Jun 28 01:18:21 MDT
 2012
 t...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP


 pkg/go/parser
 pkg/os/exec
 pkg/net/url
 pkg/text/template/parse
 pkg/text/template
 pkg/go/doc
 pkg/go/build
 cmd/go
 systrace: deny user: root, prog:
 /usr/ports/pobj/go-1.0.2/go/pkg/tool/openbsd_amd64/go_bootstrap, pid:
 5391(0)[2197], policy: /usr/bin/make, filters: 242, syscall:
 native-compat_o51___tfork(328), args: 8
 runtime: failed to create new OS thread (have 1 already; errno=1)
 throw: runtime.newosproc

 goroutine 1 [syscall]:
 syscall.Syscall()
 /usr/ports/pobj/go-1.0.2/go/src/pkg/syscall/asm_openbsd_amd64.s:15
   +0x5
   syscall.Stat(0xf840057c30, 0xf80025, 0xf840078090, 0x0, 0x0,
   ...)
   /usr/local/go/src/pkg/syscall/zsyscall_openbsd_amd64.o:01

   goroutine 2 [runnable]:
   created by runtime.main
   /usr/ports/pobj/go-1.0.2/go/src/pkg/runtime/proc.c:221
   *** Error code 2

   Stop in /usr/ports/lang/go (line 65 of
   Makefile).*** Error code 1

   Stop in /usr/ports/lang/go (line 2496 of
   /usr/ports/infrastructure/mk/bsd.port.mk).***
   Error code 1

   Stop in /usr/ports/lang/go (line 1718 of
   /usr/ports/infrastructure/mk/bsd.port.mk).***
   Error code 1

   Stop in /usr/ports/lang/go (line 2265 of
   /usr/ports/infrastructure/mk/bsd.port.mk).***
   Error code 1

   Stop in /usr/ports/lang/go (line 2245 of
   /usr/ports/infrastructure/mk/bsd.port.mk).



-- 

Reason is not automatic. Those who deny it cannot be conquered by it.
 Do not count on them. Leave them alone. -- Ayn Rand



Re: [update] lang/go 1.0.2

2012-07-03 Thread Juan Francisco Cantero Hurtado
On Wed, Jul 04, 2012 at 10:37:50AM +1000, Joel Sing wrote:
 On Wednesday 04 July 2012, Juan Francisco Cantero Hurtado wrote:
  On Wed, Jul 04, 2012 at 01:17:00AM +1000, Joel Sing wrote:
   The following diff updates lang/go to Go 1.0.2 - the current stable
   release. Regress passes on both amd64 and i386.
  
   ok?
 
  I can compile the package with USE_SYSTRACE enabled. Without
  USE_SYSTRACE, the package compiles but I haven't tested the regress
  step.
 
 Thanks for catching this - the issue is due to guenther@'s recent changes to 
 the __tfork syscall, which resulted in it getting a new syscall number (the 
 port is still using the older syscall which is now marked as compat and has a 
 different name). This is unrelated to the version update and the existing 
 port will also fail in the same way - I'll fix this in a separate diff.

OK. Try also the regression test, I've a lot of errors like this
(without systrace enabled):

fork/exec /tmp/go-build449254209/unicode/utf8/_test/utf8.test:
permission denied
FAILunicode/utf80.001s

Thanks.

-- 
Juan Francisco Cantero Hurtado http://juanfra.info