Re: [update patch] remind 3.3.5 -> 3.3.6

2021-03-31 Thread Bjorn Ketelaars
On Wed 31/03/2021 10:12, Martin Ziemer wrote:
> This patch updates remind from 3.3.5 to 3.3.6.
> 
> Tested on two amd64 systems. (One cli only, the other with tkremind)

'make test' fails for me:

===>  Regression tests for remind-3.3.6
Remind:  Acceptance test FAILED

Examine the file test.out to see where it differs from the
reference file test.cmp.


Does it work for you?



Re: [update patch] remind 3.3.5 -> 3.3.6

2021-03-31 Thread Martin Ziemer
With the help of Stuart Henderson i have a new diff, which should test
fine on all systems.

Am Wed, Mar 31, 2021 at 01:18:18PM +0100 schrieb Stuart Henderson:
> You can set that in TEST_ENV
> On 2021/03/31 14:15, Martin Ziemer wrote:
> > I found the difference between PASSED and FAILED test:
> > The test passes on systems with LC_ALL set. (My locale is german:
> > de_DE.UTF-8)
> > If i unset LC_ALL, it fails for me too!
> > On Wed, Mar 31, 2021 at 01:34:06PM +0200, Bjorn Ketelaars wrote:
> > > On Wed 31/03/2021 10:12, Martin Ziemer wrote:
> > > > This patch updates remind from 3.3.5 to 3.3.6.
> > > > Tested on two amd64 systems. (One cli only, the other with tkremind)
> > > 'make test' fails for me:
> > > ===>  Regression tests for remind-3.3.6
> > > Remind:  Acceptance test FAILED

Index: Makefile
===
RCS file: /cvs/ports/misc/remind/Makefile,v
retrieving revision 1.44
diff -u -p -r1.44 Makefile
--- Makefile1 Feb 2021 16:20:57 -   1.44
+++ Makefile31 Mar 2021 12:25:50 -
@@ -2,8 +2,8 @@
 
 COMMENT=   scripting language for reminders, with a Tk front end
 
-DISTNAME=  remind-03.03.05
-PKGNAME=   remind-3.3.5
+DISTNAME=  remind-03.03.06
+PKGNAME=   remind-3.3.6
 
 CATEGORIES=misc
 
@@ -17,6 +17,8 @@ PERMIT_PACKAGE=   Yes
 WANTLIB=   c m
 
 MASTER_SITES=  https://dianne.skoll.ca/projects/remind/download/
+
+TEST_ENV=  LC_ALL=en_US.UTF-8
 
 MODULES=   x11/tk
 MODTK_VERSION =8.6
Index: distinfo
===
RCS file: /cvs/ports/misc/remind/distinfo,v
retrieving revision 1.16
diff -u -p -r1.16 distinfo
--- distinfo1 Feb 2021 16:20:57 -   1.16
+++ distinfo31 Mar 2021 12:25:50 -
@@ -1,2 +1,2 @@
-SHA256 (remind-03.03.05.tar.gz) = Ye0X2Gvek/pyaNVxGKL773OWJvC4I6F5nEsRQgzWbsE=
-SIZE (remind-03.03.05.tar.gz) = 402481
+SHA256 (remind-03.03.06.tar.gz) = lpoMAXDJxwODY0/aoo25GRBYWFhE4uf11pR5/ITZX1s=
+SIZE (remind-03.03.06.tar.gz) = 404282



Re: [update patch] remind 3.3.5 -> 3.3.6

2021-03-31 Thread Stuart Henderson
You can set that in TEST_ENV

On 2021/03/31 14:15, Martin Ziemer wrote:
> I found the difference between PASSED and FAILED test:
> The test passes on systems with LC_ALL set. (My locale is german:
> de_DE.UTF-8)
> If i unset LC_ALL, it fails for me too!
> 
> On Wed, Mar 31, 2021 at 01:34:06PM +0200, Bjorn Ketelaars wrote:
> > On Wed 31/03/2021 10:12, Martin Ziemer wrote:
> > > This patch updates remind from 3.3.5 to 3.3.6.
> > > 
> > > Tested on two amd64 systems. (One cli only, the other with tkremind)
> > 
> > 'make test' fails for me:
> > 
> > ===>  Regression tests for remind-3.3.6
> > Remind:  Acceptance test FAILED
> > 
> > Examine the file test.out to see where it differs from the
> > reference file test.cmp.
> > 
> > 
> > Does it work for you?
> 



Re: [update patch] remind 3.3.5 -> 3.3.6

2021-03-31 Thread Martin Ziemer
I found the difference between PASSED and FAILED test:
The test passes on systems with LC_ALL set. (My locale is german:
de_DE.UTF-8)
If i unset LC_ALL, it fails for me too!

On Wed, Mar 31, 2021 at 01:34:06PM +0200, Bjorn Ketelaars wrote:
> On Wed 31/03/2021 10:12, Martin Ziemer wrote:
> > This patch updates remind from 3.3.5 to 3.3.6.
> > 
> > Tested on two amd64 systems. (One cli only, the other with tkremind)
> 
> 'make test' fails for me:
> 
> ===>  Regression tests for remind-3.3.6
> Remind:  Acceptance test FAILED
> 
> Examine the file test.out to see where it differs from the
> reference file test.cmp.
> 
> 
> Does it work for you?



Re: [update patch] remind 3.3.5 -> 3.3.6

2021-03-31 Thread Martin Ziemer
On my system the test passes:
  (22) horrad@dozer:/usr/obj/ports/remind-3.3.6/remind-03.03.06 $ make test 
  Remind:  Acceptance test PASSED

I updated on Monday to this build:
OpenBSD dozer.tda.lan 6.9 GENERIC.MP#433 amd64

My last pkg_add -ui was just today morning.

On Wed, Mar 31, 2021 at 01:34:06PM +0200, Bjorn Ketelaars wrote:
> On Wed 31/03/2021 10:12, Martin Ziemer wrote:
> > This patch updates remind from 3.3.5 to 3.3.6.
> > 
> > Tested on two amd64 systems. (One cli only, the other with tkremind)
> 
> 'make test' fails for me:
> 
> ===>  Regression tests for remind-3.3.6
> Remind:  Acceptance test FAILED
> 
> Examine the file test.out to see where it differs from the
> reference file test.cmp.
> 
> 
> Does it work for you?