Re: NEW: games/vvvvvv - a retro platformer with gravity-reversal puzzle mechanics
Thomas Frohwein writes: > Attached the updated tarball; looking for an okay for this slightly > modified draft as it's been a few years[1]... ok bentley@
Re: NEW: games/vvvvvv - a retro platformer with gravity-reversal puzzle mechanics
Hi, Resurrecting this port draft - it looks like the custom zlib license is a non-issue and I have made small adjustments (removing the RCS markers from the previous version; adding language to README to make it clear that the version has been modified to run on OpenBSD, lowercase of the PKGNAME instead of capital 'VV'). Otherwise proposing the same version of VV again. I looked at updating to the latest upstream version 2.4.1, but that now uses a number of git submodulest in the directory third_party/. Attached the updated tarball; looking for an okay for this slightly modified draft as it's been a few years[1]... [1] https://marc.info/?l=openbsd-ports=163794403416484=2 vv.tgz Description: application/tar-gz
Re: NEW: games/vvvvvv - a retro platformer with gravity-reversal puzzle mechanics
On Fri, Oct 29, 2021 at 06:47:20PM -0600, Thomas Frohwein wrote: > On Mon, Oct 18, 2021 at 09:26:59AM -0600, Thomas Frohwein wrote: > > On Sat, Oct 09, 2021 at 04:57:56PM +0200, Stefan Hagen wrote: > > [...] > > > > My read of the license is that it's zlib license with an addition > > > > limiting it to non-commercial use. As there's no CD-ROMs anymore, I > > > > don't think that matters for packaging the port. > > > > > > > > Here is the license for review: > > > > > > > > https://raw.githubusercontent.com/TerryCavanagh/VV/master/LICENSE.md > > > > > > After reading the license, I believe as well that we're good to > > > redistribute it. > > > > Thanks, I appreciate the look. Could I get another set of porter eyes > > and ok before I commit this with PERMIT_PACKAGE=Yes? > > *ping* *ping* It's only the decision about the license that needs some more input to make sure it's good to permit the package. > > > However, this part may apply: > > > > > > - Altered source/binary versions must be plainly marked as such, and > > > must not be misrepresented as being the original software. > > > > > > Once there is a patch, the software is altered. Maybe a single sentence > > > in the README about this would cover it. > > > > > > "This version of VV has been changed to run on OpenBSD." > > > > This is part of the standard zlib license [1]. As far as I know, we > > don't do this for any of the other zlib-licensed ports. There are many, > > among others are minizip, sdl*, optipng, sfml, tinyxml, and irrlicht. I > > would say the assumption is that it being in ports with a patches/ > > directory is marking it clearly enough... > > > > [1] https://opensource.org/licenses/Zlib > > >
Re: NEW: games/vvvvvv - a retro platformer with gravity-reversal puzzle mechanics
On Mon, Oct 18, 2021 at 09:26:59AM -0600, Thomas Frohwein wrote: > On Sat, Oct 09, 2021 at 04:57:56PM +0200, Stefan Hagen wrote: > [...] > > > My read of the license is that it's zlib license with an addition > > > limiting it to non-commercial use. As there's no CD-ROMs anymore, I > > > don't think that matters for packaging the port. > > > > > > Here is the license for review: > > > > > > https://raw.githubusercontent.com/TerryCavanagh/VV/master/LICENSE.md > > > > After reading the license, I believe as well that we're good to > > redistribute it. > > Thanks, I appreciate the look. Could I get another set of porter eyes > and ok before I commit this with PERMIT_PACKAGE=Yes? *ping* > > However, this part may apply: > > > > - Altered source/binary versions must be plainly marked as such, and > > must not be misrepresented as being the original software. > > > > Once there is a patch, the software is altered. Maybe a single sentence > > in the README about this would cover it. > > > > "This version of VV has been changed to run on OpenBSD." > > This is part of the standard zlib license [1]. As far as I know, we > don't do this for any of the other zlib-licensed ports. There are many, > among others are minizip, sdl*, optipng, sfml, tinyxml, and irrlicht. I > would say the assumption is that it being in ports with a patches/ > directory is marking it clearly enough... > > [1] https://opensource.org/licenses/Zlib >
Re: NEW: games/vvvvvv - a retro platformer with gravity-reversal puzzle mechanics
On Sat, Oct 09, 2021 at 04:57:56PM +0200, Stefan Hagen wrote: [...] > > My read of the license is that it's zlib license with an addition > > limiting it to non-commercial use. As there's no CD-ROMs anymore, I > > don't think that matters for packaging the port. > > > > Here is the license for review: > > > > https://raw.githubusercontent.com/TerryCavanagh/VV/master/LICENSE.md > > After reading the license, I believe as well that we're good to > redistribute it. Thanks, I appreciate the look. Could I get another set of porter eyes and ok before I commit this with PERMIT_PACKAGE=Yes? > However, this part may apply: > > - Altered source/binary versions must be plainly marked as such, and > must not be misrepresented as being the original software. > > Once there is a patch, the software is altered. Maybe a single sentence > in the README about this would cover it. > > "This version of VV has been changed to run on OpenBSD." This is part of the standard zlib license [1]. As far as I know, we don't do this for any of the other zlib-licensed ports. There are many, among others are minizip, sdl*, optipng, sfml, tinyxml, and irrlicht. I would say the assumption is that it being in ports with a patches/ directory is marking it clearly enough... [1] https://opensource.org/licenses/Zlib
Re: NEW: games/vvvvvv - a retro platformer with gravity-reversal puzzle mechanics
Thomas Frohwein wrote: > On Tue, Oct 05, 2021 at 03:39:55PM +, Charlene Wendling wrote: > [...] > > OK cwen@ port-wise; it would be nice if someone is OK with the > > licensing terms though. > > My read of the license is that it's zlib license with an addition > limiting it to non-commercial use. As there's no CD-ROMs anymore, I > don't think that matters for packaging the port. > > Here is the license for review: > > https://raw.githubusercontent.com/TerryCavanagh/VV/master/LICENSE.md After reading the license, I believe as well that we're good to redistribute it. However, this part may apply: - Altered source/binary versions must be plainly marked as such, and must not be misrepresented as being the original software. Once there is a patch, the software is altered. Maybe a single sentence in the README about this would cover it. "This version of VV has been changed to run on OpenBSD." Best regards, Stefan
Re: NEW: games/vvvvvv - a retro platformer with gravity-reversal puzzle mechanics
On Tue, Oct 05, 2021 at 03:39:55PM +, Charlene Wendling wrote: [...] > OK cwen@ port-wise; it would be nice if someone is OK with the > licensing terms though. My read of the license is that it's zlib license with an addition limiting it to non-commercial use. As there's no CD-ROMs anymore, I don't think that matters for packaging the port. Here is the license for review: https://raw.githubusercontent.com/TerryCavanagh/VV/master/LICENSE.md
Re: NEW: games/vvvvvv - a retro platformer with gravity-reversal puzzle mechanics
On Mon, 4 Oct 2021 23:55:06 -0600
Thomas Frohwein wrote:
> On Mon, Oct 04, 2021 at 07:32:56PM +, Charlene Wendling wrote:
> > Hi,
> >
> >
> > > There is an existing port draft by bcallah@ and cwen@ in
> > > openbsd-wip [2]. I've graciously adopted the patches to the
> > > bundled physfs for big endian compatibility and to use
> > > ~/.local/share/VV/ for the assets file data.zip.
> >
> > Actually, that patch may not be needed, because VV does not
> > support big endian archs [0], as i've found out later. Yet i've
> > built your port on macppc, and indeed colors are off, most sprites
> > are not displayed, so i think it needs a 'NOT_FOR_ARCHS=$
> > {BE_ARCHS}' at least.
> >
> > > Some comments on where I diverge from the version in openbsd-wip:
> > > [...]
> > > - Compiles with std=c++98, so looks to me like base-gcc can be
> > > included in COMPILER...
> >
> > Due to [0], it won't be built on sparc64, the last GCC arch
> > we build packages for, so i think the COMPILER line can safely be
> > removed.
> >
> > > [...]
> >
> > Charlène.
> >
> > [0] https://github.com/TerryCavanagh/VV/pull/461
> >
>
> Thanks, that makes sense. I added the NOT_FOR_ARCHS and removed the
> patch.
>
> I left the COMPILER line with the comment as it's C++, in case that
> will be relevant in the future. I think if there's a decision at some
> point that this isn't needed with sparc64 in NOT_FOR_ARCHS, it can be
> addressed then IMO. (Comments welcome on what direction this topic is
> going...)
>
> I've added an updated tarball; I tested it again with the free assets
> and still works. ok?
OK cwen@ port-wise; it would be nice if someone is OK with the
licensing terms though.
Re: NEW: games/vvvvvv - a retro platformer with gravity-reversal puzzle mechanics
On Mon, Oct 04, 2021 at 07:32:56PM +, Charlene Wendling wrote:
> Hi,
>
>
> > There is an existing port draft by bcallah@ and cwen@ in openbsd-wip
> > [2]. I've graciously adopted the patches to the bundled physfs for
> > big endian compatibility and to use ~/.local/share/VV/ for the
> > assets file data.zip.
>
> Actually, that patch may not be needed, because VV does not support
> big endian archs [0], as i've found out later. Yet i've built your port
> on macppc, and indeed colors are off, most sprites are not displayed, so
> i think it needs a 'NOT_FOR_ARCHS=${BE_ARCHS}' at least.
>
> > Some comments on where I diverge from the version in openbsd-wip:
> > [...]
> > - Compiles with std=c++98, so looks to me like base-gcc can be
> > included in COMPILER...
>
> Due to [0], it won't be built on sparc64, the last GCC arch
> we build packages for, so i think the COMPILER line can safely be
> removed.
>
> > [...]
>
> Charlène.
>
> [0] https://github.com/TerryCavanagh/VV/pull/461
>
Thanks, that makes sense. I added the NOT_FOR_ARCHS and removed the
patch.
I left the COMPILER line with the comment as it's C++, in case that
will be relevant in the future. I think if there's a decision at some
point that this isn't needed with sparc64 in NOT_FOR_ARCHS, it can be
addressed then IMO. (Comments welcome on what direction this topic is
going...)
I've added an updated tarball; I tested it again with the free assets
and still works. ok?
vv.tgz
Description: Binary data
Re: NEW: games/vvvvvv - a retro platformer with gravity-reversal puzzle mechanics
Hi,
> There is an existing port draft by bcallah@ and cwen@ in openbsd-wip
> [2]. I've graciously adopted the patches to the bundled physfs for
> big endian compatibility and to use ~/.local/share/VV/ for the
> assets file data.zip.
Actually, that patch may not be needed, because VV does not support
big endian archs [0], as i've found out later. Yet i've built your port
on macppc, and indeed colors are off, most sprites are not displayed, so
i think it needs a 'NOT_FOR_ARCHS=${BE_ARCHS}' at least.
> Some comments on where I diverge from the version in openbsd-wip:
> [...]
> - Compiles with std=c++98, so looks to me like base-gcc can be
> included in COMPILER...
Due to [0], it won't be built on sparc64, the last GCC arch
we build packages for, so i think the COMPILER line can safely be
removed.
> [...]
Charlène.
[0] https://github.com/TerryCavanagh/VV/pull/461
