Re: hellanzb broken on current (amd64)

2011-12-27 Thread Eric Faurot
On Tue, Dec 27, 2011 at 07:40:20PM +0100, Didier Wiroth wrote:
> Hello,
> Thank you all for helping!
> No, unfortunately it didn't help, it still crashes.
> I applied the patch and recompile the hellanzb port, but it still crashes.

Oops. This should be better.

Eric.

Index: Makefile
===
RCS file: /cvs/ports/news/hellanzb/Makefile,v
retrieving revision 1.11
diff -u -p -r1.11 Makefile
--- Makefile16 Sep 2011 11:13:41 -  1.11
+++ Makefile27 Dec 2011 19:54:12 -
@@ -3,7 +3,7 @@
 COMMENT=   retrieve and process nzb-files
 
 DISTNAME=  hellanzb-0.13
-REVISION = 7
+REVISION = 8
 CATEGORIES=news
 
 HOMEPAGE=  http://www.hellanzb.com/trac/
Index: patches/patch-Hellanzb_HellaReactor_py
===
RCS file: /cvs/ports/news/hellanzb/patches/patch-Hellanzb_HellaReactor_py,v
retrieving revision 1.1
diff -u -p -r1.1 patch-Hellanzb_HellaReactor_py
--- patches/patch-Hellanzb_HellaReactor_py  23 Aug 2010 07:02:06 -  
1.1
+++ patches/patch-Hellanzb_HellaReactor_py  27 Dec 2011 19:54:12 -
@@ -1,12 +1,16 @@
 $OpenBSD: patch-Hellanzb_HellaReactor_py,v 1.1 2010/08/23 07:02:06 giovanni 
Exp $
 Hellanzb/HellaReactor.py.orig  Fri Aug 13 17:17:25 2010
-+++ Hellanzb/HellaReactor.py   Fri Aug 13 17:17:38 2010
-@@ -9,7 +9,7 @@ reactor system so it can catch signals, and shutdown h
+--- Hellanzb/HellaReactor.py.orig  Tue Mar 27 06:20:43 2007
 Hellanzb/HellaReactor.py   Tue Dec 27 20:53:16 2011
+@@ -9,7 +9,11 @@ reactor system so it can catch signals, and shutdown h
  import Hellanzb, sys, time
  
  import twisted.copyright
 -if twisted.copyright.version >= '2.0.0':
-+if twisted.copyright.version >= '2.0.0' or twisted.copyright.version >= 
'10.0.0':
++if twisted.copyright.version >= '11.1.0':
++from twisted.internet.selectreactor import SelectReactor
++from twisted.internet.posixbase import _NO_FILENO
++from twisted.internet.posixbase import _NO_FILEDESC
++elif twisted.copyright.version >= '2.0.0' or twisted.copyright.version >= 
'10.0.0':
  from twisted.internet.selectreactor import SelectReactor
  from twisted.internet.selectreactor import _NO_FILENO
  from twisted.internet.selectreactor import _NO_FILEDESC



Re: hellanzb broken on current (amd64)

2011-12-27 Thread Didier Wiroth

Hello,
Thank you all for helping!
No, unfortunately it didn't help, it still crashes.
I applied the patch and recompile the hellanzb port, but it still crashes.
$ hellanzb.py
Traceback (most recent call last):
  File "/usr/local/bin/hellanzb.py", line 14, in 
from Hellanzb.Core import main
  File "/usr/local/lib/python2.7/site-packages/Hellanzb/Core.py", line 
9, in 
from Hellanzb.HellaReactor import HellaReactor
  File 
"/usr/local/lib/python2.7/site-packages/Hellanzb/HellaReactor.py", line 1

from twisted.internet.selectreactor import _NO_FILENO
ImportError: cannot import name _NO_FILENO

your help is greatly appreciated.
kind regards,
didier

On 27/12/2011 18:06, Eric Faurot wrote:

On Tue, Dec 27, 2011 at 04:36:41PM +0100, Didier Wiroth wrote:

hello,
running latest current amd64 (build 23.12.2011).
sorry I'm not programmer so I can't provide a patch but I thought I
let you know that hellanzb is broken on current (at least on amd64):
$ hellanzb.py
Traceback (most recent call last):
   File "/usr/local/bin/hellanzb.py", line 14, in
 from Hellanzb.Core import main
   File "/usr/local/lib/python2.7/site-packages/Hellanzb/Core.py", line
9, in
 from Hellanzb.HellaReactor import HellaReactor
   File "/usr/local/lib/python2.7/site-packages/Hellanzb/HellaReactor.py",
line 14, in
 from twisted.internet.selectreactor import _NO_FILENO
ImportError: cannot import name _NO_FILENO

kind regards,
d.


This should fix the issue.  Could you please give it a try?
Thanks.

Eric.

Index: Makefile
===
RCS file: /cvs/ports/news/hellanzb/Makefile,v
retrieving revision 1.11
diff -u -p -r1.11 Makefile
--- Makefile16 Sep 2011 11:13:41 -  1.11
+++ Makefile27 Dec 2011 16:56:46 -
@@ -3,7 +3,7 @@
  COMMENT=  retrieve and process nzb-files

  DISTNAME= hellanzb-0.13
-REVISION = 7
+REVISION = 8
  CATEGORIES=   news

  HOMEPAGE= http://www.hellanzb.com/trac/
Index: patches/patch-Hellanzb_HellaReactor_py
===
RCS file: /cvs/ports/news/hellanzb/patches/patch-Hellanzb_HellaReactor_py,v
retrieving revision 1.1
diff -u -p -r1.1 patch-Hellanzb_HellaReactor_py
--- patches/patch-Hellanzb_HellaReactor_py  23 Aug 2010 07:02:06 -  
1.1
+++ patches/patch-Hellanzb_HellaReactor_py  27 Dec 2011 16:56:46 -
@@ -1,11 +1,15 @@
  $OpenBSD: patch-Hellanzb_HellaReactor_py,v 1.1 2010/08/23 07:02:06 giovanni 
Exp $
 Hellanzb/HellaReactor.py.orig  Fri Aug 13 17:17:25 2010
-+++ Hellanzb/HellaReactor.py   Fri Aug 13 17:17:38 2010
-@@ -9,7 +9,7 @@ reactor system so it can catch signals, and shutdown h
+--- Hellanzb/HellaReactor.py.orig  Tue Mar 27 06:20:43 2007
 Hellanzb/HellaReactor.py   Tue Dec 27 17:55:22 2011
+@@ -9,7 +9,11 @@ reactor system so it can catch signals, and shutdown h
   import Hellanzb, sys, time

   import twisted.copyright
  -if twisted.copyright.version>= '2.0.0':
++if twisted.copyright.version>= '11.1.0':
++from twisted.internet.selectreactor import SelectReactor
++from twisted.internet.posixbase import _NO_FILENO
++from twisted.internet.posixbase import _NO_FILEDESC
  +if twisted.copyright.version>= '2.0.0' or twisted.copyright.version>= 
'10.0.0':
   from twisted.internet.selectreactor import SelectReactor
   from twisted.internet.selectreactor import _NO_FILENO




Re: hellanzb broken on current (amd64)

2011-12-27 Thread Eric Faurot
On Tue, Dec 27, 2011 at 04:36:41PM +0100, Didier Wiroth wrote:
> hello,
> running latest current amd64 (build 23.12.2011).
> sorry I'm not programmer so I can't provide a patch but I thought I
> let you know that hellanzb is broken on current (at least on amd64):
> $ hellanzb.py
> Traceback (most recent call last):
>   File "/usr/local/bin/hellanzb.py", line 14, in 
> from Hellanzb.Core import main
>   File "/usr/local/lib/python2.7/site-packages/Hellanzb/Core.py", line
> 9, in 
> from Hellanzb.HellaReactor import HellaReactor
>   File "/usr/local/lib/python2.7/site-packages/Hellanzb/HellaReactor.py",
> line 14, in 
> from twisted.internet.selectreactor import _NO_FILENO
> ImportError: cannot import name _NO_FILENO
> 
> kind regards,
> d.

This should fix the issue.  Could you please give it a try?
Thanks.

Eric.

Index: Makefile
===
RCS file: /cvs/ports/news/hellanzb/Makefile,v
retrieving revision 1.11
diff -u -p -r1.11 Makefile
--- Makefile16 Sep 2011 11:13:41 -  1.11
+++ Makefile27 Dec 2011 16:56:46 -
@@ -3,7 +3,7 @@
 COMMENT=   retrieve and process nzb-files
 
 DISTNAME=  hellanzb-0.13
-REVISION = 7
+REVISION = 8
 CATEGORIES=news
 
 HOMEPAGE=  http://www.hellanzb.com/trac/
Index: patches/patch-Hellanzb_HellaReactor_py
===
RCS file: /cvs/ports/news/hellanzb/patches/patch-Hellanzb_HellaReactor_py,v
retrieving revision 1.1
diff -u -p -r1.1 patch-Hellanzb_HellaReactor_py
--- patches/patch-Hellanzb_HellaReactor_py  23 Aug 2010 07:02:06 -  
1.1
+++ patches/patch-Hellanzb_HellaReactor_py  27 Dec 2011 16:56:46 -
@@ -1,11 +1,15 @@
 $OpenBSD: patch-Hellanzb_HellaReactor_py,v 1.1 2010/08/23 07:02:06 giovanni 
Exp $
 Hellanzb/HellaReactor.py.orig  Fri Aug 13 17:17:25 2010
-+++ Hellanzb/HellaReactor.py   Fri Aug 13 17:17:38 2010
-@@ -9,7 +9,7 @@ reactor system so it can catch signals, and shutdown h
+--- Hellanzb/HellaReactor.py.orig  Tue Mar 27 06:20:43 2007
 Hellanzb/HellaReactor.py   Tue Dec 27 17:55:22 2011
+@@ -9,7 +9,11 @@ reactor system so it can catch signals, and shutdown h
  import Hellanzb, sys, time
  
  import twisted.copyright
 -if twisted.copyright.version >= '2.0.0':
++if twisted.copyright.version >= '11.1.0':
++from twisted.internet.selectreactor import SelectReactor
++from twisted.internet.posixbase import _NO_FILENO
++from twisted.internet.posixbase import _NO_FILEDESC
 +if twisted.copyright.version >= '2.0.0' or twisted.copyright.version >= 
'10.0.0':
  from twisted.internet.selectreactor import SelectReactor
  from twisted.internet.selectreactor import _NO_FILENO



Re: hellanzb broken on current (amd64)

2011-12-27 Thread Eric Faurot
On Tue, Dec 27, 2011 at 04:53:55PM +0100, David Coppa wrote:
> 
> It's a known bug caused by newer twisted:
> 
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=573221
> 
> http://pastie.org/877271
> 
> http://pastie.org/877281
> 
> Cheers!
> David

I'll post a fix asap.

Eric.



Re: hellanzb broken on current (amd64)

2011-12-27 Thread David Coppa
On Tue, Dec 27, 2011 at 4:36 PM, Didier Wiroth  wrote:
> hello,
> running latest current amd64 (build 23.12.2011).
> sorry I'm not programmer so I can't provide a patch but I thought I
> let you know that hellanzb is broken on current (at least on amd64):
> $ hellanzb.py
> Traceback (most recent call last):
>  File "/usr/local/bin/hellanzb.py", line 14, in 
>    from Hellanzb.Core import main
>  File "/usr/local/lib/python2.7/site-packages/Hellanzb/Core.py", line
> 9, in 
>    from Hellanzb.HellaReactor import HellaReactor
>  File "/usr/local/lib/python2.7/site-packages/Hellanzb/HellaReactor.py",
> line 14, in 
>    from twisted.internet.selectreactor import _NO_FILENO
> ImportError: cannot import name _NO_FILENO
>
> kind regards,
> d.

It's a known bug caused by newer twisted:

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=573221

http://pastie.org/877271

http://pastie.org/877281

Cheers!
David