Re: nsh1.1 update diff attached
On 2023/03/13 00:44, Tom Smyth wrote: > Folks, > please find attached, update for nsh to nsh1.1-20230312 > I would like to give a big thanks to Chris Cappuccio, Stefan Sperling, > Justin Donoghue and Kurt Mosiejczuk for all their time, expertise and > work to help. Updating to newer code makes sense. Would it be worth tagging it upstream so we don't need to use GH_COMMIT and the date in DISTNAME? > the attached CVS diff updates the port with the upstream release, > Changes since last time > Chris and Stefan have made a number of improvements to nsh since the last > update > > 1) dhcpleased support > 2) slaacd support > 3) resolvd support > 4) ndp control support > 5) improved arp control on interfaces > 6) improved bridge/ veb feature support > 7) improved diagnostics commands > show arp > show ndp > show bridge > show interface status > 8) improved integration scripts > 9) improved reduced default configuration on new sysctls (to omit > default settings on OpenBSD sysctls) > 10) improved arp control on interfaces (arp on, static arp, ) > 11) improved usability and alignment with other industry CLIs with the > keyword "exit" used to exit interface configuration modes > > > 12) nsh.8 manual page updated to include the new features, improved > cross referencing > etc. > > further updates to nsh.8 possible but I wanted make sure at least > this diff makes the cut before ports freeze ... > > a big shout out to Justin who helped identify where we could improve > the show commands / diagnostic commands based on his use of other > networking platforms. > > -- > Kindest regards, > Tom Smyth.
Re: nsh1.1 update diff attached
Hi Stuart ill have a look at this... and see what can be done on GH with Stefan and Chris Thanks On Mon 13 Mar 2023, 11:09 Stuart Henderson, wrote: > On 2023/03/13 00:44, Tom Smyth wrote: > > Folks, > > please find attached, update for nsh to nsh1.1-20230312 > > I would like to give a big thanks to Chris Cappuccio, Stefan Sperling, > > Justin Donoghue and Kurt Mosiejczuk for all their time, expertise and > > work to help. > > Updating to newer code makes sense. Would it be worth tagging it > upstream so we don't need to use GH_COMMIT and the date in DISTNAME? > > > the attached CVS diff updates the port with the upstream release, > > Changes since last time > > Chris and Stefan have made a number of improvements to nsh since the > last update > > > > 1) dhcpleased support > > 2) slaacd support > > 3) resolvd support > > 4) ndp control support > > 5) improved arp control on interfaces > > 6) improved bridge/ veb feature support > > 7) improved diagnostics commands > > show arp > > show ndp > > show bridge > > show interface status > > 8) improved integration scripts > > 9) improved reduced default configuration on new sysctls (to omit > > default settings on OpenBSD sysctls) > > 10) improved arp control on interfaces (arp on, static arp, ) > > 11) improved usability and alignment with other industry CLIs with the > > keyword "exit" used to exit interface configuration modes > > > > > > 12) nsh.8 manual page updated to include the new features, improved > > cross referencing > > etc. > > > > further updates to nsh.8 possible but I wanted make sure at least > > this diff makes the cut before ports freeze ... > > > > a big shout out to Justin who helped identify where we could improve > > the show commands / diagnostic commands based on his use of other > > networking platforms. > > > > -- > > Kindest regards, > > Tom Smyth. > > >
Re: nsh1.1 update diff attached
On 2023/03/13 12:12, Tom Smyth wrote: > Hi Stuart > ill have a look at this... and see what can be done on GH This or similar to tag the current state of the tree as v1.1 git tag -a v1.1 -m "Release version v1.1" git push origin v1.1 Or if e.g. there was another commit upstream and you want to tag the older commit as v1.1: git tag -a v1.1 5d9dbeb4e -m "Release version v1.1" (and push) Then for the port you can remove DISTNAME and set GH_TAGNAME = v1.1 instead. > with Stefan and Chris > > Thanks > > On Mon 13 Mar 2023, 11:09 Stuart Henderson, wrote: > > > On 2023/03/13 00:44, Tom Smyth wrote: > > > Folks, > > > please find attached, update for nsh to nsh1.1-20230312 > > > I would like to give a big thanks to Chris Cappuccio, Stefan Sperling, > > > Justin Donoghue and Kurt Mosiejczuk for all their time, expertise and > > > work to help. > > > > Updating to newer code makes sense. Would it be worth tagging it > > upstream so we don't need to use GH_COMMIT and the date in DISTNAME? > > > > > the attached CVS diff updates the port with the upstream release, > > > Changes since last time > > > Chris and Stefan have made a number of improvements to nsh since the > > last update > > > > > > 1) dhcpleased support > > > 2) slaacd support > > > 3) resolvd support > > > 4) ndp control support > > > 5) improved arp control on interfaces > > > 6) improved bridge/ veb feature support > > > 7) improved diagnostics commands > > > show arp > > > show ndp > > > show bridge > > > show interface status > > > 8) improved integration scripts > > > 9) improved reduced default configuration on new sysctls (to omit > > > default settings on OpenBSD sysctls) > > > 10) improved arp control on interfaces (arp on, static arp, ) > > > 11) improved usability and alignment with other industry CLIs with the > > > keyword "exit" used to exit interface configuration modes > > > > > > > > > 12) nsh.8 manual page updated to include the new features, improved > > > cross referencing > > > etc. > > > > > > further updates to nsh.8 possible but I wanted make sure at least > > > this diff makes the cut before ports freeze ... > > > > > > a big shout out to Justin who helped identify where we could improve > > > the show commands / diagnostic commands based on his use of other > > > networking platforms. > > > > > > -- > > > Kindest regards, > > > Tom Smyth. > > > > > >
Re: nsh1.1 update diff attached
Folks, Please find attached diff which updates the nsh port to the latest release of nsh 1.1 on github I would like to give a big thanks to Chris Cappuccio, Stefan Sperling, my colleagues, Justin Donoghue, Alan McGrath & Scott Mc Donnell from my Alma Mater DCU who worked on this as part of their university work placement. a big shout out to Ingo@ who patiently guided me on mandoc and manual page writing. and last but not least Stuart and Kurt Mosiejczuk for all their time, expertise and work and patience to get me started on ports. It was a pleasure to help document some of the output of the above people's effort and indeed the wider OpenBSD Community for their contributions to the OpenBSD network stack over the years... the attached CVS diff updates the port with the upstream release v1.1 Changes since last time Chris and Stefan have made a number of improvements to nsh since the last update 1) dhcpleased support 2) slaacd support 3) resolvd support 4) ndp control support 5) improved arp control on interfaces 6) improved bridge/ veb feature support such as protected ports etc... 7) improved diagnostics commands show arp show ndp show bridge show interface status 8) improved integration scripts 9) improved reduced default configuration on new sysctls (to omit default settings on OpenBSD sysctls) 10) improved arp control on interfaces (arp on, static arp, ) 11) improved usability and alignment with other industry CLIs with the keyword "exit" used to exit interface configuration modes 12) nsh.8 manual page updated to include the new features, improved cross referencing feedback ,comments, ideas, testers contributors welcome... Thanks again, Tom Smyth On Mon, 13 Mar 2023 at 12:34, Stuart Henderson wrote: > > On 2023/03/13 12:12, Tom Smyth wrote: > > Hi Stuart > > ill have a look at this... and see what can be done on GH > > This or similar to tag the current state of the tree as v1.1 > > git tag -a v1.1 -m "Release version v1.1" > git push origin v1.1 > > Or if e.g. there was another commit upstream and you want to tag the > older commit as v1.1: > > git tag -a v1.1 5d9dbeb4e -m "Release version v1.1" > (and push) > > Then for the port you can remove DISTNAME and set GH_TAGNAME = v1.1 > instead. > > > with Stefan and Chris > > > > Thanks > > > > On Mon 13 Mar 2023, 11:09 Stuart Henderson, wrote: > > > > > On 2023/03/13 00:44, Tom Smyth wrote: > > > > Folks, > > > > please find attached, update for nsh to nsh1.1-20230312 > > > > I would like to give a big thanks to Chris Cappuccio, Stefan Sperling, > > > > Justin Donoghue and Kurt Mosiejczuk for all their time, expertise and > > > > work to help. > > > > > > Updating to newer code makes sense. Would it be worth tagging it > > > upstream so we don't need to use GH_COMMIT and the date in DISTNAME? > > > > > > > the attached CVS diff updates the port with the upstream release, > > > > Changes since last time > > > > Chris and Stefan have made a number of improvements to nsh since the > > > last update > > > > > > > > 1) dhcpleased support > > > > 2) slaacd support > > > > 3) resolvd support > > > > 4) ndp control support > > > > 5) improved arp control on interfaces > > > > 6) improved bridge/ veb feature support > > > > 7) improved diagnostics commands > > > > show arp > > > > show ndp > > > > show bridge > > > > show interface status > > > > 8) improved integration scripts > > > > 9) improved reduced default configuration on new sysctls (to omit > > > > default settings on OpenBSD sysctls) > > > > 10) improved arp control on interfaces (arp on, static arp, ) > > > > 11) improved usability and alignment with other industry CLIs with the > > > > keyword "exit" used to exit interface configuration modes > > > > > > > > > > > > 12) nsh.8 manual page updated to include the new features, improved > > > > cross referencing > > > > etc. > > > > > > > > further updates to nsh.8 possible but I wanted make sure at least > > > > this diff makes the cut before ports freeze ... > > > > > > > > a big shout out to Justin who helped identify where we could improve > > > > the show commands / diagnostic commands based on his use of other > > > > networking platforms. > > > > > > > > -- > > > > Kindest regards, > > > > Tom Smyth. > > > > > > > > > -- Kindest regards, Tom Smyth. Index: Makefile === RCS file: /cvs/ports/shells/nsh/Makefile,v retrieving revision 1.45 diff -u -p -r1.45 Makefile --- Makefile 22 Sep 2022 08:16:14 - 1.45 +++ Makefile 15 Mar 2023 22:26:19 - @@ -1,11 +1,9 @@ COMMENT = network switch style shell -DISTNAME = nsh-1.0.20220919 GH_ACCOUNT = yellowman GH_PROJECT = nsh -GH_COMMIT = fcad0f6af197ab0c96e2c5410c546ad90027f7a1 - +GH_TAGNAME =v1.1 CATEGORIES = shells net HOMEPAGE = https://www.nmedia.net/nsh/ Index: distinfo === RCS file: /cvs/ports/shells/nsh/distinfo,v retrieving revisi
Re: nsh1.1 update diff attached
Thanks, the port is looking good and I've done some quick basic testing with no issues (I assume you're already happy in general with it) - committed. On 2023/03/15 22:37, Tom Smyth wrote: > Folks, > > Please find attached diff which updates the nsh port to the latest > release of nsh > 1.1 on github > > > I would like to give a big thanks to Chris Cappuccio, Stefan Sperling, > my colleagues, Justin Donoghue, Alan McGrath & Scott Mc Donnell from > my Alma Mater > DCU who worked on this as part of their university work placement. > a big shout out to Ingo@ who patiently guided me on mandoc and manual > page writing. > and last but not least Stuart and Kurt Mosiejczuk for all their time, > expertise and > work and patience to get me started on ports. > It was a pleasure to help document some of the output of the above > people's effort and indeed the > wider OpenBSD Community for their contributions to the OpenBSD network > stack over the years... > > the attached CVS diff updates the port with the upstream release v1.1 > Changes since last time > Chris and Stefan have made a number of improvements to nsh since the last > update > > 1) dhcpleased support > 2) slaacd support > 3) resolvd support > 4) ndp control support > 5) improved arp control on interfaces > 6) improved bridge/ veb feature support > such as protected ports etc... > 7) improved diagnostics commands > show arp > show ndp > show bridge > show interface status > 8) improved integration scripts > 9) improved reduced default configuration on new sysctls (to omit > default settings on OpenBSD sysctls) > 10) improved arp control on interfaces (arp on, static arp, ) > 11) improved usability and alignment with other industry CLIs with the > keyword "exit" used to exit interface configuration modes > 12) nsh.8 manual page updated to include the new features, improved > cross referencing > > feedback ,comments, ideas, testers contributors welcome... > > Thanks again, > > Tom Smyth > > > On Mon, 13 Mar 2023 at 12:34, Stuart Henderson wrote: > > > > On 2023/03/13 12:12, Tom Smyth wrote: > > > Hi Stuart > > > ill have a look at this... and see what can be done on GH > > > > This or similar to tag the current state of the tree as v1.1 > > > > git tag -a v1.1 -m "Release version v1.1" > > git push origin v1.1 > > > > Or if e.g. there was another commit upstream and you want to tag the > > older commit as v1.1: > > > > git tag -a v1.1 5d9dbeb4e -m "Release version v1.1" > > (and push) > > > > Then for the port you can remove DISTNAME and set GH_TAGNAME = v1.1 > > instead. > > > > > with Stefan and Chris > > > > > > Thanks > > > > > > On Mon 13 Mar 2023, 11:09 Stuart Henderson, wrote: > > > > > > > On 2023/03/13 00:44, Tom Smyth wrote: > > > > > Folks, > > > > > please find attached, update for nsh to nsh1.1-20230312 > > > > > I would like to give a big thanks to Chris Cappuccio, Stefan Sperling, > > > > > Justin Donoghue and Kurt Mosiejczuk for all their time, expertise and > > > > > work to help. > > > > > > > > Updating to newer code makes sense. Would it be worth tagging it > > > > upstream so we don't need to use GH_COMMIT and the date in DISTNAME? > > > > > > > > > the attached CVS diff updates the port with the upstream release, > > > > > Changes since last time > > > > > Chris and Stefan have made a number of improvements to nsh since the > > > > last update > > > > > > > > > > 1) dhcpleased support > > > > > 2) slaacd support > > > > > 3) resolvd support > > > > > 4) ndp control support > > > > > 5) improved arp control on interfaces > > > > > 6) improved bridge/ veb feature support > > > > > 7) improved diagnostics commands > > > > > show arp > > > > > show ndp > > > > > show bridge > > > > > show interface status > > > > > 8) improved integration scripts > > > > > 9) improved reduced default configuration on new sysctls (to omit > > > > > default settings on OpenBSD sysctls) > > > > > 10) improved arp control on interfaces (arp on, static arp, ) > > > > > 11) improved usability and alignment with other industry CLIs with the > > > > > keyword "exit" used to exit interface configuration modes > > > > > > > > > > > > > > > 12) nsh.8 manual page updated to include the new features, improved > > > > > cross referencing > > > > > etc. > > > > > > > > > > further updates to nsh.8 possible but I wanted make sure at least > > > > > this diff makes the cut before ports freeze ... > > > > > > > > > > a big shout out to Justin who helped identify where we could improve > > > > > the show commands / diagnostic commands based on his use of other > > > > > networking platforms. > > > > > > > > > > -- > > > > > Kindest regards, > > > > > Tom Smyth. > > > > > > > > > > > > > > > > -- > Kindest regards, > Tom Smyth. > Index: Makefile > === > RCS file: /cvs/ports/shells/nsh/Makefile,v > retrieving revision 1.45 > diff -u -p -r1.45 Makefile > --- Makefile 22 Sep 2022
Re: nsh1.1 update diff attached
ps, most of the usual cisco-like CLIs will automatically insert a space after tab-completion finds a unique command, so e.g. you can do 'shrun" without typing an extra space; might be a useful addition for people coming from other systems.
Re: nsh1.1 update diff attached
Thanks Stuart Ihave created an issue for this .. It makes sense... it will be implemented shortly ... https://github.com/yellowman/nsh/issues/64 On Wed, 15 Mar 2023 at 22:54, Stuart Henderson wrote: > > ps, most of the usual cisco-like CLIs will automatically insert a space > after tab-completion finds a unique command, so e.g. you can do 'shrun" > without typing an extra space; might be a useful addition for people > coming from other systems. > -- Kindest regards, Tom Smyth.
Re: nsh1.1 update diff attached
Hi Stuart, just ot let you know that iui enhancement (no space after tab completion ssue) you pointed out has been resolved by Stsp in the latest commit in nsh... thanks again for your feedback and suggestion... and I have to say the double tab completion now feels much nicer, thanks again for the feeback much obliged Tom Smyth On Wed, 15 Mar 2023 at 23:01, Tom Smyth wrote: > > Thanks Stuart > Ihave created an issue for this .. It makes sense... it will be > implemented shortly ... > > https://github.com/yellowman/nsh/issues/64 > > On Wed, 15 Mar 2023 at 22:54, Stuart Henderson wrote: > > > > ps, most of the usual cisco-like CLIs will automatically insert a space > > after tab-completion finds a unique command, so e.g. you can do 'shrun" > > without typing an extra space; might be a useful addition for people > > coming from other systems. > > > > > -- > Kindest regards, > Tom Smyth. -- Kindest regards, Tom Smyth.