Re: x11/mplayer: sndio backend update to test
On Wed, Jul 18, 2012 at 6:40 PM, Alexandre Ratchov wrote: > On Sun, Jul 08, 2012 at 10:34:36PM +0200, Alexandre Ratchov wrote: >> >> I'm very interested in any unexpected regressions that this >> diff may cause. >> > > I got only positive feedback about this. Any objections I put this > in? No objections for me. > -- Alexandre > ciao, David
Re: x11/mplayer: sndio backend update to test
On Sun, Jul 08, 2012 at 10:34:36PM +0200, Alexandre Ratchov wrote: > > I'm very interested in any unexpected regressions that this > diff may cause. > I got only positive feedback about this. Any objections I put this in? -- Alexandre
Re: x11/mplayer: sndio backend update to test
On Sun, 8 Jul 2012 22:34:36 +0200 Alexandre Ratchov wrote: > This diff simplifies the sndio backend of mplayer, fixes > few constructs that never caused problems but may not > be correct and removes code that's not needed anymore. > > I'm very interested in any unexpected regressions that this > diff may cause. > > Index: Makefile > === > RCS file: /cvs/ports/x11/mplayer/Makefile,v > retrieving revision 1.207 > diff -u -p -r1.207 Makefile > --- Makefile 20 Jun 2012 12:20:37 - 1.207 > +++ Makefile 8 Jul 2012 20:25:34 - Tried it on a bunch of different formats on amd64, no regressions found here either.
Re: x11/mplayer: sndio backend update to test
On Jul 08 22:34:36, Alexandre Ratchov wrote: > This diff simplifies the sndio backend of mplayer, fixes > few constructs that never caused problems but may not > be correct and removes code that's not needed anymore. > > I'm very interested in any unexpected regressions that this > diff may cause. Works fine on my amd64.
Re: x11/mplayer: sndio backend update to test
On Sun, 08 Jul 2012 22:34:36 +0200, Alexandre Ratchov wrote:
> + struct af_to_par {
> + int format, bits, sig, le;
> + } af_to_par[] = {
> + {AF_FORMAT_U8, 8, 0, 0},
> + {AF_FORMAT_S8, 8, 0, 0},
^
I think that should be 1.
Regards,
Tim
Re: x11/mplayer: sndio backend update to test
On Sun, Jul 08, 2012 at 10:34:36PM +0200, Alexandre Ratchov wrote: > This diff simplifies the sndio backend of mplayer, fixes > few constructs that never caused problems but may not > be correct and removes code that's not needed anymore. > > I'm very interested in any unexpected regressions that this > diff may cause. > I've tested the mplayer patched with a h264/aac video for 5 minutes. The sound is perfect as always. OpenBSD 5.2-beta (GENERIC.MP) #340: Sun Jul 1 23:18:37 MDT 2012 dera...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP Cheers. -- Juan Francisco Cantero Hurtado http://juanfra.info
