Re: Small patch to docbook

2006-12-11 Thread Mikolaj Kucharski 
On Mon, Dec 11, 2006 at 08:45:23PM +, Mikolaj Kucharski wrote:
> No PKGNAME bump needed, right?

No! It needs PKGNAME bump.

-- 
best regards
q#
Index: Makefile
===
RCS file: /cvs/ports/textproc/docbook/Makefile,v
retrieving revision 1.21
diff -u -r1.21 Makefile
--- Makefile2006/08/01 06:34:15 1.21
+++ Makefile2006/12/12 01:54:04
@@ -5,6 +5,7 @@
 COMMENT=   "technical documentation XML/SGML definitions"
 
 DISTNAME=  docbook-4.4
+PKGNAME=   ${DISTNAME}p0
 DIST_SUBDIR=   docbook
 CATEGORIES=textproc
 
@@ -41,10 +42,10 @@
 SGML_INSTDIR=  ${PREFIX}/share/sgml/docbook
 XML_INSTDIR=   ${PREFIX}/share/xml/docbook
 
-BUILD_DEPENDS= :libxml->=2.6.16p6:textproc/libxml
+BUILD_DEPENDS= :libxml->=2.6.16p6:textproc/libxml,no_python
 RUN_DEPENDS=   ::textproc/iso8879 \
:docbook-dsssl-*:textproc/docbook-dsssl \
-   :libxml->=2.6.16p6:textproc/libxml
+   :libxml->=2.6.16p6:textproc/libxml,no_python
 
 .for i in ${SGML_VERSIONS}
 EXTRACT_CASES+=*docbk${i:S/.//g}.zip) unzip -qa 
${FULLDISTDIR}/$$archive -d ${WRKDIR}/$i;;

Re: Small patch to docbook

2006-12-11 Thread Marc Espie 
On Mon, Dec 11, 2006 at 08:45:23PM +, Mikolaj Kucharski wrote:
> No PKGNAME bump needed, right?
> 

Bad patch.

If you want to build libxml without python, simply make sure it
gets built and installed first.

But people doing bulk builds will build libxml with python, and this patch
makes sure they need to build it twice... which is bad.

That's the reason we have some no_* pseudo-flavors, so that individual
people who understand what's going on and who want to build limited stuff
manually can do so, not so that you can screw the whole bulk build 
process.

Small patch to docbook

2006-12-11 Thread Mikolaj Kucharski 
No PKGNAME bump needed, right?

-- 
best regards
q#
Index: Makefile
===
RCS file: /cvs/ports/textproc/docbook/Makefile,v
retrieving revision 1.21
diff -u -r1.21 Makefile
--- Makefile2006/08/01 06:34:15 1.21
+++ Makefile2006/12/11 20:42:49
@@ -41,10 +41,10 @@
 SGML_INSTDIR=  ${PREFIX}/share/sgml/docbook
 XML_INSTDIR=   ${PREFIX}/share/xml/docbook
 
-BUILD_DEPENDS= :libxml->=2.6.16p6:textproc/libxml
+BUILD_DEPENDS= :libxml->=2.6.16p6:textproc/libxml,no_python
 RUN_DEPENDS=   ::textproc/iso8879 \
:docbook-dsssl-*:textproc/docbook-dsssl \
-   :libxml->=2.6.16p6:textproc/libxml
+   :libxml->=2.6.16p6:textproc/libxml,no_python
 
 .for i in ${SGML_VERSIONS}
 EXTRACT_CASES+=*docbk${i:S/.//g}.zip) unzip -qa 
${FULLDISTDIR}/$$archive -d ${WRKDIR}/$i;;