UPDATE: devel/ninja
Hi ports@,
Ninja 0.10.0 was released a while ago. Here is a link to the notes:
https://groups.google.com/forum/#!msg/ninja-build/piOltAhywFA/zPfkrTtRCwAJ
The new version comes with Fortran support. Maybe we can finally get rid
of all the "USE_NINJA=No". This is a job for someone who's interested.
Volunteers come forward :)
This diff needs a hand full of OKs from persons in charge of the bulks.
Index: Makefile
===
RCS file: /cvs/ports/devel/ninja/Makefile,v
retrieving revision 1.29
diff -u -p -u -p -r1.29 Makefile
--- Makefile20 Dec 2019 15:51:26 - 1.29
+++ Makefile6 Feb 2020 20:33:20 -
@@ -9,10 +9,10 @@ COMMENT = small build system with a foc
GH_ACCOUNT = ninja-build
GH_PROJECT = ninja
-GH_TAGNAME = v1.9.0
-REVISION = 0
+GH_TAGNAME = v1.10.0
CATEGORIES = devel
+
HOMEPAGE = https://ninja-build.org/
# Apache License v2.0
Index: distinfo
===
RCS file: /cvs/ports/devel/ninja/distinfo,v
retrieving revision 1.11
diff -u -p -u -p -r1.11 distinfo
--- distinfo22 Jun 2019 20:23:04 - 1.11
+++ distinfo6 Feb 2020 20:33:20 -
@@ -1,2 +1,2 @@
-SHA256 (ninja-1.9.0.tar.gz) = XX7HWCj40/0aDC8xtbDOp4DN/hAxNZIoxCjBpIv81bk=
-SIZE (ninja-1.9.0.tar.gz) = 190860
+SHA256 (ninja-1.10.0.tar.gz) = OBAxiwhIlDX478GcBVJegKmTr1pVuqDf6uBGWp1F+Z8=
+SIZE (ninja-1.10.0.tar.gz) = 210313
Index: patches/patch-src_build_cc
===
RCS file: /cvs/ports/devel/ninja/patches/patch-src_build_cc,v
retrieving revision 1.1
diff -u -p -u -p -r1.1 patch-src_build_cc
--- patches/patch-src_build_cc 20 Dec 2019 15:51:26 - 1.1
+++ patches/patch-src_build_cc 6 Feb 2020 20:33:20 -
@@ -6,7 +6,7 @@ by using a set of pointers.
Index: src/build.cc
--- src/build.cc.orig
+++ src/build.cc
-@@ -348,9 +348,8 @@ bool Plan::AddSubTarget(Node* node, Node* dependent, s
+@@ -382,9 +382,8 @@ void Plan::EdgeWanted(const Edge* edge) {
Edge* Plan::FindWork() {
if (ready_.empty())
return NULL;
@@ -18,7 +18,7 @@ Index: src/build.cc
return edge;
}
-@@ -372,7 +371,7 @@ void Plan::ScheduleWork(map::iterator wan
+@@ -406,7 +405,7 @@ void Plan::ScheduleWork(map::iterator wan
pool->RetrieveReadyEdges(&ready_);
} else {
pool->EdgeScheduled(*edge);
Index: patches/patch-src_build_h
===
RCS file: /cvs/ports/devel/ninja/patches/patch-src_build_h,v
retrieving revision 1.1
diff -u -p -u -p -r1.1 patch-src_build_h
--- patches/patch-src_build_h 20 Dec 2019 15:51:26 - 1.1
+++ patches/patch-src_build_h 6 Feb 2020 20:33:20 -
@@ -6,12 +6,12 @@ by using a set of pointers.
Index: src/build.h
--- src/build.h.orig
+++ src/build.h
-@@ -103,7 +103,7 @@ struct Plan { (private)
+@@ -122,7 +122,7 @@ struct Plan { (private)
/// we want for the edge.
map want_;
- set ready_;
+ deque ready_;
- /// Total number of edges that have commands (not phony).
- int command_edges_;
+ Builder* builder_;
+
UPDATE: devel/ninja
Simple patch to update ninja to 1.10.1 but the main bugfix sounds interesting. Please take a look into the Changlog: https://groups.google.com/g/ninja-build/c/QQM54eAhrjU/m/q5zn_zTlAQAJ?pli=1 Index: Makefile === RCS file: /cvs/ports/devel/ninja/Makefile,v retrieving revision 1.30 diff -u -p -u -p -r1.30 Makefile --- Makefile29 Feb 2020 14:29:28 - 1.30 +++ Makefile3 Sep 2020 05:08:02 - @@ -9,7 +9,7 @@ COMMENT = small build system with a foc GH_ACCOUNT = ninja-build GH_PROJECT = ninja -GH_TAGNAME = v1.10.0 +GH_TAGNAME = v1.10.1 CATEGORIES = devel Index: distinfo === RCS file: /cvs/ports/devel/ninja/distinfo,v retrieving revision 1.12 diff -u -p -u -p -r1.12 distinfo --- distinfo29 Feb 2020 14:29:28 - 1.12 +++ distinfo3 Sep 2020 05:08:02 - @@ -1,2 +1,2 @@ -SHA256 (ninja-1.10.0.tar.gz) = OBAxiwhIlDX478GcBVJegKmTr1pVuqDf6uBGWp1F+Z8= -SIZE (ninja-1.10.0.tar.gz) = 210313 +SHA256 (ninja-1.10.1.tar.gz) = prb3rDYNSqvVTimcwdj6eyNM2BuUAWk9ohIhxiVpoj4= +SIZE (ninja-1.10.1.tar.gz) = 211216
UPDATE: devel/ninja
One simple diff for our brav bulk team! Changelog: https://groups.google.com/forum/#!topic/ninja-build/nY5Kb7zUvcg Does anyone want to add this to their next bulk build? RS Index: Makefile === RCS file: /cvs/ports/devel/ninja/Makefile,v retrieving revision 1.26 diff -u -p -u -p -r1.26 Makefile --- Makefile24 Oct 2018 14:28:00 - 1.26 +++ Makefile14 Apr 2019 18:05:49 - @@ -9,8 +9,7 @@ COMMENT = small build system with a foc GH_ACCOUNT = ninja-build GH_PROJECT = ninja -GH_TAGNAME = v1.8.2 -REVISION = 0 +GH_TAGNAME = v1.9.0 CATEGORIES = devel HOMEPAGE = https://ninja-build.org/ Index: distinfo === RCS file: /cvs/ports/devel/ninja/distinfo,v retrieving revision 1.10 diff -u -p -u -p -r1.10 distinfo --- distinfo20 Sep 2017 07:30:19 - 1.10 +++ distinfo14 Apr 2019 18:05:49 - @@ -1,2 +1,2 @@ -SHA256 (ninja-1.8.2.tar.gz) = hrhwDD0IgMK0TC/2fOQndKr4woy/V3JcuIFWkojBxvQ= -SIZE (ninja-1.8.2.tar.gz) = 185226 +SHA256 (ninja-1.9.0.tar.gz) = XX7HWCj40/0aDC8xtbDOp4DN/hAxNZIoxCjBpIv81bk= +SIZE (ninja-1.9.0.tar.gz) = 190860
UPDATE: devel/ninja
Hi All,
please find below a simple update diff for ninja.
- add write_fake_manifests.py and measure.py to PLIST.
- add NO_TEST otherwise there is an error if run regress.
Tested with devel/kf5, graphics/opencv, graphics/krita on AMD64.
Would like someone run a bulk with the diff below?
Comments? Ok?
Best regards,
Rafael Sadowski
Index: Makefile
===
RCS file: /cvs/ports/devel/ninja/Makefile,v
retrieving revision 1.24
diff -u -p -u -p -r1.24 Makefile
--- Makefile26 Jul 2017 22:45:18 - 1.24
+++ Makefile11 Sep 2017 19:36:16 -
@@ -9,8 +9,7 @@ COMMENT = small build system with a foc
GH_ACCOUNT = ninja-build
GH_PROJECT = ninja
-GH_TAGNAME = v1.7.2
-REVISION = 1
+GH_TAGNAME = v1.8.2
CATEGORIES = devel
HOMEPAGE = https://ninja-build.org/
@@ -36,6 +35,8 @@ BUILD_DEPENDS = devel/re2c
MAKE_ENV = CXX="${CXX}"
+NO_TEST = Yes
+
do-build:
@cd ${WRKSRC} && ${SETENV} ${MAKE_ENV} \
${MODPY_BIN} ./configure.py --bootstrap \
@@ -50,6 +51,8 @@ do-install:
${INSTALL_DATA} ${WRKSRC}/misc/ninja-mode.el ${PREFIX}/share/ninja
${INSTALL_DATA} ${WRKSRC}/misc/ninja.vim ${PREFIX}/share/ninja
${INSTALL_DATA} ${WRKSRC}/misc/ninja_syntax.py ${PREFIX}/share/ninja
+ ${INSTALL_DATA} ${WRKSRC}/misc/write_fake_manifests.py
${PREFIX}/share/ninja
+ ${INSTALL_DATA} ${WRKSRC}/misc/measure.py ${PREFIX}/share/ninja
${INSTALL_DATA} ${WRKSRC}/misc/zsh-completion ${PREFIX}/share/ninja
.include
Index: distinfo
===
RCS file: /cvs/ports/devel/ninja/distinfo,v
retrieving revision 1.9
diff -u -p -u -p -r1.9 distinfo
--- distinfo19 Nov 2016 16:06:59 - 1.9
+++ distinfo11 Sep 2017 19:36:16 -
@@ -1,2 +1,2 @@
-SHA256 (ninja-1.7.2.tar.gz) = Lt2gpUIazjz0KDCSEScHct01qRr2DJb5P5Dfa8QbFtk=
-SIZE (ninja-1.7.2.tar.gz) = 180611
+SHA256 (ninja-1.8.2.tar.gz) = hrhwDD0IgMK0TC/2fOQndKr4woy/V3JcuIFWkojBxvQ=
+SIZE (ninja-1.8.2.tar.gz) = 185226
Index: pkg/PLIST
===
RCS file: /cvs/ports/devel/ninja/pkg/PLIST,v
retrieving revision 1.2
diff -u -p -u -p -r1.2 PLIST
--- pkg/PLIST 14 Jun 2013 16:39:39 - 1.2
+++ pkg/PLIST 11 Sep 2017 19:36:16 -
@@ -4,7 +4,9 @@ share/doc/ninja/
share/doc/ninja/manual.asciidoc
share/ninja/
share/ninja/bash-completion
+share/ninja/measure.py
share/ninja/ninja-mode.el
share/ninja/ninja.vim
share/ninja/ninja_syntax.py
+share/ninja/write_fake_manifests.py
share/ninja/zsh-completion
Re: UPDATE: devel/ninja
Hi,
On Thu, 6 Feb 2020 21:45:47 +0100
Rafael Sadowski wrote:
> Hi ports@,
>
> Ninja 0.10.0 was released a while ago. Here is a link to the notes:
>
> https://groups.google.com/forum/#!msg/ninja-build/piOltAhywFA/zPfkrTtRCwAJ
>
> The new version comes with Fortran support. Maybe we can finally get
> rid of all the "USE_NINJA=No". This is a job for someone who's
> interested. Volunteers come forward :)
>
> This diff needs a hand full of OKs from persons in charge of the
> bulks.
Ninja is built with ports-gcc on base-gcc archs, but i've found that
the environment is not passed in the "do-test" hook, so tests are built
with base-gcc, and fail with:
cc1plus: error: unrecognized command line option "-fdiagnostics-color"
I've tweaked your Makefile diff to pass the test environment.
On powerpc, it builds and tests are passing [0]. I can't test bulk on
macppc within a reasonable timeframe, but i'll fix stuff with it, so
i'll report back if any issue arise.
Charlène.
[0] https://bin.charlenew.xyz/ninja.powerpc.log
Index: Makefile
===
RCS file: /cvs/ports/devel/ninja/Makefile,v
retrieving revision 1.29
diff -u -p -u -p -r1.29 Makefile
--- Makefile20 Dec 2019 15:51:26 - 1.29
+++ Makefile7 Feb 2020 21:02:03 -
@@ -9,10 +9,10 @@ COMMENT = small build system with a foc
GH_ACCOUNT = ninja-build
GH_PROJECT = ninja
-GH_TAGNAME = v1.9.0
-REVISION = 0
+GH_TAGNAME = v1.10.0
CATEGORIES = devel
+
HOMEPAGE = https://ninja-build.org/
# Apache License v2.0
@@ -56,7 +56,7 @@ do-install:
${INSTALL_DATA} ${WRKSRC}/misc/zsh-completion ${PREFIX}/share/ninja
do-test:
- @cd ${WRKSRC} && ./ninja ninja_test \
+ @cd ${WRKSRC} && ${SETENV} ${ALL_TEST_ENV} ./ninja ninja_test \
&& ./ninja_test --gtest_filter=MyTest.Name
.include
Index: distinfo
===
RCS file: /cvs/ports/devel/ninja/distinfo,v
retrieving revision 1.11
diff -u -p -u -p -r1.11 distinfo
--- distinfo22 Jun 2019 20:23:04 - 1.11
+++ distinfo7 Feb 2020 21:02:03 -
@@ -1,2 +1,2 @@
-SHA256 (ninja-1.9.0.tar.gz) = XX7HWCj40/0aDC8xtbDOp4DN/hAxNZIoxCjBpIv81bk=
-SIZE (ninja-1.9.0.tar.gz) = 190860
+SHA256 (ninja-1.10.0.tar.gz) = OBAxiwhIlDX478GcBVJegKmTr1pVuqDf6uBGWp1F+Z8=
+SIZE (ninja-1.10.0.tar.gz) = 210313
Index: patches/patch-src_build_cc
===
RCS file: /cvs/ports/devel/ninja/patches/patch-src_build_cc,v
retrieving revision 1.1
diff -u -p -u -p -r1.1 patch-src_build_cc
--- patches/patch-src_build_cc 20 Dec 2019 15:51:26 - 1.1
+++ patches/patch-src_build_cc 7 Feb 2020 21:02:03 -
@@ -6,7 +6,7 @@ by using a set of pointers.
Index: src/build.cc
--- src/build.cc.orig
+++ src/build.cc
-@@ -348,9 +348,8 @@ bool Plan::AddSubTarget(Node* node, Node* dependent, s
+@@ -382,9 +382,8 @@ void Plan::EdgeWanted(const Edge* edge) {
Edge* Plan::FindWork() {
if (ready_.empty())
return NULL;
@@ -18,7 +18,7 @@ Index: src/build.cc
return edge;
}
-@@ -372,7 +371,7 @@ void Plan::ScheduleWork(map::iterator wan
+@@ -406,7 +405,7 @@ void Plan::ScheduleWork(map::iterator wan
pool->RetrieveReadyEdges(&ready_);
} else {
pool->EdgeScheduled(*edge);
Index: patches/patch-src_build_h
===
RCS file: /cvs/ports/devel/ninja/patches/patch-src_build_h,v
retrieving revision 1.1
diff -u -p -u -p -r1.1 patch-src_build_h
--- patches/patch-src_build_h 20 Dec 2019 15:51:26 - 1.1
+++ patches/patch-src_build_h 7 Feb 2020 21:02:03 -
@@ -6,12 +6,12 @@ by using a set of pointers.
Index: src/build.h
--- src/build.h.orig
+++ src/build.h
-@@ -103,7 +103,7 @@ struct Plan { (private)
+@@ -122,7 +122,7 @@ struct Plan { (private)
/// we want for the edge.
map want_;
- set ready_;
+ deque ready_;
- /// Total number of edges that have commands (not phony).
- int command_edges_;
+ Builder* builder_;
+
Re: UPDATE: devel/ninja
Rafael Sadowski: > Ninja 0.10.0 was released a while ago. Here is a link to the notes: > https://groups.google.com/forum/#!msg/ninja-build/piOltAhywFA/zPfkrTtRCwAJ > > This diff needs a hand full of OKs from persons in charge of the bulks. No problems in a bulk build on amd64. -- Christian "naddy" Weisgerber na...@mips.inka.de
Re: UPDATE: devel/ninja
On Fri Feb 07, 2020 at 10:31:26PM +0100, Charlene Wendling wrote:
> Hi,
>
> On Thu, 6 Feb 2020 21:45:47 +0100
> Rafael Sadowski wrote:
>
> > Hi ports@,
> >
> > Ninja 0.10.0 was released a while ago. Here is a link to the notes:
> >
> > https://groups.google.com/forum/#!msg/ninja-build/piOltAhywFA/zPfkrTtRCwAJ
> >
> > The new version comes with Fortran support. Maybe we can finally get
> > rid of all the "USE_NINJA=No". This is a job for someone who's
> > interested. Volunteers come forward :)
> >
> > This diff needs a hand full of OKs from persons in charge of the
> > bulks.
>
> Ninja is built with ports-gcc on base-gcc archs, but i've found that
> the environment is not passed in the "do-test" hook, so tests are built
> with base-gcc, and fail with:
>
> cc1plus: error: unrecognized command line option "-fdiagnostics-color"
>
> I've tweaked your Makefile diff to pass the test environment.
>
> On powerpc, it builds and tests are passing [0]. I can't test bulk on
> macppc within a reasonable timeframe, but i'll fix stuff with it, so
> i'll report back if any issue arise.
>
> Charlène.
>
>
> [0] https://bin.charlenew.xyz/ninja.powerpc.log
>
>
> do-test:
> - @cd ${WRKSRC} && ./ninja ninja_test \
> + @cd ${WRKSRC} && ${SETENV} ${ALL_TEST_ENV} ./ninja ninja_test \
> && ./ninja_test --gtest_filter=MyTest.Name
>
> .include
> Index: distinfo
I would suggest that we go in with the test fix. OK rsadowski
Re: UPDATE: devel/ninja
Hi Rafael, Tested OK on amd64. Take care. Ricardo On 9/3/20 6:10 AM, Rafael Sadowski wrote: Simple patch to update ninja to 1.10.1 but the main bugfix sounds interesting. Please take a look into the Changlog: https://groups.google.com/g/ninja-build/c/QQM54eAhrjU/m/q5zn_zTlAQAJ?pli=1 This link, sadly, requires login into one's Google account (which I don't have). Alternative link: https://github.com/ninja-build/ninja/compare/v1.10.0...00968321d6ace10b6798855cab7620dc6a5620fd
Re: UPDATE: devel/ninja
On Fri Sep 04, 2020 at 07:12:51PM +0100, Ricardo wrote: > Hi Rafael, > > Tested OK on amd64. Thanks but that is not the point here. We have to be sure that this ninja update is fine for the bulk(8)'s. > > Take care. > Ricardo > > On 9/3/20 6:10 AM, Rafael Sadowski wrote: > > Simple patch to update ninja to 1.10.1 but the main bugfix sounds > > interesting. Please take a look into the Changlog: > > > > https://groups.google.com/g/ninja-build/c/QQM54eAhrjU/m/q5zn_zTlAQAJ?pli=1 > > This link, sadly, requires login into one's Google account (which I > don't have). > Thanks, changelog from upstream: we'd like to release 1.10.1 from current master. 1.10.0 introduced the restat tool, which CMake 3.17 uses to update the timestamps in .ninja_log to avoid having to run some rules twice after regenerating. This didn't work on Windows though, as you can't write to a file which is opened for writing by another process there. To clarify what I mean imagine you have the following hierarchy: a.) ninja b.) -> regenerate by calling CMake c.) -> -> CMake calls ninja -t restat d.) ninja continues the build and rereads the build manifest Between a.) and d.) the outer ninja process would (unnecessarily) open .ninja_log, but not write anything to it yet. c.) would then fail on Windows. After https://github.com/ninja-build/ninja/pull/1780 ninja will now open .ninja_log on the first write - so during d.) - or if it has finished. In the future we could even avoid creating .ninja_log if it would be empty, but I didn't want to change too much of the behavior in a minor release (it would also require touching some unit tests). The other change is that the automatic build on GitHub Actions now builds binaries compatible with macOS 10.12 (previously they required 10.14 IIRC). For a complete list of changes see: https://github.com/ninja-build/ninja/compare/v1.10.0...00968321d6ace10b6798855cab7620dc6a5620fd Please test a build of the master branch with your projects and report any problems. Thanks!
Re: UPDATE: devel/ninja
On 2020/09/04 20:29, Rafael Sadowski wrote: > On Fri Sep 04, 2020 at 07:12:51PM +0100, Ricardo wrote: > > Hi Rafael, > > > > Tested OK on amd64. > > Thanks but that is not the point here. We have to be sure that this > ninja update is fine for the bulk(8)'s. > > > > > Take care. > > Ricardo > > > > On 9/3/20 6:10 AM, Rafael Sadowski wrote: > > > Simple patch to update ninja to 1.10.1 but the main bugfix sounds > > > interesting. Please take a look into the Changlog: > > > > > > https://groups.google.com/g/ninja-build/c/QQM54eAhrjU/m/q5zn_zTlAQAJ?pli=1 > > > > This link, sadly, requires login into one's Google account (which I > > don't have). > > > > Thanks, changelog from upstream: > > we'd like to release 1.10.1 from current master. > > 1.10.0 introduced the restat tool, which CMake 3.17 uses to update the > timestamps in .ninja_log to avoid having to run some rules twice after > regenerating. This didn't work on Windows though, as you can't write to > a file which is opened for writing by another process there. To clarify > what I mean imagine you have the following hierarchy: > > a.) ninja > b.) -> regenerate by calling CMake > c.) -> -> CMake calls ninja -t restat > d.) ninja continues the build and rereads the build manifest > > Between a.) and d.) the outer ninja process would (unnecessarily) open > .ninja_log, but not write anything to it yet. c.) would then fail on > Windows. > > After https://github.com/ninja-build/ninja/pull/1780 ninja will now open > .ninja_log on the first write - so during d.) - or if it has finished. > In the future we could even avoid creating .ninja_log if it would be > empty, but I didn't want to change too much of the behavior in a minor > release (it would also require touching some unit tests). > > The other change is that the automatic build on GitHub Actions now > builds binaries compatible with macOS 10.12 (previously they required > 10.14 IIRC). > > For a complete list of changes see: > https://github.com/ninja-build/ninja/compare/v1.10.0...00968321d6ace10b6798855cab7620dc6a5620fd > > Please test a build of the master branch with your projects and report > any problems. Thanks! Unless I'm mistaken that's one Windows fix and one MacOS fix? This seems rather uninteresting for us?
Re: UPDATE: devel/ninja
On Sun Apr 14, 2019 at 08:09:39PM +0200, Rafael Sadowski wrote: > One simple diff for our brav bulk team! > > > Changelog: > https://groups.google.com/forum/#!topic/ninja-build/nY5Kb7zUvcg > > Does anyone want to add this to their next bulk build? Anybody willing to give it a chance in a bulk? > > RS > > > Index: Makefile > === > RCS file: /cvs/ports/devel/ninja/Makefile,v > retrieving revision 1.26 > diff -u -p -u -p -r1.26 Makefile > --- Makefile 24 Oct 2018 14:28:00 - 1.26 > +++ Makefile 14 Apr 2019 18:05:49 - > @@ -9,8 +9,7 @@ COMMENT = small build system with a foc > > GH_ACCOUNT = ninja-build > GH_PROJECT = ninja > -GH_TAGNAME = v1.8.2 > -REVISION = 0 > +GH_TAGNAME = v1.9.0 > > CATEGORIES = devel > HOMEPAGE = https://ninja-build.org/ > Index: distinfo > === > RCS file: /cvs/ports/devel/ninja/distinfo,v > retrieving revision 1.10 > diff -u -p -u -p -r1.10 distinfo > --- distinfo 20 Sep 2017 07:30:19 - 1.10 > +++ distinfo 14 Apr 2019 18:05:49 - > @@ -1,2 +1,2 @@ > -SHA256 (ninja-1.8.2.tar.gz) = hrhwDD0IgMK0TC/2fOQndKr4woy/V3JcuIFWkojBxvQ= > -SIZE (ninja-1.8.2.tar.gz) = 185226 > +SHA256 (ninja-1.9.0.tar.gz) = XX7HWCj40/0aDC8xtbDOp4DN/hAxNZIoxCjBpIv81bk= > +SIZE (ninja-1.9.0.tar.gz) = 190860 >
Re: UPDATE: devel/ninja
Rafael Sadowski: > Anybody willing to give it a chance in a bulk? I have started an amd64 bulk build with this. > > --- Makefile24 Oct 2018 14:28:00 - 1.26 > > +++ Makefile14 Apr 2019 18:05:49 - > > @@ -9,8 +9,7 @@ COMMENT = small build system with a foc > > > > GH_ACCOUNT = ninja-build > > GH_PROJECT = ninja > > -GH_TAGNAME = v1.8.2 > > -REVISION = 0 > > +GH_TAGNAME = v1.9.0 ... -- Christian "naddy" Weisgerber na...@mips.inka.de
Re: UPDATE: devel/ninja
Christian Weisgerber: [ninja 1.9.0] > > Anybody willing to give it a chance in a bulk? > > I have started an amd64 bulk build with this. All errors are of this type: ninja: error: build.ninja: multiple rules generate XXX [-w dupbuild=err] The initial build failures were devel/doxygen net/libproxy Those have been fixed. I picked up the fixes in the ongoing build, which has revealed additional failures: cad/qucs-s graphics/digikam graphics/krita x11/kde4/pimlibs -- Christian "naddy" Weisgerber na...@mips.inka.de
Re: UPDATE: devel/ninja
On Mon, Sep 11, 2017 at 09:42:35PM +0200, Rafael Sadowski wrote:
> Hi All,
>
> please find below a simple update diff for ninja.
>
> - add write_fake_manifests.py and measure.py to PLIST.
> - add NO_TEST otherwise there is an error if run regress.
>
added a do-test target to fix regression tests.
Cheers
Giovanni
> Tested with devel/kf5, graphics/opencv, graphics/krita on AMD64.
>
> Would like someone run a bulk with the diff below?
>
> Comments? Ok?
>
> Best regards,
>
> Rafael Sadowski
>
> Index: Makefile
> ===
> RCS file: /cvs/ports/devel/ninja/Makefile,v
> retrieving revision 1.24
> diff -u -p -u -p -r1.24 Makefile
> --- Makefile 26 Jul 2017 22:45:18 - 1.24
> +++ Makefile 11 Sep 2017 19:36:16 -
> @@ -9,8 +9,7 @@ COMMENT = small build system with a foc
>
> GH_ACCOUNT = ninja-build
> GH_PROJECT = ninja
> -GH_TAGNAME = v1.7.2
> -REVISION = 1
> +GH_TAGNAME = v1.8.2
>
> CATEGORIES = devel
> HOMEPAGE = https://ninja-build.org/
> @@ -36,6 +35,8 @@ BUILD_DEPENDS = devel/re2c
>
> MAKE_ENV = CXX="${CXX}"
>
> +NO_TEST =Yes
> +
> do-build:
> @cd ${WRKSRC} && ${SETENV} ${MAKE_ENV} \
> ${MODPY_BIN} ./configure.py --bootstrap \
> @@ -50,6 +51,8 @@ do-install:
> ${INSTALL_DATA} ${WRKSRC}/misc/ninja-mode.el ${PREFIX}/share/ninja
> ${INSTALL_DATA} ${WRKSRC}/misc/ninja.vim ${PREFIX}/share/ninja
> ${INSTALL_DATA} ${WRKSRC}/misc/ninja_syntax.py ${PREFIX}/share/ninja
> + ${INSTALL_DATA} ${WRKSRC}/misc/write_fake_manifests.py
> ${PREFIX}/share/ninja
> + ${INSTALL_DATA} ${WRKSRC}/misc/measure.py ${PREFIX}/share/ninja
> ${INSTALL_DATA} ${WRKSRC}/misc/zsh-completion ${PREFIX}/share/ninja
>
> .include
> Index: distinfo
> ===
> RCS file: /cvs/ports/devel/ninja/distinfo,v
> retrieving revision 1.9
> diff -u -p -u -p -r1.9 distinfo
> --- distinfo 19 Nov 2016 16:06:59 - 1.9
> +++ distinfo 11 Sep 2017 19:36:16 -
> @@ -1,2 +1,2 @@
> -SHA256 (ninja-1.7.2.tar.gz) = Lt2gpUIazjz0KDCSEScHct01qRr2DJb5P5Dfa8QbFtk=
> -SIZE (ninja-1.7.2.tar.gz) = 180611
> +SHA256 (ninja-1.8.2.tar.gz) = hrhwDD0IgMK0TC/2fOQndKr4woy/V3JcuIFWkojBxvQ=
> +SIZE (ninja-1.8.2.tar.gz) = 185226
> Index: pkg/PLIST
> ===
> RCS file: /cvs/ports/devel/ninja/pkg/PLIST,v
> retrieving revision 1.2
> diff -u -p -u -p -r1.2 PLIST
> --- pkg/PLIST 14 Jun 2013 16:39:39 - 1.2
> +++ pkg/PLIST 11 Sep 2017 19:36:16 -
> @@ -4,7 +4,9 @@ share/doc/ninja/
> share/doc/ninja/manual.asciidoc
> share/ninja/
> share/ninja/bash-completion
> +share/ninja/measure.py
> share/ninja/ninja-mode.el
> share/ninja/ninja.vim
> share/ninja/ninja_syntax.py
> +share/ninja/write_fake_manifests.py
> share/ninja/zsh-completion
>
Index: Makefile
===
RCS file: /var/cvs/ports/devel/ninja/Makefile,v
retrieving revision 1.24
diff -u -p -r1.24 Makefile
--- Makefile26 Jul 2017 22:45:18 - 1.24
+++ Makefile12 Sep 2017 16:29:28 -
@@ -9,8 +9,7 @@ COMMENT = small build system with a foc
GH_ACCOUNT = ninja-build
GH_PROJECT = ninja
-GH_TAGNAME = v1.7.2
-REVISION = 1
+GH_TAGNAME = v1.8.2
CATEGORIES = devel
HOMEPAGE = https://ninja-build.org/
@@ -50,6 +49,12 @@ do-install:
${INSTALL_DATA} ${WRKSRC}/misc/ninja-mode.el ${PREFIX}/share/ninja
${INSTALL_DATA} ${WRKSRC}/misc/ninja.vim ${PREFIX}/share/ninja
${INSTALL_DATA} ${WRKSRC}/misc/ninja_syntax.py ${PREFIX}/share/ninja
+ ${INSTALL_DATA} ${WRKSRC}/misc/write_fake_manifests.py
${PREFIX}/share/ninja
+ ${INSTALL_DATA} ${WRKSRC}/misc/measure.py ${PREFIX}/share/ninja
${INSTALL_DATA} ${WRKSRC}/misc/zsh-completion ${PREFIX}/share/ninja
+
+do-test:
+ @cd ${WRKSRC} && ./ninja ninja_test \
+ && ./ninja_test --gtest_filter=MyTest.Name
.include
Index: distinfo
===
RCS file: /var/cvs/ports/devel/ninja/distinfo,v
retrieving revision 1.9
diff -u -p -r1.9 distinfo
--- distinfo19 Nov 2016 16:06:59 - 1.9
+++ distinfo12 Sep 2017 16:24:15 -
@@ -1,2 +1,2 @@
-SHA256 (ninja-1.7.2.tar.gz) = Lt2gpUIazjz0KDCSEScHct01qRr2DJb5P5Dfa8QbFtk=
-SIZE (ninja-1.7.2.tar.gz) = 180611
+SHA256 (ninja-1.8.2.tar.gz) = hrhwDD0IgMK0TC/2fOQndKr4woy/V3JcuIFWkojBxvQ=
+SIZE (ninja-1.8.2.tar.gz) = 185226
Index: pkg/PLIST
===
RCS file: /var/cvs/ports/devel/ninja/pkg/PLIST,v
retrieving revision 1.2
diff -u -p -r1.2 PLIST
--- pkg/PLIST 14 Jun 2013 16:39:39 - 1.2
+++ pkg/PLIST 12 Sep 2017 16:24:15 -
@@ -4,7 +4,9
Re: UPDATE: devel/ninja
On Tue, Sep 12 2017, Giovanni Bechis wrote:
> On Mon, Sep 11, 2017 at 09:42:35PM +0200, Rafael Sadowski wrote:
>> Hi All,
>>
>> please find below a simple update diff for ninja.
>>
>> - add write_fake_manifests.py and measure.py to PLIST.
>> - add NO_TEST otherwise there is an error if run regress.
>>
> added a do-test target to fix regression tests.
Hah, nice.
> Cheers
> Giovanni
>
>> Tested with devel/kf5, graphics/opencv, graphics/krita on AMD64.
>>
>> Would like someone run a bulk with the diff below?
>>
>> Comments? Ok?
Maybe obvious: we are approaching release and ninja is kinda critical,
so better watch out for regressions.
>> Best regards,
>>
>> Rafael Sadowski
>>
>> Index: Makefile
>> ===
>> RCS file: /cvs/ports/devel/ninja/Makefile,v
>> retrieving revision 1.24
>> diff -u -p -u -p -r1.24 Makefile
>> --- Makefile 26 Jul 2017 22:45:18 - 1.24
>> +++ Makefile 11 Sep 2017 19:36:16 -
>> @@ -9,8 +9,7 @@ COMMENT =small build system with a foc
>>
>> GH_ACCOUNT =ninja-build
>> GH_PROJECT =ninja
>> -GH_TAGNAME =v1.7.2
>> -REVISION = 1
>> +GH_TAGNAME =v1.8.2
>>
>> CATEGORIES =devel
>> HOMEPAGE = https://ninja-build.org/
>> @@ -36,6 +35,8 @@ BUILD_DEPENDS =devel/re2c
>>
>> MAKE_ENV = CXX="${CXX}"
>>
>> +NO_TEST = Yes
>> +
>> do-build:
>> @cd ${WRKSRC} && ${SETENV} ${MAKE_ENV} \
>> ${MODPY_BIN} ./configure.py --bootstrap \
>> @@ -50,6 +51,8 @@ do-install:
>> ${INSTALL_DATA} ${WRKSRC}/misc/ninja-mode.el ${PREFIX}/share/ninja
>> ${INSTALL_DATA} ${WRKSRC}/misc/ninja.vim ${PREFIX}/share/ninja
>> ${INSTALL_DATA} ${WRKSRC}/misc/ninja_syntax.py ${PREFIX}/share/ninja
>> +${INSTALL_DATA} ${WRKSRC}/misc/write_fake_manifests.py
>> ${PREFIX}/share/ninja
>> +${INSTALL_DATA} ${WRKSRC}/misc/measure.py ${PREFIX}/share/ninja
>> ${INSTALL_DATA} ${WRKSRC}/misc/zsh-completion ${PREFIX}/share/ninja
>>
>> .include
>> Index: distinfo
>> ===
>> RCS file: /cvs/ports/devel/ninja/distinfo,v
>> retrieving revision 1.9
>> diff -u -p -u -p -r1.9 distinfo
>> --- distinfo 19 Nov 2016 16:06:59 - 1.9
>> +++ distinfo 11 Sep 2017 19:36:16 -
>> @@ -1,2 +1,2 @@
>> -SHA256 (ninja-1.7.2.tar.gz) = Lt2gpUIazjz0KDCSEScHct01qRr2DJb5P5Dfa8QbFtk=
>> -SIZE (ninja-1.7.2.tar.gz) = 180611
>> +SHA256 (ninja-1.8.2.tar.gz) = hrhwDD0IgMK0TC/2fOQndKr4woy/V3JcuIFWkojBxvQ=
>> +SIZE (ninja-1.8.2.tar.gz) = 185226
>> Index: pkg/PLIST
>> ===
>> RCS file: /cvs/ports/devel/ninja/pkg/PLIST,v
>> retrieving revision 1.2
>> diff -u -p -u -p -r1.2 PLIST
>> --- pkg/PLIST14 Jun 2013 16:39:39 - 1.2
>> +++ pkg/PLIST11 Sep 2017 19:36:16 -
>> @@ -4,7 +4,9 @@ share/doc/ninja/
>> share/doc/ninja/manual.asciidoc
>> share/ninja/
>> share/ninja/bash-completion
>> +share/ninja/measure.py
>> share/ninja/ninja-mode.el
>> share/ninja/ninja.vim
>> share/ninja/ninja_syntax.py
>> +share/ninja/write_fake_manifests.py
>> share/ninja/zsh-completion
>>
>
>
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
Re: UPDATE: devel/ninja
On 2017/09/12 17:05, Jeremie Courreges-Anglas wrote: > > On Tue, Sep 12 2017, Giovanni Bechis wrote: > > On Mon, Sep 11, 2017 at 09:42:35PM +0200, Rafael Sadowski wrote: > >> Hi All, > >> > >> please find below a simple update diff for ninja. > >> > >> - add write_fake_manifests.py and measure.py to PLIST. > >> - add NO_TEST otherwise there is an error if run regress. > > added a do-test target to fix regression tests. I'd be ok with adding those to the current port. > Hah, nice. > > > Cheers > > Giovanni > > > >> Tested with devel/kf5, graphics/opencv, graphics/krita on AMD64. > >> > >> Would like someone run a bulk with the diff below? > >> > >> Comments? Ok? > > Maybe obvious: we are approaching release and ninja is kinda critical, > so better watch out for regressions. Yep, so let's have an evaluation. What's in the update? Does it bring anything that is important to us that means we should have it before release? (I don't know about timescales but it's obviously getting close.) If not then I'd be happier waiting than doing an update of something like this which does really need bulk build testing.
Re: UPDATE: devel/ninja
On Tue Sep 12, 2017 at 05:18:14PM +, Stuart Henderson wrote: > On 2017/09/12 17:05, Jeremie Courreges-Anglas wrote: > > > > On Tue, Sep 12 2017, Giovanni Bechis wrote: > > > On Mon, Sep 11, 2017 at 09:42:35PM +0200, Rafael Sadowski wrote: > > >> Hi All, > > >> > > >> please find below a simple update diff for ninja. > > >> > > >> - add write_fake_manifests.py and measure.py to PLIST. > > >> - add NO_TEST otherwise there is an error if run regress. > > > added a do-test target to fix regression tests. Great Giovanni! > > I'd be ok with adding those to the current port. Yes please! > > > Hah, nice. > > > > > Cheers > > > Giovanni > > > > > >> Tested with devel/kf5, graphics/opencv, graphics/krita on AMD64. > > >> > > >> Would like someone run a bulk with the diff below? > > >> > > >> Comments? Ok? > > > > Maybe obvious: we are approaching release and ninja is kinda critical, > > so better watch out for regressions. > > Yep, so let's have an evaluation. What's in the update? Does it bring > anything that is important to us that means we should have it before > release? (I don't know about timescales but it's obviously getting > close.) Good question https://github.com/ninja-build/ninja/compare/717b7b4a31db6027207588c0fb89c3ead384747b...master I don't see anything that is very important to us (before release). > If not then I'd be happier waiting than doing an update of > something like this which does really need bulk build testing. I agree with you. I'm not in hurry with this update.
Re: UPDATE: devel/ninja
Giovanni Bechis: > > please find below a simple update diff for ninja. > > > > - add write_fake_manifests.py and measure.py to PLIST. > > - add NO_TEST otherwise there is an error if run regress. > > > added a do-test target to fix regression tests. There were no problems with this in an amd64 bulk build. -- Christian "naddy" Weisgerber na...@mips.inka.de
Re: UPDATE: devel/ninja
On 2017/09/14 15:21, Christian Weisgerber wrote: > Giovanni Bechis: > > > > please find below a simple update diff for ninja. > > > > > > - add write_fake_manifests.py and measure.py to PLIST. > > > - add NO_TEST otherwise there is an error if run regress. > > > > > added a do-test target to fix regression tests. > > There were no problems with this in an amd64 bulk build. No objections from me then.
Update devel/ninja to 1.3.3
This updates ninja to 1.3.3, which includes the OpenBSD patches
upstream and is the official version now used to build and test
Chrome.
ok?
Index: Makefile
===
RCS file: /cvs/ports/devel/ninja/Makefile,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 Makefile
--- Makefile2 May 2013 19:09:18 - 1.1.1.1
+++ Makefile21 May 2013 06:06:17 -
@@ -1,7 +1,7 @@
# $OpenBSD: Makefile,v 1.1.1.1 2013/05/02 19:09:18 matthew Exp $
COMMENT = a small build system with a focus on speed
-V =1.2.0
+V =1.3.3
DISTNAME = ninja-${V}
CATEGORIES = devel
HOMEPAGE = http://martine.github.io/ninja/
Index: distinfo
===
RCS file: /cvs/ports/devel/ninja/distinfo,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 distinfo
--- distinfo2 May 2013 19:09:18 - 1.1.1.1
+++ distinfo21 May 2013 06:06:17 -
@@ -1,2 +1,2 @@
-SHA256 (ninja-1.2.0.tar.gz) = gToeZQ9Q7W6X01O7zjMTSNOet/2tT7pT5Kmb59qTnnI=
-SIZE (ninja-1.2.0.tar.gz) = 136233
+SHA256 (ninja-1.3.3.tar.gz) = YhKvacK9ubbnpKW0WAJIOuv7XYln5DeYH6ZvDaPRej4=
+SIZE (ninja-1.3.3.tar.gz) = 147703
Index: patches/patch-src_subprocess-posix_cc
===
RCS file: patches/patch-src_subprocess-posix_cc
diff -N patches/patch-src_subprocess-posix_cc
--- patches/patch-src_subprocess-posix_cc 2 May 2013 19:09:18 -
1.1.1.1
+++ /dev/null 1 Jan 1970 00:00:00 -
@@ -1,70 +0,0 @@
-$OpenBSD: patch-src_subprocess-posix_cc,v 1.1.1.1 2013/05/02 19:09:18 matthew
Exp $
src/subprocess-posix.cc.orig Fri Apr 5 09:36:12 2013
-+++ src/subprocess-posix.ccThu May 2 12:01:23 2013
-@@ -25,13 +25,6 @@
- #include
- #include
-
--// Older versions of glibc (like 2.4) won't find this in . glibc
--// 2.4 keeps it in , though attempting to include that
--// will redefine the pollfd structure.
--#ifndef POLLRDHUP
--#define POLLRDHUP 0x2000
--#endif
--
- #include "util.h"
-
- Subprocess::Subprocess() : fd_(-1), pid_(-1) {
-@@ -49,12 +42,12 @@ bool Subprocess::Start(SubprocessSet* set, const strin
- if (pipe(output_pipe) < 0)
- Fatal("pipe: %s", strerror(errno));
- fd_ = output_pipe[0];
--#if !defined(linux)
-- // On linux we use ppoll in DoWork(); elsewhere we use pselect and so must
-- // avoid overly-large FDs.
-+#if !defined(linux) && !defined(__OpenBSD__)
-+ // On Linux and OpenBSD, we use ppoll in DoWork(); elsewhere we use pselect
-+ // and so must avoid overly-large FDs.
- if (fd_ >= static_cast(FD_SETSIZE))
- Fatal("pipe: %s", strerror(EMFILE));
--#endif // !linux
-+#endif // !linux && !__OpenBSD__
- SetCloseOnExec(fd_);
-
- pid_ = fork();
-@@ -189,7 +182,7 @@ Subprocess *SubprocessSet::Add(const string& command)
- return subprocess;
- }
-
--#ifdef linux
-+#if defined(linux) || defined(__OpenBSD__)
- bool SubprocessSet::DoWork() {
- vector fds;
- nfds_t nfds = 0;
-@@ -199,7 +192,7 @@ bool SubprocessSet::DoWork() {
- int fd = (*i)->fd_;
- if (fd < 0)
- continue;
--pollfd pfd = { fd, POLLIN | POLLPRI | POLLRDHUP, 0 };
-+pollfd pfd = { fd, POLLIN | POLLPRI, 0 };
- fds.push_back(pfd);
- ++nfds;
- }
-@@ -236,7 +229,7 @@ bool SubprocessSet::DoWork() {
- return false;
- }
-
--#else // linux
-+#else // linux || __OpenBSD__
- bool SubprocessSet::DoWork() {
- fd_set set;
- int nfds = 0;
-@@ -279,7 +272,7 @@ bool SubprocessSet::DoWork() {
-
- return false;
- }
--#endif // linux
-+#endif // linux || __OpenBSD__
-
- Subprocess* SubprocessSet::NextFinished() {
- if (finished_.empty())
UPDATE: /devel/ninja 1.7.1 -> 1.7.2
Hi ports@, Hi Matthew,
simple ninja update. Tested @amd64 with some ports in the last days.
Port highlights:
- switch to new github repo (official)
- new HOMEPAGE
- add post-install to compile ninja_syntax.py
- cleanup do-install tabs
Kind regards,
Rafael Sadowski
Index: Makefile
===
RCS file: /cvs/ports/devel/ninja/Makefile,v
retrieving revision 1.19
diff -u -p -u -p -r1.19 Makefile
--- Makefile12 May 2016 07:14:15 - 1.19
+++ Makefile13 Nov 2016 19:50:57 -
@@ -7,14 +7,12 @@ NOT_FOR_ARCHS=m88k
COMMENT = small build system with a focus on speed
-V =1.7.1
-GH_ACCOUNT = martine
+GH_ACCOUNT = ninja-build
GH_PROJECT = ninja
-GH_TAGNAME = v$V
-DISTNAME = ${GH_PROJECT}-$V
+GH_TAGNAME = v1.7.2
CATEGORIES = devel
-HOMEPAGE = http://martine.github.io/ninja/
+HOMEPAGE = https://ninja-build.org/
MAINTAINER = Matthew Dempsky
# Apache License v2.0
@@ -39,8 +37,8 @@ MAKE_ENV =CXX="${CXX}"
do-build:
@cd ${WRKSRC} && ${SETENV} ${MAKE_ENV} \
- ${MODPY_BIN} ./configure.py --bootstrap \
- --verbose --with-python=${MODPY_BIN}
+ ${MODPY_BIN} ./configure.py --bootstrap \
+ --verbose --with-python=${MODPY_BIN}
do-install:
${INSTALL_PROGRAM} ${WRKBUILD}/ninja ${PREFIX}/bin
@@ -52,5 +50,9 @@ do-install:
${INSTALL_DATA} ${WRKSRC}/misc/ninja.vim ${PREFIX}/share/ninja
${INSTALL_DATA} ${WRKSRC}/misc/ninja_syntax.py ${PREFIX}/share/ninja
${INSTALL_DATA} ${WRKSRC}/misc/zsh-completion ${PREFIX}/share/ninja
+
+post-install:
+ ${MODPY_BIN} ${MODPY_LIBDIR}/compileall.py \
+ ${PREFIX}/share/ninja/ninja_syntax.py
.include
Index: distinfo
===
RCS file: /cvs/ports/devel/ninja/distinfo,v
retrieving revision 1.8
diff -u -p -u -p -r1.8 distinfo
--- distinfo12 May 2016 07:14:15 - 1.8
+++ distinfo13 Nov 2016 19:50:57 -
@@ -1,2 +1,2 @@
-SHA256 (ninja-1.7.1.tar.gz) = UVgd5Tz0cFuJ62sUqFuqcyiK0Iv/JW59MNUpFVgTvhk=
-SIZE (ninja-1.7.1.tar.gz) = 179717
+SHA256 (ninja-1.7.2.tar.gz) = Lt2gpUIazjz0KDCSEScHct01qRr2DJb5P5Dfa8QbFtk=
+SIZE (ninja-1.7.2.tar.gz) = 180611
Index: pkg/PLIST
===
RCS file: /cvs/ports/devel/ninja/pkg/PLIST,v
retrieving revision 1.2
diff -u -p -u -p -r1.2 PLIST
--- pkg/PLIST 14 Jun 2013 16:39:39 - 1.2
+++ pkg/PLIST 13 Nov 2016 19:50:57 -
@@ -7,4 +7,5 @@ share/ninja/bash-completion
share/ninja/ninja-mode.el
share/ninja/ninja.vim
share/ninja/ninja_syntax.py
+share/ninja/ninja_syntax.pyc
share/ninja/zsh-completion
Re: Update devel/ninja to 1.3.3
On Mon, 20 May 2013, Matthew Dempsky wrote: > This updates ninja to 1.3.3, which includes the OpenBSD patches > upstream and is the official version now used to build and test > Chrome. > > ok? Tested with 'cmake -G Ninja' on amd64, ok for me. Minor bikeshedding: for COMMENT, sed -e s/'a small'/'small'/ cheers! David
Re: UPDATE: /devel/ninja 1.7.1 -> 1.7.2
On Sun, Nov 13, 2016 at 8:57 PM, Rafael Sadowski wrote: > Hi ports@, Hi Matthew, > > simple ninja update. Tested @amd64 with some ports in the last days. > > Port highlights: > > - switch to new github repo (official) > - new HOMEPAGE > - add post-install to compile ninja_syntax.py > - cleanup do-install tabs > > Kind regards, > > Rafael Sadowski Thanks, I'll have a look at it tomorrow. Ciao! David
Re: UPDATE: /devel/ninja 1.7.1 -> 1.7.2
On 2016/11/13 20:57, Rafael Sadowski wrote: > Hi ports@, Hi Matthew, > > simple ninja update. Tested @amd64 with some ports in the last days. To save time for testing, which ports did you try it with? (It will need testing with at least a selection of cmake things, plus one of chromium/iridium).
Re: UPDATE: /devel/ninja 1.7.1 -> 1.7.2
On Sun Nov 13, 2016 at 09:25:33PM +, Stuart Henderson wrote: > On 2016/11/13 20:57, Rafael Sadowski wrote: > > Hi ports@, Hi Matthew, > > > > simple ninja update. Tested @amd64 with some ports in the last days. > > To save time for testing, which ports did you try it with? (It will > need testing with at least a selection of cmake things, plus one of > chromium/iridium). I know, devel/llvm, x11/tellico-kde4, graphics/opencv, devel/dlib (openbsd-wip), devel/doxygen and more out of my scope are tested.
Re: UPDATE: /devel/ninja 1.7.1 -> 1.7.2
On Sun Nov 13, 2016 at 09:25:33PM +, Stuart Henderson wrote: > On 2016/11/13 20:57, Rafael Sadowski wrote: > > Hi ports@, Hi Matthew, > > > > simple ninja update. Tested @amd64 with some ports in the last days. > > To save time for testing, which ports did you try it with? (It will > need testing with at least a selection of cmake things, plus one of > chromium/iridium). Successful chromium-54.0.2840.100 build with ninja 1.7.2.
Re: UPDATE: /devel/ninja 1.7.1 -> 1.7.2
On 2016/11/18 19:25, Rafael Sadowski wrote: > > To save time for testing, which ports did you try it with? (It will > > need testing with at least a selection of cmake things, plus one of > > chromium/iridium). > > Successful chromium-54.0.2840.100 build with ninja 1.7.2. Thanks, I think this is enough. I just noticed this though: On 2016/11/13 20:57, Rafael Sadowski wrote: > - add post-install to compile ninja_syntax.py I don't think this is useful, pyc files are only for things which are imported.
Re: UPDATE: /devel/ninja 1.7.1 -> 1.7.2
On Sat, Nov 19, 2016 at 1:45 PM, Stuart Henderson wrote: > On 2016/11/18 19:25, Rafael Sadowski wrote: >> > To save time for testing, which ports did you try it with? (It will >> > need testing with at least a selection of cmake things, plus one of >> > chromium/iridium). >> >> Successful chromium-54.0.2840.100 build with ninja 1.7.2. > > Thanks, I think this is enough. It works for cmake too. > I just noticed this though: > > On 2016/11/13 20:57, Rafael Sadowski wrote: >> - add post-install to compile ninja_syntax.py > > I don't think this is useful, pyc files are only for things which > are imported. Agreed. I think this update can be committed, without the post-install, as Stuart said. Thanks! David -- "If you try a few times and give up, you'll never get there. But if you keep at it... There's a lot of problems in the world which can really be solved by applying two or three times the persistence that other people will." -- Stewart Nelson
Re: UPDATE: /devel/ninja 1.7.1 -> 1.7.2
On 2016/11/19 16:53, David Coppa wrote: > On Sat, Nov 19, 2016 at 1:45 PM, Stuart Henderson > wrote: > > On 2016/11/18 19:25, Rafael Sadowski wrote: > >> > To save time for testing, which ports did you try it with? (It will > >> > need testing with at least a selection of cmake things, plus one of > >> > chromium/iridium). > >> > >> Successful chromium-54.0.2840.100 build with ninja 1.7.2. > > > > Thanks, I think this is enough. > > It works for cmake too. > > > I just noticed this though: > > > > On 2016/11/13 20:57, Rafael Sadowski wrote: > >> - add post-install to compile ninja_syntax.py > > > > I don't think this is useful, pyc files are only for things which > > are imported. > > Agreed. > > I think this update can be committed, without the post-install, as Stuart > said. > > Thanks! > David Thanks, committed.
