Re: UPDATE: dnsmasq 2.89

2023-04-09 Thread Rafael Sadowski
On Sat Apr 08, 2023 at 06:16:21AM -0400, Brad Smith wrote:
> Here is an update to dnsmasq 2.89.
> 
> 
> version 2.89
> Fix bug introduced in 2.88 (commit fe91134b) which can result
>   in corruption of the DNS cache internal data structures and
>   logging of "cache internal error". This has only been seen
>   in one place in the wild, and it took considerable effort
>   to even generate a test case to reproduce it, but there's
>   no way to be sure it won't strike, and the effect is to break
>   the cache badly. Installations with DNSSEC enabled are more
>   likely to see the problem, but not running DNSSEC does not
>   guarantee that it won't happen. Thanks to Timo van Roermund
>   for reporting the bug and for his great efforts in chasing
>   it down.

Committed, thanks

> 
> 
> Index: Makefile
> ===
> RCS file: /home/cvs/ports/net/dnsmasq/Makefile,v
> retrieving revision 1.65
> diff -u -p -u -p -r1.65 Makefile
> --- Makefile  3 Jan 2023 15:45:35 -   1.65
> +++ Makefile  18 Feb 2023 10:26:57 -
> @@ -1,6 +1,6 @@
>  COMMENT= lightweight caching DNS forwarder, DHCP and TFTP server
>  
> -DISTNAME=dnsmasq-2.88
> +DISTNAME=dnsmasq-2.89
>  CATEGORIES=  net
>  MASTER_SITES=https://thekelleys.org.uk/dnsmasq/
>  EXTRACT_SUFX=.tar.xz
> Index: distinfo
> ===
> RCS file: /home/cvs/ports/net/dnsmasq/distinfo,v
> retrieving revision 1.43
> diff -u -p -u -p -r1.43 distinfo
> --- distinfo  3 Jan 2023 15:45:35 -   1.43
> +++ distinfo  18 Feb 2023 10:27:07 -
> @@ -1,2 +1,2 @@
> -SHA256 (dnsmasq-2.88.tar.xz) = I1RN7aEDQMBTvqbxWpP+1up/WqqFMWv8Zx/6bSL7wbM=
> -SIZE (dnsmasq-2.88.tar.xz) = 560640
> +SHA256 (dnsmasq-2.89.tar.xz) = Ar0jA0bPC51ZCfXhUd8WiycHEDeF62FrVmhYVa3rtgk=
> +SIZE (dnsmasq-2.89.tar.xz) = 562700
> Index: patches/patch-man_dnsmasq_8
> ===
> RCS file: /home/cvs/ports/net/dnsmasq/patches/patch-man_dnsmasq_8,v
> retrieving revision 1.32
> diff -u -p -u -p -r1.32 patch-man_dnsmasq_8
> --- patches/patch-man_dnsmasq_8   3 Jan 2023 15:45:35 -   1.32
> +++ patches/patch-man_dnsmasq_8   18 Feb 2023 10:27:27 -
> @@ -17,8 +17,8 @@ Index: man/dnsmasq.8
>   .TP
>   .B \-v, --version
>   Print the version number.
> -@@ -2217,7 +2216,7 @@ and /share/ads-domains.gz containing a compressed
> - list of ad server domains will save disk space with large ad-server 
> blocklists.
> +@@ -2231,7 +2230,7 @@ dig +short chaos txt cachesize.bind
> + 
>   .SH CONFIG FILE
>   At startup, dnsmasq reads
>  -.I /etc/dnsmasq.conf,
> @@ -26,7 +26,7 @@ Index: man/dnsmasq.8
>   if it exists. (On
>   FreeBSD, the file is 
>   .I /usr/local/etc/dnsmasq.conf
> -@@ -2676,7 +2675,7 @@ dnsmasq has no direct way of determining the charset i
> +@@ -2681,7 +2680,7 @@ dnsmasq has no direct way of determining the charset i
>   assume that it is the system default. 
>
>   .SH FILES
> 



UPDATE: dnsmasq 2.89

2023-04-08 Thread Brad Smith
Here is an update to dnsmasq 2.89.


version 2.89
Fix bug introduced in 2.88 (commit fe91134b) which can result
in corruption of the DNS cache internal data structures and
logging of "cache internal error". This has only been seen
in one place in the wild, and it took considerable effort
to even generate a test case to reproduce it, but there's
no way to be sure it won't strike, and the effect is to break
the cache badly. Installations with DNSSEC enabled are more
likely to see the problem, but not running DNSSEC does not
guarantee that it won't happen. Thanks to Timo van Roermund
for reporting the bug and for his great efforts in chasing
it down.


Index: Makefile
===
RCS file: /home/cvs/ports/net/dnsmasq/Makefile,v
retrieving revision 1.65
diff -u -p -u -p -r1.65 Makefile
--- Makefile3 Jan 2023 15:45:35 -   1.65
+++ Makefile18 Feb 2023 10:26:57 -
@@ -1,6 +1,6 @@
 COMMENT=   lightweight caching DNS forwarder, DHCP and TFTP server
 
-DISTNAME=  dnsmasq-2.88
+DISTNAME=  dnsmasq-2.89
 CATEGORIES=net
 MASTER_SITES=  https://thekelleys.org.uk/dnsmasq/
 EXTRACT_SUFX=  .tar.xz
Index: distinfo
===
RCS file: /home/cvs/ports/net/dnsmasq/distinfo,v
retrieving revision 1.43
diff -u -p -u -p -r1.43 distinfo
--- distinfo3 Jan 2023 15:45:35 -   1.43
+++ distinfo18 Feb 2023 10:27:07 -
@@ -1,2 +1,2 @@
-SHA256 (dnsmasq-2.88.tar.xz) = I1RN7aEDQMBTvqbxWpP+1up/WqqFMWv8Zx/6bSL7wbM=
-SIZE (dnsmasq-2.88.tar.xz) = 560640
+SHA256 (dnsmasq-2.89.tar.xz) = Ar0jA0bPC51ZCfXhUd8WiycHEDeF62FrVmhYVa3rtgk=
+SIZE (dnsmasq-2.89.tar.xz) = 562700
Index: patches/patch-man_dnsmasq_8
===
RCS file: /home/cvs/ports/net/dnsmasq/patches/patch-man_dnsmasq_8,v
retrieving revision 1.32
diff -u -p -u -p -r1.32 patch-man_dnsmasq_8
--- patches/patch-man_dnsmasq_8 3 Jan 2023 15:45:35 -   1.32
+++ patches/patch-man_dnsmasq_8 18 Feb 2023 10:27:27 -
@@ -17,8 +17,8 @@ Index: man/dnsmasq.8
  .TP
  .B \-v, --version
  Print the version number.
-@@ -2217,7 +2216,7 @@ and /share/ads-domains.gz containing a compressed
- list of ad server domains will save disk space with large ad-server 
blocklists.
+@@ -2231,7 +2230,7 @@ dig +short chaos txt cachesize.bind
+ 
  .SH CONFIG FILE
  At startup, dnsmasq reads
 -.I /etc/dnsmasq.conf,
@@ -26,7 +26,7 @@ Index: man/dnsmasq.8
  if it exists. (On
  FreeBSD, the file is 
  .I /usr/local/etc/dnsmasq.conf
-@@ -2676,7 +2675,7 @@ dnsmasq has no direct way of determining the charset i
+@@ -2681,7 +2680,7 @@ dnsmasq has no direct way of determining the charset i
  assume that it is the system default. 
   
  .SH FILES