Re: UPDATE: multimedia/lives

2013-01-08 Thread Nigel Taylor
On 01/08/13 13:18, Stuart Henderson wrote:
> Only thing I'm unsure about with this is adding transcode; it adds a
> bunch more dep's so I might skip that if the plugin isn't all that
> important..  Otherwise looks good to me.
> 
> 
transcode adds these extras dep's...

 liba52 libmpeg2 toolame

$ sudo pkg_add -a mplayer vorbis-tools mjpegtools-- ImageMagick xmms
cdrtools sox


$ sudo pkg_add -a transcode
transcode-1.1.7p2:toolame-0.2lp1: ok
transcode-1.1.7p2:libmpeg2-0.5.1p1: ok
transcode-1.1.7p2:liba52-0.7.5p0: ok
transcode-1.1.7p2: ok
$

Most of transcode dep's are already added by lives.

lives is 500Mb in total, transcode+extra dep's is around 7Mb of that.

>From what I can tell the plugin adds a couple of extra output formats.



Re: UPDATE: multimedia/lives

2013-01-08 Thread Stuart Henderson
Only thing I'm unsure about with this is adding transcode; it adds a
bunch more dep's so I might skip that if the plugin isn't all that
important..  Otherwise looks good to me.



UPDATE: multimedia/lives

2013-01-08 Thread Nigel Taylor
Issue found when using dpb -R to build, then checking using 
check-lib-depends.


Missing WANTLIB's harfbuzz icudata icule icuuc, a lot of ports
in the tree have this problem now.

$ make lib-depends-check

lives-1.0.10p1(multimedia/lives):
Missing: harfbuzz.2 from harfbuzz-0.9.10 (/usr/local/bin/lives-exe)
Missing: icudata.6 from icu4c-50.1.1 (/usr/local/bin/lives-exe)
Missing: icule.6 from icu4c-50.1.1 (/usr/local/bin/lives-exe)
Missing: icuuc.6 from icu4c-50.1.1 (/usr/local/bin/lives-exe)
WANTLIB += harfbuzz icudata icule icuuc
Scanning: ok

the built package changes depending if multimedia/mjpegtools and/or 
devel/liboil 
are present or not during the building. amd64 and i386 versions where found to 
be
giving different errors.

$ check-lib-depends lives*

lives-1.0.10p1(multimedia/lives):
Missing: harfbuzz.2 from harfbuzz-0.9.10 (/usr/local/bin/lives-exe)
Missing: icudata.6 from icu4c-50.1.1 (/usr/local/bin/lives-exe)
Missing: icule.6 from icu4c-50.1.1 (/usr/local/bin/lives-exe)
Missing: icuuc.6 from icu4c-50.1.1 (/usr/local/bin/lives-exe)
Missing lib: mjpegutils.5 from mjpegtools-2.0.0p0 (/usr/local/bin/lives-exe) 
(NOT REACHABLE)
WANTLIB += harfbuzz icudata icule icuuc
Scanning: ok


$ check-lib-depends lives*

lives-1.0.10p1(multimedia/lives):
Missing: harfbuzz.2 from harfbuzz-0.9.10 (/usr/local/bin/lives-exe)
Missing: icudata.6 from icu4c-50.1.1 (/usr/local/bin/lives-exe)
Missing: icule.6 from icu4c-50.1.1 (/usr/local/bin/lives-exe)
Missing: icuuc.6 from icu4c-50.1.1 (/usr/local/bin/lives-exe)
Missing lib: oil-0.3.4 (/usr/local/bin/lives-exe) (NOT REACHABLE)
WANTLIB += harfbuzz icudata icule icuuc
Scanning: ok

Now install the package and run
$ lives
lives: can't load library 'liboil-0.3.so.4.0'

Package is broken at runtime, unless liboil is installed.


Looking at configure libvisual / frei0r should be explicitly disabled in 
CONFIGURE_ARGS, should they ever become available then build would be 
inconsistent without the change. Then either mjpegtools / oil / vorbis can 
be disabled, or included the WANTLIB/LIB_DEPENDS

mjpegtools is recommended for 1.3.12, and required for 1.8.0.
liboil are speed improvements.

I added both to LIB_DEPENDS/WANTLIB, rather than disabling.

Configure also finds libvorbis, if installed, 1.8.0 recommends vorbis-tools,  
a BUILD_DEPENDS/RUN_DEPENDS for vorbis-tools has been added, as there isn't 
any library used.

Also transcode has been added to RUN_DEPENDS, reported as not present when one 
of the 
plugins was selected it is in the list of recommended software. Python is 
required 
at runtime, Python is installed at runtime for other runtime dependencies,
a runtime dependency probably should be added, I haven't. There is 
perl plugin that tries to run qtsg, this is for quicktime, and is a command in 
qtutils 
http://freecode.com/projects/qtutils for which there is no port and not updated 
since 2002, left as is.

The lives version is also old 1.0.10, stable version 1.3.12 was released 10 Dec 
2011. 
Development version is 1.8.0, I have left updating to later version.

After changes no dependencies issues are left to cause dpb -R / out-of-date 
problems.
$ check-lib-depends lives-1.0.10p2.tgz
Scanning: ok

I have run limited tests on amd64/i386, no actual editing/importing.

Ok? Tests, Comments
Index: Makefile
===
RCS file: /home/cvs/ports/multimedia/lives/Makefile,v
retrieving revision 1.5
diff -u -p -r1.5 Makefile
--- Makefile	13 Jul 2012 12:55:07 -	1.5
+++ Makefile	7 Jan 2013 23:11:57 -
@@ -7,7 +7,7 @@ COMMENT =		video editor and a VJ tool
 V =			1.0.10
 DISTNAME =		LiVES-${V}
 PKGNAME =		${DISTNAME:L}
-REVISION =		1
+REVISION =		2
 
 SHARED_LIBS +=		weed		0.0 # 0.2
 SHARED_LIBS +=		weed_slice	0.0 # 0.2
@@ -27,27 +27,36 @@ WANTLIB += GL SDL X11 Xau Xcomposite Xcu
 WANTLIB += Xfixes Xi Xinerama Xrandr Xrender Xxf86vm atk-1.0 c
 WANTLIB += cairo drm dv expat ffi fontconfig freetype gdk-x11-2.0
 WANTLIB += gdk_pixbuf-2.0 gio-2.0 glib-2.0 gmodule-2.0 gobject-2.0
-WANTLIB += gthread-2.0 gtk-x11-2.0 m ogg pango-1.0 pangocairo-1.0
-WANTLIB += pangoft2-1.0 pcre pixman-1 png pthread pthread-stubs sndio
-WANTLIB += stdc++ theora usbhid xcb xcb-render xcb-shm z
+WANTLIB += gthread-2.0 gtk-x11-2.0 harfbuzz icudata icule icuuc
+WANTLIB += m mjpegutils ogg oil-0.3 pango-1.0 pangocairo-1.0 pangoft2-1.0
+WANTLIB += pcre pixman-1 png pthread pthread-stubs sndio stdc++
+WANTLIB += theora usbhid xcb xcb-render xcb-shm z
 
 MODULES =		devel/gettext
 RUN_DEPENDS =		graphics/ImageMagick \
 			x11/mplayer \
 			audio/sox \
 			sysutils/cdrtools \
+			audio/vorbis-tools \
+			multimedia/transcode \
 			audio/xmms \
 			devel/desktop-file-utils
+BUILD_DEPENDS =		audio/vorbis-tools
 LIB_DEPENDS =		multimedia/libtheora \
 			devel/sdl \
 			multimedia/libdv \
-			x11/gtk+2
+			x11/gtk+2 \
+			audio/libogg \
+			devel/liboil \
+			multimedia/mjpegtools
 
 USE_LIBTOOL =		Yes
 
 CONFIGURE_STYLE =	gnu
 CONFIGURE_ARGS +=	${