Re: UPDATE: sqlite3-tcl

[Stuart Cassoff]

> -- Original Message --
> From: Stuart Henderson 
> Date: May 5, 2017 at 2:15 AM
> There is a thing called TH3 that tests the built library, this would seem
> more like what we'd want to use, but it's proprietary.

>From the sqlite3 site:

Even though open-source users do not have direct access to TH3, all users of
SQLite benefit from TH3 indirectly since each version of SQLite is validated
running TH3 on multiple platforms (Linux, Windows, WinRT, Mac, OpenBSD) prior to
release. 


Hey, it's OpenBSD in the list! A rare and welcome sight. :)

Thanks,


Stu

Re: UPDATE: sqlite3-tcl

[Stuart Henderson]

On 2017/05/04 17:52, Stuart Cassoff wrote:
> > The mailed diff doesn't apply..(webmail word-wrapping?)
> > Reads OK though.
> 
> Grr. Most likely the new webmail client I'm using.
> Thanks.
>  
> > Makes sense, "pkglocate lib/tcl/|fgrep .so." finds a few more instances,
> > should they be converted too?
> 
> Probably yes. I'll look into it further.
> 
> btw, I noticed that the sqlite3 port no longer has tests.

Yes, upstream don't include them in the amalgamation distribution file,
the tests we used to have are in the "Snapshop of the complete (raw)
source tree for SQLite" file which is harder to work with and they don't
recommend. (also iirc they don't test the produced library, but a custom
build where tests and library are built into one file).

There is a thing called TH3 that tests the built library, this would seem
more like what we'd want to use, but it's proprietary.

Re: UPDATE: sqlite3-tcl

[Stuart Cassoff]

> The mailed diff doesn't apply..(webmail word-wrapping?)
> Reads OK though.

Grr. Most likely the new webmail client I'm using.
Thanks.
 
> Makes sense, "pkglocate lib/tcl/|fgrep .so." finds a few more instances,
> should they be converted too?

Probably yes. I'll look into it further.

btw, I noticed that the sqlite3 port no longer has tests.

Stu

Re: UPDATE: sqlite3-tcl

[Stuart Henderson]

On 2017/05/04 08:31, Stuart Cassoff wrote:
> ping
> 
> > -- Original Message --
> > From: Stuart Cassoff <3...@bell.net>
> > Date: April 28, 2017 at 10:30 PM
> > 
> > 
> > Update to same version as sqlite3.
> > This is a loadable lib; don't treat it as a linkable lib.
> > I can take maintainership.

The mailed diff doesn't apply..(webmail word-wrapping?)
Reads OK though.

> > +$OpenBSD$
> > +--- tea/configure.orig Wed Apr 26 16:58:46 2017
> >  tea/configure  Wed Apr 26 16:59:16 2017
> > +@@ -7237,7 +7237,7 @@ fi
> > +   CC_SEARCH_FLAGS='-Wl,-rpath,${LIB_RUNTIME_DIR}'
> > + fi
> > +   LD_SEARCH_FLAGS=${CC_SEARCH_FLAGS}
> > +-  SHARED_LIB_SUFFIX='${TCL_TRIM_DOTS}.so.${SHLIB_VERSION}'
> > ++  SHARED_LIB_SUFFIX='${TCL_TRIM_DOTS}.so'
> > +   LDFLAGS="-Wl,-export-dynamic"
> > +   ;;
> > +   esac
> > Index: pkg/PLIST
> > ===
> > RCS file: /cvs/ports/databases/sqlite3-tcl/pkg/PLIST,v
> > retrieving revision 1.1
> > diff -u -p -u -p -r1.1 PLIST
> > --- pkg/PLIST   23 Sep 2016 09:14:53 -  1.1
> > +++ pkg/PLIST   29 Apr 2017 02:18:49 -
> > @@ -1,6 +1,6 @@
> >  @comment $OpenBSD: PLIST,v 1.1 2016/09/23 09:14:53 sthen Exp $
> >  @pkgpath databases/sqlite3,-tcl
> >  lib/tcl/sqlite3/
> > -@lib lib/tcl/sqlite3/libsqlite3142.so.${LIBsqlite3142_VERSION}
> > +lib/tcl/sqlite3/libsqlite3170.so
> >  lib/tcl/sqlite3/pkgIndex.tcl
> >  @man man/mann/sqlite3.n
> >

Makes sense, "pkglocate lib/tcl/|fgrep .so." finds a few more instances,
should they be converted too?

Re: UPDATE: sqlite3-tcl

[Stuart Cassoff]

ping

> -- Original Message --
> From: Stuart Cassoff <3...@bell.net>
> Date: April 28, 2017 at 10:30 PM
> 
> 
> Update to same version as sqlite3.
> This is a loadable lib; don't treat it as a linkable lib.
> I can take maintainership.
> 
> Stu
> 
> 
> Index: Makefile
> ===
> RCS file: /cvs/ports/databases/sqlite3-tcl/Makefile,v
> retrieving revision 1.1
> diff -u -p -u -p -r1.1 Makefile
> --- Makefile  23 Sep 2016 09:14:53 -  1.1
> +++ Makefile  29 Apr 2017 02:18:49 -
> @@ -2,13 +2,11 @@
>  
>  COMMENT= Tcl bindings for sqlite3 (embedded SQL implementation)
>  
> -DISTNAME=sqlite-autoconf-3140200
> -PKGNAME= sqlite3-tcl-3.14.2
> +DISTNAME=sqlite-autoconf-317
> +PKGNAME= sqlite3-tcl-3.17.0
>  
>  WRKSRC=  ${WRKDIST}/tea
>  
> -SHARED_LIBS +=  sqlite31420.0 # 1.0
> -
>  CATEGORIES=  databases
>  
>  HOMEPAGE=http://www.sqlite.org/
> @@ -16,22 +14,21 @@ HOMEPAGE= http://www.sqlite.org/
>  # PD
>  PERMIT_PACKAGE_CDROM=Yes
>  
> -WANTLIB += pthread sqlite3
> +WANTLIB += pthread
>  
> -MASTER_SITES=${HOMEPAGE}2016/
> +MASTER_SITES=${HOMEPAGE}2017/
>  
> +SEPARATE_BUILD=  Yes
>  CONFIGURE_STYLE= gnu
>  
>  MODULES+=lang/tcl
>  BUILD_DEPENDS=  ${MODTCL_BUILD_DEPENDS}
>  RUN_DEPENDS= ${MODTCL_RUN_DEPENDS}
> -LIB_DEPENDS= databases/sqlite3
>  
>  FAKE_FLAGS= PKG_DIR=sqlite3
>  
>  CONFIGURE_ARGS=  --with-tcl=${MODTCL_LIBDIR} \
> - --libdir=${MODTCL_TCLDIR} \
> - SHLIB_VERSION=${LIBsqlite3142_VERSION}
> + --libdir=${MODTCL_TCLDIR}
>  
>  # for mozilla
>  CFLAGS+= -DSQLITE_ENABLE_UNLOCK_NOTIFY
> Index: distinfo
> ===
> RCS file: /cvs/ports/databases/sqlite3-tcl/distinfo,v
> retrieving revision 1.1
> diff -u -p -u -p -r1.1 distinfo
> --- distinfo  23 Sep 2016 09:14:53 -  1.1
> +++ distinfo  29 Apr 2017 02:18:49 -
> @@ -1,2 +1,2 @@
> -SHA256 (sqlite-autoconf-3140200.tar.gz) =
> ZE8MEn99DL6HZbm7357QnWovK537pI3f2MoKQv21s/w=
> -SIZE (sqlite-autoconf-3140200.tar.gz) = 2472940
> +SHA256 (sqlite-autoconf-317.tar.gz) =
> pOSFrToW4FR2W69jcYJrUAC+7QfmJlEIlgacC/ATh0w=
> +SIZE (sqlite-autoconf-317.tar.gz) = 2515143
> Index: patches/patch-tea_configure
> ===
> RCS file: patches/patch-tea_configure
> diff -N patches/patch-tea_configure
> --- /dev/null 1 Jan 1970 00:00:00 -
> +++ patches/patch-tea_configure   29 Apr 2017 02:18:49 -
> @@ -0,0 +1,12 @@
> +$OpenBSD$
> +--- tea/configure.orig   Wed Apr 26 16:58:46 2017
>  tea/configureWed Apr 26 16:59:16 2017
> +@@ -7237,7 +7237,7 @@ fi
> + CC_SEARCH_FLAGS='-Wl,-rpath,${LIB_RUNTIME_DIR}'
> + fi
> + LD_SEARCH_FLAGS=${CC_SEARCH_FLAGS}
> +-SHARED_LIB_SUFFIX='${TCL_TRIM_DOTS}.so.${SHLIB_VERSION}'
> ++SHARED_LIB_SUFFIX='${TCL_TRIM_DOTS}.so'
> + LDFLAGS="-Wl,-export-dynamic"
> + ;;
> + esac
> Index: pkg/PLIST
> ===
> RCS file: /cvs/ports/databases/sqlite3-tcl/pkg/PLIST,v
> retrieving revision 1.1
> diff -u -p -u -p -r1.1 PLIST
> --- pkg/PLIST 23 Sep 2016 09:14:53 -  1.1
> +++ pkg/PLIST 29 Apr 2017 02:18:49 -
> @@ -1,6 +1,6 @@
>  @comment $OpenBSD: PLIST,v 1.1 2016/09/23 09:14:53 sthen Exp $
>  @pkgpath databases/sqlite3,-tcl
>  lib/tcl/sqlite3/
> -@lib lib/tcl/sqlite3/libsqlite3142.so.${LIBsqlite3142_VERSION}
> +lib/tcl/sqlite3/libsqlite3170.so
>  lib/tcl/sqlite3/pkgIndex.tcl
>  @man man/mann/sqlite3.n
>

UPDATE: sqlite3-tcl

[Stuart Cassoff]

Update to same version as sqlite3.
This is a loadable lib; don't treat it as a linkable lib.
I can take maintainership.

Stu


Index: Makefile
===
RCS file: /cvs/ports/databases/sqlite3-tcl/Makefile,v
retrieving revision 1.1
diff -u -p -u -p -r1.1 Makefile
--- Makefile23 Sep 2016 09:14:53 -  1.1
+++ Makefile29 Apr 2017 02:18:49 -
@@ -2,13 +2,11 @@
 
 COMMENT=   Tcl bindings for sqlite3 (embedded SQL implementation)
 
-DISTNAME=  sqlite-autoconf-3140200
-PKGNAME=   sqlite3-tcl-3.14.2
+DISTNAME=  sqlite-autoconf-317
+PKGNAME=   sqlite3-tcl-3.17.0
 
 WRKSRC=${WRKDIST}/tea
 
-SHARED_LIBS +=  sqlite31420.0 # 1.0
-
 CATEGORIES=databases
 
 HOMEPAGE=  http://www.sqlite.org/
@@ -16,22 +14,21 @@ HOMEPAGE=   http://www.sqlite.org/
 # PD
 PERMIT_PACKAGE_CDROM=  Yes
 
-WANTLIB += pthread sqlite3
+WANTLIB += pthread
 
-MASTER_SITES=  ${HOMEPAGE}2016/
+MASTER_SITES=  ${HOMEPAGE}2017/
 
+SEPARATE_BUILD=Yes
 CONFIGURE_STYLE= gnu
 
 MODULES+=  lang/tcl
 BUILD_DEPENDS=  ${MODTCL_BUILD_DEPENDS}
 RUN_DEPENDS=   ${MODTCL_RUN_DEPENDS}
-LIB_DEPENDS=   databases/sqlite3
 
 FAKE_FLAGS= PKG_DIR=sqlite3
 
 CONFIGURE_ARGS=--with-tcl=${MODTCL_LIBDIR} \
-   --libdir=${MODTCL_TCLDIR} \
-   SHLIB_VERSION=${LIBsqlite3142_VERSION}
+   --libdir=${MODTCL_TCLDIR}
 
 # for mozilla
 CFLAGS+=   -DSQLITE_ENABLE_UNLOCK_NOTIFY
Index: distinfo
===
RCS file: /cvs/ports/databases/sqlite3-tcl/distinfo,v
retrieving revision 1.1
diff -u -p -u -p -r1.1 distinfo
--- distinfo23 Sep 2016 09:14:53 -  1.1
+++ distinfo29 Apr 2017 02:18:49 -
@@ -1,2 +1,2 @@
-SHA256 (sqlite-autoconf-3140200.tar.gz) =
ZE8MEn99DL6HZbm7357QnWovK537pI3f2MoKQv21s/w=
-SIZE (sqlite-autoconf-3140200.tar.gz) = 2472940
+SHA256 (sqlite-autoconf-317.tar.gz) =
pOSFrToW4FR2W69jcYJrUAC+7QfmJlEIlgacC/ATh0w=
+SIZE (sqlite-autoconf-317.tar.gz) = 2515143
Index: patches/patch-tea_configure
===
RCS file: patches/patch-tea_configure
diff -N patches/patch-tea_configure
--- /dev/null   1 Jan 1970 00:00:00 -
+++ patches/patch-tea_configure 29 Apr 2017 02:18:49 -
@@ -0,0 +1,12 @@
+$OpenBSD$
+--- tea/configure.orig Wed Apr 26 16:58:46 2017
 tea/configure  Wed Apr 26 16:59:16 2017
+@@ -7237,7 +7237,7 @@ fi
+   CC_SEARCH_FLAGS='-Wl,-rpath,${LIB_RUNTIME_DIR}'
+ fi
+   LD_SEARCH_FLAGS=${CC_SEARCH_FLAGS}
+-  SHARED_LIB_SUFFIX='${TCL_TRIM_DOTS}.so.${SHLIB_VERSION}'
++  SHARED_LIB_SUFFIX='${TCL_TRIM_DOTS}.so'
+   LDFLAGS="-Wl,-export-dynamic"
+   ;;
+   esac
Index: pkg/PLIST
===
RCS file: /cvs/ports/databases/sqlite3-tcl/pkg/PLIST,v
retrieving revision 1.1
diff -u -p -u -p -r1.1 PLIST
--- pkg/PLIST   23 Sep 2016 09:14:53 -  1.1
+++ pkg/PLIST   29 Apr 2017 02:18:49 -
@@ -1,6 +1,6 @@
 @comment $OpenBSD: PLIST,v 1.1 2016/09/23 09:14:53 sthen Exp $
 @pkgpath databases/sqlite3,-tcl
 lib/tcl/sqlite3/
-@lib lib/tcl/sqlite3/libsqlite3142.so.${LIBsqlite3142_VERSION}
+lib/tcl/sqlite3/libsqlite3170.so
 lib/tcl/sqlite3/pkgIndex.tcl
 @man man/mann/sqlite3.n