Re: UPDATE: www/dansguardian flavors

2012-03-03 Thread Stuart Henderson 
On 2012/03/02 15:26, Justin Jereza wrote:
 What do you suggest? Should these just be enabled by default instead
 of using FLAVORS?

enabled by default.

UPDATE: www/dansguardian flavors

2012-03-01 Thread Justin Jereza 
Hello.

The diff below adds the icap and commandline flavors to
www/dansguardian. clamd was not given it's own flavor since the PLIST
contains files that require it.

Regards,

Justin Jereza


Index: Makefile
===
RCS file: /cvs/ports/www/dansguardian/Makefile,v
retrieving revision 1.12
diff -u -p -r1.12 Makefile
--- Makefile22 Nov 2010 08:36:47 -  1.12
+++ Makefile2 Mar 2012 06:13:01 -
@@ -3,6 +3,7 @@
 COMMENT =  content scanning web filter
 DISTNAME = dansguardian-2.10.1.1
 CATEGORIES =   www net
+FLAVORS =  icap commandline

 HOMEPAGE = http://www.dansguardian.org/

@@ -38,5 +39,15 @@ USE_GROFF =  Yes

 FAKE_FLAGS +=  DGCONFDIR=${PREFIX}/share/examples/dansguardian \
rel_group=_dansguardian rel_user=_dansguardian
+
+FLAVOR ?=
+
+.if ${FLAVOR:L:Micap}
+CONFIGURE_ARGS += --enable-icap
+.endif
+
+.if ${FLAVOR:L:Mcommandline}
+CONFIGURE_ARGS += --enable-commandline
+.endif

 .include bsd.port.mk

Re: UPDATE: www/dansguardian flavors

2012-03-01 Thread Brad Smith 

On 02/03/12 1:22 AM, Justin Jereza wrote:

Hello.

The diff below adds the icap and commandline flavors to
www/dansguardian. clamd was not given it's own flavor since the PLIST
contains files that require it.

Regards,

Justin Jereza


If you add FLAVORs they should be documented in pkg/DESCR.

I don't know what these FLAVORs do but what harm would it be to
enable the features by default seeing as this does not seem to
involve any external dependencies or any new files [in the PLIST]?


Index: Makefile
===
RCS file: /cvs/ports/www/dansguardian/Makefile,v
retrieving revision 1.12
diff -u -p -r1.12 Makefile
--- Makefile22 Nov 2010 08:36:47 -  1.12
+++ Makefile2 Mar 2012 06:13:01 -
@@ -3,6 +3,7 @@
  COMMENT =  content scanning web filter
  DISTNAME = dansguardian-2.10.1.1
  CATEGORIES =   www net
+FLAVORS =  icap commandline

  HOMEPAGE = http://www.dansguardian.org/

@@ -38,5 +39,15 @@ USE_GROFF =  Yes

  FAKE_FLAGS +=  DGCONFDIR=${PREFIX}/share/examples/dansguardian \
 rel_group=_dansguardian rel_user=_dansguardian
+
+FLAVOR ?=
+
+.if ${FLAVOR:L:Micap}
+CONFIGURE_ARGS += --enable-icap
+.endif
+
+.if ${FLAVOR:L:Mcommandline}
+CONFIGURE_ARGS += --enable-commandline
+.endif

  .includebsd.port.mk




--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

Re: UPDATE: www/dansguardian flavors

2012-03-01 Thread Justin Jereza 
On Fri, Mar 2, 2012 at 2:42 PM, Brad Smith b...@comstyle.com wrote:

 If you add FLAVORs they should be documented in pkg/DESCR.

I should have checked that. Will add it. Thanks.


 I don't know what these FLAVORs do but what harm would it be to
 enable the features by default seeing as this does not seem to
 involve any external dependencies or any new files [in the PLIST]?


I was just following how it's done with www/squid where ldap, ntlm,
and snmp support is not enabled by default even though snmp has no
external dependencies. Instead, different packages of those are built
depending on need.

I may have been two hasty in posting this without checking for new
files. In fact, a configuration file for icap and commandline should
be included in the PLIST.

What do you suggest? Should these just be enabled by default instead
of using FLAVORS?

Thanks and regards,

Justin Jreza