Re: Update: sysutils/py-scandir 1.9.0 -> 1.10.0
OK mariani@ On Wed, Mar 20, 2019 at 7:44 PM Kurt Mosiejczuk wrote: > > On Wed, Mar 20, 2019 at 11:25:59PM +0100, Klemens Nanni wrote: > > > OK kn > > > > @@ -32,7 +32,6 @@ TEST_DEPENDS += devel/py-unittest2 > > > .endif > > > > do-test: > > > - cd ${WRKSRC}/test &&\ > > > - env LC_ALL=C.UTF-8 LANG=C.UTF-8 ${MODPY_BIN} run_tests.py > > > + cd ${WRKSRC}/test && ${SETENV} ${ALL_TEST_ENV} ${MODPY_BIN} > > > run_tests.py > > How about omitting this hunk from the update and commit it separately, > > possibly in a bulk with other test conversions now that remi has landed > > your final MODPY_PYTEST bits? > > We could. I only submitted this one because it isn't actually using > MODPY_PYTEST. It is running its own tests. I was just taking advantage of > the fact that we set TEST_ENV to include en_US.UTF-8. I have others I > have been updating that I haven't submitted yet because MODPY_PYTEST > hadn't gone in yet. :) > > --Kurt >
Re: Update: sysutils/py-scandir 1.9.0 -> 1.10.0
On Wed, Mar 20, 2019 at 12:29:30PM -0400, Kurt Mosiejczuk wrote: > While looking at updating much of our python testing ports (py-test*, > py-hypothesis, etc.) one of the twisty mazes of ports wanted a newer > py-scandir. So here is an update for that. > > I tested both flavors of devel/py-pathlib2 as it seems to be the only > consumer (so far, anyway). All tests passed. > > (I meant to cc Elias, the maintainer, but I sent it only to him > the first time. This time I'm including ports@) OK kn > @@ -32,7 +32,6 @@ TEST_DEPENDS += devel/py-unittest2 > .endif > > do-test: > - cd ${WRKSRC}/test &&\ > - env LC_ALL=C.UTF-8 LANG=C.UTF-8 ${MODPY_BIN} run_tests.py > + cd ${WRKSRC}/test && ${SETENV} ${ALL_TEST_ENV} ${MODPY_BIN} run_tests.py How about omitting this hunk from the update and commit it separately, possibly in a bulk with other test conversions now that remi has landed your final MODPY_PYTEST bits?