Re: Update net/libsignal-protocol-c 2.3.2->3
On Mon, Mar 30 2020, Lucas wrote: > Soon-to-be maintainer of net/profanity here (another XMPP client, > consumer of this lib). Profanity works fine compiled against updated > libsignal-protocol-c. > > Tests passed too, after adding CK_DEFAULT_TIMEOUT=10 to TEST_ENV. > The test timing out was test_unique_signatures in curve25519 suite. > Machine is an APU2 [0], not the most powerful hardware out there, but > might be something to taken into account. > > Thanks for the work! I have committed this update, thanks for the additional test reports and thanks Greg for the diff and work done upstream. > -Lucas > > [0]: https://pcengines.ch/apu2.htm > -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
Re: Update net/libsignal-protocol-c 2.3.2->3
Soon-to-be maintainer of net/profanity here (another XMPP client, consumer of this lib). Profanity works fine compiled against updated libsignal-protocol-c. Tests passed too, after adding CK_DEFAULT_TIMEOUT=10 to TEST_ENV. The test timing out was test_unique_signatures in curve25519 suite. Machine is an APU2 [0], not the most powerful hardware out there, but might be something to taken into account. Thanks for the work! -Lucas [0]: https://pcengines.ch/apu2.htm
Re: Update net/libsignal-protocol-c 2.3.2->3
Awesome. Test runs here too and Dino tested on amd64. Other Dino users, please yell about problems -- otherwise ok maintainer. 0001-Update-net-libsignal-protocol-c-2.3.2-3.patch.gz Description: application/gzip
Re: Update net/libsignal-protocol-c 2.3.2->3
On Sat, Mar 28 2020, Greg Steuck wrote: > On Mon, Jan 13, 2020 at 9:29 AM Alex Holst wrote: > >> > I'm looking for feedback about the trade-offs of such changes. >> Hi. This seems like needless churn to me. Upstream should be nudged to >> do a new release instead. >> > > Done. > > The local patches got rolled in. Library version bump seems > unnecessary based on the diff: > https://github.com/signalapp/libsignal-protocol-c/compare/v2.3.2...v2.3.3 Looks good ports-wise, ok jca@ > make test: > > Test project /home/greg/ports/pobj/libsignal-protocol-c-2.3.3/build-amd64 > Start 1: test_curve25519 > 1/13 Test #1: test_curve25519 .. Passed1.56 sec > Start 2: test_hkdf > 2/13 Test #2: test_hkdf Passed0.02 sec > Start 3: test_ratchet > 3/13 Test #3: test_ratchet . Passed0.04 sec > Start 4: test_protocol > 4/13 Test #4: test_protocol Passed0.05 sec > Start 5: test_session_record > 5/13 Test #5: test_session_record .. Passed0.04 sec > Start 6: test_session_cipher > 6/13 Test #6: test_session_cipher .. Passed0.44 sec > Start 7: test_session_builder > 7/13 Test #7: test_session_builder . Passed0.40 sec > Start 8: test_key_helper > 8/13 Test #8: test_key_helper .. Passed0.02 sec > Start 9: test_simultaneous_initiate > 9/13 Test #9: test_simultaneous_initiate ... Passed1.94 sec > Start 10: test_sender_key_record > 10/13 Test #10: test_sender_key_record ... Passed0.03 sec > Start 11: test_group_cipher > 11/13 Test #11: test_group_cipher Passed2.20 sec > Start 12: test_fingerprint > 12/13 Test #12: test_fingerprint . Passed0.21 sec > Start 13: test_device_consistency > 13/13 Test #13: test_device_consistency .. Passed0.04 sec > > 100% tests passed, 0 tests failed out of 13 -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
Update net/libsignal-protocol-c 2.3.2->3
On Mon, Jan 13, 2020 at 9:29 AM Alex Holst wrote: > > I'm looking for feedback about the trade-offs of such changes. > Hi. This seems like needless churn to me. Upstream should be nudged to > do a new release instead. > Done. The local patches got rolled in. Library version bump seems unnecessary based on the diff: https://github.com/signalapp/libsignal-protocol-c/compare/v2.3.2...v2.3.3 make test: Test project /home/greg/ports/pobj/libsignal-protocol-c-2.3.3/build-amd64 Start 1: test_curve25519 1/13 Test #1: test_curve25519 .. Passed1.56 sec Start 2: test_hkdf 2/13 Test #2: test_hkdf Passed0.02 sec Start 3: test_ratchet 3/13 Test #3: test_ratchet . Passed0.04 sec Start 4: test_protocol 4/13 Test #4: test_protocol Passed0.05 sec Start 5: test_session_record 5/13 Test #5: test_session_record .. Passed0.04 sec Start 6: test_session_cipher 6/13 Test #6: test_session_cipher .. Passed0.44 sec Start 7: test_session_builder 7/13 Test #7: test_session_builder . Passed0.40 sec Start 8: test_key_helper 8/13 Test #8: test_key_helper .. Passed0.02 sec Start 9: test_simultaneous_initiate 9/13 Test #9: test_simultaneous_initiate ... Passed1.94 sec Start 10: test_sender_key_record 10/13 Test #10: test_sender_key_record ... Passed0.03 sec Start 11: test_group_cipher 11/13 Test #11: test_group_cipher Passed2.20 sec Start 12: test_fingerprint 12/13 Test #12: test_fingerprint . Passed0.21 sec Start 13: test_device_consistency 13/13 Test #13: test_device_consistency .. Passed0.04 sec 100% tests passed, 0 tests failed out of 13 -- nest.cx is Gmail hosted, use PGP: https://pgp.key-server.io/0x0B1542BD8DF5A1B0 Fingerprint: 5E2B 2D0E 1E03 2046 BEC3 4D50 0B15 42BD 8DF5 A1B0 0001-Update-net-libsignal-protocol-c-2.3.2-3.patch.gz Description: application/gzip
