Re: audio/mumble: missing icons
On Fri, Apr 23, 2021 at 05:52:19AM +0200, Rafael Sadowski wrote: > On Thu Apr 22, 2021 at 11:37:28PM +, Klemens Nanni wrote: > > On Thu, Apr 22, 2021 at 11:56:46PM +0200, Patrick Wildt wrote: > > > Looks like we're not alone: > > > > > > https://www.reddit.com/r/archlinux/comments/m6qvsa/mumble_no_icons_on_the_main_window_am_i_the_only/ > > > https://www.reddit.com/r/openSUSE/comments/mcf946/broken_mumble_since_2_or_three_snapshots_on/ > > Thanks for digging, so it's a kiconthemes bug according to the fix > > OpenSUSE applied. > > > > Here's a cherry-pick of their fix that makes icons show up in mumble > > again with kiconthemes. > > > > Alterntively, it looks like kf5 5.80.1 (we are on 5.80.0) has the fix, > > but I won't attempt to update the entire suite just for this. > > > > kf5 5.81.0 is ready to commit. I'm just waiting for the unlock. With that update i can no longer reproduce the issue, thanks. $ pkg_info -m | grep -e kiconthemes -e mumble kiconthemes-5.81.0 KDE icon GUI utility library mumble-1.3.4low-latency voice chat client
Re: audio/mumble: missing icons
On Thu Apr 22, 2021 at 11:37:28PM +, Klemens Nanni wrote: > On Thu, Apr 22, 2021 at 11:56:46PM +0200, Patrick Wildt wrote: > > Looks like we're not alone: > > > > https://www.reddit.com/r/archlinux/comments/m6qvsa/mumble_no_icons_on_the_main_window_am_i_the_only/ > > https://www.reddit.com/r/openSUSE/comments/mcf946/broken_mumble_since_2_or_three_snapshots_on/ > Thanks for digging, so it's a kiconthemes bug according to the fix > OpenSUSE applied. > > Here's a cherry-pick of their fix that makes icons show up in mumble > again with kiconthemes. > > Alterntively, it looks like kf5 5.80.1 (we are on 5.80.0) has the fix, > but I won't attempt to update the entire suite just for this. > kf5 5.81.0 is ready to commit. I'm just waiting for the unlock.
Re: audio/mumble: missing icons
On Thu, Apr 22, 2021 at 11:56:46PM +0200, Patrick Wildt wrote:
> Looks like we're not alone:
>
> https://www.reddit.com/r/archlinux/comments/m6qvsa/mumble_no_icons_on_the_main_window_am_i_the_only/
> https://www.reddit.com/r/openSUSE/comments/mcf946/broken_mumble_since_2_or_three_snapshots_on/
Thanks for digging, so it's a kiconthemes bug according to the fix
OpenSUSE applied.
Here's a cherry-pick of their fix that makes icons show up in mumble
again with kiconthemes.
Alterntively, it looks like kf5 5.80.1 (we are on 5.80.0) has the fix,
but I won't attempt to update the entire suite just for this.
Feedback? OK?
Index: Makefile
===
RCS file: /cvs/ports/devel/kf5/kiconthemes/Makefile,v
retrieving revision 1.14
diff -u -p -r1.14 Makefile
--- Makefile23 Jan 2021 18:09:53 - 1.14
+++ Makefile22 Apr 2021 23:32:25 -
@@ -2,6 +2,7 @@
COMMENT = KDE icon GUI utility library
DISTNAME = kiconthemes-${VERSION}
+REVISION = 0
SHARED_LIBS = KF5IconThemes 5.1
Index: patches/patch-src_kiconloader_cpp
===
RCS file: patches/patch-src_kiconloader_cpp
diff -N patches/patch-src_kiconloader_cpp
--- /dev/null 1 Jan 1970 00:00:00 -
+++ patches/patch-src_kiconloader_cpp 22 Apr 2021 23:36:57 -
@@ -0,0 +1,26 @@
+$OpenBSD$
+
+Fix icon loading for applications like Mumble, cherry-picked from
+https://build.opensuse.org/package/view_file/KDE:Frameworks5/kiconthemes/0001-ensure-qrc-QDir-searchPaths-work-for-icons.patch?expand=1&rev=5462e1e1e4e6e4cae6ff7bddc99b03d7
+
+Index: src/kiconloader.cpp
+--- src/kiconloader.cpp.orig
src/kiconloader.cpp
+@@ -1204,7 +1204,7 @@ QString KIconLoader::iconPath(const QString &_name, in
+ return QString();
+ }
+
+-if (_name.isEmpty() || !pathIsRelative(_name)) {
++if (_name.isEmpty() || !QDir::isRelativePath(_name)) {
+ // we have either an absolute path or nothing to work with
+ return _name;
+ }
+@@ -1327,7 +1327,7 @@ QPixmap KIconLoader::loadScaledIcon(const QString &_na
+ name =
QStandardPaths::writableLocation(QStandardPaths::GenericCacheLocation) +
QLatin1Char('/') + name + QStringLiteral(".png");
+ }
+
+-bool absolutePath = !pathIsRelative(name);
++bool absolutePath = !QDir::isRelativePath(name);
+ if (!absolutePath) {
+ name = d->removeIconExtension(name);
+ }
Re: audio/mumble: missing icons
Am Thu, Apr 22, 2021 at 08:54:28PM + schrieb Klemens Nanni: > On Sat, Apr 17, 2021 at 11:21:52AM +0200, Rafael Sadowski wrote: > > On Sat Apr 17, 2021 at 10:06:32AM +0200, Alexander Bluhm wrote: > > > On Sat, Apr 17, 2021 at 01:34:06AM +0200, Patrick Wildt wrote: > > > > Am Sat, Apr 17, 2021 at 01:16:00AM +0200 schrieb Thomas L.: > > > > > Hi, > > > > > > > > > > I noticed that recently mumble shows me no icons in the toolbar and > > > > > elsewhere. I already tried reverting the most recent changes in > > > > > audio/mumble, but it seems like something else is amiss. To rule out > > > > > broken configuration I tried creating a new user, but it shows the > > > > > same > > > > > behaviour. Can someone else confirm this or has an idea what changed? > > > > > > > > > > Kind regards, > > > > > > > > > > Thomas > > > > > > > > > > > > > Hi, > > > > > > > > I heard bluhm@ talk about the same issue this week. Iirc he had to > > > > *delete* some kde port or so, don't remember. CCed him, I guess he > > > > can tell you better than me what the cause is. > > > > > > > > Patrick > > > > > > pkg_delete kiconthemes fixes the issue for me. > > > pkg_add -Dsnap kiconthemes && mumble triggers the bug on -current. > > > > > > bluhm > > > > > > > Can't confirm. Both installed and none icon issues. > > I can reproduce exactly what bluhm describes. > rsadowski, do you have anything else installed that coulb be important? > > With kiconthemes installed, mumble will print this upon startup: > > 2021-04-22 18:12:20.932 Icon theme "breeze" not found. > > So mumble seems to pick up kiconthemes which wants to use breeze by > default or so -- I'm unfamiliar with KDE's theme/icon/etc. framework and > currently don't have the time to further look into this. > > > > > Pro Qt tip: Install qt5ct, run qt5ct, set QT_QPA_PLATFORMTHEME=qt5ct. > > For more themes and icons install lightly, adwaita-qt, breeze, oxygen. > > I have QT_QPA_PLATFORMTHEME=qt5ct in ~/.profile and ran qt5ct once to > set Qt5 apps to a dark theme, but that doesn't change anything wrt. > icons in Mumble for me. > > > If you do not like the Qt style, install adwaita-qt and it will looks > > like GNOME Shell. > > > > Rafael > > > Looks like we're not alone: https://www.reddit.com/r/archlinux/comments/m6qvsa/mumble_no_icons_on_the_main_window_am_i_the_only/ https://www.reddit.com/r/openSUSE/comments/mcf946/broken_mumble_since_2_or_three_snapshots_on/
Re: audio/mumble: missing icons
On Sat, Apr 17, 2021 at 11:21:52AM +0200, Rafael Sadowski wrote: > On Sat Apr 17, 2021 at 10:06:32AM +0200, Alexander Bluhm wrote: > > On Sat, Apr 17, 2021 at 01:34:06AM +0200, Patrick Wildt wrote: > > > Am Sat, Apr 17, 2021 at 01:16:00AM +0200 schrieb Thomas L.: > > > > Hi, > > > > > > > > I noticed that recently mumble shows me no icons in the toolbar and > > > > elsewhere. I already tried reverting the most recent changes in > > > > audio/mumble, but it seems like something else is amiss. To rule out > > > > broken configuration I tried creating a new user, but it shows the same > > > > behaviour. Can someone else confirm this or has an idea what changed? > > > > > > > > Kind regards, > > > > > > > > Thomas > > > > > > > > > > Hi, > > > > > > I heard bluhm@ talk about the same issue this week. Iirc he had to > > > *delete* some kde port or so, don't remember. CCed him, I guess he > > > can tell you better than me what the cause is. > > > > > > Patrick > > > > pkg_delete kiconthemes fixes the issue for me. > > pkg_add -Dsnap kiconthemes && mumble triggers the bug on -current. > > > > bluhm > > > > Can't confirm. Both installed and none icon issues. I can reproduce exactly what bluhm describes. rsadowski, do you have anything else installed that coulb be important? With kiconthemes installed, mumble will print this upon startup: 2021-04-22 18:12:20.932 Icon theme "breeze" not found. So mumble seems to pick up kiconthemes which wants to use breeze by default or so -- I'm unfamiliar with KDE's theme/icon/etc. framework and currently don't have the time to further look into this. > > Pro Qt tip: Install qt5ct, run qt5ct, set QT_QPA_PLATFORMTHEME=qt5ct. > For more themes and icons install lightly, adwaita-qt, breeze, oxygen. I have QT_QPA_PLATFORMTHEME=qt5ct in ~/.profile and ran qt5ct once to set Qt5 apps to a dark theme, but that doesn't change anything wrt. icons in Mumble for me. > If you do not like the Qt style, install adwaita-qt and it will looks > like GNOME Shell. > > Rafael >
Re: audio/mumble: missing icons
On Sat, 17 Apr 2021 11:21:52 +0200 Rafael Sadowski wrote: > Can't confirm. Both installed and none icon issues. > > Pro Qt tip: Install qt5ct, run qt5ct, set QT_QPA_PLATFORMTHEME=qt5ct. > For more themes and icons install lightly, adwaita-qt, breeze, oxygen. I tried this with kiconthemes installed and the issue persists. However, qt5ct dies with a SIGABRT when I exit it by clicking Ok. Kind regards, Thomas
Re: audio/mumble: missing icons
On Sat, 17 Apr 2021 10:06:32 +0200 Alexander Bluhm wrote: > pkg_delete kiconthemes fixes the issue for me. > pkg_add -Dsnap kiconthemes && mumble triggers the bug on -current. Fascinating, that fixes it for me as well ... I played around with ktrace(1) a bit and it seems that with kiconthemes mumbles searches the filesystem for its icons instead of using the compiled in resource files, but I have not found out why it does that. Kind regards, Thomas
Re: audio/mumble: missing icons
On Sat Apr 17, 2021 at 10:06:32AM +0200, Alexander Bluhm wrote: > On Sat, Apr 17, 2021 at 01:34:06AM +0200, Patrick Wildt wrote: > > Am Sat, Apr 17, 2021 at 01:16:00AM +0200 schrieb Thomas L.: > > > Hi, > > > > > > I noticed that recently mumble shows me no icons in the toolbar and > > > elsewhere. I already tried reverting the most recent changes in > > > audio/mumble, but it seems like something else is amiss. To rule out > > > broken configuration I tried creating a new user, but it shows the same > > > behaviour. Can someone else confirm this or has an idea what changed? > > > > > > Kind regards, > > > > > > Thomas > > > > > > > Hi, > > > > I heard bluhm@ talk about the same issue this week. Iirc he had to > > *delete* some kde port or so, don't remember. CCed him, I guess he > > can tell you better than me what the cause is. > > > > Patrick > > pkg_delete kiconthemes fixes the issue for me. > pkg_add -Dsnap kiconthemes && mumble triggers the bug on -current. > > bluhm > Can't confirm. Both installed and none icon issues. Pro Qt tip: Install qt5ct, run qt5ct, set QT_QPA_PLATFORMTHEME=qt5ct. For more themes and icons install lightly, adwaita-qt, breeze, oxygen. If you do not like the Qt style, install adwaita-qt and it will looks like GNOME Shell. Rafael
Re: audio/mumble: missing icons
On Sat, Apr 17, 2021 at 01:34:06AM +0200, Patrick Wildt wrote: > Am Sat, Apr 17, 2021 at 01:16:00AM +0200 schrieb Thomas L.: > > Hi, > > > > I noticed that recently mumble shows me no icons in the toolbar and > > elsewhere. I already tried reverting the most recent changes in > > audio/mumble, but it seems like something else is amiss. To rule out > > broken configuration I tried creating a new user, but it shows the same > > behaviour. Can someone else confirm this or has an idea what changed? > > > > Kind regards, > > > > Thomas > > > > Hi, > > I heard bluhm@ talk about the same issue this week. Iirc he had to > *delete* some kde port or so, don't remember. CCed him, I guess he > can tell you better than me what the cause is. > > Patrick pkg_delete kiconthemes fixes the issue for me. pkg_add -Dsnap kiconthemes && mumble triggers the bug on -current. bluhm
Re: audio/mumble: missing icons
Am Sat, Apr 17, 2021 at 01:16:00AM +0200 schrieb Thomas L.: > Hi, > > I noticed that recently mumble shows me no icons in the toolbar and > elsewhere. I already tried reverting the most recent changes in > audio/mumble, but it seems like something else is amiss. To rule out > broken configuration I tried creating a new user, but it shows the same > behaviour. Can someone else confirm this or has an idea what changed? > > Kind regards, > > Thomas > Hi, I heard bluhm@ talk about the same issue this week. Iirc he had to *delete* some kde port or so, don't remember. CCed him, I guess he can tell you better than me what the cause is. Patrick
audio/mumble: missing icons
Hi, I noticed that recently mumble shows me no icons in the toolbar and elsewhere. I already tried reverting the most recent changes in audio/mumble, but it seems like something else is amiss. To rule out broken configuration I tried creating a new user, but it shows the same behaviour. Can someone else confirm this or has an idea what changed? Kind regards, Thomas
