Re: devel/frama-c: Add findlib as run dependency

2019-03-23 Thread Jeremie Courreges-Anglas
On Fri, Mar 22 2019, Greg Czerniak  wrote:
> Here is what I see if I launch frama-c after installing the standard package:
>
> $ frama-c
> [kernel] Current source was: :0
>   The full backtrace is:
>   Raised at file "stdlib.ml", line 33, characters 17-33
>   Called from file "findlib.ml", line 166, characters 10-151
>   Called from file "src/kernel_services/plugin_entry_points/dynamic.ml", line 
> 287, characters 2-45
>   Called from file "src/kernel_services/plugin_entry_points/kernel.ml", line 
> 760, characters 4-49
>   Called from file "src/kernel_services/cmdline_parameters/cmdline.ml", line 
> 836, characters 2-22
>   Called from file "src/kernel_services/cmdline_parameters/cmdline.ml", line 
> 229, characters 4-8
>   
>   Unexpected error (Failure("Config file not found - neither 
> /etc/findlib.conf nor the directory /etc/findlib.conf.d")).
>   Please report as 'crash' at http://bts.frama-c.com/.
>   Your Frama-C version is 18.0 (Argon).
>   Note that a version and a backtrace alone often do not contain enough
>   information to understand the bug. Guidelines for reporting bugs are at:
>   
> http://bts.frama-c.com/dokuwiki/doku.php?id=mantis:frama-c:bug_reporting_guidelines
> $
>
> If I install the findlib package, frama-c runs without incident.

Indeed.

> Below is a patch that adds findlib as a run dependency for frama-c.

Committed, thanks.  (With a REVISION bump)

> Index: devel/frama-c/Makefile
> ===
> RCS file: /cvs/ports/devel/frama-c/Makefile,v
> retrieving revision 1.12
> diff -u -p -r1.12 Makefile
> --- devel/frama-c/Makefile13 Mar 2019 09:34:42 -  1.12
> +++ devel/frama-c/Makefile22 Mar 2019 20:35:43 -
> @@ -24,8 +24,8 @@ MODULES =   lang/ocaml
>  
>  BUILD_DEPENDS =  x11/lablgtk2 devel/ocaml-graph \
>   math/graphviz math/ocaml-zarith sysutils/findlib
> -RUN_DEPENDS =x11/lablgtk2 math/graphviz math/ocaml-zarith
> -
> +RUN_DEPENDS =x11/lablgtk2 math/graphviz math/ocaml-zarith \
> + sysutils/findlib
>  LIB_DEPENDS =x11/gnome/libgnomecanvas \
>   x11/gtksourceview
>  
>

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE



devel/frama-c: Add findlib as run dependency

2019-03-22 Thread Greg Czerniak
Here is what I see if I launch frama-c after installing the standard package:

$ frama-c
[kernel] Current source was: :0
  The full backtrace is:
  Raised at file "stdlib.ml", line 33, characters 17-33
  Called from file "findlib.ml", line 166, characters 10-151
  Called from file "src/kernel_services/plugin_entry_points/dynamic.ml", line 
287, characters 2-45
  Called from file "src/kernel_services/plugin_entry_points/kernel.ml", line 
760, characters 4-49
  Called from file "src/kernel_services/cmdline_parameters/cmdline.ml", line 
836, characters 2-22
  Called from file "src/kernel_services/cmdline_parameters/cmdline.ml", line 
229, characters 4-8
  
  Unexpected error (Failure("Config file not found - neither /etc/findlib.conf 
nor the directory /etc/findlib.conf.d")).
  Please report as 'crash' at http://bts.frama-c.com/.
  Your Frama-C version is 18.0 (Argon).
  Note that a version and a backtrace alone often do not contain enough
  information to understand the bug. Guidelines for reporting bugs are at:
  
http://bts.frama-c.com/dokuwiki/doku.php?id=mantis:frama-c:bug_reporting_guidelines
$

If I install the findlib package, frama-c runs without incident.

Below is a patch that adds findlib as a run dependency for frama-c.

Index: devel/frama-c/Makefile
===
RCS file: /cvs/ports/devel/frama-c/Makefile,v
retrieving revision 1.12
diff -u -p -r1.12 Makefile
--- devel/frama-c/Makefile  13 Mar 2019 09:34:42 -  1.12
+++ devel/frama-c/Makefile  22 Mar 2019 20:35:43 -
@@ -24,8 +24,8 @@ MODULES = lang/ocaml
 
 BUILD_DEPENDS =x11/lablgtk2 devel/ocaml-graph \
math/graphviz math/ocaml-zarith sysutils/findlib
-RUN_DEPENDS =  x11/lablgtk2 math/graphviz math/ocaml-zarith
-
+RUN_DEPENDS =  x11/lablgtk2 math/graphviz math/ocaml-zarith \
+   sysutils/findlib
 LIB_DEPENDS =  x11/gnome/libgnomecanvas \
x11/gtksourceview