empty files in the tree

2021-07-07 Thread Daniel Jakots
Dear porters,

A recent commit said "remove patch" while it didn't remove any
file. I checked if it was oversight. Spoiler alert, it wasn't, but
here's the current list of empty files:


$ for _file in $(find /usr/ports -empty | grep -v -e pobj -e bulk -e tests -e 
packages -e update) ; do ls -l "${_file}" ; done 
total 0
-rw-r--r--  1 danj  wsrc  0 May 25 21:08 
/usr/ports/devel/flatbuffers/patches/patch-src_util_cpp
-rw-r--r--  1 danj  wsrc  0 Apr 29 01:01 
/usr/ports/games/openttd/patches/patch-Makefile_bundle_in
-rw-r--r--  1 danj  wsrc  0 Apr 29 01:01 
/usr/ports/games/openttd/patches/patch-config_lib
-rw-r--r--  1 danj  wsrc  0 Apr 29 01:01 
/usr/ports/games/openttd/patches/patch-src_core_endian_type_hpp
-rw-r--r--  1 danj  wsrc  0 Mar 16 19:51 
/usr/ports/lang/moarvm/patches/patch-build_Makefile_in
-rw-r--r--  1 danj  wsrc  0 Mar 16 19:51 
/usr/ports/lang/moarvm/patches/patch-build_setup_pm
-rw-r--r--  1 danj  wsrc  0 Mar 16 19:51 
/usr/ports/lang/rakudo/patches/patch-src_core_Compiler_pm6
-rw-r--r--  1 danj  wsrc  0 Mar 16 19:51 
/usr/ports/lang/rakudo/patches/patch-tools_build_Makefile-Moar_in
-rw-r--r--  1 danj  wsrc  0 Mar 16 19:52 
/usr/ports/net/sniproxy/patches/patch-src_Makefile_am


Since they're all in patches/, I assume it's fine to remove them.

Comments? OK?

Cheers,
Daniel



Re: empty files in the tree

2021-07-07 Thread Stuart Henderson
On 2021/07/07 10:25, Daniel Jakots wrote:
> Dear porters,
> 
> A recent commit said "remove patch" while it didn't remove any
> file. I checked if it was oversight. Spoiler alert, it wasn't, but
> here's the current list of empty files:
> 
> 
> $ for _file in $(find /usr/ports -empty | grep -v -e pobj -e bulk -e tests -e 
> packages -e update) ; do ls -l "${_file}" ; done 
> total 0
> -rw-r--r--  1 danj  wsrc  0 May 25 21:08 
> /usr/ports/devel/flatbuffers/patches/patch-src_util_cpp
> -rw-r--r--  1 danj  wsrc  0 Apr 29 01:01 
> /usr/ports/games/openttd/patches/patch-Makefile_bundle_in
> -rw-r--r--  1 danj  wsrc  0 Apr 29 01:01 
> /usr/ports/games/openttd/patches/patch-config_lib
> -rw-r--r--  1 danj  wsrc  0 Apr 29 01:01 
> /usr/ports/games/openttd/patches/patch-src_core_endian_type_hpp
> -rw-r--r--  1 danj  wsrc  0 Mar 16 19:51 
> /usr/ports/lang/moarvm/patches/patch-build_Makefile_in
> -rw-r--r--  1 danj  wsrc  0 Mar 16 19:51 
> /usr/ports/lang/moarvm/patches/patch-build_setup_pm
> -rw-r--r--  1 danj  wsrc  0 Mar 16 19:51 
> /usr/ports/lang/rakudo/patches/patch-src_core_Compiler_pm6
> -rw-r--r--  1 danj  wsrc  0 Mar 16 19:51 
> /usr/ports/lang/rakudo/patches/patch-tools_build_Makefile-Moar_in
> -rw-r--r--  1 danj  wsrc  0 Mar 16 19:52 
> /usr/ports/net/sniproxy/patches/patch-src_Makefile_am
> 
> 
> Since they're all in patches/, I assume it's fine to remove them.
> 
> Comments? OK?
> 
> Cheers,
> Daniel
> 

yep



Re: empty files in the tree

2021-07-07 Thread Daniel Jakots
This has been committed, thanks for the feedback.

On Wed, 7 Jul 2021 10:25:37 -0400, Daniel Jakots  wrote:

> $ for _file in $(find /usr/ports -empty | grep -v -e pobj -e bulk -e
> tests -e packages -e update) ; do ls -l "${_file}" ; done 

I've been told:
14:58  fwiw   find . \( -path ./pobj -o -path ./bulk -o -path ./tests 
-o -path ./packages -o -path ./update -o -path ./distfiles -o -path ./.git \) 
-prune -type f -o -type f -empty -exec ls -l {} +
14:58  because $('ing find is evil because filenames are terrible 
things

(putting it here for next time)



Re: empty files in the tree

2021-07-08 Thread Stuart Henderson
On 2021/07/07 22:01, Daniel Jakots wrote:
> This has been committed, thanks for the feedback.
> 
> On Wed, 7 Jul 2021 10:25:37 -0400, Daniel Jakots  wrote:
> 
> > $ for _file in $(find /usr/ports -empty | grep -v -e pobj -e bulk -e
> > tests -e packages -e update) ; do ls -l "${_file}" ; done 
> 
> I've been told:
> 14:58  fwiw   find . \( -path ./pobj -o -path ./bulk -o -path 
> ./tests -o -path ./packages -o -path ./update -o -path ./distfiles -o -path 
> ./.git \) -prune -type f -o -type f -empty -exec ls -l {} +
> 14:58  because $('ing find is evil because filenames are terrible 
> things
> 
> (putting it here for next time)
> 

find ... -ls